From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13A26C636D3 for ; Mon, 6 Feb 2023 18:14:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A57526B0072; Mon, 6 Feb 2023 13:14:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A06F56B0073; Mon, 6 Feb 2023 13:14:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 880A96B0074; Mon, 6 Feb 2023 13:14:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 795C66B0072 for ; Mon, 6 Feb 2023 13:14:29 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5A2E21C61FF for ; Mon, 6 Feb 2023 18:14:29 +0000 (UTC) X-FDA: 80437667058.08.E68F8DD Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf29.hostedemail.com (Postfix) with ESMTP id E0A8812001C for ; Mon, 6 Feb 2023 18:14:25 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=PJfL3Wgf; spf=pass (imf29.hostedemail.com: domain of dan.j.williams@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1675707266; a=rsa-sha256; cv=fail; b=ctDFUKTGisFM8pEV2Dhpws9ePBdWRvdeuRpaSWR0y6448r173ci5XevNdpc4jz5Dz/dpbp 1OR6iKc9whEmpJr3IHFQAfKUtuLC3QhyTrX3Kdl8ZFuNZzElDItjeacLDa41pspR6ZASR7 NTq3zuRcDnXcUDrKGTGx/+hsS0YKjJY= ARC-Authentication-Results: i=2; imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=PJfL3Wgf; spf=pass (imf29.hostedemail.com: domain of dan.j.williams@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675707266; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fABKwkfzr2HbcuCozw3unjzvGAdD3HqRJrRRLqnSN/U=; b=0W7PVzmAEru6/1NojgnwhR+NJd0jbzqcZK1UugHMqqlS2FMgsz1xPkhclO7Z7UqQNpLbnN MOOwSXrlWs8L0hBrRvhgzPMgHcxTn2+s/ceuWGaiFb6USac6CmWMit1yxz4hO6E5KWk5OK Ynr0EbFi4FXoKANp0t33KX+5CjFYuo8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675707266; x=1707243266; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=O1Ks2k6t3s63j1713uiv1afVYnS1LrP4hw73wocqJUc=; b=PJfL3WgfyHTvrsTwE66xssbSOWWgTRIc8ql/Vicq0NIzLiknvUaqgN/x YliCyHTZse96LGXPAOVEHQVdsvSkdfCJd70AMJiCUNV4HJyYVXowc9CSO HOt6MgjHz8SGdZXo3EICv1PNAjVTaANENdzyfky1hPp6RQfxTp1P3/AZS hP0Le8z5bTbtJIbtZEoUoe1K4Mc15DbswDvu+9ud7aexRPizrthkooS9X H1JcSvhn9MLRfcaF3z0zWXexILME7VqVSWTvbnEzASjJ84zScxcR9qwPd hyCILlg9OkSaQ2M9OCEoS08RCJXjLof4Cx9jRUIAVeyl6rsli3Ebvoj4m Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="326961980" X-IronPort-AV: E=Sophos;i="5.97,276,1669104000"; d="scan'208";a="326961980" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2023 10:14:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="809214628" X-IronPort-AV: E=Sophos;i="5.97,276,1669104000"; d="scan'208";a="809214628" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP; 06 Feb 2023 10:14:23 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 6 Feb 2023 10:14:23 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 6 Feb 2023 10:14:22 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 6 Feb 2023 10:14:22 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.46) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 6 Feb 2023 10:14:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eJpyg9If6/3Vt5G9Ex4j0d1BqwJHP3Nv+XEpePQh9I+WBEeAtI8WLFwDMOaQoGBQ0LaiGi4WCSboJggxzNxbXGaW2ka7dAEob2n3SDw7+RUlgPT78bJKnRc0F9XPRUxz+k/vNVn0FfNb5k/h9S4rTHiCU3Uszrsby+yB8wtNYWK45h6ADXhl9fdpkv9PgAbFBXIqJPqfcH8xtTUd00e2pNrcUfI/y5wcTudFtYgfYN1fRmD9fXlq9hV2Yxx2Ahiwaq1h+seNZA9j2z9fKlhpzct2c7rVDKSSgeBjMDVECsFcbImZTRFAfaErVbkigmDOFgXf4PIKnhHpeoZV6A+XNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fABKwkfzr2HbcuCozw3unjzvGAdD3HqRJrRRLqnSN/U=; b=Pqy/BUCdKpIAph/H/yqUbKOfZeDtYaW194uMJRm3LV+DC2KlebSvbT+R26JZZbCiIvT8Na11sH/tRCTUCiylc4b54h3O1WS7g9qzIRKDSu/ak4C00Dv7JNT2U/H9/2r5/5+TEv6DuRwq5b5UOcGAWjYSPhOG0oUxuYq08Y8afk0OcKmhI7LfG3gazknJ7DiXMySx6Ggx623Tf/arFzMwXmJHW8hp0aaTE/zp2gWRNuSS2cLtODOMFn70IvJMrGOPuCcUKwZ80dYRCM1DH1hfsr8qC4kkxoPazPo3LbLp2fIuwE8tncNrGmntk4uQl8gHZ/16vMdRZ0pawaBLO3imrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) by PH0PR11MB4936.namprd11.prod.outlook.com (2603:10b6:510:42::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 18:14:21 +0000 Received: from PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::421b:865b:f356:7dfc]) by PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::421b:865b:f356:7dfc%6]) with mapi id 15.20.6064.031; Mon, 6 Feb 2023 18:14:21 +0000 Date: Mon, 6 Feb 2023 10:14:18 -0800 From: Dan Williams To: Jonathan Cameron , Dan Williams CC: , , , Subject: Re: [PATCH 04/18] cxl/region: Validate region mode vs decoder mode Message-ID: <63e1437a8e6bb_ea22229452@dwillia2-xfh.jf.intel.com.notmuch> References: <167564534874.847146.5222419648551436750.stgit@dwillia2-xfh.jf.intel.com> <167564537131.847146.9020072654741860107.stgit@dwillia2-xfh.jf.intel.com> <20230206160221.000045ea@Huawei.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230206160221.000045ea@Huawei.com> X-ClientProxiedBy: SJ0PR05CA0093.namprd05.prod.outlook.com (2603:10b6:a03:334::8) To PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH8PR11MB8107:EE_|PH0PR11MB4936:EE_ X-MS-Office365-Filtering-Correlation-Id: 8b0203a6-4423-4e9b-30f7-08db086df7d6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 76MxHsJhiMFLRSA3aTH49QHhodaUAnhrnTfDV0o+g4dT/wZrHniLEr866yXmJsCoS141WjdSzKW49Y1147NWqSQjXM0y7l2vR1VXeRCFYknChIH7829rhWcCD85oUjKqMtENryZmslU7y7ufppcckCPMC3fmAn2YS/D+SPYaVCZcXfLsix0hAZLac45JJl9DylIlWNUUCDQqnbEPaIZmQSrTC8Yj8NBNJR4txl5mqnber1DlZiYkeUwlFSrXXFLjTUsXiD1d5TkuocBhxcbix3YoGhoj91+8ksseAoNaLya8zbkSN+cbOQQfDqA2za2nbO8btNStXzwhu/sKRYg/OJMEtRxaHmzSCrxILMUSl8+nqDDPi1NJAqoI7T7SPh+CCYQmE2bu+taAf5YuDLMI5LyR132ukdAZ13d4uqtDACR96B7Af8VWTkjcoZLa9alHDhPwS4b2JK2Kz9dWNVesgolLt+m4nmH8NTbWB1MpJXUGBL2/ShpbOg/Wmfjxdie5qAE3wm7hCXaFmOQ3i7p+6FVfrSWGjX0QCkRDynxsRYBJYgf7X1RJJtpPgDgqsKyGv2UTf7f9qCkxIck4STz5IFwY+g/JZ4rX/l/uxHe/dfZTlhXvRQnaJKJFwkb1o6pRll+kO5j4caHh0t3DNBZDkw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH8PR11MB8107.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(376002)(366004)(39860400002)(396003)(346002)(451199018)(478600001)(316002)(110136005)(6506007)(6512007)(26005)(6666004)(9686003)(186003)(6486002)(5660300002)(86362001)(82960400001)(38100700002)(83380400001)(66946007)(4326008)(8676002)(2906002)(8936002)(66556008)(66476007)(41300700001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nmqEv21mt9sPP581hVAM7vgYPrqo84mtUDjUK05jXbCTtedOi0tw7GdnrAp+?= =?us-ascii?Q?JURjPmpFE0m1KD8vsSDoGO44k7YPsNSkwZuQcQPTmZjoe/eMYy9c37PlfB7A?= =?us-ascii?Q?XGy2gHUdEVBRl+Zdj//JTRLKDayh0P140KUMxl+hiOt4gtZSp5ouMc1duUeO?= =?us-ascii?Q?tD2gLbOBKbLcpGTpUwQjpt0WHJ2mo7S9AZm0rFfFPlCueAwgy/AaiBHGW9Tg?= =?us-ascii?Q?eDK/sOl2oOJftAJF/1oXiRXAEi9QDOCVV6vDXJ2N/nL/GeIgIUTQXpiwTXzo?= =?us-ascii?Q?gO8NobnM6MejDh8mctPtPbr1dH/l7AeXsaT6qBhykBbOohCD0lcudxmKUdNo?= =?us-ascii?Q?dl2T7icTPnHYSMUCRlNKWeqdCIYvKVXOyJm0ltNukc/FnOH3h0iCBmyKkYPZ?= =?us-ascii?Q?C+We4XD+e00aq6xOcqAYHtnvf1j4fm6d3J0wDzttNzzV/yi8R80dNVIKfgwO?= =?us-ascii?Q?B0mCy2SKXjzrHzdoL28ipp4ghDgl0qQMsPpoOFXjWPDI6EevLlLEuMBZTUCY?= =?us-ascii?Q?aZ8bDbuYz6Phh++MtY6scKZI/pGfj+XNGI2FQfUDztKW6hDlNFLyZphwuTG4?= =?us-ascii?Q?Bdb7CgjMqKo+i4MPtgcGY5MHhe5meFoUltTGBuLygVWh8GtL3y6Nl+0QsMC0?= =?us-ascii?Q?oRklw+P6F235kZm4Ao5CIFXJ/3k+SS1V2XoDlT5NrE0VoHYmHcfuE2IJITMn?= =?us-ascii?Q?HsbS/pBPgGWWXFxDp6ks2Gam5iVFtifOhbLLYGa6yHXH7Gs7FOjFtc6eekE5?= =?us-ascii?Q?mEpDmRS8owuH6OOrYl8VnLoPweRNYJszknpHI8ov8n6993NM9va2gfgp4BBz?= =?us-ascii?Q?V86wF4gCfNKPI0TypD7tY/yx9BtvK5nPzqE+4kL+dHRGnEvpWbH/pzW54ugG?= =?us-ascii?Q?uI0MkUC3sdTi02SrdBxRNfTL8Eyj09MQkKm/yPVL1s+taVokwNFGtZ6/5/v/?= =?us-ascii?Q?Bcmw4tcrPGnCMOMEBMEhQEaXAyL4iK0hA9XrmmvM8OPrGAQKFs0YMgLi0DsO?= =?us-ascii?Q?ZeZW/9YdhWejg0vAGPtlUGbTXicVAnVnWff8JzifHHMdgbWzy1e1PRB/fLzm?= =?us-ascii?Q?hPUhnkbyzt6bxJEAdvAkIBejNDim6ExpN3/MVDBDV2qDxp9Ajl1N0z+vrDj1?= =?us-ascii?Q?GJkNzsrnc4XSfNbIewD/AZ403LIwysnVUue2LPSniqmm+FVwDnO7BkHBIlvN?= =?us-ascii?Q?O+iPvOZRWOZYLfazhMJAt/AfjI8X30Q1QJgCfruCdzF11VRK40OuWJkratN5?= =?us-ascii?Q?ZUM7owatXMxPsJvFhDXskAgNAXprHh0welt2azyKufU8HOKQT5mCwQre2Y80?= =?us-ascii?Q?dDz4gKmvNfUE9kprBJvzWRfAZFhppaNgrP+p7ED8Ck0Kw2yRIeZoc+j2ukEb?= =?us-ascii?Q?DFwolOackqgbA+iCaL+oranc1fUD1xM23u57mXArS4aDxfhTy6wOi5vY7AWf?= =?us-ascii?Q?qfOP8yehwqhIwUFYglTwOS3e38Pau7JENcDHl59bPrq1Ak2bsAWHKc5ol9uj?= =?us-ascii?Q?joEIE3O3HeqB6wt8rLLklb4ZnYHfhjT3GYnvruGmsPjdocBI7XFxzd97Dnbf?= =?us-ascii?Q?fNcVGH1HewzrXIX+APrc1lBcPeES/zmdPa2FBLazLPFw+RT5UWR489sJqQxh?= =?us-ascii?Q?oA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8b0203a6-4423-4e9b-30f7-08db086df7d6 X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 18:14:20.8337 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cbo1WgCLKXIzwn5lQIVy7bgwLFm2Vlq2jMxxe3LHcyp0RNlqxSH2B/x/Ya4orFXHbLRL8oHGVMZTn8LxTe8A4WECYJfCRt3N8t3D/2/RT6k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4936 X-OriginatorOrg: intel.com X-Rspam-User: X-Rspamd-Queue-Id: E0A8812001C X-Rspamd-Server: rspam01 X-Stat-Signature: 4dyfx61bzdoqk893dgim7qic6y3ncf96 X-HE-Tag: 1675707265-80281 X-HE-Meta: U2FsdGVkX1/l922rFzRZ0nQa+SVyrk86NeGfFNG3zMVzp1bntSmaau/5/7ezQFkheDuBVhYikJeu091SeESiqsGaO6UvoTyquNOSOAK8O1/4L0yMeVgrax8ZCVzhocSiMZFYGceEAFQ0+ijB2zDU1fER30XI9/4q0MtmGJj5n2yPBV0aHQXqB3RSYdi7oH7w3nftOOlBMnpiKVZyI0hGQVRffeZJ8D44B8uMldAoR3njK1SPEkSCoEcw2gGFbisjqjSyiMrujK1IfkmZ8m9cRD17E2AZsFj1rGPTTKo3XaMl2qp20U1XV61hZtcPV69jlvmqOrsAk/yUe9Rk4zw+zRZ+tZPWw7LuiUy16Sb+0CIchRKnZlQdPrxlQp5QWWq3XKpayJhrhONsjPSEkTs6mzOWVRKNn6spe6EiRzBgRjSWBZzXB8spAJXa6efBKM2N5XnB7ALIVjKQRotkoHuv1pmPUbt6czlyYazzpMS3SOpFo34C2RcpgeLWRLTzS39LPre4Eul5jNtPZ85WMeqt+zovmx3Co05afB8Av5FYLcc2bAXV8jEgCw+P0xZfUhMz+oIwxvq+U3ckdCGCnIsVrH2Zs96/HbJs8UHyrXsGqi3iZXhmI+9w0NO/0H8f3B+60hmOhw2XTnq59Pt4cfTuP9tPy6SaoDj7UEqm02X7wOcEUbZ4K5NuvbIrbsmnh0T0E9AhExYhDJcmYfJ9WEkEeaUP+FT1Z4YtUWpPTAM7OPd06sb8oj6wJlA1z+9oBdCGQ/+7EWTBKr+WTSOsBkxgrhGwWLeM1L6sQ9DYC55YzWYK8jV4oycuDbfgR1LNZqhq3IBP6ziDyFtI0lBoP+YYSRst67kfn1LHmXCUJhDA8IaJ9lWs1y6RIkLcjhzkiGXay9OKzbLcnRF9hoRxWFxQG1s1f3jnW812gNknuvGcgCWkRDmguYdNEbBxVhss8gbBVpXR/GInDSUN5HdcMZr GsBVdmr2 6Za/5MGsOYlpx1d6l8uIOYedsDvi50YL0RvHWAlbBBxAO4KSOvHOQqw6Ck2oQHQNd8+DADyp8pvS9rBEOUg8sSuN9GpaksAo/1Y4ypy1dQ2zhneNDfF9z0XDn5q5k5fViJgQbnrOAvUa6gZLF0f9w//a1yECipTA3tSHXH/88JfuUUIprQFft019wiyKjYTTuoZMMJ8wZfDq7pf4QpbIYmuPtcimRX+g0WyGp21sIzXEfMXDdOaWXjOJ+LU3u/RUQG1i+2/MPUdrIUumptxDAnz2FdDelPzt8MvaHVz4jPuSULmo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Jonathan Cameron wrote: > On Sun, 05 Feb 2023 17:02:51 -0800 > Dan Williams wrote: > > > In preparation for a new region mode, do not, for example, allow > > 'ram' decoders to be assigned to 'pmem' regions and vice versa. > > > > Signed-off-by: Dan Williams > > I guess we aren't support mixed endpoint decoders for now (and > maybe never..) If we did I'd expect this to have to allow > mixed with either RAM or PMEM. Mixed is a bug, or I otherwise can not think of a scenario where it is valid. The kernel prevents it, but platform firmware can make that mistake. I think if the kernel ever encounters that and works around it that will come with a loud TAINT_FIRMWARE_WORKAROUND warning. > > Reviewed-by: Jonathan Cameron > > --- > > drivers/cxl/core/region.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c > > index c9e7f05caa0f..53d6dbe4de6d 100644 > > --- a/drivers/cxl/core/region.c > > +++ b/drivers/cxl/core/region.c > > @@ -1217,6 +1217,12 @@ static int cxl_region_attach(struct cxl_region *cxlr, > > struct cxl_dport *dport; > > int i, rc = -ENXIO; > > > > + if (cxled->mode != cxlr->mode) { > > + dev_dbg(&cxlr->dev, "%s region mode: %d mismatch: %d\n", > > + dev_name(&cxled->cxld.dev), cxlr->mode, cxled->mode); > > + return -EINVAL; > > + } > > + > > if (cxled->mode == CXL_DECODER_DEAD) { > > dev_dbg(&cxlr->dev, "%s dead\n", dev_name(&cxled->cxld.dev)); > > return -ENODEV; > > >