From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52102C05027 for ; Fri, 10 Feb 2023 21:14:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 96E706B017D; Fri, 10 Feb 2023 16:14:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 91E34280003; Fri, 10 Feb 2023 16:14:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 797786B017F; Fri, 10 Feb 2023 16:14:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 67FBC6B017D for ; Fri, 10 Feb 2023 16:14:14 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 14667160FC8 for ; Fri, 10 Feb 2023 21:14:14 +0000 (UTC) X-FDA: 80452635228.27.8C87A00 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by imf14.hostedemail.com (Postfix) with ESMTP id DC8B1100023 for ; Fri, 10 Feb 2023 21:14:09 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=fGaTs2YL; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf14.hostedemail.com: domain of dan.j.williams@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676063650; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jFwxpGRszSuldtH2UxW4/JwCMP1MCiRsI7vh/KDBadA=; b=FZsc7jPkSkrGaV9GDOca54G25zBxtvBE+SaTEu6hz8/MP2P7tjvRP/nHfxCHy6XxPzkuLb qR+zW7HJKGIG0B2DoEqgTIXOVrCi2Z3GHGGQOPLY3AlJAWhnEHBQ0h78T/30bPIsiu2NM+ 09WHxErLdXaWSXUVy85IJ+Q5uAkvSPE= ARC-Authentication-Results: i=2; imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=fGaTs2YL; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf14.hostedemail.com: domain of dan.j.williams@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1676063650; a=rsa-sha256; cv=fail; b=BcUTMl5LcjSL5Nbofu+5JChAJFHQ1+LvJuJUgQEtddCZwlFmiYb6sbRdUV5nTetiZ0pLyP J45ecUw5EXj02N5E+yucb4kM8WSlJ0Mn1AduK5kU2rLYV+mVN6meaa0+9vn+ACgqBaMHY6 tdI8C5h/7Z0bGxtWRHLv2Csa8LcUJw0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676063649; x=1707599649; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=BO34XjZLWGxBhKfn8yhJ9VDuVnjKXllAiqYv46Kdgc8=; b=fGaTs2YLXisz2OcogqdjLUk1GPvbNBrvM2mnGwMklRMs3EPlIweDY/Vk vEtKY4b/hEaymIi2JfovTbGT9NQE9CEniIicrubwtItQub6VVRFwpzBqP 2OYIZty4/uWA1yp6PNtCN7AdvbTx/BhuOx9KKyotp7slsO3MCqhlteTNp nL+IDGbDfVBftmRaqoGphSo3hwAOHNNOEbeqFzUBpNIeSFbAuAznhjn1c tIpkUemzdhne+lNpKqk5mMaPHsbiSWn4wPYrImU1QpUMdRdt64y/Lq47D uw7LivGDYC7XDa/X3IfaNT5u2p0Za00KW1CpbuJwHN0wEl5DRudJg7iBO w==; X-IronPort-AV: E=McAfee;i="6500,9779,10617"; a="357927632" X-IronPort-AV: E=Sophos;i="5.97,287,1669104000"; d="scan'208";a="357927632" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2023 13:14:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10617"; a="756917700" X-IronPort-AV: E=Sophos;i="5.97,287,1669104000"; d="scan'208";a="756917700" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 10 Feb 2023 13:14:08 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 10 Feb 2023 13:14:07 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Fri, 10 Feb 2023 13:14:07 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Fri, 10 Feb 2023 13:14:07 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rsk1ufPbGmVpk+E0X0gTT1/8a9C/tz/6Qm2kZXJkpLfF8In9GkPHZBGXax8vkfUa0WgoVaJeQ2ADggi8wnHoROPFTaNzBE6dy8cM4sO0BL/k0cjk+3RleIXEGraciXTCsjAoN5pir0Vbv7rz9zbzw2r7Tj3NXB8W1dVd1YYjyZmvRDgtPqh8aziY9BMY8YUMnlIs3568qznSzH9Vxnmqh8G8xWxixoKD/T45ziV+p/IDd8jKl9VjxyBQN1EZs91+aCySYaiw799xQR2NIitNLxznU+OIKGBiaHHIGoNwhMf43/WsLQN+qz0RhAi2pOcyGtr4KVZWgeAebmHhCG8dLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jFwxpGRszSuldtH2UxW4/JwCMP1MCiRsI7vh/KDBadA=; b=cRJvjL96eunugSnzuQ554ZKALWJ6nl1jGc+c/pDBIlt5YRvH+OhrbFdUFkZ8vGmfQS+jOntlc6w7OzosQCfvP1WCYMpwIu/QEi5uGx+ImM5S2RgNkB8T/kbjwKdZkJttPL/8CtYOGyUMyFmFHhMzQvoEuXkT/7BBZBmAwO7k9K5zhE4VkTVnDNo8RlA0B8MhaHGPN3rFbsSztGBoM8o1omZtvixddOeOF1nOPMfuhtP/vjZN8z3MwcgX+s9TAGYIRHYYHTKlvci8d1HdRJKvqEij/bhUbDOxwXGakOuHwtrT4AszKvxE/egeXi9K5Mhwi6BfXgYHSTusJLMXng6WYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) by MN2PR11MB4696.namprd11.prod.outlook.com (2603:10b6:208:26d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.21; Fri, 10 Feb 2023 21:14:05 +0000 Received: from PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::421b:865b:f356:7dfc]) by PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::421b:865b:f356:7dfc%5]) with mapi id 15.20.6086.020; Fri, 10 Feb 2023 21:14:05 +0000 Date: Fri, 10 Feb 2023 13:14:03 -0800 From: Dan Williams To: Jonathan Cameron , Dan Williams CC: , , , , Subject: Re: [PATCH v2 01/20] cxl/memdev: Fix endpoint port removal Message-ID: <63e6b39b46bee_1db5d029497@dwillia2-xfh.jf.intel.com.notmuch> References: <167601992097.1924368.18291887895351917895.stgit@dwillia2-xfh.jf.intel.com> <167601992789.1924368.8083994227892600608.stgit@dwillia2-xfh.jf.intel.com> <20230210172850.00001d5b@Huawei.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230210172850.00001d5b@Huawei.com> X-ClientProxiedBy: SJ0PR03CA0216.namprd03.prod.outlook.com (2603:10b6:a03:39f::11) To PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH8PR11MB8107:EE_|MN2PR11MB4696:EE_ X-MS-Office365-Filtering-Correlation-Id: 5458929a-53b8-4a0e-447b-08db0babbdc8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: saOvIsvbO1DTv9E9n7P75ST7AJOF2nlbRfxqJZf7592iG0VrtSSSmxTQx5Gs+pYA/8HHYmBiLF8ewL8t3/RAo4rbQ2BtT33+0xr3xTMG1jaVXJlmMkK8dY3cjUD2/aQwxJwJZTyasfIYlOXQfZTv1kMiLW+zQsvs/ufJjKNTxgtce6lEjShcsmbxHq8V8oG+fvFzAoEomnyUQ9Hwa35W/jmEKKqErmODRONPGgycdrpXOxLGvmATGFz9jdUPBLbt6N6ipAvhDqc8ywv6lD1PlBhBDpwzMwwK9N2fwNjDCforxeEhFKv+H+hk5YG7lqDfgUkotn6YBCeCMYh7AKgElIjYEKmJCHuzV1z4nt2y+FuOCHMsPoaNkgkFcGzUq2exiii8xrdvq/cG/3DqqeFYgY+tbf+hpPDjnHvCh0axf/DnKNP2d1FYtyJkflMttnyjPKHHZOlfeicezG5Ucncy40y5z9IxICVFejfQD2idt5pND2QRxpDwn4fzyHj9VI7Sf4kIbv55zYQBWRRiwlnkwUFarQsn4fwelogi1lNVPJRsnM2df4EHGKQo9Gvc6gIHdLwW2IbDpTwBPP+EM2ZR6dRA5mhKRruc2TbHGb7K7WHwX2KoEWPanwRPi0sGGX225ixb6HGKpIq375sYz+Owaw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH8PR11MB8107.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(136003)(396003)(376002)(346002)(39860400002)(451199018)(86362001)(82960400001)(38100700002)(8936002)(66556008)(66476007)(41300700001)(66946007)(316002)(110136005)(8676002)(4326008)(5660300002)(2906002)(83380400001)(478600001)(186003)(6486002)(6512007)(9686003)(6506007)(26005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RkoixTQ9YdbquiyF07SWckLyjKi0Im2ta33rinwekP4Y9goZIryuDvkr32ku?= =?us-ascii?Q?BMXqrdNaWCLLWCr4Q2dU/6nJtnF1rR0hvSUrSuAvGThVEwTOXVRIF+TPDnIl?= =?us-ascii?Q?obXG/FL+xALmoBbjVixiL+28KG4rO4Qga96g4+TfmIv/RYsfHd4NsG3De5bR?= =?us-ascii?Q?SngexyTbDXRcUJ8E14e5g8BNIqjUQ6fW9lfwqS9FlWd/a103U5yv6tfsKYbG?= =?us-ascii?Q?rzN2nQbE4FNgfRqbyt/w2pMlvat2QDUBzFDSmM+kiaqnH3lAS1beSj+xlG8q?= =?us-ascii?Q?PNg26FDkDhhMHTOk8YYH7/xBKu+JNZNvzH4Mc5rB/GSPj4+BVqadNJ6dhxGk?= =?us-ascii?Q?H2A0w0fo8pPO0dGpqz2ea/5HJnG5o+dc5sEh/ms4KYjudcBJDxqxeyFUBabW?= =?us-ascii?Q?mijQxCziw134IDvkzA8mbj7n1q1UPPPxol+dT8n3lHgLd4bvvINUKNze0kj9?= =?us-ascii?Q?pj4bxsSMVPqvRITFglYpltBnXvVT4HJqPRSs9skWK1ihilcHjd0JKSoh/oWC?= =?us-ascii?Q?z4juYYdEmS4Vcr+iczmCOhO3JlAlinNFfq8IZSFuoMfgBQl6dU08LAGwJ4w/?= =?us-ascii?Q?DjSk8XihLoz3r8gk+ZWf17lgpJInZWcsn8Ez+RXqQU1MeOEnYexgry+pl2NL?= =?us-ascii?Q?QDLObezvQJO24enTqs2C2aQtr2DuiqBw02Y4AiGXqWrbvnK+U5XCs5dZlRja?= =?us-ascii?Q?XX93V9dF6jD8Rwn3dtG0j3N4BN74VtjvjbNLIoNTpw0SYe1IqzogGVAb5ldu?= =?us-ascii?Q?b2EleFzhIEjcUw9WoLqeZ0torEMbVCyzdGOF3XyTnwczk2t5f0cWpow0jdAu?= =?us-ascii?Q?s2R9STDd4tvSxEkBMfVjCN6SdOyLwRnMja/n5UnKEh3y9lr2Bzr06ubSWFwq?= =?us-ascii?Q?yX/PInznkp6XnscqFMVrqvY8/SXNSauIoVgS70VfwwL8dJwH8Cxw+t6selo7?= =?us-ascii?Q?QzDkghDXEHrb/yyA4bRxBpNjGsvhoJwM+qv5UX8pWvSyGo2hrl3RPvZLrRDD?= =?us-ascii?Q?eRs0izLfS2BtQA1XpJCHH6XcDNUUOn+G8Kh6K9b33aA0qsf8C+PbfvJWJxsB?= =?us-ascii?Q?06G+GahTZzYn+6BZ+H4n2HO52X7FJTp8To6hWcd8ZtO79hJnkdoLQWeBk4AO?= =?us-ascii?Q?U4kXBtCeni6AaV/G3rby4NEhg6MfMZeq8QEjaEUrd0oPxAnTE1VzMl7RWU1c?= =?us-ascii?Q?I9z7Vurq8763XWxCbtoORAo1ZuGeL51mY6OzpYySzAB/2qN1nYoYGka3kQ4u?= =?us-ascii?Q?m+Vp/DZCfbkzEIVx5WlqgsaeebkozXkjbnGh26t7CSHwPRYDGJxT3j1cIh6x?= =?us-ascii?Q?v8N/qpYb3YaMOEozE4i25PgCXvRXgA9GrWJqTPrH/heh6gB4LSJqwjIpb9HH?= =?us-ascii?Q?fbdDlZWl0Y8JtNR231UCdEioXvLYM4xCzURGWcU+XfBLFYY4VIXXRpewuTJi?= =?us-ascii?Q?BxuJRbjldwgMGHmjm0m7sIJ0UTbILe6A449Q/VWUIxKKYsDUsUdlJ0e+BLgB?= =?us-ascii?Q?/eSa2Ba8DLLROnOh5ftYuRCPyZrS4ScoNSym5AX38+WcxmY6Yg2vjQ3b3d5i?= =?us-ascii?Q?GsNQcPl2z7FI6ylM0UTdr8jw7vG1S392s+e3xxtkXX19oKWX9UQKqulgFzUL?= =?us-ascii?Q?Aw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5458929a-53b8-4a0e-447b-08db0babbdc8 X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 21:14:05.5951 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lyYwN0swIe2Pz9jSybfbw/eTtM+jJR3XGhou7VS5sh6+W3hoEVJajk5BG22QW+06fdjSOPjHfa8yT6BWLWHaqb22BjijYPuQcLFL7RI1XXI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4696 X-OriginatorOrg: intel.com X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 3g3dwrkz7rog7atqur4kkwc9ykafyrp8 X-Rspamd-Queue-Id: DC8B1100023 X-HE-Tag: 1676063649-70561 X-HE-Meta: U2FsdGVkX19o4Nr5rm9dLItZijDooNqQuf4JLh0jE3/T/IZLMo8aGr0cAqgYRUvKoOf3Fy2jVQXovIjI2Tz+eXQW7/yAfrIAK3ZgaKVuUZCiPRj0m6yJhJA+Qs8GRUxWnq/DypmQ8GOp1LryPYVISDx1VPdzJ9uyj5PbihKGyjObVbf5UFCiFxz+97U2AOgmmCfML7Ccqq2GUfDs2FH+z7Ggh/7ou7ECeWzwz0a6cYYHDJjw5V5MWxwcU7CMnz5DufKS+ZySr46/l0VqUq+A6h2Vum9Celq+EeMy+4RGuTXpTBnrd4Zo29h977XF3hyqj5T3ofTjrUZ6N5JbzKXN/rHKTz1HfDidZqgrYZm+pGHM8Uwlpl80AuhftR03b37FALsJGlRcueAcdRg4D7shwhlNm2zRomqlASR8FTXREWWyWqFYrlm3WAEc1SqWAKapG6Uqf4sHfzbG1JbR6F9iA2ve1IGmQn462ZIBHNvnTTev2JYQr3WA5ev98Yh9ehAWgLcRuuOZwbJxqOsWSi+8SqqlyRrbRPeTtq08/UxLqbtFzh+o/uSBOjTnSJoTssbDU41wxU2WlP1O70qLahfJpGWKizm++SbpaBPggQn8WqXj/hLyEH/KOxw1pQieN8vdXGnl0xwqOeOQWr1Z1ScZqxayHfcJzQYVSVurbqf/KYP/1mKr2BQK5vMnDmIyq1vnHP3QEfjsN0GXLdhEWZcuuD2sRZrybz4mPFGgeY09ggvynR7z/HQQmNnpUxP/aBTTsYKv7626CnpApqaPOQoR10En8ucmTi/tE8krvlxBg4qEKiF7dWMyBz8pKxWwXmskNtYSDjhUabihN6doPvbwWpxqcawk/ZXAHz6iRkxsO4r1gxY37GCceSz4RgKUuHvMUJldCcZOTF/333ABod5IfGXKyWn7S4LNzhcj3iNhAnTEqFUz2S2Vu0/oMavdMi5HiJ3znoCtS5sGlnXRhkY gPj41j4V cyKE/MPY6mJ3xrEpH/I517AbtKmZIIFkBEAFJytHmqbPfGtcrsmX7FPPvqLXzmV3NAyagKOnyH/GmFELO/jtqfB8jiCUA1idsqhOc/DvZl7OqDhrtP62uaHl1Mm6K3gedg/WNwhXOnOHtmfjE4hoQbyOGGw7zAV8z58LaP6HbbamrDFpFQ8GK8nYUdW1tvIfeyd20ztDziKK53cZFR18yNKymXGtASZGll/iWNomxyBsnJupbf9fKtyxa7EBKRBoJxNpuiqPNEkx3ohm/PQrT+Gn/zQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Jonathan Cameron wrote: > On Fri, 10 Feb 2023 01:05:27 -0800 > Dan Williams wrote: > > > Testing of ram region support [1], stimulates a long standing bug in > > cxl_detach_ep() where some cxl_ep_remove() cleanup is skipped due to > > inability to walk ports after dports have been unregistered. That > > results in a failure to re-register a memdev after the port is > > re-enabled leading to a crash like the following: > > > > cxl_port_setup_targets: cxl region4: cxl_host_bridge.0:port4 iw: 1 ig: 256 > > general protection fault, ... > > [..] > > RIP: 0010:cxl_region_setup_targets+0x897/0x9e0 [cxl_core] > > dev_name at include/linux/device.h:700 > > (inlined by) cxl_port_setup_targets at drivers/cxl/core/region.c:1155 > > (inlined by) cxl_region_setup_targets at drivers/cxl/core/region.c:1249 > > [..] > > Call Trace: > > > > attach_target+0x39a/0x760 [cxl_core] > > ? __mutex_unlock_slowpath+0x3a/0x290 > > cxl_add_to_region+0xb8/0x340 [cxl_core] > > ? lockdep_hardirqs_on+0x7d/0x100 > > discover_region+0x4b/0x80 [cxl_port] > > ? __pfx_discover_region+0x10/0x10 [cxl_port] > > device_for_each_child+0x58/0x90 > > cxl_port_probe+0x10e/0x130 [cxl_port] > > cxl_bus_probe+0x17/0x50 [cxl_core] > > > > Change the port ancestry walk to be by depth rather than by dport. This > > ensures that even if a port has unregistered its dports a deferred > > memdev cleanup will still be able to cleanup the memdev's interest in > > that port. > > > > The parent_port->dev.driver check is only needed for determining if the > > bottom up removal beat the top-down removal, but cxl_ep_remove() can > > always proceed. > > Why can cxl_ep_remove() always proceed? What stops it racing? > Is it that we are holding a reference to the port at the time of the > call so the release callback can't be called until we drop that? Right, as long as a port reference is held then the cxl_ep_remove() at cxl_port_release() can not race this one from memdev removal. The result of cxl_ep_load() is guaranteed to stay stable until the subsequent put_device(). > Anyhow, good to have a little more detail on the 'why' in the patch > description (particularly for those reading this when half asleep like me ;) Long day for you, I appreciate it!