From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB1B8C6FD1D for ; Thu, 30 Mar 2023 17:46:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F36CC6B0071; Thu, 30 Mar 2023 13:46:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE6B06B0072; Thu, 30 Mar 2023 13:46:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DAEB76B0074; Thu, 30 Mar 2023 13:46:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CBC8C6B0071 for ; Thu, 30 Mar 2023 13:46:54 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7BB65C10FD for ; Thu, 30 Mar 2023 17:46:54 +0000 (UTC) X-FDA: 80626295148.26.47CA8E4 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by imf03.hostedemail.com (Postfix) with ESMTP id 8386820016 for ; Thu, 30 Mar 2023 17:46:52 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=LOdhm6zX; spf=pass (imf03.hostedemail.com: domain of willemdebruijn.kernel@gmail.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=willemdebruijn.kernel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680198412; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pMEUe6qirxhUGYqDUV527Cg0IXRczKbZPem5CQH2SRM=; b=Wje+wrA0viUqSYRLxIpu6JNRze6yV2AaCxnxuNvZy0MdoudTLjAm8a812FvT80Qm+10fpE qOfUtgRUctauhYC4YHq8P9sY0UeoBX8DfvuYSuByTadX8EODvl20de7RUKVWENvqfq/WZl Mey+MdPwin/e+vXzSlSppO7A1BMbw4U= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=LOdhm6zX; spf=pass (imf03.hostedemail.com: domain of willemdebruijn.kernel@gmail.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=willemdebruijn.kernel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680198412; a=rsa-sha256; cv=none; b=3eG/C1Ak8neae2wPyQJUFJU7ln8Ed1SosTTS4Q1n7r8s97g6IzrzajdoubKhwNWtz4ofR3 bGwY/9F9JhMCnBpojcRevKZN+Ro5HRYBhXlGm5MvgZEABrIS69HUGANwcgB0BSIab7aWV0 HDQe4V/A2+De6g0FDOhaesZVUD2OSMs= Received: by mail-qt1-f175.google.com with SMTP id p2so14181990qtw.13 for ; Thu, 30 Mar 2023 10:46:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680198411; x=1682790411; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=pMEUe6qirxhUGYqDUV527Cg0IXRczKbZPem5CQH2SRM=; b=LOdhm6zXTRmHE3Ehrf6yEqqMTuUaAEtD63od9/aRUc+Ot0L+YvYdImFrJnV060rDJC YvCXSCg7IonLi6kybFDwcT7fovxXp5f6RsXg4WpMr0PygIU0nsIDdnIoK8Epfk7E9Bs1 oJCIl+gZV7IycXxYj26utcOtRq9P5UEiER6KEt1PsZCHH1edvD+t6cdDhJIOpIFnF5hd 3MJWSkyq/q0qJ4ds+bUmuTQwBGJv0/uCsZsybmBbdre6WuSAskt3h7KI1866NcC85RZ3 yaEdCyIEWQn239IlxRZdmZt2IniPQbTMipYG43GTwHedzNpCOXxMectAvQhNGI7NlFIl eLEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680198411; x=1682790411; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=pMEUe6qirxhUGYqDUV527Cg0IXRczKbZPem5CQH2SRM=; b=NcVdQ6R8q5xULML3mU5L6vmIslZek+Au9lLhUP9lZAcF+KU5CQ4xjX+o8qwKSxOJum HNj0hvFthhMH9H3hYjlHfK4AeNLHjpitk6xVsW/Stbmub+/7NlQexV86vFIFZVXa7Du3 WVHGFdOa+3t5Bs88ccVlnDG3AIecdRekEgjvH2oCOtt8GvBO+iRSWZX3zMbsAO6F9JIQ fNBjtPtVMboMotTGW97xx1uxLzCra+4rD2nZ4cOIhaeso0A+p/Ug/M2i50rtUwgHjtKX 1F02Kn1vGdovMdgFiKabllsUbkXTrxIzZ9QH+X6mohjlQNydhZAfVWHIwyQMTbd1S9MQ SvtA== X-Gm-Message-State: AAQBX9cy/qjg0xi/8V4OVEUr8XIJVqfB+LVVfliRaUnSX4EHRrebj4Ds 4ERJPCs63R57S05vUei3Q6E= X-Google-Smtp-Source: AKy350YlNHw1f7seFH1iAbg2SQmDIpZYoD+JGXjW64hJRcJ8Ekejwr7Y7YBrMm3S/ICA9UDucPqB5A== X-Received: by 2002:a05:622a:1345:b0:3b9:e4cf:ce2d with SMTP id w5-20020a05622a134500b003b9e4cfce2dmr11700185qtk.16.1680198411666; Thu, 30 Mar 2023 10:46:51 -0700 (PDT) Received: from localhost (240.157.150.34.bc.googleusercontent.com. [34.150.157.240]) by smtp.gmail.com with ESMTPSA id r4-20020ac87944000000b003e38c9a2a22sm7377qtt.92.2023.03.30.10.46.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Mar 2023 10:46:41 -0700 (PDT) Date: Thu, 30 Mar 2023 13:46:39 -0400 From: Willem de Bruijn To: David Howells , Willem de Bruijn Cc: dhowells@redhat.com, Matthew Wilcox , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Chuck Lever III , Linus Torvalds , netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Message-ID: <6425caff220cd_21f5692082f@willemb.c.googlers.com.notmuch> In-Reply-To: <838854.1680187186@warthog.procyon.org.uk> References: <64259aca22046_21883920890@willemb.c.googlers.com.notmuch> <20230329141354.516864-1-dhowells@redhat.com> <20230329141354.516864-17-dhowells@redhat.com> <838854.1680187186@warthog.procyon.org.uk> Subject: Re: [RFC PATCH v2 16/48] ip, udp: Support MSG_SPLICE_PAGES Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: tjsu5133ieaxjb5izkepxqhxfzz3s1mp X-Rspam-User: X-Rspamd-Queue-Id: 8386820016 X-Rspamd-Server: rspam06 X-HE-Tag: 1680198412-304995 X-HE-Meta: U2FsdGVkX19PVxr5RGS0B/FpLLUhtjogfnZnduy+MureUPKU4IRrR0yUZ3TDFvu6lELJKCxFw7g7uXILw92Fo6SmRbsGuVYgs2RwSF4j/BY2eMfFYQ00FYUYMWAUEnOPrbxqq+kpLua0t0ec4q1hc5gyIb4tCWJ0WbcqPR1k6bDfxrI/+cTs4M+9q78079bN0WHVuSJ05JXf9vnQ88ytrmaaIV6boXaDWYgtj48Vx+rIR6wFTytDl3vF7EfMuSAKMwrjTNEyDVPj7dakNeimRVineNEN3L9xEzT9qS7Pqj6tLnzQt9oPwEGIDn/e0xvMJUc38m5Uxiy6t+TH2Diuqz/X4ssr39KKdyNjd8mSQandw80RqiCI+iRu8wbddzHwZiCZAGOWJHJmHQakO5QW4CUuZeZ+un+6XxbogmxtjSEeTX9iNQ8kE1PjqnwGiGugkVJ+JpT/nB8Th7Gxwqu5uf5VnyIK1mka8+m6Qmr7LZcTzyIPKVTYtLaYd8b9s1PQRgl1PkYRzWA9cwgj1MvPTbNzq3gbFL41trhHaKktNJk66WVnFqDJYvMwFJH8sDTcpjW4gwA2r5Qspu4UsmwJGOYHXOOpmv1pkqHbtk+k4uj/CxSP1gVf1rx4tNUGkcrcOHZbqMr2Xvpx3ipkacr1Ojxr3VWEXTrT/WcCjGzHnbAt4di3REA4e4TWBhkU1kImmQsK+4aloxAQOw7kn6f8mXx/QbXgyLTnWV8DGYr/NIcfXur8lZ6+pL9sPuppKlyHSHhy2MfUVZ+1Lk+I6euRojdqGk8TczNbOTma0Wcpy5aQUoRjiqCOPBQz4utCDGZGEI3HUoFbmVjGZrFkC+G0gidcwq9/G82PzSZ0VYJwHrNajIuV2MGC/Y6God7upiF8AddngdiHkLloOtiXC6ckIf4PUUcRFqBYhBJw0ghmEr16kiA5VbtkL4aAePAmmnh9cUQGZbJHnvQqNW5CgaC gVsBTyLG pEUO8SBaPfjoAflyRblNUi3CHElcfaJY82LAXbo0ibUPeid7BC4P9vhhD8zvXQsY9tqVOuzi//1o1Z217PPQ9pRjohhlxGNhX26bU0g4kYiP7gmNfnRBuctzuPnXFCDxAgAoq1gvCldfYubOHiXlPuWI259+ZUeRwzxc2+eYf3hUVIY4B1Z5w9qeqoXyKC5PbQeJNlWj/XeiV+4OB/UHYykHK9ySaMEEYpo+Bykk3NHAARMXzumt52xBmRZoLG1vrLVjnJscUB5Ham8XoYaO5fifXARkhJHGrELn5FdHu7dv/AiS4gy/cnR202fcMSzDHMGeh0kzzrgulnVvipJnLD1lecXxEBCvdsGjH7Togt39CcS9u/MufjzKp9fDzzRxOFMlWyZuzqVf1/PsLIsU5YevspFelb9t7Bcet2eWNT5byOnAlGYylEyo67DiT0qsavIM3cXquYhmIS49jiSoQa58e7a+L4/PPgqqKfqWYa+OJhXUQou8EeZlf7ZVYF7ZA79+w8F+Pz2mqegA6iLoRp803VpGOglAdjebh2iRWhjg50/ogIgy9F2ofxfYDR4sDiD7aT+omtLzH2Yv/VWzxKxmH6pkXIxkyz8a8tisNceoRNBlgCDI7bcpJnTNPqtGj6wiwUolOs6perORbinZ8MhRqVQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: David Howells wrote: > Willem de Bruijn wrote: > > > > diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c > > > > A non-RFC version would require the same for ipv6, of course. > > I missed the fact that ipv6 had it's own version of __ip_append_data() despite > sharing tcp_sendmsg(). Could __ip_append_data() and __ip6_append_data() be > shared? I guess that the v6_cork, the flowi6 and the ipcm6_cookie might > prevent that. We haven't been able to unify them before. As this series is complex enough as is, I would not attempt to include it. If it grows the code, maybe it'll be an incentive to take another look afterwards.