From: David Hildenbrand <david@redhat.com>
To: Hao Ge <gehao@kylinos.cn>, akpm@linux-foundation.org
Cc: willy@infradead.org, gehao618@163.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2] mm/page-flags: make PageMappingFlags return bool
Date: Thu, 4 Apr 2024 21:26:28 +0200 [thread overview]
Message-ID: <6442a40b-be04-49e8-9390-8742c82db3dd@redhat.com> (raw)
In-Reply-To: <20240321030712.80618-1-gehao@kylinos.cn>
On 21.03.24 04:07, Hao Ge wrote:
> make PageMappingFlags return bool like folio_mapping_flags
>
> Signed-off-by: Hao Ge <gehao@kylinos.cn>
>
> ---
> v2: Send this patch on the latest version
> ---
> include/linux/page-flags.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
> index 652d77805e99..5ee2d0ab62c6 100644
> --- a/include/linux/page-flags.h
> +++ b/include/linux/page-flags.h
> @@ -668,7 +668,7 @@ static __always_inline bool folio_mapping_flags(const struct folio *folio)
> return ((unsigned long)folio->mapping & PAGE_MAPPING_FLAGS) != 0;
> }
>
> -static __always_inline int PageMappingFlags(const struct page *page)
> +static __always_inline bool PageMappingFlags(const struct page *page)
> {
> return ((unsigned long)page->mapping & PAGE_MAPPING_FLAGS) != 0;
> }
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
prev parent reply other threads:[~2024-04-04 19:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240307131304.169859-1-gehao@kylinos.cn>
2024-03-21 3:07 ` [PATCH v2] mm/page-flags: make PageMappingFlags return bool Hao Ge
2024-03-21 3:12 ` Matthew Wilcox
2024-04-04 19:26 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6442a40b-be04-49e8-9390-8742c82db3dd@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=gehao618@163.com \
--cc=gehao@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).