From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f198.google.com (mail-qt0-f198.google.com [209.85.216.198]) by kanga.kvack.org (Postfix) with ESMTP id 92CA86B000D for ; Mon, 23 Jul 2018 13:28:05 -0400 (EDT) Received: by mail-qt0-f198.google.com with SMTP id z6-v6so1012449qto.4 for ; Mon, 23 Jul 2018 10:28:05 -0700 (PDT) Received: from outgoing-stata.csail.mit.edu (outgoing-stata.csail.mit.edu. [128.30.2.210]) by mx.google.com with ESMTP id p13-v6si8302693qvi.256.2018.07.23.10.28.04 for ; Mon, 23 Jul 2018 10:28:04 -0700 (PDT) Subject: Re: [RESEND] Spectre-v2 (IBPB/IBRS) and SSBD fixes for 4.4.y References: <153156030832.10043.13438231886571087086.stgit@srivatsa-ubuntu> <20180723112624.GA29710@kroah.com> From: "Srivatsa S. Bhat" Message-ID: <6473ed58-ed67-82a0-0781-20ac7275be0e@csail.mit.edu> Date: Mon, 23 Jul 2018 10:27:10 -0700 MIME-Version: 1.0 In-Reply-To: <20180723112624.GA29710@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Greg KH Cc: stable@vger.kernel.org, Denys Vlasenko , Bo Gan , Konrad Rzeszutek Wilk , Borislav Petkov , Thomas Gleixner , Ricardo Neri , Tom Lendacky , ak@linux.intel.com, linux-tip-commits@vger.kernel.org, Jia Zhang , Josh Poimboeuf , xen-devel@lists.xenproject.org, =?UTF-8?B?S3LEjW3DocWZ?= , Peter Zijlstra , Andy Lutomirski , Arnaldo Carvalho de Melo , Sherry Hurwitz , Kees Cook , linux-kernel@vger.kernel.org, Shuah Khan , Oleg Nesterov , torvalds@linux-foundation.org, dwmw@amazon.co.uk, karahmed@amazon.de, Borislav Petkov , dave.hansen@linux.intel.com, linux@dominikbrodowski.net, Quentin Casasnovas , Joerg Roedel , Alexander Shishkin , Kyle Huey , Will Drewry , Andrey Ryabinin , "H. Peter Anvin" , Brian Gerst , Kristen Carlson Accardi , Thomas Garnier , Andrew Morton , Joe Konno , kvm , Piotr Luc , boris.ostrovsky@oracle.com, Jan Beulich , arjan@linux.intel.com, Alexander Kuleshov , Juergen Gross , Ross Zwisler , =?UTF-8?Q?J=c3=b6rg_Otte?= , tim.c.chen@linux.intel.com, Alexander Sergeyev , Josh Triplett , gnomes@lxorguk.ukuu.org.uk, Tony Luck , Laura Abbott , dave.hansen@intel.com, Ingo Molnar , Mike Galbraith , Rik van Riel , "Kirill A. Shutemov" , Alexey Makhalov , Dave Hansen , ashok.raj@intel.com, Mel Gorman , =?UTF-8?B?TWlja2HDq2xTYWxhw7xu?= , Fenghua Yu , "Matt Helsley (VMware)" , Vince Weaver , Prarit Bhargava , rostedt@goodmis.org, Dan Williams , Jim Mattson , Dave Young , linux-edac , Jon Masters , Jiri Kosina , Andy Lutomirski , Paolo Bonzini , Arnd Bergmann , linux-mm@kvack.org, Jiri Olsa , arjan.van.de.ven@intel.com, sironi@amazon.de, Frederic Weisbecker , Kyle Huey , Alexander Popov , Andy Shevchenko , Nadav Amit , Yazen Ghannam , Wanpeng Li , Stephane Eranian , David Woodhouse , srivatsab@vmware.com On 7/23/18 4:26 AM, Greg KH wrote: > On Sat, Jul 14, 2018 at 02:25:43AM -0700, Srivatsa S. Bhat wrote: >> Hi Greg, >> >> This patch series is a backport of the Spectre-v2 fixes (IBPB/IBRS) >> and patches for the Speculative Store Bypass vulnerability to 4.4.y >> (they apply cleanly on top of 4.4.140). >> >> I used 4.9.y as my reference when backporting to 4.4.y (as I thought >> that would minimize the amount of fixing up necessary). Unfortunately >> I had to skip the KVM fixes for these vulnerabilities, as the KVM >> codebase is drastically different in 4.4 as compared to 4.9. (I tried >> my best to backport them initially, but wasn't confident that they >> were correct, so I decided to drop them from this series). >> >> You'll notice that the initial few patches in this series include >> cleanups etc., that are non-critical to IBPB/IBRS/SSBD. Most of these >> patches are aimed at getting the cpufeature.h vs cpufeatures.h split >> into 4.4, since a lot of the subsequent patches update these headers. >> On my first attempt to backport these patches to 4.4.y, I had actually >> tried to do all the updates on the cpufeature.h file itself, but it >> started getting very cumbersome, so I resorted to backporting the >> cpufeature.h vs cpufeatures.h split and their dependencies as well. I >> think apart from these initial patches, the rest of the patchset >> doesn't have all that much noise. >> >> This patchset has been tested on both Intel and AMD machines (Intel >> Xeon CPU E5-2660 v4 and AMD EPYC 7281 16-Core Processor, respectively) >> with updated microcode. All the patch backports have been >> independently reviewed by Matt Helsley, Alexey Makhalov and Bo Gan. >> >> I would appreciate if you could kindly consider these patches for >> review and inclusion in a future 4.4.y release. > > Given no one has complained about these yet, I've queued them all up, > including the 2 extra ones you sent afterward. > Great! Thank you very much! > Let's see what breaks :) > Hehe :) Regards, Srivatsa VMware Photon OS