From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E78CC3ABDD for ; Tue, 20 May 2025 15:22:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1F2A6B009D; Tue, 20 May 2025 11:22:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D0486B00A0; Tue, 20 May 2025 11:22:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C0156B00A1; Tue, 20 May 2025 11:22:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 699656B009D for ; Tue, 20 May 2025 11:22:22 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1E9F41606B0 for ; Tue, 20 May 2025 15:22:22 +0000 (UTC) X-FDA: 83463652524.01.FBE54ED Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by imf05.hostedemail.com (Postfix) with ESMTP id 1534B100006 for ; Tue, 20 May 2025 15:22:19 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KpmxIrag; spf=pass (imf05.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747754540; a=rsa-sha256; cv=none; b=eApY5Y7VKfPuUsFaAbNpk7CwtNIOPGO76Ua+fx9SlXC4hktVAFiKtmhhneCMGXKQFnEwDt ARj993KTFepwOlY3O9VWZ5jY6TETxxx3k2pfIBs/Aga7qO9Dg3Ntqzy334nflYwhoztDEp PrplUzwCDGsZ8HW3LaBaR+v05wYIzFk= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KpmxIrag; spf=pass (imf05.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747754540; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HPbVSjkW25BVpwZCUxpIFG7xTA4bYrqjMIINpvofoFc=; b=Tjh09oypiRJQRbowlZ0/Pe5Ip0UWekrPRsh2cloo5wbQE9oRFGtu/iZQtBBi3hYPuixf0C PSWxkpvg4TpYqIvqx+64OTAD8vggnuJNxBd+dd9CwsKbEzirJNHOfUm9C94qP+g9l/g03v eYGgYm7VSNf8G1M7CREd6hdTEt8jQIc= Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-601dd3dfc1fso5194535a12.0 for ; Tue, 20 May 2025 08:22:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747754538; x=1748359338; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HPbVSjkW25BVpwZCUxpIFG7xTA4bYrqjMIINpvofoFc=; b=KpmxIragVAqbQu19Qr/+4jxSo15zRa+1yZPfFFSEs/xmu5xQxf6A8Q6xpfZiWCJXcQ DvR0ptz52EzkzANcmqPl1dOolXl3ZqNHGwKu74jHXfeHRO70d3604gAt+alfonxiAoB1 Y8YbiiVG00Q0+OKs+cGgyKO1YJ0oY56d22inPthbvOgEXR5Tx/DJnD8PVWYp1gM6tD5G Mk+e+9/SvjJE+emwxPuJdKBNy5FilNtnHFouTb43Fnnyaa7Uz/6lbjQDi8OlUpCWjMlH Upsx79lYtViVATLX2YxPV4wMWkiA51tv1EKkmx1wpV2UZPAPGoppmxCkWkbNjQVGkvBz cTaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747754538; x=1748359338; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HPbVSjkW25BVpwZCUxpIFG7xTA4bYrqjMIINpvofoFc=; b=N6XtVZ3DkR8t4F1bHFJWlrvaKRMgVNW4rIIbnue6NE2Ui9dAUxsrXJbSiHdH/QNOjF 1wf+rUS4E4bemsZLEtiV8QBv261Og2KUcS2xtzZVUVMJD01jDUoYeDIlpejHxmB8ROio 0uNv9eDtk3/Wy0DCiG4TzD3sFUCCzooj+ro5gp+KXJQkwDxzE6ZEwsmaoZBNiI0RjW4r KiIF7p5ah5FIJGLVIyLlEGta+kL2DEEb7AQE6UqzeKlej7qL8RbvH09+OTHW1/xbmAw5 PwQmP0JgmWLU4Sba5AjEGRULFPzZDvO2iJRO0V89UDPsTlz5YLR1Ox6quB9FKlmbZE8g dWQA== X-Forwarded-Encrypted: i=1; AJvYcCWYSPmqqIqzO8BmP+1kxYBpj1b1XoMv0tVwxRbxgcOYCqirml7/eBUYqeR+xYDsAgXaLwSg9+nTrQ==@kvack.org X-Gm-Message-State: AOJu0Yxfx+GbHisRqvq03kaMuCySQesLi4yKYaKh4/+l/26Rq/PUXxGB GPK/1J11YSZ054sakuc6Y4ZfvzE02tMX7/dkobfyESjjA5JnxsRIHJF6 X-Gm-Gg: ASbGnctyoEAlw5DS1gX4Jqk3TgXEWHhVSZfMb+0S16NTKWd+VfpSJ3lBQFROH9jSC60 BobQ+SIlHDqyXv/FQ52FpIsxQiEdtjfZoP4ZQHOIKKHTXuWR2T+XWPXesmmgJxI1OL0ha/bP/In wUgyJ0TXjF0eRZ0FaB3VZmyYQIDPnsrQPon8fZ9HkYbsVvWBPXShhA/U4C7SkzkDacMgzN3Y2kY PMXcaHMrLkhod7j2q4L5NDv4fIsS62+hqmtqVAJ+pZai5FQsGVUIGzT8jTbzkk4LwuuPTpIgEvc aezrtNASh7c6JixLU8CBoI2SZ0qq0WQ/rpzqleDmZyfWtxz70QK1Y13BdtfU1BIhn2tTwJbcHeE v5XSGk7OSomfUO9+wi8spcQbD X-Google-Smtp-Source: AGHT+IFdBfhKTh3IRRTS1OzB+cE6Mi8ncamxWy1oCDWmqBxMDDzmmGVwOxOSP1OH37hHGmVHIGBoHw== X-Received: by 2002:a05:6402:3550:b0:5fd:10fe:9e86 with SMTP id 4fb4d7f45d1cf-60119cdd453mr16201818a12.28.1747754538066; Tue, 20 May 2025 08:22:18 -0700 (PDT) Received: from ?IPV6:2a03:83e0:1126:4:1c0a:f3ac:4087:51c8? ([2620:10d:c092:500::7:66a9]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6005ac327d5sm7334255a12.63.2025.05.20.08.22.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 May 2025 08:22:17 -0700 (PDT) Message-ID: <64b19c8f-e02e-490b-b987-9a996f36be21@gmail.com> Date: Tue, 20 May 2025 16:22:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] mm: slub: only warn once when allocating slab obj extensions fails To: Shakeel Butt , surenb@google.com, Harry Yoo Cc: Andrew Morton , hannes@cmpxchg.org, vlad.wing@gmail.com, linux-mm@kvack.org, kent.overstreet@linux.dev, linux-kernel@vger.kernel.org, kernel-team@meta.com, vbabka@suse.cz, cl@gentwo.org, rientjes@google.com, roman.gushchin@linux.dev References: <20250520122547.1317050-1-usamaarif642@gmail.com> <20250520122547.1317050-2-usamaarif642@gmail.com> Content-Language: en-US From: Usama Arif In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 1534B100006 X-Stat-Signature: cirgztxnq8jen13kci4kg5p9kme1m5bj X-HE-Tag: 1747754539-589840 X-HE-Meta: U2FsdGVkX1/VxdfWImnrhalZR1039AFy/QMddMrHGfCWJfleYmabQRDFzBpmKhnJT0JUEJrFYrmRKPad5dKecXTEvRkbLcv3u+OZZmpTRkmfIdwSIngWx5ceA8d1JWPMJ2+wk8f31NwasMdUEQp+4LX6JCL85ghzdhpOxcOvgjykCqmQLyAUbv67X9qtZlTdpq6a/FJc2MWY12qgp8EBTDLuPX13G756VFF8gxcal4IUl5m8crsHlxKguPIwWGbUekGS1kO05DkenkXON252AQI9zh8NxMA3TP2hDNytRlW8LmZZ1Raq96UDlOKaixUPlvnRJKNAuVppRVlYl2nxlcZ/zIxEMs4JSG/h7MX1EK9sAZ0Mb4sXtIFJNEG2TIXlNLnud+c/7+kEu2DiqYfqyUEfyHY7nw4InUIgNbo9N6cwTiVazYtKROeXxp9VRfCsATtqNc66fz98eV8hT7aw5WYJHjHPRZITBlTJHn74m7XIl9Wm3tm9eEHcJBXVzYpyFIaEZcWAOJyMSr9rAp7JTKuuh1UcO9o+iycL+83vJNdoqDiT226vU9bcksxsbBN4cnaxrkJ1LnCAh5qPYtqidZuXNL0fmymtUk+aGGdIE3uCPlDIWu39wBG/9ocqX1basRSBM3BgSoFsfkg4Tor6kXOfbcngxemekTQDYX1nxScImvjqdv00ETGEqsEK6TeNdY6gwFTnlGMD0XBFeWbDQdTRyA5QkiyETZNZsT3XdDGwdtG3BIA3sS2CoZ3h9/aD48hPTnDtD8by64XNydVJ8mvxNH3p8FAoORIn9R4cm559JjaX/e/JSdzVesylaI9+LjSWOxxFm8UB+wTTrUv8oaI6CDwJvQpilK3R9QRDOKHM3syknzw3mcUEwN59rAGdTuIHo3mk3sMyaaLMBYbyVMNL0zKXrgcWnmQ5QGG+2gtTEgcmBUlExgsw55I6ESXqmaPKZZll2bz9TJj2gTp amKB/jgm oVskTjt+60GNCVAXsgy5uaatkyqrjUj59Ist6TRH+Tt0cw/ISOI3NQXducfigRjoDOCCp8Lh83YbX/HWydGCW1JH3Ef8Y1zLOscpSJonkXOSqyN7GMsgOua7aeIpeG+jlqZpFzMhWrNqyPJYSKgvyE5LSt6bzi3ePfjcdDEeEtK8PS7qfIwBAyvsNC+IKMPwul84nXOD0NSdJ1gsrWsiKdz87ACrGGdSUe+tMAOdzAZL3NBysIB4/EwL/mbtbWxhCBQfFofj1K4Ptwi2JoFwBNUOI103igimCJoabzGukXMyUWyrhWM/8Te6g1bIem/vLTA9CZaJ34ilnO3ow7eVkE/+e1h66g0f0Mvi+5b11KI93T76i9MIXoee+OF6Kbea4/ZncrJWh4jeMJ0cKuxuwxVxD2ycltH9Cl2UQocyjY3ipbpMtaOFPJ5F+RzLwMRXK0DV8/wcoTyfPZZc+Bu4U3GaCezm0WhJL7NBqDwr31cuX23gCLiIevg2z0oEkSPizKZhxoOQi4OP8ZCOqJ+U5HOuM20Yb8uT3wguP6eI3eUaQC2I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20/05/2025 15:18, Shakeel Butt wrote: > On Tue, May 20, 2025 at 02:42:09PM +0100, Usama Arif wrote: >> >> >> On 20/05/2025 14:34, Harry Yoo wrote: >>> On Tue, May 20, 2025 at 01:25:47PM +0100, Usama Arif wrote: >>>> In memory bound systems, a large number of warnings for failing this >>>> allocation repeatedly may mask any real issues in the system >>>> during memory pressure being reported in dmesg. Change this to >>>> WARN_ONCE. >>>> >>>> Signed-off-by: Usama Arif >>>> Reported-by: Vlad Poenaru >>>> Closes: https://lore.kernel.org/all/17fab2d6-5a74-4573-bcc3-b75951508f0a@gmail.com/ >>>> --- >>> >>> Hi, >>> >>> Please Cc SLAB ALLOCATOR folks in MAINTAINERS on patches that touch >>> slab code ;) >>> >> >> Thanks for adding them to CC! I was just thinking of this as a memory >> allocation profiling issue and added the maintainers for it, >> but should have added slab maintainers as well. >> >> >>>> mm/slub.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/mm/slub.c b/mm/slub.c >>>> index bf43c403ead2..97cb3d9e8d00 100644 >>>> --- a/mm/slub.c >>>> +++ b/mm/slub.c >>>> @@ -2102,7 +2102,7 @@ prepare_slab_obj_exts_hook(struct kmem_cache *s, gfp_t flags, void *p) >>>> >>>> slab = virt_to_slab(p); >>>> if (!slab_obj_exts(slab) && >>>> - WARN(alloc_slab_obj_exts(slab, s, flags, false), >>>> + WARN_ONCE(alloc_slab_obj_exts(slab, s, flags, false), >>>> "%s, %s: Failed to create slab extension vector!\n", >>>> __func__, s->name)) >>> >>> I think this should be pr_warn_once()? >>> I'm not sure why this was WARN() in the first place. >>> >> >> Isn't WARN_ONCE the same as pr_warn_once but with needing the condition >> of the first arg to be true? We only want to warn if alloc_slab_obj_exts >> returns non-zero. So WARN_ONCE should be ok? >> > > The difference is the impact on panic_on_warn users which are mostly > testing bots. This warning is not actionable, so I agree with Harry to > covert this to pr_warn_once(). > Sounds good! Will change it to below for the next revision. Will wait for the kvmalloc conversation to conclude before sending the next revision. diff --git a/mm/slub.c b/mm/slub.c index 08804d2f2ead..ab0b7ee87159 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2101,11 +2101,13 @@ prepare_slab_obj_exts_hook(struct kmem_cache *s, gfp_t flags, void *p) return NULL; slab = virt_to_slab(p); - if (!slab_obj_exts(slab) && - WARN(alloc_slab_obj_exts(slab, s, flags, false), - "%s, %s: Failed to create slab extension vector!\n", - __func__, s->name)) - return NULL; + if (!slab_obj_exts(slab)) { + if(alloc_slab_obj_exts(slab, s, flags, false)) + pr_warn_once("%s, %s: Failed to create slab extension vector!\n", + __func__, s->name); + else + return NULL; + } return slab_obj_exts(slab) + obj_to_index(s, slab, p); }