Re: [PATCH] mm: Add kvfree_sensitive() for freeing sensitive data objects

David Howells
2020-04-06T07:44:25Z

David Rientjes <rientjes@google.com> wrote:

> > +static inline void kvfree_sensitive(const void *addr, size_t len)
> > +{
> > + if (addr) {
>
> Shouldn't this be if (unlikely(ZERO_OR_NULL_PTR(addr))?

You've reversed the logic - it needs a '!' there.

David