From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2B78EB64DC for ; Fri, 21 Jul 2023 15:13:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B5D86B0071; Fri, 21 Jul 2023 11:13:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13FE98D0001; Fri, 21 Jul 2023 11:13:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED44A6B0074; Fri, 21 Jul 2023 11:13:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D8C746B0071 for ; Fri, 21 Jul 2023 11:13:00 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 669ABC02EB for ; Fri, 21 Jul 2023 15:13:00 +0000 (UTC) X-FDA: 81035961720.13.F3DD179 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id DD18010001A for ; Fri, 21 Jul 2023 15:12:57 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EvkoIsl1; spf=pass (imf14.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689952378; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KuECWgmrt4c8ZTlDSWFvVOJXkvdaI59iER7noO41RWI=; b=hx972W10V4KC+YNpdFnlAWHSDFbgk9n7Pwj7CRHkFtoglb6ETmhkyxfwDn8tH6GA1Lu/V5 RQOwjBbpOF4AILkn+AVOSZh5ZeBZ8y5/jmEpcewkjzQTxzR+TnmHGGqLWDH18mi+0KVD5M tB9dD0KjLynJMd+VLNycz8bvNzMUXbE= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EvkoIsl1; spf=pass (imf14.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689952378; a=rsa-sha256; cv=none; b=DAK74vz5UIPz/AAAWdDe76ztzhGWVYVCd2h3O/viejzNW5+7N8Dr/izGnMiB+td4pJ5hCd Rc7tUPY2kDM1eglZtw4aenMI0YxaOABUpgMrw0hoTM691egw4mbfbXzqSNU8jVLAOk0zm4 snuIA1jURGijhTQaqQdpdQ+tABBs5Jc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689952377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KuECWgmrt4c8ZTlDSWFvVOJXkvdaI59iER7noO41RWI=; b=EvkoIsl1Ald/n0VtWGIJbPb/A4z3GOpRj0Fhdz3yIaJA9+IuTR5LFPxCvPVCsM/PPQhaFn qzg5hwNlD9wRgSbxTD2TWcJDQZR8wW/OAEghdUsxebgITTS5FZ+r49v9XHkPvQUSvVRIbm nP7MgLrNUnZr075+tH0CO8K6Rm76QwU= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-402-AmCI-4bANw6onENZ9wV6Uw-1; Fri, 21 Jul 2023 11:12:55 -0400 X-MC-Unique: AmCI-4bANw6onENZ9wV6Uw-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-4fb87c48aceso2076344e87.3 for ; Fri, 21 Jul 2023 08:12:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689952374; x=1690557174; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KuECWgmrt4c8ZTlDSWFvVOJXkvdaI59iER7noO41RWI=; b=DwKdjioHgsBsA9qsHW28wqvjwIIC0JH/hT2rdCr9ptFMsG5++91UnF5pTdJEbr5Tqc rTrb/DhRr5+j2GTz8GnIvB4iDpec2zJqfTX65aBli8r0VpV50xSMOqscaJRs+v33u3Ff XK9mF6FN/0DxKjPLOhxaTa5KJLCFQM7lA/G3zpbWGGiObGIjKptaXezILh4Ui8890Prm 5A/pwa8iCc2WF4AjCJTPvx5kNgPI19Dy1BLN9NgkhunXysOb3ay6cg2azdeC8bp1ZX8z 5UzrpMXBcGZxXlRNS5+gRmOfiNi4SLUz2c1t1YLxfz5gbug/ksKwybr0Vp1Ciuxq5ajR yd9w== X-Gm-Message-State: ABy/qLZ3CY6TIjcEoMTyrRgGB4FDYXBRZdDLRN6ZG1AsyExJfVzljKmu fjSzi5defrGuNVxzOaCv7MVeyeLBkQJFglUdsPm0ii03o3TWmqKzQ4n8LdZgwN/MSTgadp502rK epZJ3R7zGK8c= X-Received: by 2002:a19:e05b:0:b0:4fb:caed:95c3 with SMTP id g27-20020a19e05b000000b004fbcaed95c3mr1377444lfj.53.1689952374306; Fri, 21 Jul 2023 08:12:54 -0700 (PDT) X-Google-Smtp-Source: APBJJlG7b5XRxViP22WEsYjZVx9eEuQn7vFDvQWd5jPtrRlHnUDSnFTiFx5UF3BQ2XwQWfw7l/MGag== X-Received: by 2002:a19:e05b:0:b0:4fb:caed:95c3 with SMTP id g27-20020a19e05b000000b004fbcaed95c3mr1377407lfj.53.1689952373968; Fri, 21 Jul 2023 08:12:53 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id n1-20020a05640204c100b0051e0f21c43fsm2214094edw.31.2023.07.21.08.12.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Jul 2023 08:12:53 -0700 (PDT) Message-ID: <6519e3f4-7cea-01a6-724e-a0bce10c3c19@redhat.com> Date: Fri, 21 Jul 2023 17:12:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [RFC PATCH v11 16/29] KVM: Allow arch code to track number of memslot address spaces per VM To: Sean Christopherson , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Yu Zhang , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , Vlastimil Babka , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-17-seanjc@google.com> From: Paolo Bonzini In-Reply-To: <20230718234512.1690985-17-seanjc@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: DD18010001A X-Rspam-User: X-Stat-Signature: wwrpfjj3wjygy7w6i1moswc5s41s64eo X-Rspamd-Server: rspam01 X-HE-Tag: 1689952377-795875 X-HE-Meta: U2FsdGVkX1/ucn8Sx9r+P+79ArXa5SkgawTDudes9yQwyISHh+qBoE2k9JFCNGzFh570cUTv+vzfVHF28jJJxaRzyvs5xQT7iqlfoImnHnSt2OtK92lV6BNHoz4c7TSspf/uFgBtFFmBqj/FSR5dkHfK81fzAtVm+IUOxOWC2mv+osYpd7J6l+Nd2RqxujLQb8VbiI7iAYO7AurPaPCCbDqHWMdf/oaWg6bzEj51jgO6OSQuRe2RPi8MaME9fzCEFJtNnzlDlQEUtp1pVWP1xr0tgudlFZIZdGQyy8fb9ZXUL072E9hLae86R4C29ASx5BKB8lgM5PDByTNOpaT8lLiIUGHJrA0irov39C8qoFTkIibxJfOz2/k9cIqNwtaSI4ES6ZdALK+sKLxN0YtclH+UH91AbUvH6z7IEbppAWSjpDzlb8eWp4BQJYB2Rddfh8ghYEuEITxO2KG/2ERCGSN9Dl8z3vaEGO2Wmn4xRPOAmOKYVRVTJWFnflKfAQo34pMObOPTJELMjK7H1TNT5gk6nBIDc9KnIoWsXCP84Pt+FszvSH9HOoYWhxdToV9mDBDs5aEaEvCJHwoZb08tVo0MwBKcB2EVg6f4wGagVv1JDVYDnbofAcSLydMIQWo1wPQdaq6cVkFU7NnLQdVSOa/wwQllKQr4PTCvWx+htYhbruBEgp3kMAxoL6Po+xF1SkwAjTlzLqmxQi+nRMOckflhFqs9fX7jr/OQZyj38ii68vwmVMHVUVLhyPHQRj9u3J5Gt2KzeiqprgLwcqpkNO0F4J4VsxfsgXilZj5lvjOy4iOz0cT+yRd8Jx3iZ6mUSqnBDeOU5T547ZBiZM78yMDA9lNBQEUwomGGuO9QjLdFg4V4srOyOhIvQnV5rjaQDpzRYpTRNjtpoa5TN6NaWyS/z7gS3MkCi2lUEioVNP1ItcYcVjUWVAuSLsBOh0OsiZ6AQR5DZ8URglhmObf d8sgWCOl SBh2IiDQxt5SF74PuPYit/gasbk1CBnnx76yRaFWwCDgORMb4qap5zP2uvcj3CuB8f3iiZai6dBJZlYJAE+sJ5F6HDaHtzMUvRXfk9APIsz0Mp+Fx9q7Gg/mvau2ojKpsI4RDWzuIbLSw9vxwRJaIEO28y1gkQSRGWt7txkKvgBppvYktbShJAx25yMKUC4nJvt0EBAD9joV0X90XyUoKA8nDui8SMU5+EJoUPTGz52u5+z8KhukL5yqLuo6gpLgIcLiE5Zs1Hi9H6+CfpgJsgR4KoYk2MUPMtPh9/rkQXqU/bz7RxTmGpH7+Vd5U0JRsIx9llmF2nYnEODCM0GENY5+0YWqAFmZWl1y7HR1EKWMuANOtTpVlFZzKQw4bcSdW5tKIFqupH01gB2kvPBNkSkv1xWvrCq2vnPkD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/19/23 01:44, Sean Christopherson wrote: > @@ -4725,9 +4725,9 @@ static int kvm_vm_ioctl_check_extension_generic(struct kvm *kvm, long arg) > case KVM_CAP_IRQ_ROUTING: > return KVM_MAX_IRQ_ROUTES; > #endif > -#if KVM_ADDRESS_SPACE_NUM > 1 > +#if KVM_MAX_NR_ADDRESS_SPACES > 1 > case KVM_CAP_MULTI_ADDRESS_SPACE: > - return KVM_ADDRESS_SPACE_NUM; > + return KVM_MAX_NR_ADDRESS_SPACES; > #endif Since this is a VM ioctl, it should return kvm_arch_nr_memslot_as_ids(kvm) if kvm != NULL. Paolo