From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C42DC48BEB for ; Thu, 22 Feb 2024 10:20:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 203F46B0080; Thu, 22 Feb 2024 05:20:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 18DAB6B0081; Thu, 22 Feb 2024 05:20:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F214D6B0082; Thu, 22 Feb 2024 05:20:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DD18A6B0080 for ; Thu, 22 Feb 2024 05:20:57 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AA5ABC0D20 for ; Thu, 22 Feb 2024 10:20:57 +0000 (UTC) X-FDA: 81819046554.23.773DE74 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 557E0C0011 for ; Thu, 22 Feb 2024 10:20:54 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GlTkNOrc; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708597255; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Lcwqmq+d6xKT8k1pc3qQTHCV2WC3c9SdtMQAG9J3Qr8=; b=kKZCzGySVFXgerEOcZb0gJYHg/HfMr7Fl16kFwOCgEvvZ5yush+cI04B2VYmT9hFpTzco+ hRRO5nZgNkk0LtLXvM3+6tTbtecc9MJ6sMwFFSYHaa0jLufUGgQOBG0w2YJPzDPLkb17Hj RDk5iZAZUtR99B+sEcwrs1PQsdhHeQE= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GlTkNOrc; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708597255; a=rsa-sha256; cv=none; b=EeJtL/8YSe6nClNW6ZujeWoYGFgoG8o78Gj8N8XYRsDPy+ejZEO1tt8gMCczXrwPtwBaVn nyj9oXgN6kVhesTRRc1k3r6DgEKmBd+O6NwAgBOnHdtg+RDAb+HS2zV1Sr8GN3a4ENOQtT sr8RrMVF6rOsQ4blna2wAcZi+FaqHyk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708597253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Lcwqmq+d6xKT8k1pc3qQTHCV2WC3c9SdtMQAG9J3Qr8=; b=GlTkNOrccbtxlIAxiqigHlJ4WMWtyjgFXkZEpzEHlUEOIPK2lpjfsUjRe5bjJTitkI1DLV 9BNAZdVyILNOoFkILVV/KXcOmJkylPQkyQh4KMWy9fAPcxAJu7h8VH7/dud8XPhZpnd7I7 7oLiWfLHvBGW154+fnUMObv0aMIEbaA= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-287-P5R3eBv5PNi_UTHRGPi0hA-1; Thu, 22 Feb 2024 05:20:51 -0500 X-MC-Unique: P5R3eBv5PNi_UTHRGPi0hA-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-512a00a2651so1722644e87.1 for ; Thu, 22 Feb 2024 02:20:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708597250; x=1709202050; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:from:content-language:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Lcwqmq+d6xKT8k1pc3qQTHCV2WC3c9SdtMQAG9J3Qr8=; b=inZcoEX2fTqMLKQxu5j4B1T6huuqbcrFE/Sd496A1YiEskop7Y3nvQizoUOAtmu68B mZ2azDM2ctH7eG2dgH7Qw0f1tB1LgkB2QxxTX1iRkUoddoIXAIWTARoA8ybc+Xoa7TZT rBWoVPIyL4zkTvUjhaPo75WhXUj7Hpn7Jiio1bRZuy/Y2q5AmNozx021UO7bBrBDYGIn sC7yXnFzgCllh5qPKdiyB0H+YDRAWDcszcu5nFj/beBRekoVfUi30T6TaVZhLPhCxpoe YUV/idd4tnwPQB8Ue8Rp77fQ8BGgFsWdGsdBygj1xKRma70eROrs5EriRwHKM5GBcrXU Jicw== X-Forwarded-Encrypted: i=1; AJvYcCXWclDXvM9pgzS8FKmt9iTfLwarVHSE0bzMmouiqpJAXCloOA3cZynZAeIzNoxO0TRT0FzsQsD2g8vjXoKaqD839eU= X-Gm-Message-State: AOJu0YwFJISsxnEcnOTcaGREzDrlwwpWYWXrzPj2tTRXo4gvo6kr7Tbk f29BZGCqc5jjV/XdWIH5Xp0QQyJeGfw2iGN44Db42cMAPGnrOR9z/6tw3E1a26srJxpX1NpJzp1 prpaOuxpUkfVdDzqoQHPYhcmeDfh6UsTTtPa64ZmA47Gak61Z X-Received: by 2002:ac2:4893:0:b0:512:9e78:998c with SMTP id x19-20020ac24893000000b005129e78998cmr8731722lfc.9.1708597250166; Thu, 22 Feb 2024 02:20:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IFZGHDJwTeoaSkxVBGscC/OhuKuPQZf4f5Gqv2aI1oHCnc5cOR7OlCp5eekB6/sFE3drryEiQ== X-Received: by 2002:ac2:4893:0:b0:512:9e78:998c with SMTP id x19-20020ac24893000000b005129e78998cmr8731700lfc.9.1708597249777; Thu, 22 Feb 2024 02:20:49 -0800 (PST) Received: from ?IPV6:2003:cb:c70f:8b00:ed48:6d18:2152:1cda? (p200300cbc70f8b00ed486d1821521cda.dip0.t-ipconnect.de. [2003:cb:c70f:8b00:ed48:6d18:2152:1cda]) by smtp.gmail.com with ESMTPSA id a10-20020a05600c224a00b004128da16dddsm185325wmm.15.2024.02.22.02.20.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Feb 2024 02:20:49 -0800 (PST) Message-ID: <6541e29b-f25a-48b8-a553-fd8febe85e5a@redhat.com> Date: Thu, 22 Feb 2024 11:20:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] mm: swap: Remove CLUSTER_FLAG_HUGE from swap_cluster_info:flags From: David Hildenbrand To: Ryan Roberts , Andrew Morton , Matthew Wilcox , Huang Ying , Gao Xiang , Yu Zhao , Yang Shi , Michal Hocko , Kefeng Wang Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20231025144546.577640-1-ryan.roberts@arm.com> <20231025144546.577640-2-ryan.roberts@arm.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 557E0C0011 X-Rspam-User: X-Stat-Signature: o1jur6tgz797zggwrwt9kk3tox6o9t7j X-Rspamd-Server: rspam01 X-HE-Tag: 1708597254-818028 X-HE-Meta: U2FsdGVkX1+QcBtRXGS9VkBbKmXmVtZlMwFreJwp89CDpZlxMlQyBzRO4eYqg1M2Swc+Ot9hdmE+lmi9SmxqJnocp3XXeGc+yFos2QCd49aswpDAo4XrJjdiUsDZi+tlrqOf9BWP4hedwYXMktriC0JjpokpPwiSFOZ1Lb6ElprxvM4/7W9V6rinw5ueHd5E2iVONiJczoKCYmzUR7foh8RBxxL2CxqHOwsiAjCBTndX4BwctwXLEjLmn7OgvyckZaLCv5vvieksfPbm4vLLTSlMxnoinYpsLkmWLd1OmTfBpMjgN+fSp3MidJS16cuBfaOyByw7TSzB6aNjHmv//lNciabRkmBb6sQmo3q3+naRRchM5/TWXSQrjHs562QBv0vgS+Qy9s71VNvyci4r3nJ28vVAojjcN45K2VZg8IJ22QByF5vkTzGSEf1IjzRAkI1qrCvUFqQWTqh4VukSJZJ3Rg/ZDXiMZWsTNW2IEP5gsWW80EYX5LLnRJWQukt/19ax0fQvCesJtPo87GrpUC+hzL9Al28alP82ddFHBmr+sIzG4qcrKsZIO+66ubNWaitbbMP2JNsIET8K7xKYT/o/MCOuNe88m/APbsXASkt3UZRIhlI/1WK3Ldt15wLGYYiW6lK9mzzxViNSWdwLTvXjqgIWpBiq71cs8D1i1ig205rHydZN0Xe7M1DGciLWgsWmAhEiq6dnVIm8n7l+ibBsvT7ZzecHgkm47VCDhBNht6JG/f51YO7aMBkQt/dUfm8QHJuShvGcbvxv9s2VT2jKOG+pDvGtyHLbbUI7s7uIGvzAWWcXQtnIRsZ06EkxrPiFseeKVmJiQvcqXCNxdMNMAY4uOVmqyyX33tOYbA3YtXVmk1MT0jw4Ke7gwg22m9AW/vA/1xfyzGRbbGdn07DuXjnmaNqav2Ef92+lK0QzEdvwsePjXmUsrrX9KhNJBH0MczgpYNaWNXzPunq ms08QLjp B8UM3Ll0JLOY0Tb631WSsTSO5h292NA5EJ5pghnIuodw3tBaIDohD03fbgyWnFaIicYB9GHnf5diMKswYcFqgkHeo7svPv/EFY+hoUR4kR3ui372A9D94a8vUg9m+nFIlexz4BzYSP2wE9e5yxdCsX3+4ngIUY0oW7OaaV/65HbOUyptRghm/CK3s//ZaIt2P64okUQp7aJY/yTglShafwhvUCuy+Q/wO8/J+o86uK7xY4rjFMOVCm0bwGGzVKt3hRV1N1vg2C3vROsFPHmLwoP58YC+c5wSSiBuMm3oV9Levs1FZVDzeik/KG8R6jp94OJUTxxVD/3JdzM3u8hhYRw69u+Z1i8vn0JBVLHMhNiNIrQR/tCqt4umm27eK+06YqGsRqxKTccoMKIsiyWdTjEM0w/VWClP1mLDS2SW6JpRRTU0wlfwPUz6HTay82qK/Ljfm8TRwZ+GEpcQdXFQLfTKFLQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.02.24 11:19, David Hildenbrand wrote: > On 25.10.23 16:45, Ryan Roberts wrote: >> As preparation for supporting small-sized THP in the swap-out path, >> without first needing to split to order-0, Remove the CLUSTER_FLAG_HUGE, >> which, when present, always implies PMD-sized THP, which is the same as >> the cluster size. >> >> The only use of the flag was to determine whether a swap entry refers to >> a single page or a PMD-sized THP in swap_page_trans_huge_swapped(). >> Instead of relying on the flag, we now pass in nr_pages, which >> originates from the folio's number of pages. This allows the logic to >> work for folios of any order. >> >> The one snag is that one of the swap_page_trans_huge_swapped() call >> sites does not have the folio. But it was only being called there to >> avoid bothering to call __try_to_reclaim_swap() in some cases. >> __try_to_reclaim_swap() gets the folio and (via some other functions) >> calls swap_page_trans_huge_swapped(). So I've removed the problematic >> call site and believe the new logic should be equivalent. > > That is the __try_to_reclaim_swap() -> folio_free_swap() -> > folio_swapped() -> swap_page_trans_huge_swapped() call chain I assume. > > The "difference" is that you will now (1) get another temporary > reference on the folio and (2) (try)lock the folio every time you > discard a single PTE of a (possibly) large THP. > Thinking about it, your change will not only affect THP, but any call to free_swap_and_cache(). Likely that's not what we want. :/ -- Cheers, David / dhildenb