From: David Hildenbrand <david@redhat.com>
To: Minchan Kim <minchan@kernel.org>,
syzbot <syzbot+8e6326965378936537c3@syzkaller.appspotmail.com>
Cc: akpm@linux-foundation.org, chris@chrisdown.name,
chris@zankel.net, dancol@google.com, dave.hansen@intel.com,
hannes@cmpxchg.org, hdanton@sina.com,
james.bottomley@hansenpartnership.com,
kirill.shutemov@linux.intel.com, ktkhai@virtuozzo.com,
laoar.shao@gmail.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, mgorman@techsingularity.net,
mhocko@kernel.org, mhocko@suse.com, oleksandr@redhat.com,
ralf@linux-mips.org, rth@twiddle.net, sfr@canb.auug.org.au,
shakeelb@google.com, sonnyrao@google.com, surenb@google.com,
syzkaller-bugs@googlegroups.com, timmurray@google.com,
yang.shi@linux.alibaba.com
Subject: Re: kernel BUG at mm/vmscan.c:LINE! (2)
Date: Mon, 28 Oct 2019 17:18:19 +0100 [thread overview]
Message-ID: <658defc9-8727-dfbd-7e27-94f7cc36cf4a@redhat.com> (raw)
In-Reply-To: <20190802200643.GA181880@google.com>
On 02.08.19 22:06, Minchan Kim wrote:
> On Fri, Aug 02, 2019 at 10:58:05AM -0700, syzbot wrote:
>> Hello,
>>
>> syzbot found the following crash on:
>>
>> HEAD commit: 0d8b3265 Add linux-next specific files for 20190729
>> git tree: linux-next
>> console output: https://syzkaller.appspot.com/x/log.txt?x=1663c7d0600000
>> kernel config: https://syzkaller.appspot.com/x/.config?x=ae96f3b8a7e885f7
>> dashboard link: https://syzkaller.appspot.com/bug?extid=8e6326965378936537c3
>> compiler: gcc (GCC) 9.0.0 20181231 (experimental)
>> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=133c437c600000
>> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=15645854600000
>>
>> The bug was bisected to:
>>
>> commit 06a833a1167e9cbb43a9a4317ec24585c6ec85cb
>> Author: Minchan Kim <minchan@kernel.org>
>> Date: Sat Jul 27 05:12:38 2019 +0000
>>
>> mm: introduce MADV_PAGEOUT
>>
>> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1545f764600000
>> final crash: https://syzkaller.appspot.com/x/report.txt?x=1745f764600000
>> console output: https://syzkaller.appspot.com/x/log.txt?x=1345f764600000
>>
>> IMPORTANT: if you fix the bug, please add the following tag to the commit:
>> Reported-by: syzbot+8e6326965378936537c3@syzkaller.appspotmail.com
>> Fixes: 06a833a1167e ("mm: introduce MADV_PAGEOUT")
>>
>> raw: 01fffc0000090025 dead000000000100 dead000000000122 ffff88809c49f741
>> raw: 0000000000020000 0000000000000000 00000002ffffffff ffff88821b6eaac0
>> page dumped because: VM_BUG_ON_PAGE(PageActive(page))
>> page->mem_cgroup:ffff88821b6eaac0
>> ------------[ cut here ]------------
>> kernel BUG at mm/vmscan.c:1156!
>> invalid opcode: 0000 [#1] PREEMPT SMP KASAN
>> CPU: 1 PID: 9846 Comm: syz-executor110 Not tainted 5.3.0-rc2-next-20190729
>> #54
>> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
>> Google 01/01/2011
>> RIP: 0010:shrink_page_list+0x2872/0x5430 mm/vmscan.c:1156
>
> My old version had PG_active flag clear but it seems to lose it with revising
> patchsets. Thanks, Sizbot!
>
> From 66d64988619ef7e86b0002b2fc20fdf5b84ad49c Mon Sep 17 00:00:00 2001
> From: Minchan Kim <minchan@kernel.org>
> Date: Sat, 3 Aug 2019 04:54:02 +0900
> Subject: [PATCH] mm: Clear PG_active on MADV_PAGEOUT
>
> shrink_page_list expects every pages as argument should be no active
> LRU pages so we need to clear PG_active.
>
> Reported-by: syzbot+8e6326965378936537c3@syzkaller.appspotmail.com
> Fixes: 06a833a1167e ("mm: introduce MADV_PAGEOUT")
I think this should be
Fixed: 1a4e58cce84e ("mm: introduce MADV_PAGEOUT")
$ git show 1a4e58cce84e
commit 1a4e58cce84ee88129d5d49c064bd2852b481357
Author: Minchan Kim <minchan@kernel.org>
Date: Wed Sep 25 16:49:15 2019 -0700
mm: introduce MADV_PAGEOUT
[...]
$ git tag --contains 1a4e58cce84ee88129d5d49c064bd2852b481357
[...]
v5.4-rc5
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2019-10-28 16:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 17:58 kernel BUG at mm/vmscan.c:LINE! (2) syzbot
2019-08-02 20:06 ` Minchan Kim
2019-08-06 8:29 ` Michal Hocko
2019-08-08 16:34 ` Dmitry Vyukov
2019-10-28 16:18 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=658defc9-8727-dfbd-7e27-94f7cc36cf4a@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=chris@chrisdown.name \
--cc=chris@zankel.net \
--cc=dancol@google.com \
--cc=dave.hansen@intel.com \
--cc=hannes@cmpxchg.org \
--cc=hdanton@sina.com \
--cc=james.bottomley@hansenpartnership.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=ktkhai@virtuozzo.com \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=oleksandr@redhat.com \
--cc=ralf@linux-mips.org \
--cc=rth@twiddle.net \
--cc=sfr@canb.auug.org.au \
--cc=shakeelb@google.com \
--cc=sonnyrao@google.com \
--cc=surenb@google.com \
--cc=syzbot+8e6326965378936537c3@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=timmurray@google.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).