From: "Paul Menage" <menage@google.com>
To: YAMAMOTO Takashi <yamamoto@valinux.co.jp>
Cc: kamezawa.hiroyu@jp.fujitsu.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
balbir@in.ibm.com, xemul@openvz.org
Subject: Re: [PATCH 0/2] cgroup map files: Add a key/value map file type to cgroups
Date: Tue, 19 Feb 2008 22:02:00 -0800 [thread overview]
Message-ID: <6599ad830802192202t19c1f597jb7927e975eb80aa6@mail.gmail.com> (raw)
In-Reply-To: <20080220054809.86BFC1E3C58@siro.lan>
On Feb 19, 2008 9:48 PM, YAMAMOTO Takashi <yamamoto@valinux.co.jp> wrote:
>
> it changes the format from "%s %lld" to "%s: %llu", right?
> why?
>
The colon for consistency with maps in /proc. I think it also makes it
slightly more readable.
For %lld versus %llu - I think that cgroup resource APIs are much more
likely to need to report unsigned rather than signed values. In the
case of the memory.stat file, that's certainly the case.
But I guess there's an argument to be made that nothing's likely to
need the final 64th bit of an unsigned value, whereas the ability to
report negative numbers could potentially be useful for some cgroups.
Paul
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-02-20 6:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-20 5:15 [PATCH 0/2] cgroup map files: Add a key/value map file type to cgroups menage
2008-02-20 5:15 ` [PATCH 1/2] cgroup map files: Add cgroup map data type menage
2008-02-20 5:15 ` [PATCH 2/2] cgroup map files: Use cgroup map for memcontrol stats file menage
2008-02-20 5:48 ` [PATCH 0/2] cgroup map files: Add a key/value map file type to cgroups YAMAMOTO Takashi
2008-02-20 6:02 ` Paul Menage [this message]
2008-02-20 6:14 ` YAMAMOTO Takashi
2008-02-20 6:25 ` Paul Menage
-- strict thread matches above, loose matches on Subject: below --
2008-02-21 21:28 menage
2008-02-23 8:04 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6599ad830802192202t19c1f597jb7927e975eb80aa6@mail.gmail.com \
--to=menage@google.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@in.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=xemul@openvz.org \
--cc=yamamoto@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).