linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Paul Menage" <menage@google.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: balbir@linux.vnet.ibm.com,
	Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: on CONFIG_MM_OWNER=y, kernel panic is possible.
Date: Tue, 6 May 2008 20:37:50 -0700	[thread overview]
Message-ID: <6599ad830805062037n221ef8e2n9ee7ac33417ab499@mail.gmail.com> (raw)
In-Reply-To: <20080506153943.AC69.KOSAKI.MOTOHIRO@jp.fujitsu.com>

On Mon, May 5, 2008 at 11:43 PM, KOSAKI Motohiro
<kosaki.motohiro@jp.fujitsu.com> wrote:
> > >  #ifdef CONFIG_MM_OWNER
>  > > -       struct task_struct *owner;      /* The thread group leader that */
>  > > -                                       /* owns the mm_struct.          */
>  > > +       struct task_struct *owner;      /* point to one of task that owns the mm_struct. */
>  > >  #endif
>  > >
>  > >  #ifdef CONFIG_PROC_FS
>  >
>  > How about just, the task that owns the mm_struct? One of, implies multiple owners.
>
>  Ah, below is better?
>
>  /* point to any one of task that related the mm_struct. */

I'd word it as

/*
 * "owner" points to a task that is regarded as the canonical
 * user/owner of this mm. All of the following must be true in
 * order for it to be changed:
 *
 * current == mm->owner
 * current->mm != mm
 * new_owner->mm == mm
 * new_owner->alloc_lock is held
 */

Paul

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-05-07  3:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-06  5:40 on CONFIG_MM_OWNER=y, kernel panic is possible KOSAKI Motohiro
2008-05-06  5:48 ` Balbir Singh
2008-05-06  6:03   ` KOSAKI Motohiro
2008-05-06  6:18     ` KOSAKI Motohiro
2008-05-06  6:28       ` Balbir Singh
2008-05-06  6:43         ` KOSAKI Motohiro
2008-05-07  3:37           ` Paul Menage [this message]
2008-05-07 23:55             ` [PATCH] on CONFIG_MM_OWNER=y, kernel panic is possible. take2 KOSAKI Motohiro
2008-05-08 13:53               ` Balbir Singh
2008-05-06  6:32     ` on CONFIG_MM_OWNER=y, kernel panic is possible Balbir Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6599ad830805062037n221ef8e2n9ee7ac33417ab499@mail.gmail.com \
    --to=menage@google.com \
    --cc=Lee.Schermerhorn@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).