From: Paul Menage <menage@google.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>,
"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
"lizf@cn.fujitsu.com" <lizf@cn.fujitsu.com>
Subject: Re: [RFC][PATCH 4/4] cgroup-memcg fix frequent EBUSY at rmdir
Date: Tue, 13 Jan 2009 18:48:43 -0800 [thread overview]
Message-ID: <6599ad830901131848gf7f6996iead1276bc50753b8@mail.gmail.com> (raw)
In-Reply-To: <20090108183529.b4fd99f4.kamezawa.hiroyu@jp.fujitsu.com>
On Thu, Jan 8, 2009 at 1:35 AM, KAMEZAWA Hiroyuki
<kamezawa.hiroyu@jp.fujitsu.com> wrote:
> + if (ret == -EAGAIN) { /* subsys asks us to retry later */
> + mutex_unlock(&cgroup_mutex);
> + cond_resched();
> + goto retry;
> + }
This spinning worries me a bit. It might be better to do an
interruptible sleep until the relevant CSS's refcount goes down to
zero. And is there no way that the memory controller can hang on to a
reference indefinitely, if the cgroup still has some pages charged to
it?
Paul
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-01-14 2:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 9:25 [RFC][PATCH] cgroup and memcg updates 20090108 KAMEZAWA Hiroyuki
2009-01-08 9:28 ` [RFC][PATCH 1/4] cgroup: support per cgroup subsys state ID (CSS ID) KAMEZAWA Hiroyuki
2009-01-09 3:59 ` Li Zefan
2009-01-09 4:24 ` KAMEZAWA Hiroyuki
2009-01-10 0:23 ` Paul Menage
2009-01-10 0:49 ` KAMEZAWA Hiroyuki
2009-01-12 7:21 ` Balbir Singh
2009-01-15 6:12 ` KAMEZAWA Hiroyuki
2009-01-13 7:40 ` Li Zefan
2009-01-13 9:22 ` KAMEZAWA Hiroyuki
2009-01-08 9:30 ` [RFC][PATCH 2/4] memcg: use CSS ID in memcg KAMEZAWA Hiroyuki
2009-01-12 12:14 ` Balbir Singh
2009-01-15 6:19 ` KAMEZAWA Hiroyuki
2009-01-08 9:32 ` [RFC][PATCH 3/4] memcg: fix OOM KILL under hierarchy KAMEZAWA Hiroyuki
2009-01-13 8:33 ` Li Zefan
2009-01-13 9:25 ` KAMEZAWA Hiroyuki
2009-01-08 9:35 ` [RFC][PATCH 4/4] cgroup-memcg fix frequent EBUSY at rmdir KAMEZAWA Hiroyuki
2009-01-14 2:48 ` Paul Menage [this message]
2009-01-14 3:00 ` KAMEZAWA Hiroyuki
2009-01-14 3:05 ` Paul Menage
2009-01-14 3:12 ` KAMEZAWA Hiroyuki
2009-01-20 10:47 ` [RFC][PATCH 4/4] cgroup-memcg fix frequent EBUSY at rmdir v2 KAMEZAWA Hiroyuki
2009-01-21 10:00 ` Paul Menage
2009-01-21 10:32 ` KAMEZAWA Hiroyuki
2009-01-21 10:43 ` Paul Menage
2009-01-21 10:45 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6599ad830901131848gf7f6996iead1276bc50753b8@mail.gmail.com \
--to=menage@google.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).