From: Paul Menage <menage@google.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lizf@cn.fujitsu.com" <lizf@cn.fujitsu.com>,
"balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>,
"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: Re: [PATCH 1.5/4] cgroup: delay populate css id
Date: Wed, 21 Jan 2009 01:36:32 -0800 [thread overview]
Message-ID: <6599ad830901210136j9baf45ft4c86a93fec70827f@mail.gmail.com> (raw)
In-Reply-To: <20090120144337.82ed51d5.kamezawa.hiroyu@jp.fujitsu.com>
On Mon, Jan 19, 2009 at 9:43 PM, KAMEZAWA Hiroyuki
<kamezawa.hiroyu@jp.fujitsu.com> wrote:
> +static void populate_css_id(struct cgroup_subsys_state *css)
> +{
> + struct css_id *id = rcu_dereference(css->id);
> + if (id)
> + rcu_assign_pointer(id->css, css);
> +}
I don't think this needs to be split out into a separate function.
Also, there's no need for an rcu_dereference(), since we're holding
cgroup_mutex.
Paul
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-01-21 9:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-15 10:21 [PATCH 0/4] cgroup/memcg : updates related to CSS KAMEZAWA Hiroyuki
2009-01-15 10:25 ` [PATCH 1/4] cgroup: add CSS ID KAMEZAWA Hiroyuki
2009-01-16 1:18 ` Li Zefan
2009-01-20 1:57 ` Paul Menage
2009-01-22 2:37 ` Daisuke Nishimura
2009-01-22 2:59 ` KAMEZAWA Hiroyuki
2009-01-15 10:27 ` [PATCH 2/4] cgroup:add css_is_populated KAMEZAWA Hiroyuki
2009-01-16 3:00 ` KAMEZAWA Hiroyuki
2009-01-20 1:41 ` Paul Menage
2009-01-20 1:51 ` Li Zefan
2009-01-20 1:55 ` Paul Menage
2009-01-20 1:39 ` Paul Menage
2009-01-20 2:02 ` KAMEZAWA Hiroyuki
2009-01-20 2:23 ` Paul Menage
2009-01-20 2:58 ` KAMEZAWA Hiroyuki
2009-01-20 5:43 ` [PATCH 1.5/4] cgroup: delay populate css id KAMEZAWA Hiroyuki
2009-01-21 9:36 ` Paul Menage [this message]
2009-01-21 10:34 ` KAMEZAWA Hiroyuki
2009-01-22 2:06 ` KAMEZAWA Hiroyuki
2009-01-22 2:13 ` Paul Menage
2009-01-15 10:29 ` [PATCH 3/4] memcg: hierarchical reclaim by CSS ID KAMEZAWA Hiroyuki
2009-01-16 1:29 ` Li Zefan
2009-01-16 1:38 ` KAMEZAWA Hiroyuki
2009-01-16 1:49 ` Li Zefan
2009-01-16 1:58 ` KAMEZAWA Hiroyuki
2009-01-16 2:22 ` KAMEZAWA Hiroyuki
2009-01-16 7:35 ` Li Zefan
2009-01-16 7:49 ` KAMEZAWA Hiroyuki
2009-01-15 10:32 ` [PATCH 4/4] memcg : read_statistics update to show total score KAMEZAWA Hiroyuki
2009-01-15 10:51 ` [PATCH 0/4] cgroup/memcg : updates related to CSS Balbir Singh
2009-01-15 10:58 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6599ad830901210136j9baf45ft4c86a93fec70827f@mail.gmail.com \
--to=menage@google.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).