From: CAI Qian <caiqian@redhat.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Nishanth Aravamudan <nacc@us.ibm.com>
Subject: Re: [RFC] /sys/kernel/mm/hugepages/hugepages-1048576kB/nr_overcommit_hugepages
Date: Wed, 5 Jan 2011 03:54:16 -0500 (EST) [thread overview]
Message-ID: <666501532.135624.1294217656273.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com> (raw)
In-Reply-To: <20110105084357.GA21349@tiehlicka.suse.cz>
> OK, this explains the bogus value because hugetlb_overcommit_handler
> doesn't check the return value of proc_doulongvec_minmax which fails
> for
> "\n" string which you are writing to the file so we end up setting a
> random value from the stack. The following patch should fix this:
>
> Btw. what did you want to achieve by this command?
Just to do some testing for robustness. :)
CAI Qian
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-01-05 8:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1060163918.101411.1293793346203.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
2010-12-31 11:08 ` [RFC] /sys/kernel/mm/hugepages/hugepages-1048576kB/nr_overcommit_hugepages CAI Qian
2011-01-04 9:56 ` Michal Hocko
2011-01-04 10:21 ` CAI Qian
2011-01-04 10:52 ` Michal Hocko
2011-01-05 4:52 ` CAI Qian
2011-01-05 8:43 ` Michal Hocko
2011-01-05 8:54 ` CAI Qian [this message]
2011-01-05 9:51 ` Michal Hocko
2011-01-05 15:36 ` CAI Qian
2011-01-05 15:59 ` Michal Hocko
2011-01-05 16:42 ` CAI Qian
2011-01-05 16:44 ` Michal Hocko
2011-01-05 17:00 ` CAI Qian
2011-01-05 20:59 ` Andrew Morton
2011-01-06 10:04 ` PATCH: hugetlb: handle NODEMASK_ALLOC failure correctly Michal Hocko
2011-01-06 20:38 ` Andrew Morton
2011-01-06 22:23 ` Michal Hocko
2011-01-04 17:21 ` [RFC] /sys/kernel/mm/hugepages/hugepages-1048576kB/nr_overcommit_hugepages Eric B Munson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=666501532.135624.1294217656273.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com \
--to=caiqian@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=nacc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).