From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78EC8C7EE31 for ; Thu, 26 Jun 2025 18:11:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D2FE6B00AD; Thu, 26 Jun 2025 14:11:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1AA456B00AE; Thu, 26 Jun 2025 14:11:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E75E8D0001; Thu, 26 Jun 2025 14:11:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E95826B00AD for ; Thu, 26 Jun 2025 14:11:42 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3E06414037A for ; Thu, 26 Jun 2025 18:11:42 +0000 (UTC) X-FDA: 83598344844.04.D8E1636 Received: from sipsolutions.net (s3.sipsolutions.net [168.119.38.16]) by imf23.hostedemail.com (Postfix) with ESMTP id 727F3140007 for ; Thu, 26 Jun 2025 18:11:40 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=sipsolutions.net header.s=mail header.b=T5M0f1Ah; spf=pass (imf23.hostedemail.com: domain of benjamin@sipsolutions.net designates 168.119.38.16 as permitted sender) smtp.mailfrom=benjamin@sipsolutions.net; dmarc=pass (policy=none) header.from=sipsolutions.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750961500; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LjE007gYCBpNBo6Eo9JKv1OoWp0a2hHAJM79jEQpxYM=; b=l0Rax+v1RdbonFW95WZcwj7wdslVfNWINvFmoCvekpptrSXsbuNFKnqUh7xUJo5uXTHMyW ktGHzY2HTMuh6ZunoBLgO/a09bp3E6a+8TlkWgvoVglbi/FjsrxOJf1ttjUUwPEO54C6tV we47upKT2pG/MFKmrgzf6bkFiwiwjTE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750961500; a=rsa-sha256; cv=none; b=iIjOdsioI6t5g8CXfJZX876/tCgCTjQTdwk8bBRZ14QAnu/Ewv6w6czs7WzIuskeWJDEoN pajeNIqVTzvKjpmKF2jk9TtAuJck0uCnuJbBCaQg+GCPmFa219c9xiQmuSDYOpWeVRd5+c VZktdtm9KaQyw24eAub0tr12UxklNGY= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=sipsolutions.net header.s=mail header.b=T5M0f1Ah; spf=pass (imf23.hostedemail.com: domain of benjamin@sipsolutions.net designates 168.119.38.16 as permitted sender) smtp.mailfrom=benjamin@sipsolutions.net; dmarc=pass (policy=none) header.from=sipsolutions.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=LjE007gYCBpNBo6Eo9JKv1OoWp0a2hHAJM79jEQpxYM=; t=1750961500; x=1752171100; b=T5M0f1Ah5fGq6Mse2Fev83Bz2EQzqVIvOT4TcJvvHeD1A20 3t0OFL51Mbsp8Xekaqo5C4t0UtscDS5m3PHQUFG8LNT9Y5mxIAXvt0afEApXbSDyYap+r4vkUSuw0 4qtX6MUvQf1zXZ7virYeAipWFOtrjBiDw63Yy6rdAkgHBridTtq5S2AsN0GG0VdQEHmGOAjU+mZ6W gCiTQY950ojCvI1oJrmffWuQjt04yn1vNxjvbZHvSbvdcmGd6krGaYnxrmZI796bfxmHeJmdAPiEk LkY2goPgtvoVtxiZQiHJVVIZV63/Wk6obEPnVInzApvFbA4Yx/RykmEH9XQK7Grg==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.98.2) (envelope-from ) id 1uUr4B-0000000BuZ7-2DCz; Thu, 26 Jun 2025 20:11:19 +0200 Message-ID: <66deaafe1974c989e949975bafe3ab0b2ae3f5ff.camel@sipsolutions.net> Subject: Re: [PATCH v4 12/15] kunit: Introduce UAPI testing framework From: Benjamin Berg To: Thomas =?ISO-8859-1?Q?Wei=DFschuh?= , Masahiro Yamada , Nathan Chancellor , Andrew Morton , Willy Tarreau , Thomas =?ISO-8859-1?Q?Wei=DFschuh?= , Brendan Higgins , David Gow , Rae Moar , Shuah Khan , Jonathan Corbet , Nicolas Schier Cc: Christophe Leroy , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, workflows@vger.kernel.org, Kees Cook , Alexander Viro , Christian Brauner , Jan Kara , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Date: Thu, 26 Jun 2025 20:11:17 +0200 In-Reply-To: <20250626-kunit-kselftests-v4-12-48760534fef5@linutronix.de> (sfid-20250626_081057_904093_DFB49A53) References: <20250626-kunit-kselftests-v4-0-48760534fef5@linutronix.de> <20250626-kunit-kselftests-v4-12-48760534fef5@linutronix.de> (sfid-20250626_081057_904093_DFB49A53) Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3 (3.54.3-1.fc41) MIME-Version: 1.0 X-malware-bazaar: not-scanned X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 727F3140007 X-Stat-Signature: js5saou3azx3667jdjpfhewbt9z7ta9a X-Rspam-User: X-HE-Tag: 1750961500-799620 X-HE-Meta: U2FsdGVkX18e2iKuTqhvvc/owIv1b1UWFIsbaXsvEHiSMreZ+ItYLTx0mNo86xQ2XLUdZfdAv6D5EAGtkkA91dK9Zwm52nRbWZO2bw+1ET3ABlGU8l3DKLA4IbTvCGdtpmynegTU5gAGjFkVdSbrKu8s/9jEvRHeBlfnYAnTgI4uCrPoSw0vXHvEb7qkqO9nBpTH1/XASjOyxg0XhWT6BW9fKKCikN42WkjnNPdWZqLJiL/HDb74Z+cxOkeXwDaMLOjxFlRejp1JADYr+lRhBVnLfG+keKgvwMiGmlNgwcOfmBk6NnUB7H0EvqQexdjq9yyy/P3qe24LEiXRVaeZYvwyvDy7+LefGa6tJxqQU1PiZeAvvVVLCdx/Frvq0hYVWWQ7M/XXWb4m0skbVBI4zVxGwKHd7klwE5o5j2wgx9ADT7JyN/8jOQKxuu7TPTa86HH9Sopyi/ZHdJLhTeW+6+j8yBmXdW3UA6zagmd+vFaBEuhZQTDq4k3sU2KPSixA90T8l3PBFY6i/xLWSklnygCBv+aTHFYfIsdz7ZxpKKno8Qe7qrCqH/70jPzmnr64cf0EqD2U4zNiDxPYqFphkp3+MkQexht/IrzfgAIEyCX800da25OjyUsOEeQnnFwPzCqEnuy2h8YpSe2Ef4SCekJ08jvEE7rQmOHd96QnAndzaL8D0o8TrNWuk42890lAiE5tYAwp19w6EiiYAWdEpzpJ+FBJAjydKrUpR7immQ39G9vo3Zyh6feVqKFMdXd+qVF4z0xN+NapCbQG10YF51cZgafwbw6TrWC7LrE8viwFXbcqgy7cmxWvj/uwaxMZxdIk23RJm+JFjytTbdHIqvE3k+BvYWN0TPWxyoRiS/+E6pSB96X8swVsswVy47WZ8KIJjqAer9rDtDh+QMKUOff4g1yuGxlBSfVfEa1AT0Ivrj5zkoTd2ttlfLukIAZd6C4r5Bc+81294De9dvt BRiDpuFv twZTFzHLpXAPutLo80DMEgZuzETCeRhIS4YmLYU8I0Iy6AnrFQYdQBBmJdo0gZcw9gR3oANMaO0+6d37SKSbSD/bFfiUZQdIQZ4PP1puut+uuCI/itqwyhzVA7+uQ9gqB7a7NJwkgIpKI97z3L08TP8a1Be8zr/GotxgqZql4U3Aq1/kw71+xTMgW9Ay3IcZIiMuMAuMiL8rwdXLTRmR8215bHEdV9batW1KV1rMrFM+rP3Ts6hWBlS+UOg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Thomas, I ran into two minor issues trying out the patches, see inline. On Thu, 2025-06-26 at 08:10 +0200, Thomas Wei=C3=9Fschuh wrote: > Enable running UAPI tests as part of kunit. > The selftests are embedded into the kernel image and their output is > forwarded to kunit for unified reporting. >=20 > The implementation reuses parts of usermode drivers and usermode > helpers. However these frameworks are not used directly as they make it > impossible to retrieve a thread's exit code. >=20 > Signed-off-by: Thomas Wei=C3=9Fschuh >=20 > [SNIP] > +/** > + * KUNIT_UAPI_EMBED_BLOB() - Embed another build artifact into the kerne= l > + * @_name: The name of symbol under which the artifact is embedded. > + * @_path: Path to the artifact on disk. > + * > + * Embeds a build artifact like a userspace executable into the kernel o= r current module. > + * The build artifact is read from disk and needs to be already built. > + */ > +#define KUNIT_UAPI_EMBED_BLOB(_name, _path) \ > + asm ( \ > + " .pushsection .rodata, \"a\" \n" \ > + " .global " __stringify(CONCATENATE(_name, _data)) " \n" \ > + __stringify(CONCATENATE(_name, _data)) ": \n" \ > + " .incbin " __stringify(_path) " \n" \ > + " .size " __stringify(CONCATENATE(_name, _data)) ", " \ > + ". - " __stringify(CONCATENATE(_name, _data)) " \n" \ > + " .global " __stringify(CONCATENATE(_name, _end)) " \n" \ > + __stringify(CONCATENATE(_name, _end)) ": \n" \ > + " .popsection \n" \ > + ); \ > + \ > + extern const char CONCATENATE(_name, _data)[]; \ > + extern const char CONCATENATE(_name, _end)[]; \ > + \ > + static const struct kunit_uapi_blob _name =3D { \ > + .path =3D _path, \ > + .data =3D CONCATENATE(_name, _data), \ > + .end =3D CONCATENATE(_name, _end), \ > + } \ For me, the compiler could not find the files for the ".incbin" unless I added an include path. i.e. adding ccflags-y :=3D -I$(obj) to lib/kunit/Makefile fixed the problem for me. > [SNIP] > +static int kunit_uapi_run_executable_in_mount(struct kunit *test, const = char *executable, > + =C2=A0=C2=A0 struct vfsmount *mnt) > +{ > + struct kunit_uapi_user_mode_thread_ctx ctx =3D { > + .setup_done =3D COMPLETION_INITIALIZER_ONSTACK(ctx.setup_done), > + .executable =3D executable, > + .pwd =3D { > + .mnt =3D mnt, > + .dentry =3D mnt->mnt_root, > + }, > + }; > + int forward_err, wait_err, ret; ret needs to be initialized to zero here as the kernel_wait function will only set "ret" if wo.wo_stat is non-zero. Benjamin > [SNIP]