From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F2D7C36002 for ; Wed, 9 Apr 2025 11:07:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E596328006F; Wed, 9 Apr 2025 07:07:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E09B7280068; Wed, 9 Apr 2025 07:07:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA91228006F; Wed, 9 Apr 2025 07:07:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id ACAAF280068 for ; Wed, 9 Apr 2025 07:07:19 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1C3111A0525 for ; Wed, 9 Apr 2025 11:07:20 +0000 (UTC) X-FDA: 83314229040.12.7C74668 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf24.hostedemail.com (Postfix) with ESMTP id 2F1C2180011 for ; Wed, 9 Apr 2025 11:07:17 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JMFcv85N; spf=pass (imf24.hostedemail.com: domain of jirislaby@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=jirislaby@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744196838; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KfChTG8ckiYOLVuLtmRFFXH5M/82it80bobRROrJFM8=; b=ZZsC8ZtR7mDpWcPUITE0FsUFdZyuRv1zXhDQFSEtP/KUf52sBHTuvYS8JqHYUKYMmemO/a LDHZdTcQ4ZD5EJG/QxNj6lYMptC1bX/F+b5NwfLctyyOx62DY/8XXrzErw+vTSjngZzv7Z 8B0pXi4jT3GhsMduQPgmwE5SqnF0VGM= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JMFcv85N; spf=pass (imf24.hostedemail.com: domain of jirislaby@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=jirislaby@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744196838; a=rsa-sha256; cv=none; b=iVToECGj4dibFWnRpZI9A0FhaNlljJuoZoTz4yVuaCZ3C/O4WUt1VgtnK5Ga4i7gFeRoeJ Wm8ZTRc8V/dNB+9cFCp4dErTAQGiChSjDEV1wiiUCZGk9FM2pWQqMYKoPLtrCUorWzm6Ku nbmXcZkhGIzF2N5rKMkG9i4hXm7uLWU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id B56CBA498D9; Wed, 9 Apr 2025 11:01:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 282B0C4CEE3; Wed, 9 Apr 2025 11:07:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744196837; bh=5WALcSlXLF4jOWGCUwqVjywh8RLohDbgqlLN686J2Co=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=JMFcv85NoqIbs4DlNh1qTYARvZUZr7qnD6MYTCBnS1G1L2lbk2dErmODU1foLYFGu MOkY1q7D5/QVRHYEdCphs9+N/wYsulyW237bRmUNa42sKemo64gxVxZgfjFE2YQDwo oACNTULyMZXi1mLH3Q/VcGTwZp+URx76kspAgajXRw9G0tLGrqtyjO8gm4Slg9VDFv JnuH0ZRSfSgsB5hyo51dhOaJvObq5ZxGk4JSnhdRIAz2XFkws37ZJAWaTQ2KeePD0t V/7Ge0OCTeuIKR9WBwQ+3KUno9Ems9m5LJVHCUTPX5Ggn4Dc1OfE1sn8uKK7WLAPO2 TQlyHB/vkq4NQ== Message-ID: <66e54eb9-58b3-4559-af32-66a77fe1ea01@kernel.org> Date: Wed, 9 Apr 2025 13:07:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 6/6] percpu/x86: Enable strict percpu checks via named AS qualifiers To: Uros Bizjak , x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-arch@vger.kernel.org, netdev@vger.kernel.org Cc: Nadav Amit , Dennis Zhou , Tejun Heo , Christoph Lameter , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Linus Torvalds , Andy Lutomirski , Brian Gerst , Peter Zijlstra References: <20250127160709.80604-1-ubizjak@gmail.com> <20250127160709.80604-7-ubizjak@gmail.com> Content-Language: en-US From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: <20250127160709.80604-7-ubizjak@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2F1C2180011 X-Stat-Signature: 1xkfazyphb7qrk4mpobcod9so9ueaczy X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1744196837-667947 X-HE-Meta: U2FsdGVkX1/7YtToc+oU3XEJr/b9vyzEFIH9dZP/o37gqCQLUXlXaKYdmbj8uIBu2YaH6OKuUgEezHYizPctyf5/1Pi0CSvtCPId2dAUiy/opHp7Lhg7WfY7tw81n5dNW5TDaJuCEifu0Whpe5q9m9E25QQvXg10Rpk1HI4RHtV5M6tedVFebw0x05+DA36i0J0B3o044s8Hzkhy7R59PkWmBD3NJAa6UjNrsVI9X5S2dHyssuS0hG6qbpzKr8zSzCC9/ptKLIrqS8EX8tgypUkn3TrBnFWGWya4wnpIAcv23L/63fuazG6lANVSlaXjqx0UTmQHYy5aDQjxitfhM7WgqoFbQ4Eu/9YoGuszS8m7Qxa4zjo08+X3b9kvs1egAHECMtmPDRq7GHngHlLTevUWZ58YdN9jrqvLKIrn5kBj72GRqKZ1PX9oIn5ejXuRcP2vtRc7dPeo9QyOuemJ4r+SLrOfdx1zy0ZO+86Ae3wegme6h57Gt4jpuapq4oZBY2shFSDSb5qULuwmp6++Cy+6Gf0ZcmgPXvtzknXBGUjTrhBAnXepaSWcnn56O5q4PPj5wviMZLbWJQA30Smf+wANQ/ZhkWUDu5uxsx98jh/tt9FX7RlhMAF5aVl9ZK12tzubGCFGqyG0Q97mTRUHGGV0j/slbbbWHtMh3RLDZFNHC1/ryh5oidkYBxcqamu/8u2sC+F0WTlDA9GsQxmygZTPUV6+VO10CJYRgGh0ydq9S5QoODUjPSiDEPUz+UrmPDnxwVomI9qMpvDaa+ny6Xyblpvw46YraQepfMibrPJvMQV4Aj9wGIM/Q0kJh8ohPOwY19LN+/A/ALskYHLsibxg9ebtzA82Bap0SasCzTa1ghUKdPwxdQBZhlEc1bpHWIhrMu9kyDRxb8+/T1p7vCrKZuBPAmddXLWwsDXGC2bMBfc7QFMoEC5Fa38dVtHwsIustG2Xf7cXEuBE9N7 3dCdQgN9 lp7pdcGjTp75+kEzaJqol8V7xvZrSAenaRRmWpZXNNL2ogLXf0MNtcYMCmqNngMOq2uxrs71qbmrBVJRX0OyibxfukbGBanGYowrxmaw9jUtsgJo0kh9uJfBMAPm2qK2ZELWEtUbRkU9taamXoaHERygRsozw7SXqWeWTHRHbyvZQZNAbhreC0ipKAYdO67708GNH2tUc119TIleMSkHzjRCZEulal5jlfthzkeZGmb7B4sq26zuB7cLE84x9ebMUxH/TZP2N1J7vGvUxT+Qe4ZwfOgnZ2tX2ku7HEVhL9BcTAqGK4DW6JUeDCOY3k25ez4T43TnvJK9Mn0YY4uQAubfkA6sWdoTsSgl9Mpc7HjFESlmJdnbOeJN+UY9vHaK/UIrlTqd5fApjhDStF/X9M5413aj1YXU9ZGTWgaHx+1uMo/6s1cXhgfAyO8gDFVsyi64iN9h8MnjOnFQMmgLKws60MtU/Sq7pl6hH0qrS9rTqi/ByeGEF6Y+OoYnYGZgmTicR7SLxOdYB35Ph/KkeymDIJsVWzOEJ5XvYHJCwQt0dMW+u7iAEtvyPpnlcF0gQpP2TnOkaiZIgeC+9dTCuyHCm5IvupCGG1AGiEnKUf0GEfMMPS2CIumovKxGfCvZINySSZsYRFtR4cIeLF6zLkAVuqA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27. 01. 25, 17:05, Uros Bizjak wrote: > This patch declares percpu variables in __seg_gs/__seg_fs named AS > and keeps them named AS qualified until they are dereferenced with > percpu accessor. This approach enables various compiler check > for cross-namespace variable assignments. So this causes modpost to fail to version some symbols: > WARNING: modpost: EXPORT symbol "xen_vcpu_id" [vmlinux] version generation failed, symbol will not be versioned. > Is "xen_vcpu_id" prototyped in ? > WARNING: modpost: EXPORT symbol "irq_stat" [vmlinux] version generation failed, symbol will not be versioned. > Is "irq_stat" prototyped in ? > WARNING: modpost: EXPORT symbol "fred_rsp0" [vmlinux] version generation failed, symbol will not be versioned. > Is "fred_rsp0" prototyped in ? > WARNING: modpost: EXPORT symbol "cpu_dr7" [vmlinux] version generation failed, symbol will not be versioned. > Is "cpu_dr7" prototyped in ? > WARNING: modpost: EXPORT symbol "cpu_tss_rw" [vmlinux] version generation failed, symbol will not be versioned. > Is "cpu_tss_rw" prototyped in ? > WARNING: modpost: EXPORT symbol "__tss_limit_invalid" [vmlinux] version generation failed, symbol will not be versioned. > Is "__tss_limit_invalid" prototyped in ? > WARNING: modpost: EXPORT symbol "irq_fpu_usable" [vmlinux] version generation failed, symbol will not be versioned. > Is "irq_fpu_usable" prototyped in ? > WARNING: modpost: EXPORT symbol "cpu_info" [vmlinux] version generation failed, symbol will not be versioned. > Is "cpu_info" prototyped in ? > WARNING: modpost: EXPORT symbol "gdt_page" [vmlinux] version generation failed, symbol will not be versioned. > Is "gdt_page" prototyped in ? > ... That happens both with 6.15-rc1 and today's -next. Ideas? Config: https://github.com/SUSE/kernel-source/blob/master/config/x86_64/default It is enough to: make CC='ccache gcc-14' O=../our -j160 vmlinux to see the above. > Signed-off-by: Uros Bizjak > Acked-by: Nadav Amit > Cc: Dennis Zhou > Cc: Tejun Heo > Cc: Christoph Lameter > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: "H. Peter Anvin" > Cc: Linus Torvalds > Cc: Andy Lutomirski > Cc: Brian Gerst > Cc: Peter Zijlstra > --- > arch/x86/include/asm/percpu.h | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/include/asm/percpu.h b/arch/x86/include/asm/percpu.h > index 27f668660abe..474d648bca9a 100644 > --- a/arch/x86/include/asm/percpu.h > +++ b/arch/x86/include/asm/percpu.h > @@ -95,9 +95,18 @@ > > #endif /* CONFIG_SMP */ > > -#define __my_cpu_type(var) typeof(var) __percpu_seg_override > -#define __my_cpu_ptr(ptr) (__my_cpu_type(*(ptr))*)(__force uintptr_t)(ptr) > -#define __my_cpu_var(var) (*__my_cpu_ptr(&(var))) > +#if defined(CONFIG_USE_X86_SEG_SUPPORT) && defined(USE_TYPEOF_UNQUAL) > +# define __my_cpu_type(var) typeof(var) > +# define __my_cpu_ptr(ptr) (ptr) > +# define __my_cpu_var(var) (var) > + > +# define __percpu_qual __percpu_seg_override > +#else > +# define __my_cpu_type(var) typeof(var) __percpu_seg_override > +# define __my_cpu_ptr(ptr) (__my_cpu_type(*(ptr))*)(__force uintptr_t)(ptr) > +# define __my_cpu_var(var) (*__my_cpu_ptr(&(var))) > +#endif > + > #define __percpu_arg(x) __percpu_prefix "%" #x > #define __force_percpu_arg(x) __force_percpu_prefix "%" #x thanks, -- js suse labs