From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04A6CCF34D5 for ; Thu, 3 Oct 2024 23:32:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7484C6B02A0; Thu, 3 Oct 2024 19:32:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D2E06B02DB; Thu, 3 Oct 2024 19:32:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D5C36B02DC; Thu, 3 Oct 2024 19:32:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 211CD6B0287 for ; Thu, 3 Oct 2024 19:32:48 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B6BE1C0C60 for ; Thu, 3 Oct 2024 23:32:47 +0000 (UTC) X-FDA: 82633893174.14.9FDE5FB Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by imf04.hostedemail.com (Postfix) with ESMTP id 3876540006 for ; Thu, 3 Oct 2024 23:32:43 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ICnxmEux; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf04.hostedemail.com: domain of dan.j.williams@intel.com designates 192.198.163.15 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727998234; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a6RghFaKQE/PmzNCJx2vYMRlahPi2acUkkQ0jZ3UL2E=; b=YNCRHOUqv4yq4CaVyX3kaG6UYFpegJQ1/vxEeQjEAbzasYHYaL3/qLbJhoIa9w1WFiH3aU ZXTPlUwjqC7hBiKCHwTc3yihnOPNNBzQug9gVK5ojbCuDmsg/Y8QqkDQLYw6YxQqanpK38 +X0Jaio5sQ9hCp/Rrhr2o2HsIhTz5+E= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1727998234; a=rsa-sha256; cv=fail; b=ki30J2u3aSbGixuYLA6jjsdbt3f/oPaSEUtMH8VxaNPC+33i55kDIU7zeWv4jyjSY+pgTI PtkQKvr8UsGxtPr6PQgvz5jkwrEJUNmnZQCeRcNfdEhKlKllLpr4PzLv6fTgUvMmF+ZohK 6wjQ1/iQ3DUCiyGQUvFr/3/sH7tdCVE= ARC-Authentication-Results: i=2; imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ICnxmEux; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf04.hostedemail.com: domain of dan.j.williams@intel.com designates 192.198.163.15 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727998363; x=1759534363; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=NXPY6VM54uLM3Vaj+4PFWuX/xYmrdL43RiO1H07qMZQ=; b=ICnxmEuxkF8X/riVvq8VxbIXBMmD3SxnDWpWHjZrxolQscy993lTxi9l +phAxrbyL8A++IGZLisVp87A4jKoWHgzuw5y6lyS929IwaIA1bNJ+8+Eh +tAFCbfoFyBhCzE+9TyaAWhjQ95qVtnCY3qVLCeh7qUhgT4sFIK71Mtuf 7Z082wiGpbGvzLp5FEPEB6iZMrSwKiarXDNxV6X0g+64G3RE7jyblXGEM 9/5RwA+jTFfaIWtSNMFgQ2oQiaEUFGwGFShsUi7O7BOAiiJ0aKvgG9MxB wKDUsaeP3JxOi1z7keqPPqPDaajz5nykmrNf6+p65Sd3dWAcuYTjklscH Q==; X-CSE-ConnectionGUID: Zz94gcxPTuynGWPWEeVxyQ== X-CSE-MsgGUID: oUZrN9JLQvC/G3c5HbLy3g== X-IronPort-AV: E=McAfee;i="6700,10204,11214"; a="27364184" X-IronPort-AV: E=Sophos;i="6.11,176,1725346800"; d="scan'208";a="27364184" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2024 16:32:42 -0700 X-CSE-ConnectionGUID: /UqPlSpgSuOTqYjzLBchXQ== X-CSE-MsgGUID: FH8plIiXRV6PWo6b2VxE2w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,176,1725346800"; d="scan'208";a="79362414" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 03 Oct 2024 16:32:42 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 3 Oct 2024 16:32:41 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 3 Oct 2024 16:32:41 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 3 Oct 2024 16:32:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=psZeuCEtO/bAB/6RsQWngL3JIZUk4xmPIoq+izADJoO1fOQ0ISPWl7PUEdZ4YHhRaUxVrJ4mml60FXGPrpo38RPhrUz5VCNgR/6teUZ59cdsJjB3OrLVTs5875zkvUh+Bfi+IEwTLqGkUy+6gBCAKzl6gKNa79tJknHEPlRiZgzbWAOBcivx/rOjh6JrAb0Ui6KsDiWK6FwR3olrLSWYdzclvDPFg60cX9Hbef6FFr4x/QvEZ9aYN6yTNGN9jWY5Yq32sENDLJC22meGMc9jSUIWEGfFBqMvhoCE/lxXHgkNGUsuB8RcohuO8x/dvHO/SfX724Vts4J1MwGsOFLGWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a6RghFaKQE/PmzNCJx2vYMRlahPi2acUkkQ0jZ3UL2E=; b=nyrgtDnLfQVNiu81t5mVfA9XNYnqKlFB+k5l9a24pop7vndFkJIMcjKIGYW4hb7CU601c9i8OV0StdY2KcawfJplSANqy52tR2pxpfsPBi79PCbWPmOiWZbkUQBKVCj3i33ex0FIM0zxSw3nD19Ur9AaL2ApLpUXDK+tHpTwANSTKDGoBdjL8UlTF3BFb6rbqzGOR7LhQf2GihxLqNL8znViLUR6lWVKjeAmDeXDR/F17xaPhzyh1X2nlkuLgqyhhAJFsvh0CyE2M2qo1ts84T3j779cQpfcz5CbtS21frnaev++gY8zzwtF4eoYZhE3uSLIGl5p7EiOLWvMYZXCyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) by SJ0PR11MB5054.namprd11.prod.outlook.com (2603:10b6:a03:2d3::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.18; Thu, 3 Oct 2024 23:32:05 +0000 Received: from PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::6b05:74cf:a304:ecd8]) by PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::6b05:74cf:a304:ecd8%4]) with mapi id 15.20.8026.016; Thu, 3 Oct 2024 23:32:04 +0000 Date: Thu, 3 Oct 2024 16:32:01 -0700 From: Dan Williams To: Yang Shi , "Huang, Ying" CC: David Hildenbrand , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "Kirill A . Shutemov" , , Andrew Morton , Oscar Salvador , , , , Dan Williams , "Kai Huang" , "H. Peter Anvin" , "Andy Lutomirski" Subject: Re: [PATCH] tdx, memory hotplug: Check whole hot-adding memory range for TDX Message-ID: <66ff297119b92_964f2294c6@dwillia2-xfh.jf.intel.com.notmuch> References: <20240930055112.344206-1-ying.huang@intel.com> <8734lgpuoi.fsf@yhuang6-desk2.ccr.corp.intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: MW4P221CA0025.NAMP221.PROD.OUTLOOK.COM (2603:10b6:303:8b::30) To PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH8PR11MB8107:EE_|SJ0PR11MB5054:EE_ X-MS-Office365-Filtering-Correlation-Id: cf514b64-cd32-4b62-9e6a-08dce4039672 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?aERaMUpWQmcwL0NuK3B2Z3hoZkhpckVkV2hHZ3hpNk5vT1JRK1k5bGlPQ1Nl?= =?utf-8?B?VmZYdElJV2N5dW9jQ1FtZlltNVVnbE0zNXFoVmpZMkhYaTBDR0pJTFg2WlpY?= =?utf-8?B?ZHk3bDVWeHRsUWQzbzV4cloySVZvMVJGeXA5Qm5KM2JPd09Zc0Q1SFZLN3E0?= =?utf-8?B?Y0plSlhhTFR4Z0huMUJVNlRHcFdsUmtsVGZIUy9ZajJPSlRrTzlDUkZoa0c0?= =?utf-8?B?dzhrZjJtQkxCcXhoWTU4LzA2Y3ZXa0xQWklGZE8xMUZaNXlBREZXUzl0VFFX?= =?utf-8?B?Y1Y4UnczU2FlRU5RL0kwM2lERStWaDBWV0FlUWFKbHZIaU1jMnRMQXNiS2lM?= =?utf-8?B?TzdJblc1MTgwUnhHelRHNUJWNW5NczBzbEJJZ0E1TE1sMk9weTR3NEc1ZGMv?= =?utf-8?B?MkQycG1vVWdiaEo4QUh3VCtqSVJhUzBlRC9kMEN4QjlZZWNEaTd6eWk2cVVZ?= =?utf-8?B?cXBsRW9oaEd2U0RlT0oxMmg5OVJ6cktRVVFqb1l5ak1xclA3eWpXYktNZklT?= =?utf-8?B?bW1uMlZkRE5sWWhsMUZrQ0lEcVFoV2FqNktlTkEzc3lINnZRYVBEYnlrUk1F?= =?utf-8?B?U0QwYytQRER2UCt6Wnl1RS9VNWZkQjR6Znd3c3JBeFdlOXpzUWVVSU11U2xN?= =?utf-8?B?VXRYeGh1M1VTQnJnMWtOVE1Mb2ZrZWtnR215OHhJeUJTd3hYUFM1RWl4VEZs?= =?utf-8?B?aElFNGM0Q3RMdnNvZDVBK2NZY1krZytYcnMxK2tpS2krK0VOT2ptc0tkdDU4?= =?utf-8?B?YkdnQmtPeUtHZHZ0c090RmlTcVJnYlV1ZXl3RW1zZW9rc2p6TjVYcVlHN2pZ?= =?utf-8?B?d3Q3aERVR2pESkNzRWZCWGZnaU9OOXhVM2xRM2ZYV2lQd29ab0NWU0k4NU5Q?= =?utf-8?B?bkZMYnVqd0xyRjh2MnlXdjNkVFB6cGhoV3lCakhhOFVmNHRYSjA4NkZrdkdP?= =?utf-8?B?TDMvOTVTZ0tNR2cwWnRER3BnWlM4bVp3TjAzYm92NWczV3NZeXJPWDRESlBF?= =?utf-8?B?QUJrTTgvZTlNejhvdEZIWWhIOVB0TjJRM29HV3JZTjNLdXY0YTc2M0ZOZ1gx?= =?utf-8?B?Q0pZTTJFKzNud0NZUDNsNVVwR1ljcXdzUkpwcHVLcVN6SlJUaVk0bWxmN2E0?= =?utf-8?B?SHV2dFlHellUL1VIUXJoMFhNWXVHckJNMG5uVFFMaERJZmR0dWxMaVY3U01t?= =?utf-8?B?b0t0aWhqZnRZRUh5cGNReEg4Sk5tSjlCS2Z3SXBIVnJ0NnNtY25hNS9wbDY3?= =?utf-8?B?YzZiMEZPUzA0OU8xOWRLMTJHTXJicTZ3Y3pWZWw3UkNYUDBZeEQxM2NKR1d3?= =?utf-8?B?RHJoYUFFZExqaVFRZzNEVjBYU3BJVW9Ha1RSVkYrYTArdElZbVNXZnY1K0RX?= =?utf-8?B?Y2cyZ0dBZVdJVVZEaDczdEhLdHZ4bGJUaDNkekFIcmpmZW5VcVkzb1pvc0V2?= =?utf-8?B?UmN4UWVuK01FTXBabWUvcDlLNm1DSnRoT3lZOHZDdXVoMmZiaUU5K0h6bllN?= =?utf-8?B?cWNxRkcwUFBnaXJodnhDQ1A5N1NWR2pRakRpRFNZdlZyQzVUVW9iRDJCSGtE?= =?utf-8?B?WFBlcUt5a0NaZjVZNURmKy8zSVVGNTVxcXU5Mzc3RzhDOCs2d04xNUREaitw?= =?utf-8?B?Qlk1dEVabEhUdDV2eno2Q0FjRTFyN01wMUVLMzV0Q2F1dmNKdnRQbVNzOVpZ?= =?utf-8?B?L2VlRURrUk9jZ3lUYzVsbkhwZHVhZnZ1ZGhHUkV1Qm0zeks4dlFiOFlBPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH8PR11MB8107.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VnVJRE1lK1MyWHc0bVFJTVN2cm44ZStjZ2NpODVvUGVJaXJXV3VoT2ZWd0do?= =?utf-8?B?WlJTVnhoZHV1Umx4dC9DcEFlY1c1ZFR5YzJucmwrK1o2dXIwaCtxdEFRQkZx?= =?utf-8?B?a2lUdXc5T24yZTQvOHZaVnNIUG1qMjNocmw5Y1ZMeXR6ZDF2MndBN1pZL3VW?= =?utf-8?B?Wkl2eThSUmhUYTdCWFlCRHI1bHo4cW5ZNEFtOUJnUE80N1FZU3BHbHhPUjUx?= =?utf-8?B?ZkQxVjh3Yk1MQ1lwemZpVXpxaXVSaStNL0pmdlpqYkZjbnNwaXdhekhIZzNq?= =?utf-8?B?R1crdkpkb1J2WisvYkRYcDM1ME1oMVJLSzRkZjVDbGpvejlWZnE3OStIc1BK?= =?utf-8?B?ZE5VQ0srM1FGd2o1d3hLZDEzMmIzcGFyRytMNE1oaXM2bzdtc1ZzVzVPRm5p?= =?utf-8?B?QlZGUEE1WUNvanBVS0lOV3V6aDY0cTJHZGZKTmwyaUhyWENlOW91V0kvSzA3?= =?utf-8?B?K2QwMWprd0N4QjU2OFZyZWM2b3FzWis3SVFkRUFEYlltZzlkZXVTMVUrZkt4?= =?utf-8?B?d0h5NUpDdWZMVGt2N0tFYW5mb1BZamkyZVAvcWkraC9TUngwYXRDemxjK3FC?= =?utf-8?B?U2dWYXpIcFFKU0k4OVV0bmFmaDRPZVBNemQvc1RYY1U0TjMzaXN1TGcyRWNn?= =?utf-8?B?S21DUGJ0eVRVZmkzcUFJL0tlcjlIT2FvbXNCdlFRYWFaQi9hb0p2ZjVNVWR4?= =?utf-8?B?MVZialhXUFFadW5ybHNjWGxKT1dEa21MNFo4bFF4ZUFYYXltTnFhbHcvb2Nj?= =?utf-8?B?OEp3clQ5Z0xpa2xXU2cva3JsMTRoSWF1aVNLVEI3TjUvUUZleTdNWVBUOE9i?= =?utf-8?B?RmY0ajgzc0wvZU9BRHdBU29JNitoWEFYQlM0YUhadmp4SndUTDA1NkM1TTV1?= =?utf-8?B?cXEwQm54NjlhQkdma0lBYXdjZk1jNHNEU1VoZGladUdhT2dYRnNWSXh4bmVI?= =?utf-8?B?ekNnY2YyQlFoK0htMTIrNS9oS2ZDMTNFNWpoMnpOWXUrWXpTYWx3aVdZZFFj?= =?utf-8?B?d1laTlhpcGNrZzNxZlFGR1VlUjRQNFV5UlZ3clM0R3JJbnRvYXhDV0xxRmVT?= =?utf-8?B?TW9mTk5DKzh4bERmUWR3R0RZd2pJNG12Sms2UmkwN1FndjY4YmZ2NThGVk5z?= =?utf-8?B?VXArM1BkMzRNek1abjdzNEpSak11amErby9aM1VIVFI2dUF4VFBERUNTdmJ4?= =?utf-8?B?bi9yQzZ2blNlZzdQV0xtalFFZmlqcG9OVjBTTXVDdzhCN3prZTltRjVjUC9W?= =?utf-8?B?OENjK3l5WU9UZUZTcGJKMno3SFV1REZrL2RjcEpzR0FIOWdnMlZrZk1ObEVJ?= =?utf-8?B?VHpJVXZRSkFEbHZITDY2OFZEbWFDSW51aFI5RXhvTWpFajRaWUNJaHFwdk81?= =?utf-8?B?ZnppTWZKYVdMd0R3cE5qN2FreSt4SW9leTRHc0I5WkxRUE5neGg4WkEwTEpM?= =?utf-8?B?UjY5b2VTa2tyeWpXSitleGRQaUJaYTdPbityYisxajlBcldFYnZqNnRxSTFC?= =?utf-8?B?RjVHR2UvUy9kaFpMVm1Cc3NpSGJ4N1ZPdHRkQTJPUUp1SVRsVnlUeG9WL1RT?= =?utf-8?B?YUIreGF0a1dBVU53ZkdwbHVjYnYxT2xISGgzUmtGMnc0VytlTUh0Wkp5WUpY?= =?utf-8?B?V21NVERmem9PTEV3bmU2MldUOU1RWlFRaVBRRHZ6NVNOK01ZOVkzQ2FUWk1p?= =?utf-8?B?VFRTQ1NCeHVrNEFEN3hUQVJNWmJvMktOVWVMNzhOSEpUL1BKZTQ5R1pRSnRB?= =?utf-8?B?UGpkTWUySHpFL3NUcHFhbHhtTnFvSmRJa1BNQ05PUWdWRWpRNmZPL3pPUWRi?= =?utf-8?B?VDJxcElPbWc5OHhaQVYrWGtXMk14VG5KWE5vQ2toMis0SkN3bll0ZWZLWkJj?= =?utf-8?B?OVpxYXN3bEJDL2ZOTFlLd1RMYzNFTGkxbmtVbEFpQndaOUc4a2dNU2FCSVRG?= =?utf-8?B?bzVBOHFqWHJXS0ZTZmNxMGEzQXNIRkpITUJSQVlaUkdtM2k0U2Q4NnlDYXAy?= =?utf-8?B?Kzh6L3VoaXFCbi9uRXE1Z2dqSVlxYTFOeDBudEZGOVoyZW15M0JhNjY3OHJZ?= =?utf-8?B?STF2QzdWYXVwcGhFQi82WEYvVWk1SUdYcFNVMGpBelBHaGxiNGVOVjcyWVM1?= =?utf-8?B?S3hJdG96bVR3T25vZCtSR2lIRUJaT1BwMmVhWWxjdTFtOGlEaGVGZkNJeXRx?= =?utf-8?B?Znc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: cf514b64-cd32-4b62-9e6a-08dce4039672 X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2024 23:32:04.1180 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jOigjKCRhVPYNwu+Mmo1vBTgByMIFk6Sk8YZs5aU7sa/KA+XzDvh1Sl0z27gmL0H9oiCerQZYE+su1N0FqPS+5LrzN0MA+z+hItQ4Q3Mdl0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5054 X-OriginatorOrg: intel.com X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3876540006 X-Stat-Signature: tt95doqygmyz9sm1c8yy6rdcki6n56m6 X-HE-Tag: 1727998363-506491 X-HE-Meta: U2FsdGVkX1/7g3ubKOIFHUzJQILwIsg1noZ5sPzQNm5FqygFJmwSlddCVQd+rl/oa/+btb+y5CsJY78UzzPkctJ3TdqUizYEX1GTtuCvBCKkwpsBmMzFC4hHjTzK/r8P+RFlErI8JONzwgJj6EA9fV/1MtdGM0fUWp6tvBAalIJYlmNhYmQ9MUWqXTdr8jmhKraZ9CghY/b1gI+eliZWKzeAwqKl88ZLNsn5evDPj5gi58LI+1WzjroD6UTyvyIJk12hVQ23VQ8fJm27XwTf/8kjKIWI32VhB/NZsMcTSSiJCPvTDM++3dk1HNSlSMJwfQ2ttOG7LxfdvOB+4CgPqd/1JSEoTUSlzLQCPyBrGZ4b0SB+RVjYwg6KRb9HmXSWQ88d2Hstn1Jjv6Fcm9sle9WulpgxUnmarsC9kuHRHUfmz+DYTKdQjGW9+N8WsGRmCaf+ZC0Uuz9PVzXKdK9doMB2VxjyGpgSiLh8H5VEAdOrmm0yn1bxiw/h6C6+YxLkn1xeWP0zuJgB1/ZaLozprdtSf4JW11HHgFVgmbzlcdM4jv6Jf1bCjJa37nSsfSMU9Y0Av4obvZRSU5ZTBUKnz3y/NHIhJT0DNxy3TgFmbQVbg7lrThvqWzOfKvph7wYHk3DFASY+sHTPrrMajQTHJpjEdNRROVU6ZatGiK/EUme6Xs+8WeE0raG8hbSnJMGv2uxTEsw1pMQx5JNkeVCfjRId+i4z5AQstoqUUaLImR0xav/0imRhOJUi15PW0a6POq20xwW06Ggx6JZA44EZGZh9W4e6fnZ+u74EgNygbcAD05oZH5hQIwDoA1p2k6Gvp+jq+CCWIZvEckv6dmzztHIdK1LCDjfU4pPjEYKpA0vHpIcJGNnYjax2hur/cOVmBeXpck1wtK3426wgvbiHhAxmzq+bhAEuTlEAF3uaIVAgra1NGucQtXYp0ZHczpFOjWny22HsdWTb3pURpb+ 51ydVdB6 EZk/q1cyyA+WT/JeMonDrR/rV9NcgHHrfUi1GVtrs3JG4ooFHL48t5i/BZdOdc+R8egbQLBmtvt3cXdc2MsJ5qPtXfMzbdtkBjOnKuF+VDvsNWLqhDj49LiCmcOB3Bs57WMAJ7F1y12sSHeVxA8g4Fa5zl9wCYp9E0VgB0QsNxQrXRLbjxQzJCVj2tv0k9Ri7g1bS3qsyR+GgiYw0z6GYVzyQygNyJBtss2Ewkt0wBuUh7clTkD3pHmzanOnlwyzzYJ37hX1VunKiWX1cL8/eYgXPMXhJH1jgwqoWF+33CUQGuxJE5ZDRpEpXZNel79vGktK1HDEaEf48bTZxPCZpC2LKokQ8wstpKiOoGVqN0w6wKeHKhnbJkl2jiGpftoYwMpk8e3xNoRCjFGuujEhNZhQpoPMt6Oano3lKUole++t5Okk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Yang Shi wrote: > On Mon, Sep 30, 2024 at 4:54 PM Huang, Ying wrote: > > > > Hi, David, > > > > Thanks a lot for comments! > > > > David Hildenbrand writes: > > > > > On 30.09.24 07:51, Huang Ying wrote: > > >> On systems with TDX (Trust Domain eXtensions) enabled, memory ranges > > >> hot-added must be checked for compatibility by TDX. This is currently > > >> implemented through memory hotplug notifiers for each memory_block. > > >> If a memory range which isn't TDX compatible is hot-added, for > > >> example, some CXL memory, the command line as follows, > > >> $ echo 1 > /sys/devices/system/node/nodeX/memoryY/online > > >> will report something like, > > >> bash: echo: write error: Operation not permitted > > >> If pr_debug() is enabled, the error message like below will be shown > > >> in the kernel log, > > >> online_pages [mem 0xXXXXXXXXXX-0xXXXXXXXXXX] failed > > >> Both are too general to root cause the problem. This will confuse > > >> users. One solution is to print some error messages in the TDX memory > > >> hotplug notifier. However, memory hotplug notifiers are called for > > >> each memory block, so this may lead to a large volume of messages in > > >> the kernel log if a large number of memory blocks are onlined with a > > >> script or automatically. For example, the typical size of memory > > >> block is 128MB on x86_64, when online 64GB CXL memory, 512 messages > > >> will be logged. > > > > > > ratelimiting would likely help here a lot, but I agree that it is > > > suboptimal. > > > > > >> Therefore, in this patch, the whole hot-adding memory range is > > >> checked > > >> for TDX compatibility through a newly added architecture specific > > >> function (arch_check_hotplug_memory_range()). If rejected, the memory > > >> hot-adding will be aborted with a proper kernel log message. Which > > >> looks like something as below, > > >> virt/tdx: Reject hot-adding memory range: 0xXXXXXXXX-0xXXXXXXXX > > >> for TDX compatibility. > > >> > The target use case is to support CXL memory on TDX enabled systems. > > >> If the CXL memory isn't compatible with TDX, the whole CXL memory > > >> range hot-adding will be rejected. While the CXL memory can still be > > >> used via devdax interface. > > > > > > I'm curious, why can that memory be used through devdax but not > > > through the buddy? I'm probably missing something important :) > > > > Because only TDX compatible memory can be used for TDX guest. The buddy > > is used to allocate memory for TDX guest. While devdax will not be used > > for that. > > Sorry for chiming in late. I think CXL also faces the similar problem > on the platform with MTE (memory tagging extension on ARM64). AFAIK, > we can't have MTE on CXL, so CXL has to stay as dax device if MTE is > enabled. > > We should need a similar mechanism to prevent users from hot-adding > CXL memory if MTE is on. But not like TDX I don't think we have a > simple way to tell whether the pfn belongs to CXL or not. Please > correct me if I'm wrong. I'm wondering whether we can find a more > common way to tell memory hotplug to not hot-add some region. For > example, a special flag in struct resource. off the top of my head. > > No solid idea yet, I'm definitely seeking some advice. Could the ARM version of arch_check_hotplug_memory_range() check if MTE is enabled in the CPU and then ask the CXL subsystem if the address range is backed by a topology that supports MTE? However, why would it be ok to access CXL memory without MTE via devdax, but not as online page allocator memory? If the goal is to simply deny any and all non-MTE supported CXL region from attaching then that could probably be handled as a modification to the "cxl_acpi" driver to deny region creation unless it supports everything the CPU expects from "memory".