From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2777CC7115B for ; Fri, 20 Jun 2025 06:31:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A9F116B008A; Fri, 20 Jun 2025 02:31:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A48A06B008C; Fri, 20 Jun 2025 02:31:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 985696B0092; Fri, 20 Jun 2025 02:31:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8BC906B008A for ; Fri, 20 Jun 2025 02:31:05 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9193C121F12 for ; Fri, 20 Jun 2025 06:31:04 +0000 (UTC) X-FDA: 83574806448.08.FB58D02 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf22.hostedemail.com (Postfix) with ESMTP id DA2AFC0011 for ; Fri, 20 Jun 2025 06:31:02 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750401063; a=rsa-sha256; cv=none; b=WoFs7PUl+/nRSc+csu2KjPiBYLXmuh/J6ry2StGi3KIg1jlOXDuaMfSCyblJyAQNS+U+QD pU4WrBDWovunRvv3EMDe1HhfJkPozNuS36fpo5SAOQt57yIhFl8cG1a4quXKR5Ri05tnpl iwcUm1glE1waY10hTsAcceVEDbslyow= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750401063; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fPE88859JjlMrveS0uNJaUnWDCcBPUEsyFPcxBf+5sY=; b=yj3wdMgIqsGDnLaBQ/KcF5VyZAbtWdr9Ud2fnAz/Hz8ZBD4Ee5dU+SsMbTBQYqJvxgIpgk ZUnSlBwJMOeGGgpyxJZU2vUTP46VOsK9W9s9oPcudtaxXoSFIDOuIabqhEp6Hyr0yy7Zpn TaqDhUH5Uc18w7SvwDjpVd3xaOXk8jA= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4397B176A; Thu, 19 Jun 2025 23:30:42 -0700 (PDT) Received: from [10.164.146.15] (J09HK2D2RT.blr.arm.com [10.164.146.15]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9C8773F66E; Thu, 19 Jun 2025 23:30:58 -0700 (PDT) Message-ID: <670878b5-23fc-4b11-b585-9ddd43576963@arm.com> Date: Fri, 20 Jun 2025 12:00:55 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 1/2] lib/vsprintf: Add support for pte_t To: David Hildenbrand , linux-mm@kvack.org Cc: Andy Shevchenko , Rasmus Villemoes , Sergey Senozhatsky , Petr Mladek , Steven Rostedt , Jonathan Corbet , Andrew Morton , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org References: <20250618041235.1716143-1-anshuman.khandual@arm.com> <20250618041235.1716143-2-anshuman.khandual@arm.com> <1eceff0f-4df8-4716-8e3c-e2cb9e142511@redhat.com> <8f41d3ed-d490-4207-a907-75090c81bfc9@redhat.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <8f41d3ed-d490-4207-a907-75090c81bfc9@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: DA2AFC0011 X-Stat-Signature: mphwf4jwgats76nkiauxw65ah57zak9n X-Rspam-User: X-HE-Tag: 1750401062-92495 X-HE-Meta: U2FsdGVkX1+iPWEArpVZEd58RjlFJnhYPhK6NGUd0gjSge9RaQSMNaQFHErB2b+1vZ8eX66nuQC52ZOoRzbwtfnfJrblaMsZTwfDX+tyBHWfuwbMCealLIEiF0NfoHqT0vXykksxW8myEFQMv3HMqlBfJlOFzJuke4wOXGqdxtziMLvBRLOUQpZ+Xd/QTsJ0eLRPnJNVmBvUsFaLhOeNUL7DsmCazHJWRQj5VvqpZG/oLZ3ZGRk6AO+FgFjYDEN73d1iTPLIuMc/uMHGGIk+TAZl3hJT5jL8UA5ATw04w9A8GOuQdWO+bf3rxPuw7xoWvEDKIzl3sXAc7fVoZLsUW28RT8kGbh0KY5KZZbezTFdJ/VmFzoNNDZwnVGAiu2P9gfHX5xsiS+Zu1IHpBMNab+HI8hpgqKspqCOTa4wMGj6BUHFLchgd2tLPniyt5VZHk38j59t3YIAvUdSOyN4DK28XO/RhQWUJfmLSTmmJLYV+wZ2WbfT4hcqJylIKW3ZvKD6Zyc29jR+eKZI7w5+UuMPsEI1vPcRjQLqmYq48wc0EukQqGRSjZHniUXS1y2DNXyO1zLMVWacn1L0W24106RCkN0Zi3B4feToyvivbE7rX3DrmDqvWkz73puMCItIiJKfi9zL6kdlkKZCz4oj7IWNtv6sD5egxOsRtem/9urHoKJQeJSoXvQizA6zfweGG7gFYKL7EXa90ylF1qrJGcgQalaggk2u0uQxpfIB98bBtm5dJM3jLNfT8IuKHL6WWOzQhuqkx/voG5jKJYkkHia/CVzdRmLIFqwrPQ/tb3xBMetFCQIonS/oQAIQzY7if5PjTekNaTE6TrT+dPLmGBaigJzK/pbEX5xQkWn+8MB8NglaMly3bcJFOsShYyry2sAhkKqtvL6qa3E0VFfLfG9cjUWv3+QyVj9Vj4UV3I8xlLJNl+cGM7WPAZg2u/i+EIategusbScfRwieoPkR Z409N5Vg 324W+goUsI1EKAsx/OB01OcASRQ8PMdxM8SJlSqfVBWqyQNENnhh5QX0MQTM9f36vgOZNW44FHZb0sZ4dXAFddkM+Wt6JqRd0RUHGRrS497tefNsZrOsgklADHhRjH15Wlk21466MclGL8z+hU79Y7ex5wK0/INUafrSDdqfWXY0EOoH8CUnPUuzUm3yYhm7+fWIXY55fDxyRQq5NiUHyYPSQCA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18/06/25 2:13 PM, David Hildenbrand wrote: > On 18.06.25 10:33, Anshuman Khandual wrote: >> >> >> On 18/06/25 1:49 PM, David Hildenbrand wrote: >>>> +    case 'p': >>>> +        if (fmt[1] == 't' && fmt[2] == 'e') { >>>> +            pte_t *pte = (pte_t *)ptr; >>>> + >>>> +            spec.field_width = 10; >>>> +            spec.precision = 8; >>>> +            spec.base = 16; >>>> +            spec.flags = SPECIAL | SMALL | ZEROPAD; >>>> +            if (sizeof(pte_t) == sizeof(u64)) { >>>> +                u64 val = pte_val(*pte); >>>> + >>>> +                return number(buf, end, val, spec); >>>> +            } >>>> +            WARN_ONCE(1, "Non standard pte_t\n"); >>> >>> What about 32bit with 32bit pte_t? >> >> Ahh, missed that. Just wondering which all platforms might >> care about the 32 bit pte representation. > > I think e.g., 32bit arm has 32bit ptes? > > arch/arm/include/asm/pgtable-2level-types.h > > typedef u32 pteval_t; > ... > typedef struct { pteval_t pte; } pte_t; Right, missed that. I will accommodate 32 bit representations.