linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Dan Magenheimer <dan.magenheimer@oracle.com>
To: Konrad Wilk <konrad.wilk@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
	devel@linuxdriverproject.org, linux-mm <linux-mm@kvack.org>,
	kvm@vger.kernel.org, Nitin Gupta <ngupta@vflare.org>
Subject: RE: [PATCH] drivers/staging/zcache: support multiple clients, prep for RAMster and KVM
Date: Tue, 28 Jun 2011 14:47:03 -0700 (PDT)	[thread overview]
Message-ID: <6713c9ef-0d16-45f2-aac7-643c40fd92f8@default> (raw)
In-Reply-To: <20110627160622.GM6978@dumpdata.com>

> From: Konrad Rzeszutek Wilk

Hi Konrad --

Thanks for the review!

> Subject: Re: [PATCH] drivers/staging/zcache: support multiple clients, prep for RAMster and KVM
> 

> > +int tmem_get(struct tmem_pool *pool, struct tmem_oid *oidp, uint32_t index,
> > +		char *data, size_t *size, bool raw, int get_and_free)
> 
> And also here.. make get_and_free be bool?

This is actually a tri-state so can't be a bool.  The
other variables, as you pointed out, should be bool.
I will fix them and clarify the other two items and
post another version (and I'll remember to cc lkml
this time too ;-)

Thanks again,
Dan

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2011-06-28 21:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-26  0:20 [PATCH] drivers/staging/zcache: support multiple clients, prep for RAMster and KVM Dan Magenheimer
2011-06-27 16:06 ` Konrad Rzeszutek Wilk
2011-06-28 21:47   ` Dan Magenheimer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6713c9ef-0d16-45f2-aac7-643c40fd92f8@default \
    --to=dan.magenheimer@oracle.com \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@suse.de \
    --cc=konrad.wilk@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ngupta@vflare.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).