From: David Hildenbrand <david@redhat.com>
To: Qi Zheng <zhengqi.arch@bytedance.com>,
akpm@linux-foundation.org, maobibo@loongson.cn,
chenhuacai@loongson.cn, songmuchun@bytedance.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
loongarch@lists.linux.dev, chris@zankel.net, jcmvbkbc@gmail.com
Subject: Re: [PATCH v3 1/2] mm: use update_mmu_tlb() on the second thread
Date: Fri, 30 Sep 2022 10:44:21 +0200 [thread overview]
Message-ID: <673e494c-eb91-470a-026b-59e414d0916e@redhat.com> (raw)
In-Reply-To: <32a53a8f-f6f8-6efc-a5f6-a004ffab8c99@bytedance.com>
On 30.09.22 10:43, Qi Zheng wrote:
>
>
> On 2022/9/30 16:30, David Hildenbrand wrote:
>> On 29.09.22 13:23, Qi Zheng wrote:
>>> As message in commit 7df676974359 ("mm/memory.c: Update local TLB
>>> if PTE entry exists") said, we should update local TLB only on the
>>> second thread. So in the do_anonymous_page() here, we should use
>>> update_mmu_tlb() instead of update_mmu_cache() on the second thread.
>>>
>>
>> Maybe mention here "This only affects performance, but not correctness."
>
> Oh, this is better. Hi Andrew, do I need to resend the v4?
>
I assume he can squash it, most probably no need to resend. :)
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-09-30 8:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 11:23 [PATCH v3 0/2] use update_mmu_tlb() on the second thread Qi Zheng
2022-09-29 11:23 ` [PATCH v3 1/2] mm: " Qi Zheng
2022-09-30 8:30 ` David Hildenbrand
2022-09-30 8:43 ` Qi Zheng
2022-09-30 8:44 ` David Hildenbrand [this message]
2022-09-30 8:46 ` Qi Zheng
2022-09-30 22:31 ` Andrew Morton
2022-09-30 23:09 ` Qi Zheng
2022-09-29 11:23 ` [PATCH v3 2/2] LoongArch: update local TLB if PTE entry exists Qi Zheng
2022-09-29 11:42 ` Huacai Chen
2022-09-29 12:10 ` Qi Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=673e494c-eb91-470a-026b-59e414d0916e@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=chenhuacai@loongson.cn \
--cc=chris@zankel.net \
--cc=jcmvbkbc@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=loongarch@lists.linux.dev \
--cc=maobibo@loongson.cn \
--cc=songmuchun@bytedance.com \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox