From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A51CC18E7C for ; Wed, 26 Feb 2025 16:01:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB83128000F; Wed, 26 Feb 2025 11:01:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E67F928000A; Wed, 26 Feb 2025 11:01:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6C2928000F; Wed, 26 Feb 2025 11:01:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A801F28000A for ; Wed, 26 Feb 2025 11:01:49 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 01A5481915 for ; Wed, 26 Feb 2025 16:01:48 +0000 (UTC) X-FDA: 83162561538.19.F064ACC Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by imf04.hostedemail.com (Postfix) with ESMTP id 11F624004F for ; Wed, 26 Feb 2025 16:01:35 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="Y/2m01uN"; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf04.hostedemail.com: domain of ira.weiny@intel.com designates 198.175.65.16 as permitted sender) smtp.mailfrom=ira.weiny@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740585699; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=suBkNubPrHDOBcwN+1PFq3gY0n2lC1B/IG9pXtPwvDU=; b=FJUAwF4pJe9K0jrEJUa+znsxDJqaWvEfYlOVEuwLUBFhzzcrL5IkeOzt/QHGqk4xrFsb71 qeGjNcD+PXNU/LiuhIkx85DRX4Zqn58aPgb4ymEJaFaqpQ2Hmg6qP2SEN2cNDPRBckTpBk 2MsUY9WRoUImj5gPnZLzf4cVGqalYzk= ARC-Authentication-Results: i=2; imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="Y/2m01uN"; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf04.hostedemail.com: domain of ira.weiny@intel.com designates 198.175.65.16 as permitted sender) smtp.mailfrom=ira.weiny@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1740585699; a=rsa-sha256; cv=fail; b=z55/tds739B07PJfbjrpJoScl4gUnJoceM+QjF7BGm1P+tY9O2Fd5KUMhhumX6H6Wkzs56 984ZzUGaRteNaRmVHjXM6KVoT/bnwsREQ/m3klwXjpAA90oJJzTk5Saz0qKUa0SvvkSCPJ Ge38oMhiaV+Zw6GoC0X9/GozBrFUFbg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740585698; x=1772121698; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=ZK4/XVNvgmOyIp9/z+UBjfPxNuxuJqfqGOdpNMiBF1M=; b=Y/2m01uNfs1qADVpIj0q9GWBu3EJDVm+eso54bC43g7yssr2zfomUCU/ D/GTp5PmyZSOmRdMzOxrzJmER+jWcgN2k9Hsknyqax25oNLWyfGCFgQq8 jYRAgUD/+PfBDPka5Pjg+okstgdlMQe9ol1FKo2FrLzpYU4nOMGxYCKIN m1GqeOaLJz7+IMR0dEeH8djK7O+OX1YxrPczNX7zfeOZOl0SCLNJiYMbm FdT/fsXkg2rzYfVI2tLN8axv4X0sozHoPG+L88g2PBNkfy1fYS6R4WZve b4Qwl9NEqHw7atYqa5okNy1j98w6APCOwbzvNSKAru3mxudBahxKxWRs/ g==; X-CSE-ConnectionGUID: nu9zvuLDRTGEbf3q8rMC+w== X-CSE-MsgGUID: epE4ioxBQTyTnua/bhRGjA== X-IronPort-AV: E=McAfee;i="6700,10204,11357"; a="41569738" X-IronPort-AV: E=Sophos;i="6.13,317,1732608000"; d="scan'208";a="41569738" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2025 08:01:33 -0800 X-CSE-ConnectionGUID: JIQjJ1UkRamyINgp+c0OYw== X-CSE-MsgGUID: sRU1zkvoSyCgE+UU3yP50w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,317,1732608000"; d="scan'208";a="121683347" Received: from orsmsx901.amr.corp.intel.com ([10.22.229.23]) by orviesa003.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2025 08:01:33 -0800 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 26 Feb 2025 08:01:32 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14 via Frontend Transport; Wed, 26 Feb 2025 08:01:32 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.43) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Wed, 26 Feb 2025 08:01:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oQVzmPjTiSY59+jAfZjXg/oWUKr4RLciQ5GJ0cNmCITMsui9q7P69YfWXgo1w8m8BfzQaoq8IX60W/fufd/ixf7kLBy/Sk8YOVefU5FRQSidVk92VsycG7N1bKbGPOKG/ewy/mswgqiqv3n/tJMNhfoYWNAM5QExCO5bWYLy8t602isLTQSyc9uBjJRwX8t5UbBx2DziuMvwJHb/hhid2ud5i18g4JShD5MSlWXWEYNSyD714Xh9KMTwr0K+x1cmotT67QTNqQdecjjqicwVZLr0smi0nqEFDXlbt/km95UlPadtockt+TV6uVwJ3cncrQ5075jMjernTtMEbktKLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=suBkNubPrHDOBcwN+1PFq3gY0n2lC1B/IG9pXtPwvDU=; b=S33dl5ABzOLxGCbid5LEkfer6CIQQL08az9pVsjnrgGEhbT33Zvc8d5PTke0qcG9wtvXSOyB5mF5Wnau3An/hBccPIBtEnEECmJ4DA1upU1sO4U/jqsDLCKp3QkYtK0dRuTDQkIbsUmaWYNdGynDaW2UfVXPEu0oBdCWtoxeElmtow5bt4z0tSL+/+6wprBrEj1w/Og+1dKG+pKVTkq5Tk+P8VDDU7ZGs3z5yxMnpV9qgWf23dppwfcZJVkHkccgmdsiaSGnkm6mJBDTeBYymSel8RPaEAApu8KjD6KjsMoIx2PHjp+VJFhkLNO5vQhjdHY/V0jGu5z17ou5D3KbWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB6733.namprd11.prod.outlook.com (2603:10b6:806:25c::17) by PH7PR11MB6857.namprd11.prod.outlook.com (2603:10b6:510:1ed::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.20; Wed, 26 Feb 2025 16:01:29 +0000 Received: from SA1PR11MB6733.namprd11.prod.outlook.com ([fe80::cf7d:9363:38f4:8c57]) by SA1PR11MB6733.namprd11.prod.outlook.com ([fe80::cf7d:9363:38f4:8c57%5]) with mapi id 15.20.8489.018; Wed, 26 Feb 2025 16:01:28 +0000 Date: Wed, 26 Feb 2025 10:01:29 -0600 From: Ira Weiny To: Yosry Ahmed , Ira Weiny CC: syzbot , Barry Song <21cnbao@gmail.com>, , , , , , , Subject: Re: [syzbot] [mm?] kernel BUG in sg_init_one Message-ID: <67bf3ad9ac2df_41ae42942@iweiny-mobl.notmuch> References: <20240318204212.36505-1-21cnbao@gmail.com> <0000000000009221d60613f58726@google.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: MW4P220CA0009.NAMP220.PROD.OUTLOOK.COM (2603:10b6:303:115::14) To SA1PR11MB6733.namprd11.prod.outlook.com (2603:10b6:806:25c::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA1PR11MB6733:EE_|PH7PR11MB6857:EE_ X-MS-Office365-Filtering-Correlation-Id: 29747e70-ec39-462a-d437-08dd567ed439 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WUlpQXl2NXdTZiszdnIzbmtlR2JQQkd1c3NRRldEaTdFVk5kUFBWM2xCOEZu?= =?utf-8?B?N2t5dzFCd0Y1a3BsQ1BueFBKdG45SjBLTGpDYjV0SzRXd2tteTRpWm0wajho?= =?utf-8?B?bXNvblhuWDQxbFhjZlBpcHBobS83SkNreGFoUTBYWWhKYU1Hd0ZiRnAwUHV4?= =?utf-8?B?WENlaVRmWkNhK0dzVTJONnR3OHEwalBQZk1HNjhJZjNUL20wRGx2dkx6YU9z?= =?utf-8?B?SFFNMlpvMVVEeDlrNXFYYUplQ1hHZWpLbGlLWmhTUURvRndCK0dNUk1RQTh3?= =?utf-8?B?TXJaNjhxb0x5eFc4cEhlSVZtQUt5a0pwREVWdGZSL3NBL2NnbWJlUlRLUjdx?= =?utf-8?B?cWU2SGhuTVVFSm9SR28vVk9CbEZ4OE5NbTNLTVVra2NVSkhaUEFaSHJxa1d2?= =?utf-8?B?NnE5b2V0NzVHdUdqU1Y3bURhcnAvRDJ0N2tRUXBCZHZvMTI5QzNzR2o0TFFB?= =?utf-8?B?bUxjV21KL3NuQjQvcVZkcEFQVWNIakV3NXdzNjNLZy8rYVBESTNkV3huUllr?= =?utf-8?B?TG1UZ2FQVFBscWRCN3F3cndLRHcwaUhjdVJpSHdZQkNUQit3YnZ1WnROblVN?= =?utf-8?B?ZE5OK0Vac2NabkN6QjQ5THRKSHE3RyswdFRSa1RqUGpyV21yQ2ttMEIyL2xl?= =?utf-8?B?NHZvSUg3WnFrWXBQVDNMaWlpa01PdE5FWUdLSExQZ2RxUTJ1UnIwcjRPRXha?= =?utf-8?B?ZGI3YXZJNER2c0toYThwTUZpU2VuK3BVVWV5YlcwK3JZUXpOWVNrME1CTWFm?= =?utf-8?B?UHBacGw2dmtsWlBseTNDVEdpaWpNMjlNWFFnNDdUZUIxZTVybzcwcmhLS3NY?= =?utf-8?B?QzBtNkNYLy8xRHFCR0EwZDRQN2xJTFFEb1JHVGowN3VrMVBzb0hkcXNsaVFr?= =?utf-8?B?aUZUQjJsWXNCdmdlblROZGw3SFlGYktSbmxxU1ZDdFRsM0FSQmo3YjM2bFox?= =?utf-8?B?cmR3ZlV0dm1XK1VBaEszNkZDQjVlaldad2ZOQ0d6MTVCSC9Gd0twWTVsYnhB?= =?utf-8?B?MmRiR3lZUWMxZ1RvMWE3dlR2cXJSVEY0dG8zWk8rbW9MYjV4MEQveXA0azFt?= =?utf-8?B?N1dSTlljSVYwVXVXbXVnamV3elROWFBLK0toNGwvRHZVemZMUGNCNUdKZFhi?= =?utf-8?B?aWg4NzcyUlZwK2VPY1Bsci9nQ0Vyd3dlQU14eURKL0ljVy9xTFlwNVU1Njdh?= =?utf-8?B?NFpOaEd4Yk9rS0ZaY2FISG9JQ1c3Q0tnN0JuMUUyZ3BKUkFnOVU2WVhoNGZz?= =?utf-8?B?SW5sTHVIWm1VN2R6OFpyRTErdGNNT2hMRDNXR3hQRjMvSVp5cFVPOUFnbm82?= =?utf-8?B?VVo1T2NDUDFqbzVsTmszTUt1RU1rWFZCVThWQ3JMK0NZYnluK1pKNmc5N3Rs?= =?utf-8?B?ZkNhNVBva3VjQUtXWFhjUnFrOWpoQVFhN0ZIMzZvTkdsSXNqTDNCQm9CdE5W?= =?utf-8?B?M2w2OWtnbEZReTJlTHVFU09BMWhMRmdYZTRjaC9JTWNzRG00YUJXVnFDNW9G?= =?utf-8?B?Q0Y3emNSM010Z2NYZUdpOFU1cDY1ZU9VU09waUt6SmxQVEdTdU56WWhwdXNt?= =?utf-8?B?QUpMSkJpYWZIbGdwOXQrRThqSjhEUytOcXdTME1jaHhsMVNTcVdCMGpWQmpR?= =?utf-8?B?S2JsanNTTGYzemErYnU0U0Y3S0RNNXg0QVhyemkxY2xiUTRSdnhQbDFRK01I?= =?utf-8?B?d3ZDVVhFTXlWSVlSVW1qQzNTcVhZZyt6dXUzR040MFZwUmxaYURRYjVwcDlR?= =?utf-8?B?NXBZUXVEbEVzZWZqS0Z4T0Ura1h3MTg3bmV0dnRWbmRNMzBtbUhEUElxYXJ2?= =?utf-8?B?bUpvRHRLMGVkK2duNCtQMVdNTUMzcDluQkZMTDFHeHFwTkhLRXNLWnF3Q0ZL?= =?utf-8?Q?1yZrrKdYLYY0V?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB6733.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWRTZkwxa0dPMVU5R2V3bFl2TFNGenhWMTd5RFZmMVBWTE1QWWpRZ0ZkeXBX?= =?utf-8?B?STRUemE3NHdic0dJUUpJUmtSbHRHa3JMekVaVHJBaU9mYmhvVkdJNEFKKytH?= =?utf-8?B?dXBVTFVJNUhTQnpERllpS2thNXhIdWZ6M1lnczRGRUlvSXRoVzlWQVpNM3pL?= =?utf-8?B?OVN1OTU0UThPL1RhUlJqTjhqaU5NSnVNMlZzemI4OHdYaHZFcDhqTkQvSlYy?= =?utf-8?B?Z1l4SnJWZk5TaTlmTEhXb1FlMU1jVlRBUjIweXRTSXpMNCtRK3RybjdqamxC?= =?utf-8?B?WURpMjd5Tm9PYnoyVHJsK3FXd0tKOHIxRmhaWGtEdWpvekRLTkV0STIreE5v?= =?utf-8?B?bFQ4RmNaWG1Fd3FydTVMVE1uZk4yNVpSUmVFTERUMUk0WEovMkRLV0txYkpR?= =?utf-8?B?ZllzTGtDK0k2ZUpoTVNDaGVzb3FPQ0o1bUxtaG9SbVJ3R2RreU9iZG5aUUI2?= =?utf-8?B?VzM1NHo0TFRYSnh2NG1zRCtpMVBJTEFYRGJPMFFBWkoxdjJaS05tVHBMM3N2?= =?utf-8?B?SU9sZmJ6cDJCQS9CdlJOOFd6OXZMR1hIRUNYN2dWaGp0RzNuQXBRbEsyV0JM?= =?utf-8?B?N2gxazFrRFRnWUUrdUl2RzZ6dGVZUkRmcUpHYmp5SGhNMVhBeEV0YUU3dk1Y?= =?utf-8?B?UUpaZTJFUGorU3RkUldnV0x1TkdXQUZkaEhjQjVYbGhRbmYxbUg5czZJMUhI?= =?utf-8?B?YVY4bHNXcU5NU2pJOEt3WFowUEZjNS9oYWloQnRHRGp4aEdIcHo3OVRKQkhh?= =?utf-8?B?c01aZDJtNmNLaHB6SUgxczNBcTRnVFZWYlA2TUVmYUl4UDVYbndSUkhiemJw?= =?utf-8?B?TDYvYVVCeGpocm54SXdpTWxwVnpWK1QxWVlybk5CdWJqeVdlM291VG5BTXpt?= =?utf-8?B?dUVtRURuUTJyTjA1TE4rSWNiV2FrMXJhSWVWNHFDN2FjU2dseEhWUUpDZGI3?= =?utf-8?B?RFFFdlZsd3RBVERiQkZiaTN1YzMxSXdCVFlKM3MrblNURTZ6NzFCUDVxT1Ux?= =?utf-8?B?dVFlMTVUWTZGS2RyV2pJTjhuNEJCNFhwUmdYbUt6WHhKckh6N3I4MXhGalg0?= =?utf-8?B?a2pEc05jWWg5Wnk0RkQ0cGE2R1ZieTlZc3hsK1l2a1VkVk1WZkNhUkhGbjNu?= =?utf-8?B?NVlpTUJxVFhtbHREVm1Bd1lwRFhCVnA0QkFCTmR5dy9ZWU5kM2MxZWtXYjIw?= =?utf-8?B?dk1XTXRXVUdQYWRlS3ZESUJ2ZnNPeC9wWUJqcytrdUVqamJLeHJiQXc4UkVw?= =?utf-8?B?YlVIZVhuOVUxZ0xWWWRpQlQvek9jdVBjUVdrS1VTZGtSaFFNZ3hkd2FxM2Va?= =?utf-8?B?MnE0a01NcS9KdVdQZlRtTlA3RmNjMkNndks1U3llWHQxREFZZ09rYjZycDR2?= =?utf-8?B?YzdCcTRQRURaMGV2blVKRm42K0VUZUZsM2xwMlBRbGk0NnFaRUdjUDk4V0Uv?= =?utf-8?B?Z2lPd1BqRXdsTE16SlV1SUgveDNKZytZTDE2Wi9Kdmc1Qk5VcE12UkYvREI0?= =?utf-8?B?YkxsUk82NXVSYm5WNzBhOWIwN051eGlYQkw5aHJMQTZhY2VBLzdyRTN4VkZB?= =?utf-8?B?UkFKbm9xUkwrU09SeFZDODE0VkNUM3pwWVFLR2NRUmdYZkMzSkJIdW9FcFA5?= =?utf-8?B?T01kZklwMStOdTNqYVV5Y0ZYZUpETG51ZSswTUdwMENFUHFSc05icUxIOW9F?= =?utf-8?B?ODJPMXVyMEZCYVc4bGViZzlYakZhdDhrT2YzZFQrRlMvWkd4RXBOaUpKVERi?= =?utf-8?B?VHNGZUFUeTErSXVvQ0NKb1NqYkFtTWQzVFRYUWZDck9vMnE0Rm1EMGhMalZF?= =?utf-8?B?Wi9pcE10ajJ1a251eUdZYVA2TUN2YVBqWnJWZkpRa3p2WlhNcS9STXBETU5P?= =?utf-8?B?ckxrUitBYy9PLzBMZkQxWno2SUpCaUlFVG93VzBRcXZDODUvb0hDZHBkTmhE?= =?utf-8?B?RzVJK0pDWUxwRlVYTnRBMW8za3dTMUszbWNSUGV3YnphUXd6M0R1N0NmOXFC?= =?utf-8?B?M2pHWVoxRTJ1R3cwR2M5cnppbGw2aEtKYldlYUdCNUsrT3BjdkdFY0diWmRr?= =?utf-8?B?d0R4Sm0zK2JZQ1BBUlgxbjBrWXRJdkdFdTg1WFBXS2J0N0RUcGNGOG9pRlhF?= =?utf-8?Q?z3zSniIIH2hv7fc5jv7cwij8/?= X-MS-Exchange-CrossTenant-Network-Message-Id: 29747e70-ec39-462a-d437-08dd567ed439 X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2025 16:01:28.5929 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VuI2XPw6gsmZAzjCF/vtA+fRh9LTarCv7vk5H7EK1Vbo4+LLgN/L8QgiyNFyPF6S10EnPgZBCMVCAnET08Z8/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6857 X-OriginatorOrg: intel.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 11F624004F X-Stat-Signature: 3wap5oarfm54fpc9pp1gnbb6rhharbfc X-Rspam-User: X-HE-Tag: 1740585695-569333 X-HE-Meta: U2FsdGVkX18pXfWqhUPW6zuXL9gkFazfTXuUgKhi/Y7LekVUKlckWy3YUvEFWUqR4oeyLGN1sQgc4r1focmqG55AD8YLlHlsMG+XK9ZcuL3DMeNOfmdbOAwj4mW85pkjuhyoN2e2OwEjZ8RA7OwffqLULVXwHtS/DdRSbfw3i9okMUgt1jafRym5u7Trwap1wG+9A7c+KJ9roA5mfal5TOtekTZZYD/AQ9GHB4jHO2AQhVMhV7DFn3SDnczIe5HyFoh8bQZtUMtE0F5qs2+L8iYQwY9tBwQK7u7SkZ8e+wBhgokmoKyVTgs8HiUko6EOrrxoD1q/AO1ON08mjalbUDb2CHQIn6EEzmTZF+nF0S2T6isCL+1P9CRTXmAmFMMu5pmOGghVvNahMhGS3Bf5RxP/J3y79jSlb0j9ziDyhP1yPpjSUmTG5AmgpIXToZyzXWg8xnO46vWOeDCNGuHKuHBeU434TYX3S837rstflADPbA676WEC5F2LXp22L7yTUxleR171H7hVc2YNmBrZRMFvoV8MRgXA1TogDrkhZURbiNFV5HaFDyIE+dF2oJctqHX89qwdUID7KkycCP+fWmg8jGly+WNrpc4prhbtStWyl1ai38LHytnOunzJR8LK4a+AR4YD86Dx1e12KRUhh/s/Y6sok+vLu7A83I7Xm6WSdsslZSCJLzpJDtgg2xMWGlprOrTt+6jcnWIT7meOsU5bkAq5x6C/tfXFqf9YtqkalNjGPb3WCYiJutu4VHpGY1W83Dli8cXAgIKc/wRYT5HDi2+WI+Z8nEfnrZ6jzjnlaeNnrhtwt3e/sggZrYqlZNouQCkueCASZwzqis3Z5/IHHEQgmB2b02sP0ZZHaDZ3M7rTKiKLsbeY0GDGQsTmbfyMuxhRLgrHaGufeBDoHjvPyMiHC9fFzxouA+bARLqGjW0Kfhvuae0QgyOb0Jix5+1j99ERjOziT+NI18z YrUB8cu5 eILDP47xqhLHUfQLYtX46ikTYjsBBLkBSLTZkYuemsWdzKyfDKUaGajyNZWWXvMTyGqTF+rLWCbMLvmqmbDqrlr3taanY/nd342wkFCeSTAZuPjCIqUYRENW9/yiCSSORNu3Jw3hTyy5O+ZHOKW+W0nzGvrqWOJYxcKdwB5P5LBBsRvKthoWkbE7gMm5l0e5E0RSfe/qY2eNw6FT3P1KPZf9ElDHEcHyY0711KrTzBHKlHmy22W0lJw4Ear6+NPfGMb5EcGhUcXFvsX4EJNisxiD852UTflZUTdgejLXKXAOwQiQPNgLZWmwjwKK2NvES3diNZQSKByHrMZXGnuU6JRpRe+ZRnNi9I4yOB8c1OEOYVvmjpQ1NKV5ukR3jFjLuakDxw4mhTEkiB6VWTiyK3J5MTFRSjKLfzPhXpv9jJ9ofeeVsbV9REpYRf7kBolRGHGFLijjKbby5gRm010hpBPLmtV7o1jLLMKL7+QqFFAZ/ProAjNcrbZmBrEcDa72pCcGyW57hFu3WC9ricWpTSFkVoW1p73tgiPpDcs5bZemV6LvXGip6u/uLhiz0CCa9jkrYv07IGhVBqNHBUbLmSpo3k1IKmwH7UwhN7hL8I+Dis/oTgOs+AxSczrG4NcRV4znJOvwcQd1LLIO7lB3mvWbGJvksv54vl/u8pm1Q2QSPyoDU1OKovQ5uJPtPAYutDuW6OxW45fgDsH4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Yosry Ahmed wrote: > On Wed, Feb 12, 2025 at 09:20:24AM -0800, Yosry Ahmed wrote: > > On Mon, Mar 18, 2024 at 2:03 PM Barry Song <21cnbao@gmail.com> wrote: > > > > > > On Tue, Mar 19, 2024 at 9:52 AM syzbot > > > wrote: > > > > > > > > Hello, > > > > > > > > syzbot has tested the proposed patch but the reproducer is still triggering an issue: > > > > WARNING in __kmap_to_page > > > > > > > > ------------[ cut here ]------------ > > > > WARNING: CPU: 0 PID: 3529 at mm/highmem.c:167 __kmap_to_page+0x100/0x194 mm/highmem.c:167 > > > > Modules linked in: > > > > > > + Ira > > > > > > Hi Ira, > > > > > > I noticed this warning is coming from commit ef6e06b2ef87077. > > > > > > you have a commit message like > > > " Because it is intended to remove kmap_to_page() add a warn on once to > > > the kmap checks to flag potential issues early. > > > " > > > > > > Do we have a replacement for kmap_to_page()? The background is that we > > > want to pass a highmem buffer to sg_set_page() but we only know its virt > > > address. > > > > I am reviving this thread because new zsmalloc changes will make > > mappings sleepable, which will allow zswap to drop the memcpy() in > > zswap_decompress() -- except for the !virt_addr_valid() case. We can > > get rid of that too if we can use kmap_tp_page() in the scatterlist > > code. > > > > Ira, could you please answer Barry's question above about > > kmap_to_page()? It has been a year and kmap_to_page() is still around. > > (Trying again with Ira as the main recepient just in case) > > Ira, could you please help us out here? :) Apologies, No there is no alternative to kmap_to_page(). The work I was doing has stalled out and I really don't know if it will resume. There are a few folks, like me, who would like to remove highmem but every time the subject comes up someone speaks up about a rare (mostly embedded) platform which really needs it. So I don't see it going away soon. Removing the warning could be justified by saying that highmem removal can be done completely within the kmap calls and only when that has been completed can these calls go away. But generally kmap_to_page() is not a popular call and it might be seen as a step backwards by some. For example: https://lore.kernel.org/linux-mm/20221216070621.GA24832@lst.de/ The patch with the warnings was a stop gap to ensure current users did not break. Do you have evidence that the extra memcpy is bad enough performance that you could justify using kmap_to_page? Ira > > > > > Thanks. >