From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98B59C5AE59 for ; Sat, 31 May 2025 23:45:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C3596B01F1; Sat, 31 May 2025 19:45:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 974236B01F3; Sat, 31 May 2025 19:45:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 813FC6B01F4; Sat, 31 May 2025 19:45:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 649116B01F1 for ; Sat, 31 May 2025 19:45:17 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C678F815BB for ; Sat, 31 May 2025 23:45:16 +0000 (UTC) X-FDA: 83504836632.17.4D8C78F Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by imf16.hostedemail.com (Postfix) with ESMTP id C12A2180006 for ; Sat, 31 May 2025 23:45:12 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="RbR3CN/l"; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf16.hostedemail.com: domain of ira.weiny@intel.com designates 198.175.65.15 as permitted sender) smtp.mailfrom=ira.weiny@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748735113; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tC86QTZDXAMQoa9ZFP2UL1nRVrYivZshlv1IM+fn68E=; b=IDy4Iu7/BWxm2HWYMZxBrFRBJxpnyrh+mol8vhSNtrNCJdpOC9aOyVlhtgJtEPxjqyi5rg AC5HkhyM8fL3fqZMbeBHRa1DJmE4v1ruMvCAKPDod6bpZskJPjHHdxyuSwZpc49YdB8ku9 Yjtona1PSObywqAF5rKFDWu8EdYsXHI= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1748735113; a=rsa-sha256; cv=fail; b=o4Emyqlyzy1NXfBRklf4wVWJI8WdKDW+R97zFo+r3CisJh1F7RjlKwgbLjIog8r4flcqoH QDS1A1uU1s9avd6VOHr08fqotBYnRFazM32gB5l5IAZgQqUTAYi4PgAWN220rnftVa+lVR jeEt5LAQWIdIoZ4b0i2Mfs48FNihrmE= ARC-Authentication-Results: i=2; imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="RbR3CN/l"; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf16.hostedemail.com: domain of ira.weiny@intel.com designates 198.175.65.15 as permitted sender) smtp.mailfrom=ira.weiny@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1748735113; x=1780271113; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=tq7OPFEd457FQ6GzmbkLZisNt2V7xB9oIBDCOtcKA8Q=; b=RbR3CN/l9jyac7pLFNPpdi+N3C5iFUGw1A2eQvYhZy3vClvxEv9NiGPc Z2JEY4ypqiylvheATpd0isMTTeCSulFkAmw7jX/6qv2cuOvexqlcm6K23 zcUONRVmEo69EA1PG7olABfHmimiHLgxox43Ugf6PPGghe6QevJsoV2A0 8GfdpilJ5oWJBy90hfQW3AqDV0mjHBc0zHVzq6W/sae7AaB+pQAuRzd/E 18uOVMJGLllkMd3Y1iuR8bwbhOeklrKYJjlWLhIteaZ1S4dRBVW0JW3YY McI3cQdybrI/Z/ctahdhS35Ag4XNGr26vnnpRujgJPtO7x+S1K1c1XiDI Q==; X-CSE-ConnectionGUID: swD8ZglAT1you0Pab3OCTQ== X-CSE-MsgGUID: 5vmxBpQeRGeYTAOF3X7Y8g== X-IronPort-AV: E=McAfee;i="6700,10204,11450"; a="54456182" X-IronPort-AV: E=Sophos;i="6.16,199,1744095600"; d="scan'208";a="54456182" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2025 16:45:11 -0700 X-CSE-ConnectionGUID: ztTP1XElR0yQfhkFJQG/2A== X-CSE-MsgGUID: 7D7R5Zy1S4OaKtSqqUY1NA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,199,1744095600"; d="scan'208";a="167388454" Received: from orsmsx901.amr.corp.intel.com ([10.22.229.23]) by fmviesa002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2025 16:45:09 -0700 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.25; Sat, 31 May 2025 16:45:08 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.25 via Frontend Transport; Sat, 31 May 2025 16:45:08 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (40.107.93.86) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.55; Sat, 31 May 2025 16:45:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=s5TqZuJNdJNIaUHgt+k7/UrGPab1XVXjJ3Hatv2yNW4tlm/R2PthgClPhFiZMx1RRJukBzbZEIXiRhh+90wqs9dTLkFwruzNbiCELx3ZcpkFwNO3HQPICymS3RTrp5vKmwLF8NhdrEPe3EwNHG6otaXMSQaWbJnKUz5pdOGVJlD5imBH1CW5u9q0xLh3xSNH5ATgLgEt26u3oIlrqu+9ElNz7nzPFlz0iw/iwWShS3/G0xwdSRYDWVyqcGnPhql4WWwF9Y5bNJ3QrNCPe17rjNf+7bFvdP2v6tkuGXigExNriRVkpHf5ZA4RxWK6LOIVQDQgsN1qS6slbVh+kltgtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tC86QTZDXAMQoa9ZFP2UL1nRVrYivZshlv1IM+fn68E=; b=c2v2RY+ii6l1XEN5e2aKDB+RAP/YiwrmfEXV2X1z5d0MSKew5IDjeNM6AufHY5hymsxHBrHiheCMVf4bJYhaC4CL1o8FDF8+oS2cd7hKLBMLXI6a/reFK2lv+sQY2f7JhXBN8r9KQpaaClRWxo7fZo685Ij1we77YHGVSRXm6FYIuZWxhn6mrFr+Hoq4XgMIk0NmOU0cVAG8A1gAq9qmLQLQxn7Z6xVdvjwNCIAkOW+m/BFXJeR2zDdBXkWXpbESd03S3hh3bLw4aOSLzgJ/j5yrKl9iPsOZrkXhqvRwgaPeOGe3NF1F8Bx9p31xdQrSiIXsLM3vlS2ho218SiHPoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH3PPF9E162731D.namprd11.prod.outlook.com (2603:10b6:518:1::d3c) by CH0PR11MB8165.namprd11.prod.outlook.com (2603:10b6:610:18e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.32; Sat, 31 May 2025 23:45:06 +0000 Received: from PH3PPF9E162731D.namprd11.prod.outlook.com ([fe80::d013:465c:f0c4:602]) by PH3PPF9E162731D.namprd11.prod.outlook.com ([fe80::d013:465c:f0c4:602%5]) with mapi id 15.20.8769.022; Sat, 31 May 2025 23:45:05 +0000 Date: Sat, 31 May 2025 18:45:55 -0500 From: Ira Weiny To: Ackerley Tng , , , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [RFC PATCH v2 22/51] mm: hugetlb: Refactor hugetlb allocation functions Message-ID: <683b94b359be_1303152941e@iweiny-mobl.notmuch> References: <1f64e3c7f04fc725f4da4d57de1ea040b7a56952.1747264138.git.ackerleytng@google.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1f64e3c7f04fc725f4da4d57de1ea040b7a56952.1747264138.git.ackerleytng@google.com> X-ClientProxiedBy: MW4PR03CA0222.namprd03.prod.outlook.com (2603:10b6:303:b9::17) To PH3PPF9E162731D.namprd11.prod.outlook.com (2603:10b6:518:1::d3c) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH3PPF9E162731D:EE_|CH0PR11MB8165:EE_ X-MS-Office365-Filtering-Correlation-Id: 9ebefa72-cc41-4518-8f40-08dda09d2b3d X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?aFO+4wu9qGMXfcsSt3syY1pbTmPaB78C5iPvbdhqDDi/S9cXnAvtnWgXeSL/?= =?us-ascii?Q?7b5d+zWDCa0a4YSa75/B7epHxwLwYYTK2excuMAnx8+gxV9J5d6tGtrBfAk0?= =?us-ascii?Q?JyCqQn0600bpEidiRwfDV+r0w1Tis/Kg7yaBHibzkEV2K2Z+guVPrdp5+imf?= =?us-ascii?Q?tP2pDLkI6T1hwHGnQVCDV1gxwPZT+lv6bBRgMuDzQBCY7cKgFy5KRBAkKXR3?= =?us-ascii?Q?CrpVHIPDMETntRFYZ6rzbKRmUgMl5xEJHIuJbRyJN6sefUYKd8esW6gq3Yfv?= =?us-ascii?Q?nbiB4CyUIop+DLKHqIRMX9uKmoGswmelz4bLmqMIlcHDiMFsTjacocVHSYn0?= =?us-ascii?Q?cuaL2oOJCW0+ibQJZiT/PybGdzwsUGjkQSzag5rbWPVvPqBaUYLwcR0cQIA6?= =?us-ascii?Q?fyF5eJQK8VUzNXeITSt7RULVyUDpyZ30Wl3hKO8EiqP1ieOACbY1t4HsPtSs?= =?us-ascii?Q?Nq9WcZuteYBsypM3YdKgkKHYqea2RI+xGf53DsGHYpfyxaO5E5w8C4hWH2/V?= =?us-ascii?Q?JSA41lrunnvPqatXouQfylR4uuiPdaeQYolAXM9ZZ731BmrpQazQykHrVdrK?= =?us-ascii?Q?AOLhpHlcbtJeHWFrJoQDpoOWi7uHicm4b45M1kAA+QPvk6hDwkJCyRHn+gwK?= =?us-ascii?Q?1s+2VN6jYw/P39Y0kY88I2SX4qn6qoZ/7NKEzqFNK3EZwr+bycXgpLR42HYC?= =?us-ascii?Q?MANExqAt2sT3iiNcAmxwTIXehygtdh5nMK+wVT3sYxk9SMH0Ql6HBtKaFrtC?= =?us-ascii?Q?VY8UjhYiUVdt6zj9eBAEMsVAT7UNpEL+57dsgkDLFspWTIlBUUEaniJDUPRI?= =?us-ascii?Q?/5SiRoDpu+yrnJpGGtoDjSySfHgkoUrDKRnh3kbM7VKQeSK/fyobad6WUAQp?= =?us-ascii?Q?eAlowKCnawt1tyh9Lt6Xq1jI2N6wap1abIiUmE024X8ZH4HwNrKDitMI1B2y?= =?us-ascii?Q?AmZUzt7TTQi66CZU66XYsGF/DxgBNmHrj7NbJtMvP3zsfiLx0F4+4oPaue9q?= =?us-ascii?Q?W5eDd9WxvhwqJo0c9EZkft6dstiKtGsv8acb0dksFSf0SQtcP3JrBrPI9zGM?= =?us-ascii?Q?UTMVn9tmVb7xSbGQXiWWzGAaXEYl9RSDx441S7CbI4h+a+khZvbrzVwjbVFP?= =?us-ascii?Q?8l1iZx6KlM5MkLvLFwx40z6oVQ1GLMVBOr37ECE80cdfU6CwetD6IPjLx5sT?= =?us-ascii?Q?GgSD64A/F9UY3HEJhDfnNTHCck00fty6SUaTfuh0p7r+SykUlj1/is2Ei5fF?= =?us-ascii?Q?NT+OljzXUQU7o4wn+3NCkRYT4AboJDFwj0USi6e+xV/nk6z+E0ibP5xg6mMs?= =?us-ascii?Q?o0qxt6+FoS2AxLw/W+Mc4fO7HqvHlHr2ByinOs1XF6ksnlADv+kD1D2C0u0E?= =?us-ascii?Q?wwG9LnpKdRkDVc+IET4WLX2Ss2vhCfAXEerPF6pJQbpnYcefNnNszNLQl8g6?= =?us-ascii?Q?+TPWJKSaGLU=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH3PPF9E162731D.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7416014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rOH+Cr2kHurmT0xM+kRr78kEGCEXP9VMKcCBsIGxnUpHGBsjmhD8gr1ZIN0t?= =?us-ascii?Q?xx7eTlTH3M1Qv1U+9my/xoQe3jRYIAjOxe9wDaG1IOOWpSoUFRTEENgJTkNX?= =?us-ascii?Q?QR4PBMLGBLthw5XvfUya20uNQrLf8cpjhkjTleRwjo1nKK6NUmxaKxOt2UMG?= =?us-ascii?Q?eGGE6gM7n7vtcLkzkoPAOJLxjSHbmD702saXCWCZllJyaPkUupPr92Jq7P0O?= =?us-ascii?Q?BcfOU8ZVLzXCG7OoUVchkzfxGCSW+MEFfRHtRKKutmhN3oH4Ft5+mgNhMzGF?= =?us-ascii?Q?GZdeolI57OmOEaU0Zf/Cc1T82aN78UU/FRilItrW5uYkT4nsNwadSTk0ZYYr?= =?us-ascii?Q?DP1MQ/iXF8izZzEOmnbCh4HRkySXeZgiv6wY5dIFnSgmyRCNscEUmO9NRW5t?= =?us-ascii?Q?el0eIIoznZy1pTV/yH+o+RIQopuVdF3AwMl4Mjn42JzGzy0p1VCo5jN4NEGU?= =?us-ascii?Q?IR1Y4UbLA6XfB3zV+F/1uJQsZSSiDRTVK6zlnWwR9/8ErDlEiz3wpB+U0exs?= =?us-ascii?Q?LjYghVOYV6sNp6sN/PXdnzUmG6j34lDWJns5dlWlAqztAxBU3dEnOwiNGkRg?= =?us-ascii?Q?A9jp7FN6HCfd94W5KqMzxa5aZrer8lfZ1SVEFAoSebc3kwOrNcGYPo3Tx4dA?= =?us-ascii?Q?9Lac4geYGOI3cuKmx5tChJaZbWLUC8j9qwDCQeqr89XRCws0OrPffMMPBnJJ?= =?us-ascii?Q?DwObZCW20j8CJz/yBAxGSpSJLHhPOrTb1Kdv4hyhrQm4gC0ysSPJDjPHb5OB?= =?us-ascii?Q?bhqqBj+ToEf0fFqFoacoJkwubqegfiRGzSZjHUzLm7+6fq+D5WVvKB7yYyF3?= =?us-ascii?Q?qTRHf5m0ziGMm7HHerxTXD0RnLqme9VqZNi8C5I5Ykyhb96qeZu+SycQiPKa?= =?us-ascii?Q?imvWQT/m2LoVBySE2Dsk0ZrgPmqg9T9V04/XybjM8jMepImwPD1OKM0IP1JP?= =?us-ascii?Q?gtRwJBlz63vOw3cF5Q2xlOMr1/F8U0jhGdgRDJ6fXI9wxGnAPiSGuveR62O9?= =?us-ascii?Q?+8pwevtHj+4aiiQ1kH2HHEWa2SttSOtQUh6qb6+4Qo9tQ6TMlOMANrkhlBZQ?= =?us-ascii?Q?sWdn9aMrJi4KCAV6Sv8+3Sx06QGfH98SI4cAadD3sv1LWwuiZ99Eb5a0nYTz?= =?us-ascii?Q?ZT6qPhbd2tvjibVWeOz/OA9PX4JnfFZx1ROt0AVQ7F+nzX0i2b+3Q5RZX/0F?= =?us-ascii?Q?UNsEqug+kr05deXbTKKY1wMf/XvqnO5f/6R7UUv0Pi6aYOuEainlX8i6Fs35?= =?us-ascii?Q?e9fYAXk0seeL+qmvEJbmJ01498d6h7ZvefpEKYBv/r5SeKRiRZwloVGMlrFj?= =?us-ascii?Q?NJQr5apUhpGWWW1SjQN66UfY9akm3yfKQO1R5mwqBfZ4atkwHyt7k8BURDQF?= =?us-ascii?Q?GbiuoI7rlENs0R40m5ySiknAW8PiI37dYFWxmvRLWyzCYzjOmFfYBVmi7924?= =?us-ascii?Q?pC42+Efm5yarjNIHl+3SdELYKTGzr1ucYBBV+mDeDd+cnHIwSqQGz+l6nefy?= =?us-ascii?Q?Tcuxp0IrHfceC+p0kLN/Lpzs3EWRt5mE3fjmgwm0ObZfGqSPBbmQiFFEaMM7?= =?us-ascii?Q?k5kff6LlVXsgMJVgsg0A02M5vJZLzBT3dsI6rrO6?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9ebefa72-cc41-4518-8f40-08dda09d2b3d X-MS-Exchange-CrossTenant-AuthSource: PH3PPF9E162731D.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2025 23:45:05.6572 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H/k8/XoeyWxhF8XBXQu3rdWNArrq6gd7wPNmJj90rg5N7swB+q/CGWYXpAhHd154pexMittw/fBq8m2igIWioA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB8165 X-OriginatorOrg: intel.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C12A2180006 X-Stat-Signature: ihabtjwxdfttf8tp1gjia3ucpk8m9ijd X-Rspam-User: X-HE-Tag: 1748735112-977782 X-HE-Meta: U2FsdGVkX1+Pnkea+F9SZJeBeQXNp23z+iPqE8sQfZ5fH/Y41qkfctFT4J1UNlWxmLD3tmICF2F2hOLECcFnRl5aJMe3uJ+tJVkQ/MBh961Q3U2zZYrpmU/+yfDs4mkF3Z4ENpxiL7uiPIHu7Xm8VtVyYcaUEAQcIYdhF9k74aPpMaVpD9jLRH6ejYkiAnjnzg274MVlKkgagN9uZbyGNLByNtrFpEbPM78hBziGNiTlRrZ5v/Eh0YGJPH/AL9sjU5V4nUpycEiiVDSC83AbeByLoyRlA/Z+eSxfEkTx/PI2K4EVYlG8mS8aA2XSN3Amb6o+dkFtnw6EdDDaoComiG7M5/zK/OKRFaZzkT3/c6HNAyOq7bxwr0Zi73ItcYNiGeCuQ9Imw5KNUYnZjc9Be71exu5cXasI0hl90ARfJcZ2vL6MCfdTYwTxFllHP9qmV+UKWl7oR60FJ7pq1znCDvuz9qyQHD4NDgD5ePu1hqMHU5xE73J5d3Nd5XHR85CiV1TxqKC4DfaOFOg2qzrtMcxRrAa0FW7NjZXPBoW6MsqnGtAIToaBjPX4ePcYLxGi+bVzG+B2c+DcuGmvlkDlJOl2ya1WmZbaCMzRyoiYSrIieCkrK7dlS3uwZi+CD7t8cTZweenUB6D2oW4Nnxc0GxkMkLp5Uju4TWIXcOGYARAo99R/vpascG3xA+cFfR9Nk93iD/wP+dJUzgSabMHpj/1+YNy+JDtv1mQyyMbzAXB7lq3WEFTlphYvC4WOJvLRwmK0tsiGKJi/95KSwbrUaoDANAMAhNjQd8sCvGlodq2DeVfq8AXLjN6b0L9ZwbasBqDd2YZzs/h+9q+EbxU//TzoY72xt5LMqLmYIy4m2L4LY05YuJ3nnUx34vubVv3uHs3MQoJL70keJVFaxrhJa2kZx/nN7JXRt62Co0SYywKT4YCxMJC51KhxsLx4lUcwJLYYYF8nf+Jae5UqTwB pmU83iHm XRUYyTwroLptfJyfkWhJYXdjw+iBUxbVOZlRkIQm6vWUuHbJw2j4Gk+nWSF7ahSC6mt5QmGBmRLLS3MnZfqMG2EaZnZD2krAJvMCnYdGXi9uoQoywHJqvwCOKyzqve8RTwN0fYRU9ASNRJyZqi0dG5tp8n4mlAqt7r/XWEjcYVO34qTExotMWOZLlHa9tGbu7yTITRzsgnHEa4UwCfhvSqWKfUXvJ4H6ac4rtd+/e2l9X8ZgIGAt0P69uRSSmfuoJNDDsQS5TQ4N6R0HHLls91X9mLbdbnQRbIMjvcXwbvJ3HH1W2qbd01YwixncxKHxB4CjWwBtqFbcCfG31QnpcrFyxbKGvTf4DY6TtO1W5FgRKiqv8YqDkLlwyiux3++5fs2g7cxXmHR1KYzmxvJK9huxZTQJmJn1PiodmcHgIGTwcpNODxQxGwZ6E9HTII3hsFoBXBKWs/ikq9CSxfGfJIQo6hRMU8rnxMK6F3tzXMAg3OgYcI9RzLADEHiJVBOir8DCSHmNMmiGiBZXrat9fZtqABL+UooduvCM+7QMgJEZIclY/i+fcF7rAshWpsE1n7OCa3a97L53STbs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Ackerley Tng wrote: > Refactor dequeue_hugetlb_folio() and alloc_surplus_hugetlb_folio() to > take mpol, nid and nodemask. This decouples allocation of a folio from > a vma. > > Signed-off-by: Ackerley Tng > Change-Id: I890fb46fe8c6349383d8cf89befc68a4994eb416 > --- > mm/hugetlb.c | 64 ++++++++++++++++++++++++---------------------------- > 1 file changed, 30 insertions(+), 34 deletions(-) > [snip] > > @@ -2993,6 +2974,11 @@ struct folio *alloc_hugetlb_folio(struct vm_area_struct *vma, > int ret, idx; > struct hugetlb_cgroup *h_cg = NULL; > gfp_t gfp = htlb_alloc_mask(h) | __GFP_RETRY_MAYFAIL; > + struct mempolicy *mpol; > + nodemask_t *nodemask; > + gfp_t gfp_mask; > + pgoff_t ilx; > + int nid; > > idx = hstate_index(h); > > @@ -3032,7 +3018,6 @@ struct folio *alloc_hugetlb_folio(struct vm_area_struct *vma, > > subpool_reservation_exists = npages_req == 0; > } > - > reservation_exists = vma_reservation_exists || subpool_reservation_exists; > > /* > @@ -3048,21 +3033,30 @@ struct folio *alloc_hugetlb_folio(struct vm_area_struct *vma, > goto out_subpool_put; > } > > + mpol = get_vma_policy(vma, addr, h->order, &ilx); Why does the memory policy need to be acquired here instead of after the cgroup charge? AFAICT this is not needed and would at least eliminate 1 of the error conditions puts. > + > ret = hugetlb_cgroup_charge_cgroup(idx, pages_per_huge_page(h), &h_cg); > - if (ret) > + if (ret) { > + mpol_cond_put(mpol); ^^^^ here All that said I think the use of some new cleanup macros could really help a lot of this code. What do folks in this area of the kernel think of those? Ira [snip]