From: Ira Weiny <ira.weiny@intel.com>
To: Shivank Garg <shivankg@amd.com>, <david@redhat.com>,
<akpm@linux-foundation.org>, <brauner@kernel.org>,
<paul@paul-moore.com>, <rppt@kernel.org>,
<viro@zeniv.linux.org.uk>
Cc: <seanjc@google.com>, <vbabka@suse.cz>, <willy@infradead.org>,
<pbonzini@redhat.com>, <tabba@google.com>, <afranji@google.com>,
<ackerleytng@google.com>, <shivankg@amd.com>, <jack@suse.cz>,
<hch@infradead.org>, <cgzones@googlemail.com>,
<ira.weiny@intel.com>, <roypat@amazon.co.uk>,
<linux-fsdevel@vger.kernel.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>,
<linux-security-module@vger.kernel.org>
Subject: Re: [PATCH V3] fs: generalize anon_inode_make_secure_inode() and fix secretmem LSM bypass
Date: Fri, 27 Jun 2025 13:21:17 -0500 [thread overview]
Message-ID: <685ee11da5119_2ec7172946a@iweiny-mobl.notmuch> (raw)
In-Reply-To: <20250626191425.9645-5-shivankg@amd.com>
Shivank Garg wrote:
> Extend anon_inode_make_secure_inode() to take superblock parameter and
> make it available via fs.h. This allows other subsystems to create
> anonymous inodes with proper security context.
>
> Use this function in secretmem to fix a security regression, where
> S_PRIVATE flag wasn't cleared after alloc_anon_inode(), causing
> LSM/SELinux checks to be skipped.
>
> Using anon_inode_make_secure_inode() ensures proper security context
> initialization through security_inode_init_security_anon().
>
> Fixes: 2bfe15c52612 ("mm: create security context for memfd_secret inodes")
> Suggested-by: David Hildenbrand <david@redhat.com>
> Suggested-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
[snip]
next prev parent reply other threads:[~2025-06-27 18:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 19:14 [PATCH V3] fs: generalize anon_inode_make_secure_inode() and fix secretmem LSM bypass Shivank Garg
2025-06-27 8:27 ` Gupta, Pankaj
2025-06-27 18:21 ` Ira Weiny [this message]
2025-07-01 8:33 ` Christian Brauner
2025-07-07 5:23 ` Shivank Garg
2025-07-03 2:13 ` [PATCH v3] " Paul Moore
2025-07-04 10:41 ` Shivank Garg
2025-07-07 20:01 ` Paul Moore
2025-07-07 20:38 ` Chris PeBenito
2025-07-08 2:45 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=685ee11da5119_2ec7172946a@iweiny-mobl.notmuch \
--to=ira.weiny@intel.com \
--cc=ackerleytng@google.com \
--cc=afranji@google.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=cgzones@googlemail.com \
--cc=david@redhat.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=pbonzini@redhat.com \
--cc=roypat@amazon.co.uk \
--cc=rppt@kernel.org \
--cc=seanjc@google.com \
--cc=shivankg@amd.com \
--cc=tabba@google.com \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).