From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F868CD5BAE for ; Thu, 5 Sep 2024 12:23:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C70FB6B0402; Thu, 5 Sep 2024 08:23:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BAB126B0404; Thu, 5 Sep 2024 08:23:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4C4D6B0403; Thu, 5 Sep 2024 08:23:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 81CB06B03FE for ; Thu, 5 Sep 2024 08:23:49 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 39200414C8 for ; Thu, 5 Sep 2024 12:23:49 +0000 (UTC) X-FDA: 82530600978.01.2FF818F Received: from out-173.mta0.migadu.com (out-173.mta0.migadu.com [91.218.175.173]) by imf22.hostedemail.com (Postfix) with ESMTP id 6A8F9C0006 for ; Thu, 5 Sep 2024 12:23:47 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=qIprDKky; spf=pass (imf22.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.173 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725538950; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lLByLv8rw/zOL3j4lfqH8Y8PpLKTX3K0pHjcs2rvP4s=; b=Ai59FV/wClbZsLrO+uo8UcYPawkkbt7r8WgXQiL0GKU6oJUz3tfRAUYpPTZFGdYyUhyBgT rt9U88C2xcePKS+ZmXZu/ZzVrjZFdyhaFgel+Hx4XkeIVjrseuVFy4X5DafE0rM0dfFkC9 HhDV+tZZt2KrvdSH9ln4cDaR2mAH0BA= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=qIprDKky; spf=pass (imf22.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.173 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725538950; a=rsa-sha256; cv=none; b=FbA+K95X4yeMBeYOsLcVLdGjAShamD27T4mUdpHWbDAgzOiZDCINnVDqzlV5pcnKRjtSM8 LV+XJGpqERW2k9q3zPcG9cGHU6Y4kXQdgQEhpJOIkRzP4oyXcxxPiGswtD0MWLrcIzQJoM owPXpGBxaJ4b/uWLCk6qk5h8lt3m8aI= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1725539026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lLByLv8rw/zOL3j4lfqH8Y8PpLKTX3K0pHjcs2rvP4s=; b=qIprDKky84jYBcTOlWU0VsCg3PCkUABBoUNoabNnPl/kHYtmLYn6JrjyHwQZD2PlANABeN SWQT3EbNY1AeZs6F/KKpmrJh7OKyFFzsvYVx4NEjaerCpC5YiPojpdrWYArdGSJX3H6yJE rdLsViLeoTGcKRE4dGRvnpDBrtxgxck= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: [PATCH v3 12/14] mm: multi-gen LRU: walk_pte_range() use pte_offset_map_rw_nolock() X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20240904084022.32728-13-zhengqi.arch@bytedance.com> Date: Thu, 5 Sep 2024 20:23:05 +0800 Cc: David Hildenbrand , Hugh Dickins , Matthew Wilcox , "Vlastimil Babka (SUSE)" , akpm@linux-foundation.org, rppt@kernel.org, vishal.moola@gmail.com, peterx@redhat.com, ryan.roberts@arm.com, christophe.leroy2@cs-soprasteria.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org Content-Transfer-Encoding: 7bit Message-Id: <6867F624-A83C-4A3C-947D-ECFA4925130F@linux.dev> References: <20240904084022.32728-1-zhengqi.arch@bytedance.com> <20240904084022.32728-13-zhengqi.arch@bytedance.com> To: Qi Zheng X-Migadu-Flow: FLOW_OUT X-Stat-Signature: 5oatdytin8qrdsf8q68xwt16tob9z1yt X-Rspam-User: X-Rspamd-Queue-Id: 6A8F9C0006 X-Rspamd-Server: rspam02 X-HE-Tag: 1725539027-88262 X-HE-Meta: U2FsdGVkX18iAv8ep74Oxpu/vIiTFBLRvI4zVUM1axB9AvZm7V8huAp0Mh/ABNy7Kec2LhUv86jS41oCRUDsvZqOG2DH8oT+rZKTUnCBCgKuriaVOa8eiL+79IYjV55SLKczCruy8mGjOTCHh2XJwLqDvUwIzCHmMQ8PlZbRn+CMjYZQP+LGvZN1MYYlh0WY5henm2b5tXxqYltupWh/hymf135KZps4QFScWUKwXJtlAs0ukkkay3UiCADnuu76ckOof6G+xZs0HJxz9KohQspYvxr6q37ZkTT0sodxSUD7CCl04NQ8b/ujp1kofPg3ym1UWp12+5uPbKc/16ZE/8VoR/B2n11TOWExsfsFHDgjxXA0Ih1Vfe2hjpbkjII8owLujcrGsGcxgC/1aguSdh1PW7WjVN4w9Px1qDK/Q3ZNaI77Jl0F8cD0yFixHyPBPbRnkc/C16BknhTt02R6Z/05WpLIeaWal6IDEqMoWQ40jHZ1ttqbjjVsqFyL8SE2HUIqLBuVoIfdTrEoZOjCh6Sc3ucH11lRhYkBkDg8IGpyM1hn2JvOaON1dg+x2mkpM6KvMZoqSoBsJo2JCAsEbw7yNCq/woFan5FNxTmHk88Nz4/cKXH+Fq/F6jUHH2biOlqWxZg7Tkgfg/kGFtku5OGEruWenLleFW40oSgas91Cua+SywP7ex+wTq1oFoa9aL2fCcCPLKSYwaQB/W45+4i3k0uWv+onw8to6nm9LO4t7rs01i86Otb0s435/cWd+QLlv5e7jiVt2djE6W2jXrdTyhJHoHonQ1eCMljyBrrMgb9fTgexdmVZvqri1vM8CkeAJILHGgKPjBeOQUSNiKdEjS17G6DujB+wz9msgvux/+PH4iCEOKHQLx+8TJzuhOetHPBGT8lVvnKR89sUjXLH8IPasS/yn9NBRfYvDg+CuFo/D1PL+ti71xG49aqveLnM1nLj13SpkKtbrTh ZRWjAQ+Q dhx5uzmcUSL7Pa6DmjAcsNjDERQyZ0MUcUJoqUdBRRrju7MBZ09pJnLX7Rj8oXWFbZZirODQP2mRMjC8F3ZHioFkdLyorcTv8ORdbp+5Sie7/F1/iU+bkvfQ4pOGnGgce7FfArqaaoxc2Xiav2QTn5eUGJFvl2pt+s/FlXSWJ5yQCKTfYRFaHClx6GnMI3BTc2mpDmN0SxnEoRbRp+sO7Pg6SqRXyM0PA2XTc5Wgc0rpz1DI1xXfKXGNWKOCcLc/+r16T1qkaBNFfL/TCN3lWvN0KlnPLx+8tlvVM2VnG9JCqujmTNCOw9h4oETrWQCjMrKLUp4B2jcMDIGAoSU1GLHgYiYuIABv+vqLN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Sep 4, 2024, at 16:40, Qi Zheng wrote: > > In walk_pte_range(), we may modify the pte entry after holding the ptl, so > convert it to using pte_offset_map_rw_nolock(). At this time, the > pte_same() check is not performed after the ptl held, so we should get > pmdval and do pmd_same() check to ensure the stability of pmd entry. > > Signed-off-by: Qi Zheng Reviewed-by: Muchun Song Thanks.