From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADE53C32793 for ; Wed, 18 Jan 2023 14:31:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47E296B0071; Wed, 18 Jan 2023 09:31:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 42E616B0072; Wed, 18 Jan 2023 09:31:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CF556B0074; Wed, 18 Jan 2023 09:31:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1F50E6B0071 for ; Wed, 18 Jan 2023 09:31:35 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id AF3F81C03C6 for ; Wed, 18 Jan 2023 14:31:34 +0000 (UTC) X-FDA: 80368158108.10.75D58F3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id BDDB520036 for ; Wed, 18 Jan 2023 14:31:26 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FaynD6Ww; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674052290; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MZJOxLnmkEvZGZ/FgYrJ/gq7makso9s4WdJRv05FlCs=; b=FCEeeTp93LcMGhzgXyWcPiTBv0/mNaFV3nVRQmN6/Wk7scPKSqegs07Jn/FDXv4qmc0gA6 ZpOmXbXag/Sd+YFPXjpxwysuHnccZTBUAkG44ArBSfXdmFnD13e6+y9UiZPFZQLbo4uMob gtyMr724axMYon9flYHh31QGdMP8vMk= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FaynD6Ww; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674052290; a=rsa-sha256; cv=none; b=eAjyHLf/iA9Bujz9S+Y4YKHBGHE/2D16jVhtQ9sKxuUg1EndiiZgcd+sJxy3LAye95+sMr bkhkLuODHLZQ1PbJK4fDqlU7wtV4ettwvmZTT7LU48vla3JWBhtz5NQJOhHbcPD4wFM4gl hR4F3fDvUNSC+5NtiqVvfv1YxXn1C7A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674052281; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MZJOxLnmkEvZGZ/FgYrJ/gq7makso9s4WdJRv05FlCs=; b=FaynD6Ww7PggX5rzV3xoomz11PSvon45nphbQu0hRH3xwPDVIB+H5FbDt9X4kCfkdp6bSJ 73u/JWtC1TWjMwLuYi9WqqtypmYFpxMSqcouGKyeDbjiKMY4NuT1SoEMap5itR4AdLTF74 CB6PU4vO/RReejxTewfk5hVyA3eU1Ck= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-263-X5lc2D9YPxaHlMDvMrf-zw-1; Wed, 18 Jan 2023 09:31:19 -0500 X-MC-Unique: X5lc2D9YPxaHlMDvMrf-zw-1 Received: by mail-wr1-f71.google.com with SMTP id j30-20020adfb31e000000b002be008be32cso2304348wrd.13 for ; Wed, 18 Jan 2023 06:31:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MZJOxLnmkEvZGZ/FgYrJ/gq7makso9s4WdJRv05FlCs=; b=0KCTWQRrRD0l0TjY6HOOo8F+cuBC7XScwaTZvHQaPdsUFg0U9ai+kYD4TiJi7aW3u4 1T1+nYEUxIrRpfnnX9hPzsW/DzHEM8kS3pHCZm+jB0+L+2ifxUtCc7pFqgOI0hhm8ywm Qw9CFKvUCMnl4D5Os7u/EOPgNAE+ZxUIXTfL/TbPwAjmlDLMyvT3UylsnLojYKHCRfQE 9968S1wKmTH0B+ytU07zOcfrbuGPC1CSIFhjPoI06qbAuZ5HC8K7nsoI6KWJ3PjDaHgZ iJq1yH3I3RZuHMWCGSUCWmPCybxK6p8Ex8BqvaoWtJpM3DSCHgDSpVP0E/KKHGAJ1m30 jshw== X-Gm-Message-State: AFqh2koU+5qCieCCESUvWoyxiI2dzcOUKNxvuHc6QDRcr5bxkUE/oOf/ NJ1cVa4b1utXpSzxneyU+r06wMh5DwsXtcSMCN33/P9ZlgiCXllLDQuW/2k6cIpT+eOCJKtlyuZ OjbfPGE7F7RM= X-Received: by 2002:a05:600c:1508:b0:3d3:5166:2da4 with SMTP id b8-20020a05600c150800b003d351662da4mr7009878wmg.8.1674052278233; Wed, 18 Jan 2023 06:31:18 -0800 (PST) X-Google-Smtp-Source: AMrXdXsth3/hCFmCk0CHrLL4sAw6wLN3YDRV43ECbmf5dcJXsZ/th3eShzA76PWIJL/IQZihhGpC9Q== X-Received: by 2002:a05:600c:1508:b0:3d3:5166:2da4 with SMTP id b8-20020a05600c150800b003d351662da4mr7009855wmg.8.1674052277937; Wed, 18 Jan 2023 06:31:17 -0800 (PST) Received: from ?IPV6:2003:cb:c705:800:1a88:f98a:d223:c454? (p200300cbc70508001a88f98ad223c454.dip0.t-ipconnect.de. [2003:cb:c705:800:1a88:f98a:d223:c454]) by smtp.gmail.com with ESMTPSA id f2-20020adff982000000b002bde537721dsm13524925wrr.20.2023.01.18.06.31.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jan 2023 06:31:17 -0800 (PST) Message-ID: <688bd1cb-0b4c-3b4f-6af9-7a07da3d16fa@redhat.com> Date: Wed, 18 Jan 2023 15:31:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v5 4/6] ksm: count zero pages for each process To: yang.yang29@zte.com.cn, akpm@linux-foundation.org Cc: imbrenda@linux.ibm.com, jiang.xuexin@zte.com.cn, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ran.xiaokai@zte.com.cn, xu.xin.sc@gmail.com, xu.xin16@zte.com.cn References: <202212300916292181912@zte.com.cn> From: David Hildenbrand Organization: Red Hat In-Reply-To: <202212300916292181912@zte.com.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BDDB520036 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: whfyxwdeiscpqg48uxbsrw4tp3ceufdb X-HE-Tag: 1674052286-242323 X-HE-Meta: U2FsdGVkX1/kXOTjNquxcCP99vtL52YFun0g+IEfKf1bz7y6T0iYW11W+8E47EKb8xqCjZnQZNeZTo34oyLzBPOnZuwJp5R5f2FgsqzRU5rvyCR3Fk6YACPUfxBgWimCxEJEV+XraGI0MVHsOBjpBxT+Q4nnH3PVOuuahPbm4w5Xw0RgjfW1EwHwpFJKF5tza9sqM/jQBoB3tHwG3bSL5GbpvukqX+WYb/7l7wh7WxOdKSiPONOCxb3G8u0GgGfa7g4Z3tV5Mg3kHqX7gcfr3SwHWPU81hv9+cx6DOQcPayIH2WYUU731c88x4GBwxDAGSvgotyPtSFKuZFF7NB/RuaWuE5w4xULbrGEWpafbCcfpvTmuNzqzaw9DQ4Fkk5M36rmUN/7X5H9fFo0GU2SKi1HecPioH3dM5zb3T7rUFIL5qmSweuMMUQxKeUlF0exP9/mgXKxAkwvLe255/p9PZkEuv2xNTOozvkT8ncrD+ncAtxlg8oWlN2DHQg8XbFDpvt66HBE4MBKyzGkRwizhb1K4IJd2RZKCgmRGm15sxKEyedLpAHmN3EjrAwTkWWX9wU7eliRVYQZkBrVjJfMCObxjiYHwldW3GahmWdPp6kFAxaDTeY8TNYgnKb9eSnR84ErHDh33+MhP8d1cFBG5nu22iTnfRLH+qTn2oJXraSfc6FJIER4MTlufHAHE5L9lZaGKDxawKrWnXpszmT1rzdzVBghxUnmfQ2eQeQr84rItW69VtzQPK6Rn5M6G4kBMWysC8mzJe5Djh8zVrJr2e2KuDqby63jTRtzMXfkmE7TTHmLUsux+qQXxPI6TumIVoSzasVaZdiVRA0z2iAkVJcWeJ37oJBOfcs55P6W/KTD14IUDm2EXITkJR5RcXjPRlERB2kZdgmpbSZXvvTFRjPY2ulXsgIfseHqjM10xg1YPm8hR5JrgLm8l08udCzs/4q7RhSOcmYr/hpGBxU EgF8zyYm YwSQwXqx1Em7M7T12VXHCiuS+oQt4ON5X6mozZD7xHujyfpd30zCB6d992Pf/wyHluzwM3HbPslzsgR7VK1meuyDZKQwbirt6ncq4GH/c6/scI66zDoOgiK1/rA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 30.12.22 02:16, yang.yang29@zte.com.cn wrote: > From: xu xin > > As the number of ksm zero pages is not included in ksm_merging_pages per > process when enabling use_zero_pages, it's unclear of how many actual > pages are merged by KSM. To let users accurately estimate their memory > demands when unsharing KSM zero-pages, it's necessary to show KSM zero- > pages per process. > > since unsharing zero pages placed by KSM accurately is achieved, then > tracking empty pages merging and unmerging is not a difficult thing any > longer. > > Since we already have /proc//ksm_stat, just add the information of > zero_pages_sharing in it. > > Cc: Claudio Imbrenda > Cc: David Hildenbrand > Cc: Xuexin Jiang > Cc: Xiaokai Ran > Cc: Yang Yang > Signed-off-by: xu xin > --- > fs/proc/base.c | 1 + > include/linux/mm_types.h | 7 ++++++- > mm/ksm.c | 2 ++ > 3 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/fs/proc/base.c b/fs/proc/base.c > index 9e479d7d202b..ac9ebe972be0 100644 > --- a/fs/proc/base.c > +++ b/fs/proc/base.c > @@ -3207,6 +3207,7 @@ static int proc_pid_ksm_stat(struct seq_file *m, struct pid_namespace *ns, > mm = get_task_mm(task); > if (mm) { > seq_printf(m, "ksm_rmap_items %lu\n", mm->ksm_rmap_items); > + seq_printf(m, "zero_pages_sharing %lu\n", mm->ksm_zero_pages_sharing); > mmput(mm); > } > > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h > index 4e1031626403..5c734ebc1890 100644 > --- a/include/linux/mm_types.h > +++ b/include/linux/mm_types.h > @@ -776,7 +776,7 @@ struct mm_struct { > #ifdef CONFIG_KSM > /* > * Represent how many pages of this process are involved in KSM > - * merging. > + * merging (not including ksm_zero_pages_sharing). > */ > unsigned long ksm_merging_pages; > /* > @@ -784,6 +784,11 @@ struct mm_struct { > * including merged and not merged. > */ > unsigned long ksm_rmap_items; > + /* > + * Represent how many empty pages are merged with kernel zero > + * pages when enabling KSM use_zero_pages. > + */ > + unsigned long ksm_zero_pages_sharing; Same comment as for previous patch: this counts rmap itmaps, no? ksm_zero_rmap_items might be more appropriate. -- Thanks, David / dhildenb