From: <dan.j.williams@intel.com>
To: Alistair Popple <apopple@nvidia.com>, <linux-mm@kvack.org>,
<akpm@linux-foundation.org>
Cc: <david@redhat.com>, <osalvador@suse.de>, <jgg@ziepe.ca>,
<jhubbard@nvidia.com>, <peterx@redhat.com>,
<linux-kernel@vger.kernel.org>, <dan.j.williams@intel.com>,
Alistair Popple <apopple@nvidia.com>
Subject: Re: [PATCH 1/2] mm/gup: Remove dead pgmap refcounting code
Date: Tue, 2 Sep 2025 18:17:56 -0700 [thread overview]
Message-ID: <68b7974488914_75e310062@dwillia2-mobl4.notmuch> (raw)
In-Reply-To: <20250902051421.162498-1-apopple@nvidia.com>
Alistair Popple wrote:
> Prior to aed877c2b425 ("device/dax: properly refcount device dax pages
> when mapping") ZONE_DEVICE pages were not fully reference counted when
> mapped into user page tables. Instead GUP would take a reference on the
> associated pgmap to ensure the results of pfn_to_page() remained valid.
>
> This is no longer required and most of the code was removed by
> fd2825b0760a ("mm/gup: remove pXX_devmap usage from get_user_pages()").
> Finish cleaning this up by removing the dead calls to put_dev_pagemap()
> and the temporary context struct.
>
> Signed-off-by: Alistair Popple <apopple@nvidia.com>
Looks good, thanks for this work Alistair.
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
prev parent reply other threads:[~2025-09-03 1:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 5:14 [PATCH 1/2] mm/gup: Remove dead pgmap refcounting code Alistair Popple
2025-09-02 5:14 ` [PATCH 2/2] mm/memremap: Remove unused get_dev_pagemap() parameter Alistair Popple
2025-09-02 7:47 ` David Hildenbrand
2025-09-02 12:06 ` Jason Gunthorpe
2025-09-02 20:31 ` kernel test robot
2025-09-03 1:20 ` dan.j.williams
2025-09-02 7:46 ` [PATCH 1/2] mm/gup: Remove dead pgmap refcounting code David Hildenbrand
2025-09-02 22:52 ` Alistair Popple
2025-09-02 12:06 ` Jason Gunthorpe
2025-09-03 23:07 ` Alistair Popple
2025-09-03 1:17 ` dan.j.williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68b7974488914_75e310062@dwillia2-mobl4.notmuch \
--to=dan.j.williams@intel.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=david@redhat.com \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).