From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1C59C433E1 for ; Wed, 26 Aug 2020 00:13:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9679D206F0 for ; Wed, 26 Aug 2020 00:13:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="2BrDqwaM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9679D206F0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 412ED8D0002; Tue, 25 Aug 2020 20:13:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C4B26B0007; Tue, 25 Aug 2020 20:13:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DB148D0002; Tue, 25 Aug 2020 20:13:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0115.hostedemail.com [216.40.44.115]) by kanga.kvack.org (Postfix) with ESMTP id 19B0F6B0006 for ; Tue, 25 Aug 2020 20:13:43 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id CD2BC824805A for ; Wed, 26 Aug 2020 00:13:42 +0000 (UTC) X-FDA: 77190796284.09.tin36_5114e5227060 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id AB7D6180AD80F for ; Wed, 26 Aug 2020 00:13:42 +0000 (UTC) X-HE-Tag: tin36_5114e5227060 X-Filterd-Recvd-Size: 3437 Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Wed, 26 Aug 2020 00:13:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=Gs2cxssngByG89pViSAo1+L2dbs8m9mQvOVpn+U3G2s=; b=2BrDqwaMOar/R1I06H0535xd83 Hmo808kwqEjorIjeH0G4FX64/zc9FXzlweQtVMZjPNMVr9aZ4R3PrS07cU8HgNh7yQKPK/SL7OlLG E3K5FveGJfeeJDTbsvYg3SrMUQiSfqpCOKD6419K3q+ukJ5+yZ26VQBQq6MVfFHXasDVFN7SumZnR VqvDIEtDbRm+roJy/lY9GawCShBv3lOV5yCOJUwK9Dmc1BLR/58pz0Wgewef62cnefHY+0AR6S59R kBk+J6nIZsFRwRH5SlKlkiBNqRTzlA2/1Wnp9UZxDLkNJ0HuUEoVaPEvbsQQXomrGC7kx0eElVGML i74xmMrA==; Received: from [2601:1c0:6280:3f0::19c2] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAj4M-0003f3-T2; Wed, 26 Aug 2020 00:13:39 +0000 Subject: Re: [PATCH mmotm] x86/numa: fix build when CONFIG_ACPI is not set To: Andrew Morton Cc: LKML , Linux MM , Dan Williams References: <70e5ee34-9809-a997-7b49-499e4be61307@infradead.org> <20200825165214.2b5e1fbf53d68fd3714c8050@linux-foundation.org> From: Randy Dunlap Message-ID: <68e4e428-9b66-cfac-ef20-0d30b29d0773@infradead.org> Date: Tue, 25 Aug 2020 17:13:35 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200825165214.2b5e1fbf53d68fd3714c8050@linux-foundation.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Rspamd-Queue-Id: AB7D6180AD80F X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/25/20 4:52 PM, Andrew Morton wrote: > On Tue, 25 Aug 2020 08:20:27 -0700 Randy Dunlap = wrote: >=20 >> From: Randy Dunlap >> >> Fix build errors when CONFIG_ACPI is not set/enabled by adding >> in the #else (!CONFIG_ACPI) block. >> >> ../arch/x86/mm/numa.c: In function =E2=80=98numa_setup=E2=80=99: >> ../arch/x86/mm/numa.c:43:3: error: implicit declaration of function =E2= =80=98disable_srat=E2=80=99; did you mean =E2=80=98disable_irq=E2=80=99? = [-Werror=3Dimplicit-function-declaration] >> disable_srat(); >> ^~~~~~~~~~~~ >> ../arch/x86/mm/numa.c:45:3: error: implicit declaration of function =E2= =80=98disable_hmat=E2=80=99; did you mean =E2=80=98disable_dma=E2=80=99? = [-Werror=3Dimplicit-function-declaration] >> disable_hmat(); >> ^~~~~~~~~~~~ >> >> ... >> >> --- mmotm-2020-0824-1606.orig/include/linux/acpi.h >> +++ mmotm-2020-0824-1606/include/linux/acpi.h >> @@ -709,6 +709,8 @@ static inline u64 acpi_arch_get_root_poi >> #define ACPI_HANDLE_FWNODE(fwnode) (NULL) >> #define ACPI_DEVICE_CLASS(_cls, _msk) .cls =3D (0), .cls_msk =3D (0), >> =20 >> +#include >> + >> struct fwnode_handle; >> =20 >> static inline bool acpi_dev_found(const char *hid) >=20 > I don't think there's anything in -next that caused this? It's in > mainline also? >=20 Calls to disable_srat() and disable_hmat() are not in v5.9-rc2. If they are in mainline, they were added after -rc2. See these patches in mmotm: x86-numa-add-nohmat-option.patch x86-numa-cleanup-configuration-dependent-command-line-options.patch --=20 ~Randy