From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A403C77B7C for ; Mon, 23 Jun 2025 18:13:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 571FB6B0093; Mon, 23 Jun 2025 14:13:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 521FD6B009A; Mon, 23 Jun 2025 14:13:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 410EC6B00A5; Mon, 23 Jun 2025 14:13:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2FD9D6B0093 for ; Mon, 23 Jun 2025 14:13:24 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F1E6AC0B7E for ; Mon, 23 Jun 2025 18:13:23 +0000 (UTC) X-FDA: 83587462686.11.602ABD1 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf21.hostedemail.com (Postfix) with ESMTP id EBC5C1C000F for ; Mon, 23 Jun 2025 18:13:21 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZKtbDdHj; spf=pass (imf21.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750702402; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6LrdwSWHeZun5Ikk+tm0V9xNzZKjhyaxpn+cvba2gWU=; b=dp9ZfqmRqXJusFDA9nRi8NmTyHf4El9m6QE2tA06j1Jlf5xW11uzbLKQYJIPVkTucAOjEx ao3a8inxWrijXwMqWoyL8gaxjnRbkoZlwcGV9bi9emebgZ6uAn9Cf3X1bRamw/tHMbJkLi H31BzUYF9GMVxbtpKsXxHqcAXAJVadk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750702402; a=rsa-sha256; cv=none; b=heNCy/HiNousqLOfX7nZiPJFQZl4KIQeUAixdkMLFpLWrp9JaRJM38v2PkkEDb6QMBdW7p xJ4GtzdJCqe434XySKi1SzG6LdL+knk1+hLH7vATOffYOUIwZHCbzuEJPdmRqsz6Z+wCt1 98Ajy3YnjPZIX5aLCHGeugeQpzWys7g= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZKtbDdHj; spf=pass (imf21.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-6077d0b9bbeso7560279a12.3 for ; Mon, 23 Jun 2025 11:13:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750702400; x=1751307200; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6LrdwSWHeZun5Ikk+tm0V9xNzZKjhyaxpn+cvba2gWU=; b=ZKtbDdHjHOA2HZBtB0WcFYZi7PQUGPAAJkyxTWzXpLJMCKkWedQkU9p5mmQ+cOmwBE PBw/bJfLYryrQhqlrt0TL1ecRSEs2lJ9zUFozx6AaRj+uqIZ5AVm/mz2Mx3aNBt5FLs9 AEBnbLjbC7868dQE+DPG5kRZaFmDVyvlzVZxnTKW8iX9EZkfl4rpDEXU1o39e1Drz1Hp QVT06boeuRhGbKeyqbPiFGp2f5GSF6hItwF8LlPnRfDNuRZ2cQiXdcaWPrp9o6BaUXhz DnjJlB3SejapVNFjfwkswIlcoNuirG3PaS9HJfhF3hKbd910uTApryqx/2jdwzKfzDp8 /1lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750702400; x=1751307200; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6LrdwSWHeZun5Ikk+tm0V9xNzZKjhyaxpn+cvba2gWU=; b=dKecD/B9fGPAar1agxVAGq+BbqqVHJpKaP00QMF5Gb/bYcggJM3/Tx1h3C81UiOLE0 IK2yLhbmwHnq0HG/Qf1oWy/7a3dE5LqG6IHOwXLeYFg+vohGjA8lyAbsasm60jjM6ZmB SpJYxRKpXNgkKGKPHnpgtVJB+V+Ahk3xOUcWRDAtdZGzzZrJ4EsEJuJypo5Aua30b2Yk kYLe8Nx5rCXzjjMyjRSNOJfVxplUpe8dNoDn/THuKr972sctGfFO/TyXrfRW1tAsm/CI 9UPiJW9UGNYnO+N+mLCVjeiVKV/KTUotnMuzmg+EFkfZBFk3Kqo3XyX1JTSdBx3n5Yvt N/Uw== X-Forwarded-Encrypted: i=1; AJvYcCWwqO+FfTAKhR4RoEY2SUmH9SR9zhWBkvvGAIZYoSz6+LmLm+xuZWf1faYCUOaVjtLwS5Ukghypmw==@kvack.org X-Gm-Message-State: AOJu0YyVd2TEc6oJNpsTjX+fpMPPYf8qrU1XefCXTygPLV5zzH/usiPP VJuUz74EMdg8MuOgMe5NhnsdGaVNQ+ESwaJkLkRuT2ECxUz7W1Tly+Ox X-Gm-Gg: ASbGncuTz/YFGfO+rTwIFxGX2IgE/EyU/+8UYajwgyHoxpLPI2qftqBrU7v/+qypl0n nDYxM3aIJSssOwFeztjQs8VfFjKxSaehGYf5mKk+SMWi3C5HiSSpeN9PsvzYINz4jEdVHJ6mvTC E1gHJJGEqSBigC+ooKhVme4rqWJgmHNHfhYOQdB6qKLBrnl5VgNgnCQCExGKpmv8oXTftoU9+aH szS9B1leITHrMwPlHdHwhnSOwly10LnisJ6JomiJJj+AQ2/5NoyZu1O69GD9x8Wnc4Vb+N4ANtI 5bv8Y+/FxUa5csX8AD8oRyH/Acrgjy29lqvOJLheM7JHdiiEg7Cw+IQhNmCkRppNLIRfxW4= X-Google-Smtp-Source: AGHT+IGVyIbY5OnBTaikvnY7RLZc7XLvD71jN/UmphK8N4zgi8FEO251lgkOrd45uxn6HMs7wFE0aQ== X-Received: by 2002:a05:6402:1d54:b0:607:1ebe:53a7 with SMTP id 4fb4d7f45d1cf-60a1d18eb77mr11113961a12.23.1750702400003; Mon, 23 Jun 2025 11:13:20 -0700 (PDT) Received: from [192.168.8.100] ([148.252.128.65]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-60a1857e8f9sm6414258a12.32.2025.06.23.11.13.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jun 2025 11:13:19 -0700 (PDT) Message-ID: <69762ce3-ead1-4324-ba33-9839efbe31e7@gmail.com> Date: Mon, 23 Jun 2025 19:14:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v6 9/9] page_pool: access ->pp_magic through struct netmem_desc in page_pool_page_is_pp() To: Mina Almasry Cc: David Hildenbrand , Zi Yan , Byungchul Park , willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com, hannes@cmpxchg.org, jackmanb@google.com References: <20250620041224.46646-1-byungchul@sk.com> <20250620041224.46646-10-byungchul@sk.com> <20250623101622.GB3199@system.software.com> <460ACE40-9E99-42B8-90F0-2B18D2D8C72C@nvidia.com> <41e68e52-5747-4b18-810d-4b20ada01c9a@gmail.com> Content-Language: en-US From: Pavel Begunkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: EBC5C1C000F X-Stat-Signature: inzyh14ji1paeeoc9nxjp86wjambg5dx X-Rspam-User: X-HE-Tag: 1750702401-596703 X-HE-Meta: U2FsdGVkX190Nz05esIrrW/6Eh/2EHhZr56vIJPSheUSAyHFujAF3PuaYCp/Wo2PCg7p9yDnHEMtlxlkCKy+0rqlluMx0kVcthU55tFIBgjbaRz0ZDSaF+uWBg1Hiccw+xF2fc1G+FzEsNtkQ/Z2mRfuSo+VzqSaR2aq00iCfthG3uPTMDB7UIqht9x7H/dCoJqRzI5JNrv8I0KTMiCT22WcRwdATF/fiOO8jxX2cKkYvlfCUiCBT2u7Hyp8EVoIl58+abW9QIIpFqaZIPblIs03F+1O2zaLLtYj5RnofIHb/0T2FVSA2D/FOO+VXZL5rGRSVJ7X7q7Zp6lhrJRiOwvoX+zTq6lwtj6SP0J96j7dMbB0TbwB1R+jPFv5okBFDitN+ZvnLELx7IyeBErq5rYXagyqgAwwlsHir2OdNx7j9fG+aZc6Xgtns+pcm8PnlB1xI2oewKIjO5yo4i/nW0OmRp++6Qgzv+FitMfcOoz4W1Q0HgwouBeVuId7Xn9HQJjulEiTJqiJfIblhYgnpWhG84RTWcrXGj1MBTq0AWloXSA0Zwr520mCjjIVojLSAVdLZmZFQQHn37cBdPJH+p4aO+Taeytrr1FjeeXHO9JEhOB4p5Fb0lW6UTh9uM6gKY9xj//dh3XeUXo/It+F175/0k008aNEHNiORh8mQZvvfWbeW/gZWQAYHGZrfN3WpDTU6XnfF3WeVB4LgCr7YFK+tJd6tGf/NjnEF+6Wv/Mfn+suvWJPFolCIw+6aOi/znaxP7iUj6+jzdVOqe41r8zVIz4ByMYQunJiZMytVnwiM0LYAvi8ZU1EUx02TfFvMn2fAvtZ7lRCALMZdIp5HDc8Nzc3Q0NUq7240Tpjz51wH+OQ4R2pFTUFus6JciSrXZjdT/Igm3+MbzYka9/bGIeDTGaIEttc60T3XgX4fpXErPr274EBWEQh5K5ZvqRvOwXsXLLK+mOIQLXqUsH 5DPaJHwC Z8AG9loAtSR8SPntJhBYUXhWiAV3hDI3XDo99Gfs9fXUHjC1K339/3RqVApIgVZQUsOmwQyWtDM+DVB5kQRQDMyQ9TpqP9BSJPLYk0xmpCfEqkzgu2b7Wru0aa0Y1NGg/1as7/qeynkhDyfNDdYhY5/lYEFO29y4NPLEx4S6JuUq9BUXlbSPZ9yGthHrUro+JWcKconwZkGc7Cdavf/o5KXHblqgUhWH3YdDWxkV1YanOO7ypOpArLuhTd6Yv5u8eP/TRhqam43q+kCC2/Kphgb6kx5kHiTSnCz1ASwEYXwhmNeVSB9OvwEYFjAOmcLn98+PMf3de14KqTAHZxaSykvLcukBUfRJOUsxIl+8gXL/CxVVapxqAtOjDfXOSiiCKM2vpIQhIskwO//G+JVf6yJ4VzkCo/udFzkclIlOdzg9Nv2e4Zn8r4a16KvP+u4IU/38LH13gzcRTmlCo3T+Klt2SlojmxOrwxFHHC1F0T7i7kSPhiF3eICEL2HETavVCYRs4Kg3eQ7jOT6QJZXO3J1CYx2FpW6I/jlUIgC/M0zqHb+4tNhePagP6m6m2DtrYjWXytVfhYRXQqcYZJKe6jcdOn+5DT38toVbf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/23/25 18:28, Mina Almasry wrote: > On Mon, Jun 23, 2025 at 10:05 AM Pavel Begunkov wrote: ...>> As you said, it's just a sanity check, all page pool pages should >> be freed by the networking code. It checks the ownership with >> netmem_is_pp(), which is basically the same as page_pool_page_is_pp() >> but done though some aliasing. >> >> static inline bool netmem_is_pp(netmem_ref netmem) >> { >> return (netmem_get_pp_magic(netmem) & PP_MAGIC_MASK) == PP_SIGNATURE; >> } >> >> I assume there is no point in moving the check to skbuff.c as it >> already does exactly same test, but we can probably just kill it. >> > > Even if we do kill it, maybe lets do that in a separate patch, and > maybe a separate series. I would recommend not complicating this one? FWIW, the discussion somewhat mentioned "long term", but I'm not suggesting actually removing it, it serves the purpose. And in long term the helper will be converted to use page->type / etc. without touching pp fields, that should reduce the degree of ugliness and make it more acceptable for keeping in mm. > Also, AFAIU, this is about removing/moving the checks in > bad_page_reason() and page_expected_state()? I think this check does > fire sometimes. I saw at least 1 report in the last year of a > bad_page_reason() check firing because the page_pool got its > accounting wrong and released a page to the buddy allocator early, so > maybe that new patch that removes that check should explain why this > check is no longer necessary. -- Pavel Begunkov