From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6796EC761A6 for ; Fri, 31 Mar 2023 19:16:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 987196B0074; Fri, 31 Mar 2023 15:16:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E8B76B0078; Fri, 31 Mar 2023 15:16:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7895A6B007B; Fri, 31 Mar 2023 15:16:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 621E76B0074 for ; Fri, 31 Mar 2023 15:16:30 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2D52E120D24 for ; Fri, 31 Mar 2023 19:16:30 +0000 (UTC) X-FDA: 80630149740.20.5A63311 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id 6CD3810001A for ; Fri, 31 Mar 2023 19:16:27 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aNACXKQu; spf=pass (imf14.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680290187; a=rsa-sha256; cv=none; b=PpWqfmD1us2geCIjySAibRMIfgJfiJ7u7rdKyGUeZc9u6AE0HXkFoJezBrAbgAJQgZeCSR 0BEeO0oCDA9boSQPlzmICc2PPNIBjmIMXZRZ118zFoIBJVS69lu2UEsaKZrzBkFOIQ0aXa CKbzJZr1YumTX9WnGlXivNvM3w/WKJ8= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aNACXKQu; spf=pass (imf14.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680290187; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+Aw5PY41r2nBZXxAWm5lLPcmUiax7gAB7xCsvNATWwQ=; b=j8dMP3rEsCZbBFfo8I5vZEQ5nEgFPH2RRVYcuvNSoJqM57eVkjYsJ4qglxsSvEzOKjCGDq 6/9K/hoAyj7xpRBENi6A/GVgN1nzXGN8zR9VmUhBIhH94KkeXcX3DU4S6bsa5OuqjW/qj7 JuBebjdnd71q9akG22MxgygiwaNSLEU= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6D85A62B6F; Fri, 31 Mar 2023 19:16:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C4C3C433D2; Fri, 31 Mar 2023 19:16:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680290185; bh=67/RGvHHjDJru2OHFghr0M4JV0SNZ9LI/thmTUTVZmM=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=aNACXKQuDUI3+ZSSXDzQ9hXLgYS/6W4y1lJmYGI2AJCSAQ8gI9vK5YAaMB8YjWfP/ WxGuNi/5prRbfRHJ0LhidgHqMFjXaxIdnQozGH7K21NYrdLAXP+9qfLPtx+gYg6xmq +zFk4DvuEQp6bd0mcn73ISpURphCWTxSfdCHgjN60tbEmU50HlnqBjc7jgSeOHIg8p HSRGQKxhzfS0gjSoDOEvJndbHRrOa1zeZ1IfRvLFmtk9oxsqCkvs09h0TaijHb57lp 6792bIjh8vmBYuk6G9//dekKpnzDUNzXv64+Yw4y/LEQrIO6OC98qEN7xx92VF6c18 kp5BsgidzrtsA== Message-ID: <6a0e9fd260a9ef373b5a9f64af46974f73201760.camel@kernel.org> Subject: Re: [PATCH v3 02/55] iov_iter: Remove last_offset member From: Jeff Layton To: David Howells , Matthew Wilcox , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Al Viro , Christoph Hellwig , Jens Axboe , Christian Brauner , Chuck Lever III , Linus Torvalds , netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org Date: Fri, 31 Mar 2023 15:16:22 -0400 In-Reply-To: <20230331160914.1608208-3-dhowells@redhat.com> References: <20230331160914.1608208-1-dhowells@redhat.com> <20230331160914.1608208-3-dhowells@redhat.com> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: 6CD3810001A X-Rspamd-Server: rspam01 X-Stat-Signature: nasjwn1ms4kwq9zt5k831e9h6c9p74co X-HE-Tag: 1680290187-196772 X-HE-Meta: U2FsdGVkX1/thzq+ZwiKjomlzZPwq8PvddJlhW2iqkoCZNFJZbYC+R+sXjzQh+GwfAfWNhENniddctofNvdPgrmOWvWo9IC3rYpIjRrQasr9qjTKaIZyIq0nl359jKYJBuya++v2vl9P5mi5Go0Mbb0js4LJHmhEJH4cEBMqYvTa8khxRa7MPzn90weWx6GcSVrtfWxf7v95RAmSQIgZINr5NaVjAInaWB9L260xm0/4AZer9Fxrt4hbWNzEfTFrCVSvKdo4to55cwwpfIktWdgWqgoLAB+ADSiiiYyiVjO7KYwBj63nv2Sgto/26vtBo8JzVRLuIWg1pAu0Ik/kNLRkmCmHpChfDCN+f1Rqi5TIgkSBjSUgwwoB6FVfxFf82MTbLt3SUyuugpCvgRxUNisA32n7SHCGMDi8QZ2chlDLkMjl18VwW/XiTWro0GBTlz/Zq8qJjeHRqF2k31AFbxqmPUhXSSWxQ3hZM8JcptV29bAwbYfHkxMsESaV1H5iGgflpmwGMIAbg+z502k0gP3ZXoMUZpxUBt9VPXtGQj1sbsW372oaDUxXIGnEo0XZmlweaC+bdSUCdvvD81t39z6SChmL5gDKpl6J70bAws4sqWdaPg/c7X0xWjwY5tGlPAAJI1XTlxDLZZ0TvpLN6qY7ISk2qGwcNUmIlBwALxw81i4EtQ7hKv7V3oPYzS4kHSjutgrSEv3RBdb+B/Vk91jIKsXw1R+sUUC/q2ZXDClJsisx/ojzhSf3hhwpoSi7ifhxYXtrnm6lfAHUpOMgLw/RsbaTPBuDPmtoU7KP0TPCxh/X1Du7nUsg50lfNYBDzn63TF61uwPre/xyqE/rDNkQx1F6r76m35JdZBrbKQasEQTFW5Xg46oNwgb124DIBgcdX/lg6xeut5R9c6LsdFwbb+5NITFt3DcXUpuIZWQy3R10tXEdsDfL/vFe6xgYJtkf7ChQayj3wcGKOax dMTGy6Fa G4kMl9ZLclKNvrGs8HlOOeeTICNY2y7M/z4wi48+go3ia9vIydXbnsUNoY8Mx4XPb7hNxq8S/mGbwpce7uOVE1WTtBB/W2fTKzIw3b+iA1Wind3OwVvrAfZjdH/6LaWHbapFN7BO2yz3mrfFqupqjIvGO2C+dEE9F7d2fXo0KqMsAMRVz77nRrIaPmxJaLUHl55ig2mu49oQ9TulJDwEy+SUxhPcIqL2WF/8TciSl/EQit8+SX4Q2br1C8t7WZwWRhpqdOj17IESsnSc9BRt9CK0oaJ56rIAMLbJYDnXvHxUtHLw1qQ5CPkbM29oDPD1oaVgCX1KG0XU9JUqyqSqK97lYjoDTG4nDGMQLWh/KDVTVwQZd9wNd+4UgYUrGxlOnGKaZ+dQohrlExL7eR3AOpHRdipUP+o9qA8bM+gUTKiOxrxQCKkD0GXig/t3A0a8kanATmNBrqRs5fTnbgaUzbtgU6jyLBoqigNTWaldakORRJM9EzLfwddbobB+Tp3qt7rCFM0qw2gt2NMPgyM9TVo8QaiItbwiB9jC+NW/BNaKZBKoHNGC2V1lDuk5gKSWQvRuE0JSk3yO6sMb1Y26e6kSlq5d9oJ6V7OipjlvAdy7aGQ0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 2023-03-31 at 17:08 +0100, David Howells wrote: > With the removal of ITER_PIPE, the last_offset member of struct iov_iter = is > no longer used, so remove it and un-unionise the remaining member. >=20 > Signed-off-by: David Howells > cc: Jens Axboe > cc: Matthew Wilcox > cc: Alexander Viro > cc: Jeff Layton > cc: linux-nfs@vger.kernel.org > cc: linux-fsdevel@vger.kernel.org > cc: linux-mm@kvack.org > cc: netdev@vger.kernel.org > --- > include/linux/uio.h | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) >=20 > diff --git a/include/linux/uio.h b/include/linux/uio.h > index 74598426edb4..2d8a70cb9b26 100644 > --- a/include/linux/uio.h > +++ b/include/linux/uio.h > @@ -43,10 +43,7 @@ struct iov_iter { > bool nofault; > bool data_source; > bool user_backed; > - union { > - size_t iov_offset; > - int last_offset; > - }; > + size_t iov_offset; > size_t count; > union { > const struct iovec *iov; Reviewed-by: Jeff Layton