Re: [PATCH 4/4] selftests/mm: fix exit code in pagemap_ioctl

David Hildenbrand (Red Hat)
2025-12-18T08:07:24Z

On 12/16/25 15:26, Kevin Brodsky wrote:
> pagemap_ioctl always reports success, whether the tests succeeded or
> not. Call ksft_finished() to report the right status.
>
> While at it also fix the exit code in unexpected situations:
>
> - Report SKIP if userfaultfd isn't available (in line with other
> tests)
>
> - Report FAIL if we failed to open /proc/self/pagemap (returning
> -EINVAL from main() is meaningless)
>
> Cc: Usama Anjum <Usama.Anjum@arm.com>
> Signed-off-by: Kevin Brodsky <kevin.brodsky@arm.com>
> ---

Fine for me to fix return handling for the overall test in a single patch

Acked-by: David Hildenbrand (Red Hat) <david@kernel.org>

--
Cheers

David