Re: [PATCH 2/4] selftests/mm: pass down full CC and CFLAGS to check_config.sh

David Hildenbrand (Red Hat)
2025-12-18T08:04:14Z

On 12/16/25 15:26, Kevin Brodsky wrote:
> check_config.sh checks that liburing is available by running the
> compiler provided as its first argument. This makes two assumptions:
>
> 1. CC consists of only one word
> 2. No extra flag is required
>
> Unfortunately, there are many situations where these assumptions
> don't hold. For instance:
>
> - When using Clang, CC consists of multiple words
> - When cross-compiling, extra flags may be required to allow the
> compiler to find headers
>
> Remove these assumptions by passing down CC and CFLAGS as-is from
> the Makefile, so that the same command line is used as when actually
> building the tests.
>
> Cc: Jason Gunthorpe <jgg@nvidia.com>
> Cc: John Hubbard <jhubbard@nvidia.com>
> Signed-off-by: Kevin Brodsky <kevin.brodsky@arm.com>
> ---

Looks reasonable to me and I hope we find no surpirses :)

Acked-by: David Hildenbrand (Red Hat) <david@kernel.org>

--
Cheers

David