From: Tadeusz Struk <tadeusz.struk@linaro.org>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: Tejun Heo <tj@kernel.org>, Hillf Danton <hdanton@sina.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
syzbot+e42ae441c3b10acf9e9d@syzkaller.appspotmail.com
Subject: Re: [PATCH] cgroup: don't queue css_release_work if one already pending
Date: Mon, 23 May 2022 12:00:06 -0700 [thread overview]
Message-ID: <6ac66e89-2063-c5e8-df15-f77b76befc05@linaro.org> (raw)
In-Reply-To: <20220520164255.GB17335@blackbody.suse.cz>
On 5/20/22 09:42, Michal Koutný wrote:
> On Fri, May 20, 2022 at 09:38:12AM -0700, Tadeusz Struk <tadeusz.struk@linaro.org> wrote:
>> as this is a result of enqueuing the same css->destroy_work onto the same WQ,
>> one on the rcu path and one on the css_release path.
>> I will prototype it today and test with syzbot.
>
> In my understanding, you'd need two independent work_structs in a css,
> not two separate workqueues to put the single entry on.
Yes, separating the css_killed_ref and css_release paths with two separate work_structs
fixes the two syzbot list corruption issues [1]&[2].
I tested it on mainline v5.18.0 and v5.10.117
In case of [2] the mainline triggers an issue, but it is unrelated to list corruption.
[1] https://syzkaller.appspot.com/bug?id=e26e54d6eac9d9fb50b221ec3e4627b327465dbd
[2] https://syzkaller.appspot.com/bug?id=3c7ff113ccb695e839b859da3fc481c36eb1cfd5
I will send a patch soon.
--
Thanks,
Tadeusz
next prev parent reply other threads:[~2022-05-23 19:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220412192459.227740-1-tadeusz.struk@linaro.org>
[not found] ` <20220414164409.GA5404@blackbody.suse.cz>
[not found] ` <YmHwOAdGY2Lwl+M3@slm.duckdns.org>
[not found] ` <20220422100400.GA29552@blackbody.suse.cz>
[not found] ` <317701e1-20a7-206f-92cd-cd36d436eee2@linaro.org>
2022-05-19 11:23 ` [PATCH] cgroup: don't queue css_release_work if one already pending Hillf Danton
2022-05-19 23:26 ` Tadeusz Struk
2022-05-20 8:13 ` Tejun Heo
2022-05-20 16:38 ` Tadeusz Struk
2022-05-20 16:42 ` Michal Koutný
2022-05-20 16:56 ` Tadeusz Struk
2022-05-23 19:00 ` Tadeusz Struk [this message]
2022-05-23 19:02 ` Tejun Heo
2022-05-23 19:08 ` Tadeusz Struk
2022-05-23 20:05 ` Tadeusz Struk
2022-05-20 23:48 ` Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ac66e89-2063-c5e8-df15-f77b76befc05@linaro.org \
--to=tadeusz.struk@linaro.org \
--cc=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mkoutny@suse.com \
--cc=syzbot+e42ae441c3b10acf9e9d@syzkaller.appspotmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).