From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBAB4EB64DC for ; Tue, 11 Jul 2023 10:21:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 587046B0074; Tue, 11 Jul 2023 06:21:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 537E26B0078; Tue, 11 Jul 2023 06:21:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 400D96B007B; Tue, 11 Jul 2023 06:21:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2DE116B0074 for ; Tue, 11 Jul 2023 06:21:30 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E65171201BB for ; Tue, 11 Jul 2023 10:21:29 +0000 (UTC) X-FDA: 80998939098.07.328EA07 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id AD6ED40015 for ; Tue, 11 Jul 2023 10:21:26 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="ET+Q/Wyf"; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689070886; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3CdkdlOsc3iW5ATS8hrwj2Vbpb61+JmYd2YSFneWYxY=; b=YRZCjQsSfFakMDPKJeAZKxTGfzfMwPHXiUgol3pb1DvmaQ6nAib/qanDtF6g9ApXrgJYEd U9FXeXh/ouxNR9GEqTnGLIib5QVLAX7Ln5g5kfa7xZ3nquoogBFmaHv/woatSsksyPxbsG UmortjBrO1Mm4q7jpHV2E0N8Fkkv27U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689070886; a=rsa-sha256; cv=none; b=X1G06C3e7aeJNV0uRQeUzN7XUtkiQB2YcgnYfrjQsVGfSIpF6v+rj3HdNlPhfiV3E91NRb vbU85PA7fuEYnLMmQKkBm3/vAjlPWoDgXnUYJOU9TGql/4BGm4pjWFnegbDnhUN54VKpp7 /ceYC0hJaN0pNRkZI8niTzFwH9TGBZ8= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="ET+Q/Wyf"; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689070886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3CdkdlOsc3iW5ATS8hrwj2Vbpb61+JmYd2YSFneWYxY=; b=ET+Q/WyfvG0mTh+ptaZOt8nfuo5vLKzKbrMzIj9dx5Qbipcf0yoaAdNvw3BmXn2iNKAY9W ETNPG+uWns3ET9ZUUhNZM746LanLEVa9QRhmsTImos8JWYytM3xfkKfuGq75p+qMZUl1Al fL8Iztu6psB/7W858XKYN+r8uv4KBro= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-493-BcK9bgEUO3Kq765-pkoxDQ-1; Tue, 11 Jul 2023 06:21:24 -0400 X-MC-Unique: BcK9bgEUO3Kq765-pkoxDQ-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3fbfc766a78so27641005e9.3 for ; Tue, 11 Jul 2023 03:21:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689070883; x=1691662883; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3CdkdlOsc3iW5ATS8hrwj2Vbpb61+JmYd2YSFneWYxY=; b=CRJWjk5ZTwCaEJb2t7JEllYfnkZoRVx9st+kAE7slLNlgYh5NfPS5it6zdIRIKCWgC 0UFB0VcHinDGInnXwLU0K63debfu0+dxqJYoP7QgLtFNRGh0VR5zGmUaSn3s9cjbE66X UqOtzzzyvzUFrD0BT8oVblPVFz9004P3utbg2pJUs7onLZ1ex6KH0yqfpXiEDxa/bag0 sWlMvHL7sjbwF7MtpOuztkqd/DAjsQZCz5eukC1T4rJrtEgeVSK6fJhEpS6t6UDeYArf iASoJljjkyO2rq2Yh1u5uDj7FFr1P2x3le43aaTmO1Fcx3L7W1Q3HfMmRusvIbgdQahB bbvA== X-Gm-Message-State: ABy/qLa3sXk01vg5FLVObEmSuDF1Zl+s4jT61XIDdZhWgYRwtaRZ7kUm W8vNrNsiT2cRkpd6MsMpPLdtLwV8aVGXoBKIKbZ3TEEMTjGGFRT632NnbWAkulVSUxUIQk9qLC9 hD720WeQsNvA= X-Received: by 2002:a1c:e915:0:b0:3fb:b5dc:dab1 with SMTP id q21-20020a1ce915000000b003fbb5dcdab1mr12747494wmc.39.1689070883572; Tue, 11 Jul 2023 03:21:23 -0700 (PDT) X-Google-Smtp-Source: APBJJlE2M31E1VCPbSw8pkfSZYPDyGHo4xFLwBFEG1lvc++RC35ptTSDjosBu7e0oQqdNT2XNXwtiQ== X-Received: by 2002:a1c:e915:0:b0:3fb:b5dc:dab1 with SMTP id q21-20020a1ce915000000b003fbb5dcdab1mr12747470wmc.39.1689070883279; Tue, 11 Jul 2023 03:21:23 -0700 (PDT) Received: from ?IPV6:2003:cb:c745:4000:13ad:ed64:37e6:115d? (p200300cbc745400013aded6437e6115d.dip0.t-ipconnect.de. [2003:cb:c745:4000:13ad:ed64:37e6:115d]) by smtp.gmail.com with ESMTPSA id l3-20020a1ced03000000b003fc0062f0f8sm2151136wmh.9.2023.07.11.03.21.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jul 2023 03:21:22 -0700 (PDT) Message-ID: <6b59462f-1cce-9a76-1dbc-7a4092634fa1@redhat.com> Date: Tue, 11 Jul 2023 12:21:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 6/7] dax/kmem: Always enroll hotplugged memory for memmap_on_memory To: "Aneesh Kumar K.V" , linux-mm@kvack.org, akpm@linux-foundation.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, npiggin@gmail.com, christophe.leroy@csgroup.eu Cc: Oscar Salvador , Michal Hocko , Vishal Verma , "Rafael J. Wysocki" , Len Brown , Dan Williams , Dave Jiang , Dave Hansen , Huang Ying References: <20230711044834.72809-1-aneesh.kumar@linux.ibm.com> <20230711044834.72809-7-aneesh.kumar@linux.ibm.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230711044834.72809-7-aneesh.kumar@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: x7warn8rk3pds96c3n51ed65girbpus7 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: AD6ED40015 X-Rspam-User: X-HE-Tag: 1689070886-469302 X-HE-Meta: U2FsdGVkX1//Uuda93tF5ZhikRmUhnnRfDPebfcCy5CNxNa4KcQEUSu4daai8ci7UtwigHu+5NzTHLo0vUw5whtvoh5E9Bjqdt/3WQjYRCVcRKZHOl/SltpAt9lDOHSKCs7MqVS4F/o7xYPWLPYUCWZKNJOtAxV8fF/Z1f2hLgdudp917RN1T+nEyQk2NppX82AhQupQKOQAlK0gnO7Kmvin7IzrxJda3ck0tn7tWi2kQCQsZ1mO8Rq+14f2kGgaLjtdih1FfULPzDON0+d3/Q5XXqWBqOPtZyfWYQzZxusqEZBoJk1DMX8UVNBZTf6k6BnuQ+eixIgb2aaLoRKn/O5V2awBE2Gi61FIRvu0qkgoZDJ05rX5rVWjZccV/ITTlwzTZmyIEw3CQbFmrcPyNL799Fj5qaSQHYeeS+A7TEar1U3jN3Ywi79irX5wCzdML10quz1Ix0wn7yeVgqIS1QN59kqWXE6yv31NspwM+vD+MAt7Sw9ZWpY2Ik7YfCO7dNmAvn1qxQpojDGT0gbvySpY1gvjthF/caUvrPplcbILu5Y8It8RY9Yv+7x20/tO6zTHiw2aLr1PorzY3mAUOuHCrIeAeO/h8X1j40jZz807hynEssAcK2MHSH2jzHp9gnjIDud5ICCttrjbK/ok0kfLAC/zrz+cw1moeZrlblYemZypgmyfiC2tjNIhkh0BsopoYZmteoCEjncsgYrdXQPeVRcFZQdxY29iSZhDpuauA5y4c0nQcSRl4niTRHJIttGb/7uSz3+NXawrgVN8GpcehiBTwCdT7f+3VPlJQiYPaMU/yEVztvSehVKpEqP8ibl6snO3HArGFY0W3pkIbtC13C5suK+SGt4CMQNHpM5YZ+NJYWupNKNjcY9M1gYeS0CgRM2GhPE/EfWKgUd1PaPFl4zPiyArTVn7ZEl1Ck12uDOjvynpSfodAJv+QZmpnvJlVRJCHcfOX10HA62 VfVOOXw5 2LN9NgFUoW2kHX0xzMzLunbwVvjlLaKha5wAvFkcjb/5otuqMlX/kgOJsQJ3PscsFUMPV+ZlJr7eDLtCV6JuOA482WVqS1YO2J7Q7xB2AGYoqBgKl8WZXCvK2V43lnuVprGUhAp22AgoNDMhEMtGznSp4V4RQbntqyU6xB4mzCHkoJL5/PgBjY2rcsxyizAjnHZcx860C4TSNILoadZ29TSGT9l8/8+EpqnAG166s/ZRV2diss5rpHJKLVPex/bIWwUnkVtTW6zO0I5SwKyf62ENB1Ti1sEZyzAei+vwAV3agDglrApW0EUoqoRhNwXH1qylWkGd6Yu/xClY4JITBQWD+sv/j9Mlm1Dgsw5pkscftaV4Dre/RLuGRg0lwRrTTL1Tq8ZQFpzTLUQH7Pi3JqM5dBQhmlKy9QKqPVe/i+4zgw4oiEfdu27ik5j/seqaCQgwIf/w+8KFubJRqFLLbHEKwm5gj0xGqluf8tOxxO7WYtIoMZVrje1BUwZNIgRmP72xwe6o295UzCMM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11.07.23 06:48, Aneesh Kumar K.V wrote: > From: Vishal Verma > > With DAX memory regions originating from CXL memory expanders or > NVDIMMs, the kmem driver may be hot-adding huge amounts of system memory > on a system without enough 'regular' main memory to support the memmap > for it. To avoid this, ensure that all kmem managed hotplugged memory is > added with the MHP_MEMMAP_ON_MEMORY flag to place the memmap on the > new memory region being hot added. > > To do this, call add_memory() in chunks of memory_block_size_bytes() as > that is a requirement for memmap_on_memory. > > Cc: "Rafael J. Wysocki" > Cc: Len Brown > Cc: Andrew Morton > Cc: David Hildenbrand > Cc: Oscar Salvador > Cc: Dan Williams > Cc: Dave Jiang > Cc: Dave Hansen > Cc: Huang Ying > Signed-off-by: Vishal Verma > Signed-off-by: Aneesh Kumar K.V > --- See my feedback as reply to the original patch. -- Cheers, David / dhildenb