Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>, Hao Ge <hao.ge@linux.dev>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@suse.com>,
	Brendan Jackman <brendan.jackman@linux.dev>,
	Zi Yan <ziy@nvidia.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Usama Arif <usamaarif642@gmail.com>,
	Shakeel Butt <shakeel.butt@linux.dev>,
	Harry Yoo <harry@kernel.org>, Hao Li <hao.li@linux.dev>,
	Christoph Lameter <cl@gentwo.org>,
	David Rientjes <rientjes@google.com>,
	Roman Gushchin <roman.gushchin@linux.dev>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH 3/3] mempool: account the element array to the caller
Date: Fri, 20 Nov 2026 11:36:26 +0100	[thread overview]
Message-ID: <6b646955-4ab9-418d-b3ca-deda9506fedf@kernel.org> (raw)
In-Reply-To: <0d55ddb1-0cc7-4d87-9d29-9165d35102a7@kernel.org>

On 11/20/26 11:33, Vlastimil Babka (SUSE) wrote:
> On 11/19/26 09:52, David Hildenbrand (Arm) wrote:
>> mempool_create_node() accounts the struct mempool and all elements to
>> the caller, but the array of element pointers allocated by
>> mempool_init_node() and mempool_resize() ends up being accounted to
>> mm/mempool.c in /proc/allocinfo.
>>
>> Let's consistently account all mempool allocations to the caller, like
>> ptr_ring_init() and ptr_ring_resize() do, by using the _noprof variants.
>>
>> mempool_init_node() is only called from mempool_init_noprof() and
>> mempool_create_node_noprof(), which already set the allocation tag.
>>
>> While at it, make mempool_init_node() static and rename it to
>> mempool_init_node_noprof(): it is not used outside of mm/mempool.c, and
>> calling it without an allocation tag would be wrong.
>>
>> Signed-off-by: David Hildenbrand (Arm) <david@kernel.org>
> 
> LGTM, but if this is due to an AI report, they should teach it better about
> what's urgent, to the point of not reporting such things at all :)

That's just a cleanup from me while reworking #2, where AI tried to do some of
this here inconsistently in patch #2.

Feel free to drop this one here.

-- 
Cheers,

David


  reply	other threads:[~2026-11-20 10:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  8:52 [PATCH 0/3] alloc_tag: two fixes and one cleanup David Hildenbrand (Arm)
2026-11-19  8:52 ` [PATCH 1/3] alloc_tag: handle a NULL tag in alloc_tag_set_inaccurate() David Hildenbrand (Arm)
2026-11-19  8:52 ` [PATCH 2/3] mempool: fix missing alloc tagging in mempool_resize() David Hildenbrand (Arm)
2026-11-19  8:52 ` [PATCH 3/3] mempool: account the element array to the caller David Hildenbrand (Arm)
2026-11-20 10:33   ` Vlastimil Babka (SUSE)
2026-11-20 10:36     ` David Hildenbrand (Arm) [this message]
2026-11-20 10:02 ` [PATCH 0/3] alloc_tag: two fixes and one cleanup Vlastimil Babka (SUSE)
2026-11-20 10:08   ` David Hildenbrand (Arm)
2026-11-20 10:40     ` Vlastimil Babka (SUSE)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6b646955-4ab9-418d-b3ca-deda9506fedf@kernel.org \
    --to=david@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=brendan.jackman@linux.dev \
    --cc=cl@gentwo.org \
    --cc=hannes@cmpxchg.org \
    --cc=hao.ge@linux.dev \
    --cc=hao.li@linux.dev \
    --cc=harry@kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=shakeel.butt@linux.dev \
    --cc=surenb@google.com \
    --cc=usamaarif642@gmail.com \
    --cc=vbabka@kernel.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox