From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAFF5C52D7C for ; Wed, 21 Aug 2024 21:39:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 85D076B0104; Wed, 21 Aug 2024 17:39:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E5656B010B; Wed, 21 Aug 2024 17:39:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65F7B94000B; Wed, 21 Aug 2024 17:39:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 460296B0104 for ; Wed, 21 Aug 2024 17:39:46 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EF9881A029B for ; Wed, 21 Aug 2024 21:39:45 +0000 (UTC) X-FDA: 82477569930.15.78AE56B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id B0333A000B for ; Wed, 21 Aug 2024 21:39:43 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f8iyA6TN; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724276303; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VUO213Ze5zszhXHHYWUdqCWuIzvUfpaBvszkr8PmtFU=; b=OAqC1zqYl4Z6vEfDjvzljlfqMgc0xNJ+brIn47sDiUYP886yWroDixW1Sli1cUr93v26NB WvJov2OuOlPCEkMckIpFhzM6G2Gy8Z8Xr5qO5L0zOz7egHCILm+bda33pzsQz+9LbwUqte y4g/fVRAHrbxaWR3RXOh+cnREyg4JzY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724276303; a=rsa-sha256; cv=none; b=Z59SvWpPPBWBqqXa8Lu4TvUpcDPpfDg/8VmsV3xtfUeXmjjLmXeJTGmEFyRQ7ktW91gwFJ sxfazSyGIa6d5TkcSSMRexNgKIdT8JbFg/khhqjLKbQL0K2WSF0Q8EbhIBVOxRtMoBbC1i Mj8SibAIKewrI8JQoz5hOZ8XFOHWYEw= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f8iyA6TN; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724276383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VUO213Ze5zszhXHHYWUdqCWuIzvUfpaBvszkr8PmtFU=; b=f8iyA6TNYDHYmvoTm6qilxJ2b7i2sdRZP2q3+1/QN0xcuhALssmXqsJ2rh1LBJjiMiLypN ybDiY1lyGmztz1H0bmjVWgAVwLdq3FqZKrEBEm1sgI5bGmlh61xpYQp1jzFXQSX9tdpqPm DMNaEHjorgL4Za0OofG1l2VpL2tkK2o= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-695-0Hr9iuykNSOR0amB-2MgRw-1; Wed, 21 Aug 2024 17:39:38 -0400 X-MC-Unique: 0Hr9iuykNSOR0amB-2MgRw-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-428076fef5dso472475e9.2 for ; Wed, 21 Aug 2024 14:39:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724276377; x=1724881177; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=VUO213Ze5zszhXHHYWUdqCWuIzvUfpaBvszkr8PmtFU=; b=JkfsgW4Ks1H8OeAK7kk9Z3RiTUkoz8GHbeIiv582BYnM3R8anulclx9LjsDUh1ucRr SUFN56+nzp0a1De31RU4V1wElvSg294AYkZUgjHoSbRULnCm94vRcek11IWa3d6kXgGH QpiGot+3thEmLRavS87dXQQLpf9CAHUKETR06XPrN4+DfoSfXY8KV3xUt1q89/c7eJeW gbh0UjfHS9CFIoFm35GiU/tPu1fUoNmJuBGT5LJpapbv66NDh2CkOF6OJ5CpZSIZxdg5 qhJYGhZBBF1Ds3w21Ib0qjZTgpZBqHCgOTxwwwLx8DN2uKk2/XVuxO3SXhpzO0zxl7qr q24A== X-Forwarded-Encrypted: i=1; AJvYcCWfMwgi1ABbLQpX9yKiljzYymZ5lHrjf6/Bm+jEIxsPqg2AUPtOrorVtldWZmPsVbErk5FC5/isuw==@kvack.org X-Gm-Message-State: AOJu0Ywqxkbg9Vs/MYV+H0mblPPKObsmD0wg9cHGX2pRo0DxBDjDHrwp nXWKG9oA8c8gghC/DlMSvtBUnoM9o04+x4LpENATSspa22a+ckWPL0lroykZX7iznRHW3aI558c Bb9jYU8IzPw+utJuQr4tJ0j04SZZHGXy7BUuB5rmVKAw3KeeT X-Received: by 2002:adf:fdcf:0:b0:36b:c66a:b9fd with SMTP id ffacd0b85a97d-372fd576d35mr2270444f8f.6.1724276377501; Wed, 21 Aug 2024 14:39:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHm0c6X/sX7cfnudili3E3oMoccOZ+YYBaOn+Go6JfP9o466U/5drSHtDyL85+aorgkfGNEgw== X-Received: by 2002:adf:fdcf:0:b0:36b:c66a:b9fd with SMTP id ffacd0b85a97d-372fd576d35mr2270425f8f.6.1724276376667; Wed, 21 Aug 2024 14:39:36 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:4300:16d5:c5b:8388:a734? (p200300cbc705430016d50c5b8388a734.dip0.t-ipconnect.de. [2003:cb:c705:4300:16d5:c5b:8388:a734]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3730813ce6fsm34539f8f.30.2024.08.21.14.39.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Aug 2024 14:39:36 -0700 (PDT) Message-ID: <6c01b794-7c51-4d90-a215-210ac21401d2@redhat.com> Date: Wed, 21 Aug 2024 23:39:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] mm: collect the number of anon large folios on split_deferred list To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: baolin.wang@linux.alibaba.com, chrisl@kernel.org, hanchuanhua@oppo.com, ioworker0@gmail.com, kaleshsingh@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, ryan.roberts@arm.com, v-songbaohua@oppo.com, ziy@nvidia.com, yuanshuai@oppo.com, Usama Arif References: <20240811224940.39876-1-21cnbao@gmail.com> <20240811224940.39876-3-21cnbao@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240811224940.39876-3-21cnbao@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 4fzqsoga1kcr9w9q1y9td8brqpobn73c X-Rspamd-Queue-Id: B0333A000B X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1724276383-428828 X-HE-Meta: U2FsdGVkX1/9kbmpsHzMcuXMB90SX5iL16arb9r9AWQIPhCrhHNL/sxIkXic0m+5OA3aOT1juBr7D4KvWfScfigg8D912yLuF2M0QjLy8kOWi1d1c5D5MRUC9TWb4+Zo1Pi/8KiES34t6ZYWuBEprisykoGHGzb9Lh84kEYe4h14E6pMRldPWE3rJ0KRvm+a7sAcVHRH2Um4ml+BJ/bsjuPhwYqWrUB96GYiRfcakn/n7RhlRzh8dY4tXOeCdGvDY2FODe2GL2PVYNJnVS/H1rsGQ01RgzQ2pWzzuVPRP9GVKNPoNWjK2lSbUb6QAv38JEHrnsUxe7X9T0zyECyUxzQ/ghL9c9g/2su+YHGDKhcRBqg/EW6fPpnwzzdhmzXhq3XsPRgVpRmlQ2vzocG+4khJPz4L+IFtACR3446HUNrlRBxu2rDz928WdCK8TssVwA+SE7/Sf8M9/OkMpLFYSTqTU0V5PrmTdE9G6TWbtwSXkXxUrqn64x4MOSvsFkyz0DbTfmkMK/SBOgQ6LhwdNQaI4+6qkrbM0FLYoGA2dAn6VCKxj4ADnVFd8IEGt6VngO7t1p7nn0ba1U/S66Xr8uAkWReFhfn58JUpYa+rIg8AW9qjF2zkTvouXI690NbefAmgHkOxyCIZ1zq7BIqT9/Tvd0vcakVV8welBtWoR/ntZFiAumE4gdobtMG4+2KmwJNdycwtl4BoA+j0dQII6FvjcOOjexOyZnjAaMW+XMddXYWSmTxfu4b+GFVSZqdkRBYLPv4O0rvROYVw4R5dwSz8ETii9VS9gTmHFlDIXlfULYGpsmP4k/GZbBhQkx4t4Qf2utAvE1bewBPB+ApRUxqihJyWzAT1Fp0gZfxGvV4OxHlUf7LJdhfDO9iXzy80qFC3xhqA5Lp5l6iZVfsHUO7XP/yOC2JZiX6m4IRyTSTw/iAZNeQ9nQQf2FMKkdYka1xarhKF/kgu81SC/5P aCxPt5hS xyfxMN8Zg3KeT2QpzvjhOsKWf6TxwfyhQWSotC2R8z1HezaiAvgHpEvf+Jvfy3vJ2Ps9HjMLh/zZ/QVzuRaX628n5nQGR1jxa7O6DJCFaumf2SAyXGPrBWCDGVRA0WxYMWfp2TWSymoRz3ULeCmFPuxS6GOnqeKooEQE9u3VrMROSTvail6Rj4Xmv0aVNxmaKnCSwC1oeGolxna9UJ2UCXoG7sqrVIxw0lIDA7NxdPTOb+pzKSskD7mLdv37c6cweeC1TvnUxvkoZkSOedck+tH+558qUZGzPI53zsDhMwVlybkh46jVP/MCFtdsO/dSGGzS4NtbbU1S6yPp1GAAD7AlrZHs9DJfEfK8tCDos7sk7uvO/+ukxaF4OfJFAl/Q7aLM06zZSqqTIAvszqQPObndZ18oiZV4rqFIDyqGWpJNq0AYmKVAKEsGpaLC8ELPOO3fxGnTMQgTJCfpGrMpHjNRVI/AP0k+rbPP6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.08.24 00:49, Barry Song wrote: > From: Barry Song > > When an mTHP is added to the deferred_list, its partial pages > are unused, leading to wasted memory and potentially increasing > memory reclamation pressure. > > Detailing the specifics of how unmapping occurs is quite difficult > and not that useful, so we adopt a simple approach: each time an > mTHP enters the deferred_list, we increment the count by 1; whenever > it leaves for any reason, we decrement the count by 1. > > Signed-off-by: Barry Song > --- > Documentation/admin-guide/mm/transhuge.rst | 5 +++++ > include/linux/huge_mm.h | 1 + > mm/huge_memory.c | 6 ++++++ > 3 files changed, 12 insertions(+) > > diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentation/admin-guide/mm/transhuge.rst > index 9fdfb46e4560..7072469de8a8 100644 > --- a/Documentation/admin-guide/mm/transhuge.rst > +++ b/Documentation/admin-guide/mm/transhuge.rst > @@ -532,6 +532,11 @@ nr_anon > These huge pages could be entirely mapped or have partially > unmapped/unused subpages. > > +nr_split_deferred > + the number of anon huge pages which have been partially unmapped > + and put onto split queue. Those unmapped subpages are also unused > + and temporarily wasting memory. The name suggests something else ... like a counter of how many have been deferred split :) Would "nr_anon_partially_mapped" "nr_anon_split_pending" (or something less mouthful) be clearer? (likely "anon" really should be part of the name in any case) The name we chose (and the implied semantics) will likely have implications on the handling of Usamas series. -- Cheers, David / dhildenb