From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CBA3D3F28A for ; Fri, 18 Oct 2024 20:29:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3B2E6B00B5; Fri, 18 Oct 2024 16:28:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E9F86B00B6; Fri, 18 Oct 2024 16:28:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 88B396B00B7; Fri, 18 Oct 2024 16:28:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 672A16B00B5 for ; Fri, 18 Oct 2024 16:28:59 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 60FE5A00F1 for ; Fri, 18 Oct 2024 20:28:36 +0000 (UTC) X-FDA: 82687861872.14.20A6879 Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) by imf07.hostedemail.com (Postfix) with ESMTP id 31EA740017 for ; Fri, 18 Oct 2024 20:28:41 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=ETIFRhXr; spf=pass (imf07.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.46 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729283262; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HEIxT3pzjyKiKOABBKcn+MsmKD+aZXCEjCwEplxkrC4=; b=EK3bbI6d51xWAqHXwn/wKxetZAsZMZ0/J2xpHjo5AnzyCLypeqCm/+ZCjRTF2EAbO4Nw4N qYN3GN6l507SQSRHd05MyVkO5SQJbH08M5AVaeWLdtbdd6Qc+CTsMVaw1+kEGbvHqevmhj iIWrOUrF2WCgSyhtzYy1n2tZ5Iq0Vuk= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=ETIFRhXr; spf=pass (imf07.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.46 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729283262; a=rsa-sha256; cv=none; b=DSfCFWi52d9gOuddc0Szv7nLH3K2qkv3ud27STj+A7co8b8uRDkahAPNmNNTplslrSgTo2 jQOt6S10JhHtYrLxE/lqd5v7Y0SnLLkQz5YzmyBJJzygl9CZ5l6SLYjFvC3pzLhxr9qtC+ 4Q26gbNsxSQMoI+M2KuVgZy1j7mp/3I= Received: by mail-io1-f46.google.com with SMTP id ca18e2360f4ac-83ab21c269eso92111739f.2 for ; Fri, 18 Oct 2024 13:28:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1729283336; x=1729888136; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HEIxT3pzjyKiKOABBKcn+MsmKD+aZXCEjCwEplxkrC4=; b=ETIFRhXrRPdGSVBtqCy5+7NpQEel6azdVF0Oz848PZ4Bosq55ue4yN8/xeGGACea8D /zZ4BqZy0InYQRNBnn87f9Z6QQb3+wVn5VP+7hkPlQostM2mUqhHU9oSuF7YljmgLiPC jtLQgeJ776hRXsvO9z0YEvH5EQftQBfa3Ls9w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729283336; x=1729888136; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HEIxT3pzjyKiKOABBKcn+MsmKD+aZXCEjCwEplxkrC4=; b=A+u/CKiwOJwF8JW0wSkdDxMbZfrnoXDhQpio8C0mLR0voGZn+oX/kSY2zU/B1tY5re gr7g9JrOre95iJJRnGlJt9HwFuXjtOpWtTEMXLZSgcE7sk5Yr8eOghPyZbZlfoWHORiw tTerSmO2jqbEXHohHeVmKPbe7FD+U3WJyIwt6vZnzBn3l8/fjZdClUnS11qynFn20nD/ MJRfiXO9kTOZ28Z8sgTUL8WNGQReChVL+auzAlxRwTkhzpKshaFa/nvCEfvnPbzTTPw/ dfFmBC9EUvFC+x3bkNoan0v+o9bA6aKwbnW384DQx7OEfabi5Z5ansVYvcKixPzBOusx jlLg== X-Forwarded-Encrypted: i=1; AJvYcCXcsN9U5nkGHWX35R/9udA1zLKTBclp21KPQ0PPm79HKWsOT0rCpUupikwekTaZhEptMlW+r92VCQ==@kvack.org X-Gm-Message-State: AOJu0Yx6vWb4W29FeDWFiVTZV3xQSRRP2TfppNOchmVwYU5ui/w1ZyEB 5uaiEFKAimUchVowPsjFZJrPIFsk+nBYivZaUJC2ni3Z8SwKhJBoVZEFMo9DEn4= X-Google-Smtp-Source: AGHT+IEmNTlbTxL/CzSKbj6Z1Ayoclfp2LZg5Ml5s5uZ6FaqD2hmPUC5+ArYCuRJH83neks98+42+g== X-Received: by 2002:a05:6602:3fcb:b0:83a:b3f8:e517 with SMTP id ca18e2360f4ac-83aba2f3b7bmr370716439f.0.1729283335889; Fri, 18 Oct 2024 13:28:55 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-83ab9d80c17sm57750739f.6.2024.10.18.13.28.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Oct 2024 13:28:55 -0700 (PDT) Message-ID: <6c9796ff-ccf8-404b-917f-57b48b42f6d6@linuxfoundation.org> Date: Fri, 18 Oct 2024 14:28:54 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/5] selftests/mseal: add more tests for mmap To: Lorenzo Stoakes , Jeff Xu Cc: Mark Brown , Muhammad Usama Anjum , akpm@linux-foundation.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, pedro.falcato@gmail.com, willy@infradead.org, vbabka@suse.cz, Liam.Howlett@oracle.com, rientjes@google.com, keescook@chromium.org, Shuah Khan References: <1f8eff74-005b-4fa9-9446-47f4cdbf3e8d@sirena.org.uk> <736fefd9-4bce-4aec-a492-2267fdc83776@lucifer.local> Content-Language: en-US From: Shuah Khan In-Reply-To: <736fefd9-4bce-4aec-a492-2267fdc83776@lucifer.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 31EA740017 X-Stat-Signature: gc7r5kmd1fws9yakxg641tf3k4wryqry X-HE-Tag: 1729283321-526558 X-HE-Meta: U2FsdGVkX1+tRm11UAMhehk/QS7d8U+Qc0x6AcH6/dDAl3YuuAt+OrVNxdA1ywvbouDGxuU2Ly2H7LzrMIUPliJRMmzHO8PmytDBudl0O2g2aYoAyrLx3AX6/J/X0heEFqzaHkgzNTDdXiD4OHpRzSGH3YWgpDMdN6L8Mi531Q+8dUh+gVWAlK3D1SiOIKOan7uBDFYGqu4zD26cOAkHlkxjgLuILcglivoom+JfrMNC7huv71jLE7rcQlv0NajBONf9V/K4PknzqlQkiG1VpSQkfTFTvcSkYgDnbMDNXzeSeispL8aqu8VmSE0hgiWU/eEFRISL3rFomOxt7s1du5VRsZaaN5e7oIyUffTrzgqsyeMcHseIThTlY/KmRyTfXRwcEgjqec8ScKCLE7jCNZp4EY7YC9YHUljJNPX1WXiG7U0BK6onQjmhScfA9KCycZTVRjnrWwonFDGgL71PWhXKz5UmeOe2aZu61r++tWkdi4MkTTS+gSnIsF1ot6MAwpI0CA0gI/78qnsr+a0UbiHbHjSe0S91+qHfTz16ZYBweDe5M1svDlJtd2TagTepyxmd78SDFdo8Hqs65XCytxMSeH8cW+n6C8Ry338xSS0d0o9tFEHXcHtEjDziB9CpiDB7oIDEliPlLKjSWXIZeRlEhbW5OK13q4Z0hWS6weMMbuj00vKCWWYN71Md7lvN1dlODPbY+8869TUNBfxAJrZehavzrzsRzW1KbN4oPcfawQoK32tLS7pcVC0ERzuJPgbhoOTug39M5gqt45wjh64V5UKnQZZaY0YcAj6I6Ll0StYKi4eCxtqjAW1hGHG06PVHXoC0Lpt3Dcm1LFQfjnnWVnMF2y93wINMFHb6FS0S7PmLWKvvDOFFuXc2BNu9byzsVE4Z3Mj/+rW9sXEJLdxD10buCynhJOBVC614BUVDFioPX3CF80ifEIbrN9cLRY17LE5UjJbgoCxcIBw Ed9l+MYu p2GKOjClk6aMtvjQhTbdtHq+z/iJA1sfnj/zq75M+grQhOpEEey15ZokZpjvgjB/XsA3LeY2o+qKPMOMfdtHRoCnVqx3jrp2UwJhWJRqWHg4thInvrlsDtuI3V4+cVnwrnuXt3M4phQutWU8Ey/5WTRCLNSF0YTw4zvg64vEeJO0daVUrTT8S3xW6xqU+2dM3StxpqCgvu+eBA2y1t1mKKbNk7Egisxkyg3/O1tG+43vUjNskyw0NNN7kpazRs8tPkiO9kHTYwKKZ0d8Z8GrOWCMGQMLonFoQp5H9cEEL2dz+PKEYXQw8nE2gcv7zLEEIoMTORWwSXmociXqZyed5XgNEQQVVnEMJAmtpL5E7Ow5VdwhaEiX7elr4Ift1kLlf071P1Awe2dia0N95/QWAywwe57JHYxCGg7WjJCK8EOqlUwE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001949, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/18/24 13:52, Lorenzo Stoakes wrote: > On Fri, Oct 18, 2024 at 12:32:37PM -0700, Jeff Xu wrote: >>> when they encouter a failure, the pattern I sketched in my earlier >>> message, or switch to kselftest_harness.h (like I say I don't know if >>> the fork()ing is an issue for these tests). If I had to have a macro >>> it'd probably be something like mseal_assert(). >>> >> I can go with mseal_assert, the original macro is used by mseal_test >> itself, and only intended as such. >> >> If changing name to mseal_assert() is acceptable, this seems to be a >> minimum change and I'm happy with that. > > No. > Jeff, Please pay attention to the feedback you have been receiving so far from Mark and others about using the existing kselftest framework for reporting results and don't reinvent wheel. We have two frameworks to choose from - they both have been in use for quiet sometime by tests. If there is a need to add new functions and fix the existing ones that should happen in kselftest_harness.h or kselftest.h. We keep fixing problem and enhancing them as needed. With my kselfest and framework maintainer hat on, I don't want to see yet another framework emerging which is buried in tests. thanks, -- Shuah