From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EA9DC5AE59 for ; Wed, 28 May 2025 07:37:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A344E6B0089; Wed, 28 May 2025 03:37:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E4706B008A; Wed, 28 May 2025 03:37:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D3F56B008C; Wed, 28 May 2025 03:37:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6DCC46B0089 for ; Wed, 28 May 2025 03:37:48 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id EBE9F160569 for ; Wed, 28 May 2025 07:37:47 +0000 (UTC) X-FDA: 83491512174.08.5445CB1 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf12.hostedemail.com (Postfix) with ESMTP id E63154000A for ; Wed, 28 May 2025 07:37:45 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TKLjfM3K; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=asml.silence@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748417866; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t1dSHMFfDFy764C5jJ4C2GRVs5CFaHPqL3t86S7wFV4=; b=IOj+LJ3o9bJeHPPO27ejAQpIKge/SEthRybpO+6m5ZHYw8Lb/6diTFMh0sMINLBf1WXePJ kdsDwQX+dESxR9WtMBwxXk5Y8G9NZYV0o/UO/o3EL8aOaeYjOBnBn7P8jWdYGHIy0XJzoU rSdobSXZYx7YEKeXFIriUt2bevPB4O0= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TKLjfM3K; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=asml.silence@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748417866; a=rsa-sha256; cv=none; b=6F6WqnIygozJ1CQo2G8I61nvvg78GPFdUD6Qis+ZVBl++Maxk+FrH8RwBeY74ZrvJNLjkY P2A149YnK1s7MDK+yMe4JHkAsU5fTrAUSDeljH23Z8sb1p6/X+Vdp4Ojp7oTE4YA2D8Y3H zCbV2iZ3oU41mSynd5x8X+BoJwbHwzE= Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-ad8a6c202ffso11076066b.3 for ; Wed, 28 May 2025 00:37:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748417864; x=1749022664; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=t1dSHMFfDFy764C5jJ4C2GRVs5CFaHPqL3t86S7wFV4=; b=TKLjfM3K48lnb877297lBshhaudPiz4BtGpNQMI5UJEXymSEMi4jvhcnUidvQloV52 n0GajFL0WBkKOP3MYNm3RPydu/0eAs2G5ckvlJ6O6ovQ85/ihor8lKlkWQrUiXmEkObO kXFvpWXzOgRARAIZxou2h/wrJrH+Kw8KvBbA3A8EIGTpth6kroEvDamgUKU8/uCAtpts vHQbsJ1NDEYwYZKaKpAIIlkE+bKcI+JElHdy/lIBwJyT7kWwpUS+Huh89pdT+tkLpKee DJ+GmYa4KdHn0R5CWf4DSz2DvlLhvxnqYwDQdy1HeJwJng+4WxrcB3IJhulIWGgNqfpL 85jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748417864; x=1749022664; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=t1dSHMFfDFy764C5jJ4C2GRVs5CFaHPqL3t86S7wFV4=; b=o6coUxfVrqnM9dv9XfMFhIFQFWWw6M1WaUjZezCxdeNXMlGIXKNiznM2bmbkxOlufA jWx3iTHKwByIKgOrtNPaLzFwPdtNaenneCTJ/+Wld+xgXFSxmbd++VuCrGCusOYLY2VZ nX0N80Z5IqO+26nwaBbDnCg245H8afaveNqSjEvMG5SRt86S+98SoBUZCAdJQOZXtPG4 3uRznQVsxXKraZLbgF6ggJWsNmZgzi4I8bcOIbMS7NqA7t7pDBFSQi7166b9XFdWNKZz DlJv5R00BnJh1fLpJ00hIlsM1B3m1dSzB9ZzeZ5VKIEbCOSL7s1ZWpCOvZbbkHBGC8bh /rsg== X-Forwarded-Encrypted: i=1; AJvYcCWQ1yBChlqvle+9wh0Hiz5s2HVBdOEaPxFE6sKvAizAZ0i9ReLwHIs/O6dqZX4X4W+Xo1Mfyi4AhA==@kvack.org X-Gm-Message-State: AOJu0Yw03Dfm361GUtiCsXnKDWkB9ZijxgaD4jcj9l1+NhYLyHTxHfTn T0oE09J8bjVluGvqwNktBMiXlC9YkLTjb1OpK9QhCQy8ChTplz+xai3J X-Gm-Gg: ASbGnctfiPjaEELiUpCicdU71cjKTkujp7I9Qisy8xF5WeVZZ5ETfH2NgxR4PTwdU7c 9Wll5IgxGE0h7SYzumhfVwlwJQ3vqdzE0uuFne0R8Rr9PxBUciqcq86q/Zb98HayYrvKm3UqOjt 8Jc1QUzCTLcuBcrSKZweeEfOAkK1waQsPjmBpm4iYIo/nfQwZyGUTMoVK/xVKiDhVAlFNf7g6hh oMc70jwVoOf/kNrofJPE4yOVS0ovID4fz1h8A3gdHciHDvhUUIw1im03pmBj2PelgW9a5FE1wD0 RVEgt6nzhT88ZsrjJm5ttyLmz4wCCcEa+FIprAFCNzW+YTOJtjU6PAELB+h+/yAgaYBQ2egfEQ= = X-Google-Smtp-Source: AGHT+IGVvc9x00EqEBp/+uRhBV0Xy1432qgXuuK+2L3w2LGJ/kw7OOqZ6bGFRPbEXoSuuCXV4u1knw== X-Received: by 2002:a17:906:99c2:b0:ad2:4144:2329 with SMTP id a640c23a62f3a-ad85b1205c3mr1472269966b.7.1748417864109; Wed, 28 May 2025 00:37:44 -0700 (PDT) Received: from ?IPV6:2620:10d:c096:325::6f? ([2620:10d:c092:600::1:c447]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad8a1b28a5fsm61572066b.90.2025.05.28.00.37.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 May 2025 00:37:43 -0700 (PDT) Message-ID: <6cf44bd6-325f-407a-aadb-74eb567974ef@gmail.com> Date: Wed, 28 May 2025 08:38:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/18] netmem: introduce struct netmem_desc struct_group_tagged()'ed on struct net_iov To: Byungchul Park , Mina Almasry Cc: willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com References: <20250523032609.16334-1-byungchul@sk.com> <20250523032609.16334-2-byungchul@sk.com> <20250527025047.GA71538@system.software.com> <20250528012152.GA2986@system.software.com> Content-Language: en-US From: Pavel Begunkov In-Reply-To: <20250528012152.GA2986@system.software.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E63154000A X-Stat-Signature: pfgewz1q57h45955qur3putzqrtr16ew X-Rspam-User: X-HE-Tag: 1748417865-923970 X-HE-Meta: U2FsdGVkX19v7krGruEGF/gPB95HCQKtw+X2XRRW1Afu/tCrSmIPO/Q78zug2pQeOHCE+D6jeELvpflK7IGviQyQ7vi5eawcavai3H3TpXJadnbUi4MJx8yjOAkcd+f1/uqIsEKiQn0f6qX19Ayt79JyQEH0nzuHkrgo+iRU6Qb/Evq+4yzmrnEdnHQ5vue2sYhA/nGEHVgP4ITkIG1fMQxgPedJnqXrB5DLc9iHLJJqjFFjpX+ZBnT/khZRCSHoWD0uCsGvTFrMjoKABSRdd7dqC8y+wgX5BsfPi4X60CN8Wp8sALQ+GDH3iQQxgwG8RWoQgDUeaURRK05shKwmDTT8vMwTjjc2Rhqa0AyFjZCBxp5cg9H3/xQbyFYA8YAhQGThMN+M+TsjdY9DLi/E8BgWmVoru9UR3+GVvvUXbwhHgFtGq291GmIPLMSYNdhz5UI07wNtLGw5XNNSHJj1TZ1x2OVz4DPLbGxbpxaj4+IF1qhdiolsnGxQWSp3jG581EqOs7LDcV9lXq0qVIz5aY4R7mW9p/3S+OV2ROjaZXoXb8V3cN9c8OblVXrhDgYe7dyWp4V7sMHMBMR1jKyH71N9Pj0BZanR6SmxsJzpeqoxdEi0WVOWXVKqxpKAZGw6nKCKi9uB64jAmLPUIihkR0ARkudVQJhsju4t80DWsTvkI61tcByhXP62qcPwwNWheABc+ltpHHvaOLWFHUUdtUD1NXNI5YIN/hOvMA9eNYZwPIa2sUjbiQblXUiZrwEkOeLPD8Msm1/NPaRt1qJIr3zvK04pGWZ5Q8xZ8mNuJNCF7xRj/cqOoIjmGQruRy0xfo2mlHrDENBMyDMhfMHwSplERCuON7VUBa8ghtrtv8Y5MHX+JkPmtg+eSGnKFs05luqGcLLR0w1QmYrv8VFISYOYXuh2iYtDHdXUmVWesFmpydTzDOM5HBm9GtJEohpLiQ1jOoPks85nulo5rP3 7IFOpJmg utz4LFcc2cD6g9LYq/9jLsP9YDXcIC7NRdsx1f618OW3DHFmTAzEi3Avt7LTvR1B1ePiDacNumhWUqb4UNCg00wLM4Qe8+ox6LKj9RD317lYi5HavqscSlA2QPUAIuPXaBvE7A5WQfsoxgK8e8iV97PRx6N3y+zWek3gu/zbrDtSdSHihBegQcQEnaCYUIfCfG06Vkgwe5v0YWMdCjGZd62JdmWcnvj0X55xr+RQNaFfo5F9wbZSQOjDWVZOVdyE01U/irsd+2ijQlRdp/F2vqe+Zby9tOEgkJUXeWhDZ/PISfFwTZ0ISY2sy6aakbolYxp2THBmwdZyHefx9B6ikRDnQUxw/V6+ddMgjkNRvxWk9b1fVbgrMNevnIFF5MlnVQKvPjU8Jv3kAIN86fiAs3Jwg1Yc999C6HvR8RZ1S7Jd2U9Y1Z0kZEzUMUWWrD5uVUZewfSH2uhEnygho2GFn89aJGS+jntiWW8IyTAhs0CwjufB/YopbWz7EAucIyIJmXtofiX+yTxi4ZotaO2XMTCEmEWfRNwjUz9Pv2/No+A+W0egqw+8gnWOVEXSW5Rp2yPrl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/28/25 02:21, Byungchul Park wrote: >>> So.. For now, this is the best option we can pick. We can do all that >>> you told me once struct netmem_desc has it own instance from slab. >>> >>> Again, it's because the page pool fields (or netmem things) from struct >>> page will be gone by this series. >>> >>> Mina, thoughts? >>> >> >> Can you please post an updated series with the approach you have in >> mind? I think this series as-is seems broken vis-a-vie the >> _pp_padding_map param move that looks incorrect. Pavel and I have also >> commented on patch 18 that removing the ASSERTS seems incorrect as >> it's breaking the symmetry between struct page and struct net_iov. > > I told you I will fix it. I will send the updated series shortly for > *review*. However, it will be for review since we know this work can be > completed once the next works have been done: Please don't forget to tag it with "RFC", otherwise nobody will assume it's for for review only. -- Pavel Begunkov