From: David Hildenbrand <david@redhat.com>
To: Oscar Salvador <osalvador@techadventures.net>
Cc: akpm@linux-foundation.org, mhocko@suse.com,
dan.j.williams@intel.com, pasha.tatashin@oracle.com,
jglisse@redhat.com, yasu.isimatu@gmail.com, logang@deltatee.com,
dave.jiang@intel.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Oscar Salvador <osalvador@suse.de>
Subject: Re: [RFC PATCH 0/3] Do not touch pages in remove_memory path
Date: Tue, 7 Aug 2018 16:41:33 +0200 [thread overview]
Message-ID: <6d07f588-cc40-132e-2d89-26e00fff5a88@redhat.com> (raw)
In-Reply-To: <20180807142826.GB5309@techadventures.net>
On 07.08.2018 16:28, Oscar Salvador wrote:
> On Tue, Aug 07, 2018 at 04:20:37PM +0200, David Hildenbrand wrote:
>> On 07.08.2018 16:19, Oscar Salvador wrote:
>>> On Tue, Aug 07, 2018 at 04:16:35PM +0200, David Hildenbrand wrote:
>>>> On 07.08.2018 15:37, osalvador@techadventures.net wrote:
>>>>> From: Oscar Salvador <osalvador@suse.de>
>>>>>
>>>>> This tries to fix [1], which was reported by David Hildenbrand, and also
>>>>> does some cleanups/refactoring.
>>>>>
>>>>> I am sending this as RFC to see if the direction I am going is right before
>>>>> spending more time into it.
>>>>> And also to gather feedback about hmm/zone_device stuff.
>>>>> The code compiles and I tested it successfully with normal memory-hotplug operations.
>>>>>
>>>>
>>>> Please coordinate next time with people already working on this,
>>>> otherwise you might end up wasting other people's time.
>>>
>>> Hi David,
>>>
>>> Sorry, if you are already working on this, I step back immediately.
>>> I will wait for your work.
>>
>> No, please keep going, you are way ahead of me ;)
>>
>> (I was got stuck at ZONE_DEVICE so far)
>
> It seems mine breaks ZONE_DEVICE for hmm at least, so.. not much better ^^.
> So since you already got some work, let us not throw it away.
I am not close to an RFC (spent most time looking into the details -
still have plenty to learn in the MM area - and wondering on how to
handle ZONE_DEVICE). It might take some time for me to get something
clean up and running.
So let's continue with your series, I'll happily review it.
(I was just surprised by this series without a prior note as reply to
the patch where we discussed the solution for the problem)
>
> Thanks
>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2018-08-07 14:41 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 13:37 [RFC PATCH 0/3] Do not touch pages in remove_memory path osalvador
2018-08-07 13:37 ` [RFC PATCH 1/3] mm/memory_hotplug: Add nid parameter to arch_remove_memory osalvador
2018-08-07 13:37 ` [RFC PATCH 2/3] mm/memory_hotplug: Create __shrink_pages and move it to offline_pages osalvador
2018-08-07 13:52 ` Jerome Glisse
2018-08-07 14:54 ` David Hildenbrand
2018-08-07 15:19 ` Jerome Glisse
2018-08-07 15:28 ` David Hildenbrand
2018-08-07 20:48 ` Oscar Salvador
2018-08-07 22:13 ` Jerome Glisse
2018-08-08 7:38 ` Oscar Salvador
2018-08-08 7:45 ` David Hildenbrand
2018-08-08 7:56 ` Oscar Salvador
2018-08-08 8:08 ` David Hildenbrand
2018-08-08 13:42 ` Oscar Salvador
2018-08-08 17:55 ` Jerome Glisse
2018-08-08 21:29 ` Oscar Salvador
2018-08-09 7:50 ` Oscar Salvador
2018-08-09 7:52 ` Oscar Salvador
2018-08-08 7:51 ` David Hildenbrand
2018-08-08 8:00 ` Oscar Salvador
2018-08-07 14:59 ` Michal Hocko
2018-08-07 15:18 ` Jerome Glisse
2018-08-08 6:47 ` Michal Hocko
2018-08-08 16:58 ` Jerome Glisse
2018-08-08 21:28 ` Oscar Salvador
2018-08-09 8:24 ` Michal Hocko
2018-08-09 14:27 ` Jerome Glisse
2018-08-09 15:09 ` Michal Hocko
2018-08-09 16:58 ` Jerome Glisse
2018-08-09 20:50 ` Oscar Salvador
2018-08-16 14:58 ` Oscar Salvador
2018-08-16 17:32 ` Jerome Glisse
2018-08-08 9:45 ` Oscar Salvador
2018-08-08 17:33 ` Jerome Glisse
2018-08-07 13:37 ` [RFC PATCH 3/3] mm/memory_hotplug: Refactor shrink_zone/pgdat_span osalvador
2018-08-07 14:16 ` [RFC PATCH 0/3] Do not touch pages in remove_memory path David Hildenbrand
2018-08-07 14:19 ` Oscar Salvador
2018-08-07 14:20 ` David Hildenbrand
2018-08-07 14:28 ` Oscar Salvador
2018-08-07 14:41 ` David Hildenbrand [this message]
2018-08-07 14:52 ` Oscar Salvador
2018-08-15 14:05 ` Pavel Tatashin
2018-08-15 14:32 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d07f588-cc40-132e-2d89-26e00fff5a88@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=osalvador@techadventures.net \
--cc=pasha.tatashin@oracle.com \
--cc=yasu.isimatu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).