From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B771C27C79 for ; Thu, 20 Jun 2024 14:01:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 990DB8D00B6; Thu, 20 Jun 2024 10:01:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93EF58D00AF; Thu, 20 Jun 2024 10:01:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 792688D00B6; Thu, 20 Jun 2024 10:01:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5A2228D00AF for ; Thu, 20 Jun 2024 10:01:30 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8C6191A01B8 for ; Thu, 20 Jun 2024 14:01:29 +0000 (UTC) X-FDA: 82251429498.05.B53522A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 642B7C004D for ; Thu, 20 Jun 2024 14:01:20 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ixMEiWka; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718892068; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H+/uFiCGrKYOr8f3Xm2xUT28S49p5SQ4fyxld7R6VYc=; b=QA4pd8E5hsD6v4v3esmHZebzV0GAAL63/B3CES+NeqEvyWMMgS7TxFWYEtJu2ejXB1hxK3 bcurB0OHsTnBSpemr6hEhECB8+66e37XRGLDP7umZB7PfPfCVHdC2/a8fdWrwLqUxEF5gx 9duS71hL2gzU5pf1jbfLT1WcapQScgg= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ixMEiWka; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718892068; a=rsa-sha256; cv=none; b=rbmh6U++osaJbeZpr0WUmNn16+CNH6RXRObZySPDHLnP6F2K75gSsq/x5Vo+68bfbeCIcm ppoOu8EtS7nBlgHbsjPORrfKFbhm0+qIRz+Nx0ymjemjyax9Y146bUZOKOXNzzZ2ufuZ8V y5nRbXNt84Ep4JvztEYJibgPL8xAsNs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718892079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=H+/uFiCGrKYOr8f3Xm2xUT28S49p5SQ4fyxld7R6VYc=; b=ixMEiWkap+XOrk11td8xRmaIuJ6vM1Ptstwk8M0j1Qa7a/hjVH6fIGAAXbV/ZHO/YF6ptl 36GcUYLAkHtq9+6RZ5ltAxCb63Cz8HFeVBxKxk6wH7Fc7fBqBn6W4jZWO7zDZ4kil0E8YK Y1uy7QMQXFgBn6crLzcIyZGoFKKFZgQ= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-63-QW566zsuPzaGAoFeP3K5yQ-1; Thu, 20 Jun 2024 10:01:17 -0400 X-MC-Unique: QW566zsuPzaGAoFeP3K5yQ-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-52bc0027a29so623309e87.3 for ; Thu, 20 Jun 2024 07:01:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718892072; x=1719496872; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=H+/uFiCGrKYOr8f3Xm2xUT28S49p5SQ4fyxld7R6VYc=; b=XTyFhOWPyiBGoceskpUkhc4+WO2j/1jCe1ThmrElPdNA7E2UfJh2CKfXDi75sgBY8c qwpLN20vVIz3GfzcrVJ1XCWDP5Pu3iPzSA9JPJuKksUyA+z3QNJRD1dH+CWSiTNRQ9BG SpE+pOnDewT5MPiPvQlO36J5Vy34zV8JmbeZUEMPkPJsmlevDKzWId/3+vQB6673CUZm CnULyZ2TKjWgw6jnLJSF2GuB3KLbBHEBGLEqfUHh9zXGV4DQp6xJkj9xfz3bdDZrxV3i O+YNl3yiethbv3MnKR8M/h4ifn7DfgrRvIqksK2Vv3F09gMit7EyGV7ZilKzOj04HO4r beTA== X-Forwarded-Encrypted: i=1; AJvYcCW3LLLGcv9V/q6gaSWQ2vuPjL5tiNVHPY5ikdw4yzKpId5RmlOX55KdQbh0aU/i0O3RhcRAzFJBW7DwgW4b+y2BGpM= X-Gm-Message-State: AOJu0Yz8GQh7A7jBXUMTetDBwNW50vXRL1wXNhBsaaQ1J8mSlsbB7TGh AKOZAXK7cfJ3Ewq7J1lQy1dRParV4+AcnaRh1iR+YeSOUOGSqsVj7dvTA3dnO51b5MrlfQkE1E5 Bz2wn1ME/4pfR5GCJq1ZpJrc+7VPNkkxWnsNBPhxS2LED3LOY X-Received: by 2002:a05:6512:348c:b0:52c:8c5b:b7d8 with SMTP id 2adb3069b0e04-52ccaa60842mr3095389e87.30.1718892072246; Thu, 20 Jun 2024 07:01:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHJYjbE9xh8gzOPded+ami9ji3Kn9OHGGwuOWKeuzEOUKBoz3fjdadzXWT0QtMsnTT8F0tbiA== X-Received: by 2002:a05:6512:348c:b0:52c:8c5b:b7d8 with SMTP id 2adb3069b0e04-52ccaa60842mr3095368e87.30.1718892071716; Thu, 20 Jun 2024 07:01:11 -0700 (PDT) Received: from ?IPV6:2003:cb:c719:5b00:61af:900f:3aef:3af3? (p200300cbc7195b0061af900f3aef3af3.dip0.t-ipconnect.de. [2003:cb:c719:5b00:61af:900f:3aef:3af3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4247d212254sm26724175e9.45.2024.06.20.07.01.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Jun 2024 07:01:11 -0700 (PDT) Message-ID: <6d7b180a-9f80-43a4-a4cc-fd79a45d7571@redhat.com> Date: Thu, 20 Jun 2024 16:01:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 0/5] mm/gup: Introduce exclusive GUP pinning To: Jason Gunthorpe , Fuad Tabba Cc: Christoph Hellwig , John Hubbard , Elliot Berman , Andrew Morton , Shuah Khan , Matthew Wilcox , maz@kernel.org, kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, pbonzini@redhat.com References: <20240618-exclusive-gup-v1-0-30472a19c5d1@quicinc.com> <7fb8cc2c-916a-43e1-9edf-23ed35e42f51@nvidia.com> <14bd145a-039f-4fb9-8598-384d6a051737@redhat.com> <20240619115135.GE2494510@nvidia.com> <20240620135540.GG2494510@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240620135540.GG2494510@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 642B7C004D X-Stat-Signature: stwu1ed8xrbctxxtxnns7eajmss4wzfu X-Rspam-User: X-HE-Tag: 1718892080-460953 X-HE-Meta: U2FsdGVkX19zy6MAN91xTmOyhk+LcMOBhlOetvKeR7K14GowCmwLpJ3zj5Sjfjfbo/4zTAvXEqRXDfP1kAQJprvl9nogjcKLi2rnf6U96xcVSLsbS1NdB0u/wR04MKppCthpYmeL2YCt2qCGpuA/xVXPErWHgx6538+vgd790EQTdLdetuwp40VSRSc87vhEdI8c2shqW3Y+b9THkP+ptpQHQrCplwXIV5weRZlx9+2s0v+upGR9iOAKf2KF52eBi2ipQib6QcRA5fRVXyqO9/wTsfqBCjJURninLdZrKI2qQ4El6uO14Xx22cep5A5DS/Oq+/0Ap61J1AqGx8ZmeRTPwXG1HRIlTUwlqVI+4jSXKIhnP5/vkvCZBotWF/NE8Bh3sUeHufdqvpbbp7jfKy3/1bdk212uO/8CedLONXLEjM0LHTpo1JO6UboSBWUV7a0Ol0+QUZASeGjhv4BCUWDF17bajyCe3omVjWeqTOb0eND1lCIcJAJa8J0yfkGgsPYnzDIrsiIRzsJ1a8uWaoHjV+M+kmYfiurv2scl+Rby33fN/VQKfzwrA0RBwavJm8ouc1hFXCEoR68KxuVYjK9YFjB0NjDliBo1I07jCqz4x+f9IbRr4+7PE+PUrzsdKYylTSJFoYMqf8zSp6fKDSuGpoKJ96uPkdD4iU0vtym8EVpvYIS56Vjx+x6ut+yGQ532oWejDlQJ9qEhp4EKlvOyctWFeG2h0TP3bdNK5JKCSIudc3o8dRkNxQj8hThO15EN+eUpCcS7KH+F4awY/jS/WwZa+o5Wp6bX3/8BDM8/BrMsx62LgvZwBqxzjNiZD/vSHtowKjR/IP9+/whWfrb2gmiZlWdeOs3KsTOFdo+/tfSH3pPywLiuXY4CxqjgUrCVqhzaAWajZJ7B7eDOdRrwXLhcF/9IwJ4XSs6k8ggdC4V+TyRjTkv30Sz8Of3ds0umZRmi31H5AbiwOzi ba6pu41J 9JHeO8uCtzbDSkDODrOtt1JHI7NyViniOMuRG2ca1iXMoJQT/c6ALS9H+VGs6kwuoeSCiQ6e1BTubq2s5hyGB/zjLikFGSi3LhRCTivpyf0EDQ7nDWDCpFr1gB502rDY8Ow1gyAVCm51ngNO3LctesP305JEM7oTaOmmCjxusonB51QNm3qn+Gb7IbgTrLRINc3TuoVhe82n7JhuK+v+GYHG/QC0UscisnZhqKooaIsTX5BdEKUxxs+eYR0bfOPPiwlambKeOp4rerfZmlabvLcD2iY90PymljGLYlYSFw7WJ/zR1fdxi8cI28xtXY/y+5TaMcbk66OsTe7wZj05zSQNhPLZx2uIzAExwTuZzKn+t8K50jFQUBMxDvyYJ8kyRN+y43zoHgx/qCfc2JdAK2fKLhgnJG9qlYVFZjqAqcJpk3ECUXw3eVeSodG/KaacrvlA2xtu9MBFKgew= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.06.24 15:55, Jason Gunthorpe wrote: > On Thu, Jun 20, 2024 at 09:32:11AM +0100, Fuad Tabba wrote: >> Hi, >> >> On Thu, Jun 20, 2024 at 5:11 AM Christoph Hellwig wrote: >>> >>> On Wed, Jun 19, 2024 at 08:51:35AM -0300, Jason Gunthorpe wrote: >>>> If you can't agree with the guest_memfd people on how to get there >>>> then maybe you need a guest_memfd2 for this slightly different special >>>> stuff instead of intruding on the core mm so much. (though that would >>>> be sad) >>> >>> Or we're just not going to support it at all. It's not like supporting >>> this weird usage model is a must-have for Linux to start with. >> >> Sorry, but could you please clarify to me what usage model you're >> referring to exactly, and why you think it's weird? It's just that we >> have covered a few things in this thread, and to me it's not clear if >> you're referring to protected VMs sharing memory, or being able to >> (conditionally) map a VM's memory that's backed by guest_memfd(), or >> if it's the Exclusive pin. > > Personally I think mapping memory under guest_memfd is pretty weird. > > I don't really understand why you end up with something different than > normal CC. Normal CC has memory that the VMM can access and memory it > cannot access. guest_memory is supposed to hold the memory the VMM cannot > reach, right? > > So how does normal CC handle memory switching between private and > shared and why doesn't that work for pKVM? I think the normal CC path > effectively discards the memory content on these switches and is > slow. Are you trying to make the switch content preserving and faster? > > If yes, why? What is wrong with the normal CC model of slow and > non-preserving shared memory? I'll leave the !huge page part to Fuad. Regarding huge pages: assume the huge page (e.g., 1 GiB hugetlb) is shared, now the VM requests to make one subpage private. How to handle that without eventually running into a double memory-allocation? (in the worst case, allocating a 1GiB huge page for shared and for private memory). In the world of RT, you want your VM to be consistently backed by huge/gigantic mappings, not some weird mixture -- so I've been told by our RT team. (there are more issues with huge pages in the style hugetlb, where we actually want to preallocate all pages and not rely on dynamic allocation at runtime when we convert back and forth between shared and private) -- Cheers, David / dhildenb