From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D827C001DE for ; Fri, 28 Jul 2023 16:13:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A02A38D0002; Fri, 28 Jul 2023 12:13:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B20C8D0001; Fri, 28 Jul 2023 12:13:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 853258D0002; Fri, 28 Jul 2023 12:13:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7378B8D0001 for ; Fri, 28 Jul 2023 12:13:35 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4362AA06E4 for ; Fri, 28 Jul 2023 16:13:35 +0000 (UTC) X-FDA: 81061515990.14.B90218C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id AD67D180018 for ; Fri, 28 Jul 2023 16:13:32 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AFbMPjso; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690560812; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1Dyh7+qatvQDKM5qDRHq8YkO5TCQeLww3uN1vYmzEUU=; b=oJ8AkioFg8uDTBazR47Xf1Jl1W0/zw3jvCaN/DWU8uxV7n175dZxWv45xLi8P6TrIGPWbq i49juGY9UTAzwBC+aSPtNQu2PQShJOjqkiYHvuE8eN3axAnuUwBQ1yBIolxckQkaCAOIvP bqlI/8EDFFX6m3zSUpajSpJGHWGutxM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AFbMPjso; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690560812; a=rsa-sha256; cv=none; b=Cx25nx20wUZBGuXCT5c196rSWT6mcXjOjrZ40xuJJ9Yl54f3WqqLtmDq9yTCznkv17iyFH scOsZeqOX/3pQMragWRR1ZwKdi/1duWu1R0PH09YvvWp+m2Swdcp1xdVvDuFZ+54+lTOw+ ZlvppRQT6s2WIDlatZXCfLt9A8auQ0o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690560811; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1Dyh7+qatvQDKM5qDRHq8YkO5TCQeLww3uN1vYmzEUU=; b=AFbMPjso2WqSsOp2d5xg+I3BXEHluRanBRXUI2K2yYD/BriPHbbF0lpb2CNMl3Yua2HZEr 7Vr6tz/4xcLcUDrZr9xbf049qjKLI5v7EqdFatbXnLku29ZEmw9EoN9Z6M/n5y06sNm8Tw +VXn1tmDygFFwl2ozKQTi5PBekTPm/w= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-648-2H9hCMfUP02AVdDhrRKfqg-1; Fri, 28 Jul 2023 12:13:30 -0400 X-MC-Unique: 2H9hCMfUP02AVdDhrRKfqg-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-99bd6ea0d9eso131539666b.3 for ; Fri, 28 Jul 2023 09:13:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690560809; x=1691165609; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1Dyh7+qatvQDKM5qDRHq8YkO5TCQeLww3uN1vYmzEUU=; b=W1gMj9oSnR3m4/DjcDE4+gF8Q3TJAUzC1Op56dLlJ6fKdFxTsa9NtmaTecApM2Iz+o Kzr4gWU/0R6hJ+K+lrZpCQJOHLnvmC89ocrUd1NHlJeVhL5BPGrGDRlowyiTVydOBT/U 6CsYe1mrbhY4OGzqXVNyGGySv7/Ey4OdgbN8VQIlxge55aeBxOvQMMoU6MqQhk7slfxh 7/RdIdCuTjdE/A0h6qwWdBNFbfmQNMf3xnBktRLqN0XQnUmvetzUoeJBOEcO0P8/4nX/ aVF5yziR8n22Uh9DIxqIP1xNwBhi9R5ZPAsMKGXvgMpiuSteC+5fJiTrJ3dFa+WlRlXk 0ReQ== X-Gm-Message-State: ABy/qLb95qUCGV7OwQWVK3tRtVM2WtrLcEnIjwd2XJuzlrhpgarTqgjB ML7vmSbZo+O85qNVEimJXrxotiAJ3pAEprMN0APm1KAKX+wKOaP1HVFxphpWsqOsROMOxjLejnk dzwS/1oAgh3M= X-Received: by 2002:a17:906:5354:b0:99b:efd3:3dcc with SMTP id j20-20020a170906535400b0099befd33dccmr1357356ejo.62.1690560809634; Fri, 28 Jul 2023 09:13:29 -0700 (PDT) X-Google-Smtp-Source: APBJJlHd2sX/AyGtIAscRR2p4pTksaGOsuCTBRQ37WpaEGChaEB1fcJtjozFJjrwhV4jFSHGD+pttg== X-Received: by 2002:a17:906:5354:b0:99b:efd3:3dcc with SMTP id j20-20020a170906535400b0099befd33dccmr1357325ejo.62.1690560809219; Fri, 28 Jul 2023 09:13:29 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id gy26-20020a170906f25a00b00993470682e5sm2197928ejb.32.2023.07.28.09.13.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jul 2023 09:13:28 -0700 (PDT) Message-ID: <6da710cf-2bc0-bb6e-26f1-fba14ca767db@redhat.com> Date: Fri, 28 Jul 2023 18:13:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [RFC PATCH v11 10/29] mm: Add AS_UNMOVABLE to mark mapping as completely unmovable To: Vlastimil Babka , Matthew Wilcox , "Kirill A . Shutemov" Cc: Sean Christopherson , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Yu Zhang , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-11-seanjc@google.com> <20230725102403.xywjqlhyqkrzjok6@box.shutemov.name> <692b09f7-70d9-1119-7fe2-3e7396ec259d@suse.cz> From: Paolo Bonzini In-Reply-To: <692b09f7-70d9-1119-7fe2-3e7396ec259d@suse.cz> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: AD67D180018 X-Stat-Signature: 1au4gft7hpj139mmgxiru1j64od68yfx X-HE-Tag: 1690560812-459824 X-HE-Meta: U2FsdGVkX18j0bfW9kK8KwwQUUlJfuSgT12VjnnUTHNUlGwnesaF5s8jVXfZV4V2mwmZyxuIEhDCVq4WVfUv62PXI7wDZPszaKeyrUU50WUbXgsZ6Wv/qf3tHGVUkSy65U11rSWCIwmoaxEOou+KlZlPfF1btuRYXyroXsk94hMs8HxTUwLHX3DGKaPwRVThq6W1ILhF0WyishovpCPeAuiURIZmlJ4BakYTf/xEXlIJGbhZxbXGarOWVtuZC9nVhnJ9cbDvdvkL84HkFXxdGBsKe4V+2jgocQ3PYNObvAIbxq7wy1l7StX+jqZvimEklG6vE1l4Mx4BlKgy9PCbJkymVcjq+KSwWwpVf7QkoP2vxvAIlWaETNSktiwQkXz9jjv8OiinjB+2WBfeI9RDXo2PaVZDVECtDBCkP8t4R1QNMsQfOxTlmnfNbM00gQdk/FRoL63VE6f0BNzqcq/WLQlRkKq9lim3nADzNcYEB8hflCkHmnq9vQgv3wGFHBM7a/xkpGN4lhLvUgp8nj5WQc+fd67Fj/jUxZN2lSvGDKTw+55A3hH1xvsLSPWEdA+DjZYA32f8F9MWjlw4FrAd7UZaEGNcBHhnXWc/VpPHNE05gL/WR2C6Fv2CGQrGVbwy2vc2cZmnIileHf7KRoNHuiyVt8858dRg8MG1NSiM50G0sahueyOR5aZ32GdPV1Bv48o1quuSAkM7CDVk6fYCn9iyrSZwJOF/aDOzz8HQl36NbUA4S+ahYJ6L5GdQtXVxWMZM8lFrNxvNE+n19ODaV2MqFGVFICidBZTQXtMVra/mZqlZJqX6U7/G3L6Ejgao6L77fCzQFsq+J65OB5A1khZeUJvTnOauDQ/uFKKc4VDDNTjlHAsQwfNnJoU9zpRLH2M/5376tH62JYEd36E7KdqORuJeqQjKDpq4scs6nske3L6s55mnfkSufl3sly4qBywsBxxmqjOg/eYQtq+ f77lBZiz wAtIjLW0EGPk1sXe1JIVK1MysLvB5wUa3pC+8eJ9H5f46mBHLaGs+7sWRllBVhOQTq3ySoVKRjfND6t8dmPxGDPZPWjTllnz70k6SbbNZqWgGs/IpB9ilpk0opjjwqVGlduS4PgGKbxqRV7PVDnWl0T/OJPKK7N13Pe4lKG3y3XYGAHctFK0GtpnwH6qhD0AUYRjNM4AMMqQY6TOqz9+9gM47OHRkRN1f8knt/RSXKGDKWVGXQBK0pui+yt5J/OD84RE9NkE0KlyQ9xl+841LVtsZE5mas9fNnTQgzHCJIXGuIAKxoLqDg+9ivv8vP85LnR7ASd/WIaXMmMBfefCAA3VIY97aAy279bEFREjP1iPElJEaGt942LxdUn6o5sRfTaz+DyjLYH7biDOQURrIEWhYx7PcE7814BJL89xkXUQUyp3fXrn2UENv+i7SeSFm0QWYhDh4w80g2xD9E35kDjFxfw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/28/23 18:02, Vlastimil Babka wrote: >> There's even a comment to that effect later on in the function: > Hmm, well spotted. But it wouldn't be so great if we now had to lock every > inspected page (and not just dirty pages), just to check the AS_ bit. > > But I wonder if this is leftover from previous versions. Are the guest pages > even PageLRU currently? (and should they be, given how they can't be swapped > out or anything?) If not, isolate_migratepages_block will skip them anyway. No, they're not (migration or even swap-out is not excluded for the future, but for now it's left for future work. Paolo