From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC27DC5AD49 for ; Mon, 2 Jun 2025 12:26:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38AE96B0296; Mon, 2 Jun 2025 08:26:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 33B466B0297; Mon, 2 Jun 2025 08:26:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 203BB6B0298; Mon, 2 Jun 2025 08:26:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F33D66B0296 for ; Mon, 2 Jun 2025 08:26:29 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A94C7C0438 for ; Mon, 2 Jun 2025 12:26:29 +0000 (UTC) X-FDA: 83510383698.20.E30F5DB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 46D7A1C000B for ; Mon, 2 Jun 2025 12:26:27 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jWo2fHKK; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748867187; a=rsa-sha256; cv=none; b=U9DgXBryxkgoPMZwPyvq2H0EM5O3YGxtZsgH0PLxBY37xboaZUthr/8a10SMPoKYTx/cXk 5roUMvaK9tRLgnwfWyqupdVq4D+9EzB6YpXSZYlbrQA0OEfMUEhnlOtfDicSU1BYCZygxI ZDKU6+SCecdUBZZuK8WFcMwW65mVS+4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jWo2fHKK; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748867187; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=murmMMX5h7qj5SslZFh+7lBZ+d1kCAp76FkWnJBtyAE=; b=51FfI2ZlBucJAYlQ6IvpNwx+2Nkf6umb4iA6mB3uPEQfAgUJFifXlmXhVldjwZcK+PHQzM ORvAU5IfKzc0Bosjly2vGRVsFpfhaNW/nVGiSkfuUHi08oW0vQcVmwHXoYv3BfeDtkQBm1 o4AFQx5vud8x8SwK+KjF76ETWHhig0Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748867186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=murmMMX5h7qj5SslZFh+7lBZ+d1kCAp76FkWnJBtyAE=; b=jWo2fHKKZiGT2SnDfeGYDu0jYuv6KY8+R5/+caH83wUyh+LNobAhhH6fT3gqfTwTz2eNMm aKLuzSVoGSoRfSotnAUZm1a1jmyTdhahQr4nq0z7xGsqpNWkVky0j5nFazj/If/Tt804Zo sG2fXf/Gr2D7NGWtydl5RgMUFzVglWQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-518-qUUFDhKAOnKOcmJpYoNlQg-1; Mon, 02 Jun 2025 08:26:24 -0400 X-MC-Unique: qUUFDhKAOnKOcmJpYoNlQg-1 X-Mimecast-MFC-AGG-ID: qUUFDhKAOnKOcmJpYoNlQg_1748867183 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a50049f8eeso679763f8f.3 for ; Mon, 02 Jun 2025 05:26:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748867183; x=1749471983; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=murmMMX5h7qj5SslZFh+7lBZ+d1kCAp76FkWnJBtyAE=; b=aN2BQnvNIiolD6pUEHKuqNJjbz1qb/pWE7Bv82jUWazRPJrcQspMgjy8vIXNnS2M4d cBsBUq3EpjK1zdX26QFATU9aOpEvHsGI6FWFIX9UKnNND6wu22n9F0mn97mfSe5eZdAg cYLv2hrI5ltiV9wo5j5SJi4M44LGR491Eo5hBqtvWvAZQvOU40Xb1BTygLj2xtOkc9DV UirpM1H1AaiSnoYE8rosjm711hvS0XS8ZEN5w16gCTgdOTTcPiKYZAqhIpH0abOgQ6ep ifmt2LVmaG0j37d2mv1VKBb7APb3usmFEslZ2g78anATpZkeWqdAkPQm1yLPrYHboPet h6hQ== X-Forwarded-Encrypted: i=1; AJvYcCVkNUk+8e4TwMnjSCk9xfisTt+wdlpGKQOvjz8dicVZRLgIeI7huPVMYmCA63Oqoh2O9s9ghwSNuQ==@kvack.org X-Gm-Message-State: AOJu0YyDa4prPbSozJ3lsw1SrdbFbeubrILyYqYwv/b1uiJpQlx1Q8zw zSpxkjOA8kHPkc3/FcDOtGyKfs6grbkRbFHB+CEdYdQhbHfyc+yDjnPT4yzm92hRBr8SYMFmXJm j7oY80FlxkSQ5vmRGJxscLQvB7gvbtjhxhPggiWJFZFPyV5eJiZ9p X-Gm-Gg: ASbGncthXzcFmxK7ntiHXufyA76/DP8buE7uqIyZZzNcIhzymcby0+U6PJhVef5c6x7 zqDzbp6P6wUhyd4s+2y3qhbX8paPV0AwUYnMzFMb52z9YA0ZYT9PhHAoVqSNUdEhKughbcd3Pw7 kF+uE2GdDBDO6fNsAPN6Y04vOQI/TFfReULjv37Zc+sSiXbPg2elB43ZfBqpz47i8S20ruC585E frrA0q9L+5NUCToip3aXcUWNZnJf5KHjK92ecmrjMWaTf8+qgnSdkcwokeF9fztcVcpeHKjxP5R WSP68CD0XfnJ7CCxHO27UGzNMHm7zYxshONQzVy53Co0EeIR4bs8MeJ0PqoPbDB8jYKj8t+Kgtv JBchxquOKlHNr1wIREt354TQU5cQWM4vefIgY5+k= X-Received: by 2002:a5d:5f8b:0:b0:3a4:e841:b236 with SMTP id ffacd0b85a97d-3a4f89ddd6fmr10574187f8f.33.1748867183245; Mon, 02 Jun 2025 05:26:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEnaWANB9zbp0ilBADD04kHr3ms2pu7nAWaU9IC6TaCnKgeYHJWpaEq5+LUjY+ufTDAVKKdWQ== X-Received: by 2002:a5d:5f8b:0:b0:3a4:e841:b236 with SMTP id ffacd0b85a97d-3a4f89ddd6fmr10574165f8f.33.1748867182869; Mon, 02 Jun 2025 05:26:22 -0700 (PDT) Received: from ?IPV6:2003:d8:2f34:a300:1c2c:f35e:e8e5:488e? (p200300d82f34a3001c2cf35ee8e5488e.dip0.t-ipconnect.de. [2003:d8:2f34:a300:1c2c:f35e:e8e5:488e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4efe6c7e5sm14699842f8f.28.2025.06.02.05.26.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Jun 2025 05:26:22 -0700 (PDT) Message-ID: <6dd3af08-b3be-4a68-af3d-1fc1b79f4279@redhat.com> Date: Mon, 2 Jun 2025 14:26:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/4] mm: Fix uprobe pte be overwritten when expanding vma To: Lorenzo Stoakes Cc: Pu Lehui , mhiramat@kernel.org, oleg@redhat.com, peterz@infradead.org, akpm@linux-foundation.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, pulehui@huawei.com References: <20250529155650.4017699-1-pulehui@huaweicloud.com> <20250529155650.4017699-2-pulehui@huaweicloud.com> <962c6be7-e37a-4990-8952-bf8b17f6467d@redhat.com> <009fe1d5-9d98-45f1-89f0-04e2ee8f0ade@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <009fe1d5-9d98-45f1-89f0-04e2ee8f0ade@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: TYkRi2QBVB7ktIGTmU_4CaJz2K5d5OtJmUKdPCynVDg_1748867183 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 46D7A1C000B X-Stat-Signature: j4xorfpft7df78wxh7itaauzhkqpw4cb X-Rspam-User: X-HE-Tag: 1748867187-605822 X-HE-Meta: U2FsdGVkX1/9X+xmA8Vluc2is2q51pt6PGd7YwelQ7Hw9nXwWdSrxRgjzVTh6iFGQMRMB0qOpVM0GpAk+YKQR+LxbKEcIYjC1vEaYVbgEZeVg89PVs2fg/1JWeiLmADVH7U1ErVBhrmJEXrO4q4xBuBdqs+4Op0GhL7cffz2TAkg8ykzuTtYPQNCz30LaYxeNknYdp+gOTcfhkTgg65XoWVD+o5YYNUr3FL9qY1QYy7dKwNsEBeCi9ggcughw4aev4xVZtytnld5EhmATYi/A7DD9dKmCSajhPKLcttGAnxT8QntqcVz3+qEewEObJgQVp5oJbg67cO72uygFlDynoBtE+ydfbCm4II/4fofMZh5Ql4jhkGsrtaJntgiZ3cB+aagdyOrhQb0WB4NkU+1uu0hvzC4+7AMGjd71/cygrXSrz/eu9VonG3SSt2OdtnIAsPDaRwATvzDj+rjEn0j8YMyNcfBinecIznONbu+6iIuSwEHMuuo8wFb4O0DQytnvqInNTZTW3sImKJnZ82SZHpfvo/RanUywVakrowtnsfpMtO8u0V0fsL3iKKxIZEVbvLhWjM+4NRvLdMK9JnjWlS9zCE9dt0rGFSik1VwtQFD6ldw/ursxwRRDExmgnmfHJ6YvSYbnY4NBsZeJ0eEOJyaSekH2JKS5zTHbtz4Ch1efSIWZjcPEt57VByUFjcTPZu1MZEsAZMwew9xNEJaBSqT/uYGZq+VbEUxUjwCBjCuAYVp6jR9YwbnP9EsOwj8zu0AYEH22X0xdi5YwNZFeRXhSXYLZNw7V3hFqk0ashaam4cyL+55te8X5wK/h4xP/OJZVUQC2v3jsh3/vMKYu4Y922VTOo0V3CN3U7KfZLUEkydk6kivWuNsHJRfxirCAvRugpvO4z48lFLcQ6R7/IrD5dILPcx/5PpWcqMGcpihIXVR7qNYlz0bIhJQ0xizMtrqMHspx1h3MQa6Tik z1ScEmfr nRD3V+mUPXq7voiAVGJ1VR+CN5fcWFgREfCKwoRKmh6eUxCacMz0yef1jI6kGD8tPlH9eiW8AQzFYfnWzjyzckTuTbiUeVM5O6FeS+S1+5mSZctIPDgQTnaWeLhr6/MhxN7LfGQlOwaB5ic6hW3aFy/pL2GGW5rY8Ll9CNBIFKkk2jNHocsOolvkYBmpjtf4Nw6mp0v3N0Fdgf0juFApsLhBBgvRh7OlgK0cMhGHoVsFLX/B0F9ZfxiNYG1cVMQJWTqpOeeb52iklt6jbDB0Q+f0FsAKTuzrtoLVzL9gDkYym7gxzG6fXhL9hVnhf7d2QTOVd4Hnw7TiCWbnRc2d+Y1zJ6e/m45j9oh9UVbCiiMgwvbyHay4aobaMaQhEXLi8t6iOq4PbDT2sGcFTUlo3t5z4RQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.06.25 13:55, Lorenzo Stoakes wrote: > On Fri, May 30, 2025 at 08:51:14PM +0200, David Hildenbrand wrote: >>> if (vp->remove) { >>> @@ -1823,6 +1829,14 @@ struct vm_area_struct *copy_vma(struct vm_area_struct **vmap, >>> faulted_in_anon_vma = false; >>> } >>> + /* >>> + * If the VMA we are copying might contain a uprobe PTE, ensure >>> + * that we do not establish one upon merge. Otherwise, when mremap() >>> + * moves page tables, it will orphan the newly created PTE. >>> + */ >>> + if (vma->vm_file) >>> + vmg.skip_vma_uprobe = true; >>> + >> >> Assuming we extend the VMA on the way (not merge), would we handle that >> properly? >> >> Or is that not possible on this code path or already broken either way? > > I'm not sure in what context you mean expand, vma_merge_new_range() calls > vma_expand() so we call an expand a merge here, and this flag will be > obeyed. Essentially, an mremap() that grows an existing mapping while moving it. Assume we have [ VMA 0 ] [ VMA X] And want to grow VMA 0 by 1 page. We cannot grow in-place, so we'll have to copy VMA 0 to another VMA, and while at it, expand it by 1 page. expand_vma()->move_vma()->copy_vma_and_data()->copy_vma() But maybe I'm getting lost in the code. (e.g., expand_vma() vs. vma_expand() ... confusing :) ) -- Cheers, David / dhildenb