From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74045C3DA4A for ; Thu, 1 Aug 2024 09:34:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 154016B0089; Thu, 1 Aug 2024 05:34:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DD0E6B0092; Thu, 1 Aug 2024 05:34:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC05A6B0093; Thu, 1 Aug 2024 05:34:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CCFB76B0089 for ; Thu, 1 Aug 2024 05:34:17 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 86B5A120A3C for ; Thu, 1 Aug 2024 09:34:17 +0000 (UTC) X-FDA: 82403165754.21.9318603 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 450D01C0027 for ; Thu, 1 Aug 2024 09:34:15 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Y27PmUB3; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722504799; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4zaTn/YFgotAIGylW43Vgzq+0aYbo1DIlhcwsiRMBu0=; b=OsX3kBHrJWzAaTeGHGgQoHC3Zz9Pn9rsE9WMt0X29BoGCm2pJjBFOUFq2IAemkBnoOJYGf X7PYeskGjvNyfXLSWbqdlHbf1dpt0HjHyoAIcKo+pHOc7bIjnVaBx15mp0bSjElnqAUxXl RbKBKX+K1HAjUdSQxP06Td5f2WhfZ0Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722504799; a=rsa-sha256; cv=none; b=uAlM8rkZoVkF7e1c9TK4K8XhpUh9gO7y7TOoixMaJi+/5qabXLbQFseJJ1AR+mJzaLX+zl rTBL520mUS+E7c6KjLa06lHzB0aMEVQn46K1K54duLB6Vmt1R/+MHXgP8msqNXpUAHhtQY HX2403TPmIZbCy1zph7X3Uy+ksxWqAA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Y27PmUB3; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722504854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4zaTn/YFgotAIGylW43Vgzq+0aYbo1DIlhcwsiRMBu0=; b=Y27PmUB36E22KSZ0tkTFKz5UdBX1cTQd5NJlmZ5AcFaRkMEHDGBOucYkpS0FvAJqOScbiM u9YmTNOuWsvC1C/f5A2itddYGNf5MB0n7Ny0PpiNvioSIJWYF6O3T0xE3hJW2jegXlkg1t hUnGDgkUnXmfh4K8if0TBxGEA13M6r8= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-363-L8DvDujaPMmlQeEPxN8NvQ-1; Thu, 01 Aug 2024 05:34:11 -0400 X-MC-Unique: L8DvDujaPMmlQeEPxN8NvQ-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-428040f49f9so39931605e9.0 for ; Thu, 01 Aug 2024 02:34:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722504850; x=1723109650; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=4zaTn/YFgotAIGylW43Vgzq+0aYbo1DIlhcwsiRMBu0=; b=nQzVTaNanFW4NYuwJXge/9lXvEVk3+nF5/na5xPB2H1O8OJVj5bRFY+04u1pu/s72m tjBg3rSNeiN0nxo9dzIbt4tH1n1rr1Nx7633NKkqdBd8xVdzFDPVfP0qBYW5gv51xSA1 iQ8wNDCR6/tVW4CpvDPchTnlQULip3Q7mUmjT3KIACYQNTe9vzMVt3YQ3W/uM+2G8/pM 6D8dYk0BPBNWhfCoO9RBY7HMYA/N932PYuusV/HPgY0b6JN6jx2nuT99REx/OuejAOMn G7w6QQnOu57t/peXIqDo8gAiBMXnZHAZEMhhmom4s9nRWP8/tpRXE4o8Byf8Y6D3uFf6 ci6A== X-Forwarded-Encrypted: i=1; AJvYcCWi0SPud6Rwo+e482HmN31q4Fs5GaixSOFDVVWH4UC5bnNQzvXRqTU107dJ1OQBHo8oOGDUmsr+jQBPktuYpVOzHyU= X-Gm-Message-State: AOJu0Yw4Zd5zwe06BuGjjENix9uFuLknTfqPr1TBRDnfKgsANQa1u88N xkY7aKy7O5CiiuNMfmLLU5ZVoWHreLJ10MZjtYWcqySPCsnYZh1o5+ASgG1yWNJC06GmSUovVw9 Qi2l/lQbgLPwW7vZkkDa9TK5yzqoW/w4nriNeOabaIIaCUAbW X-Received: by 2002:a05:600c:46d2:b0:427:abf6:f0e6 with SMTP id 5b1f17b1804b1-428a9bdba6dmr16726855e9.9.1722504850105; Thu, 01 Aug 2024 02:34:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGsdIi9cbdhCyGOUOk209ImdY8rj8k70L4gcpiRY4RmZ4B6fxJ3acejCtVHfR5vm+WNgcQG9g== X-Received: by 2002:a05:600c:46d2:b0:427:abf6:f0e6 with SMTP id 5b1f17b1804b1-428a9bdba6dmr16726645e9.9.1722504849565; Thu, 01 Aug 2024 02:34:09 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:5c00:e650:bcd7:e2a0:54fe? (p200300cbc7075c00e650bcd7e2a054fe.dip0.t-ipconnect.de. [2003:cb:c707:5c00:e650:bcd7:e2a0:54fe]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4282dae2f73sm43560015e9.21.2024.08.01.02.34.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Aug 2024 02:34:09 -0700 (PDT) Message-ID: <6ddd626e-23c3-48aa-9753-ab8d73a5f798@redhat.com> Date: Thu, 1 Aug 2024 11:34:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 04/11] mm: Add missing mmu_notifier_clear_young for !MMU_NOTIFIER To: James Houghton , Andrew Morton , Paolo Bonzini Cc: Ankit Agrawal , Axel Rasmussen , Catalin Marinas , David Matlack , David Rientjes , James Morse , Jason Gunthorpe , Jonathan Corbet , Marc Zyngier , Oliver Upton , Raghavendra Rao Ananta , Ryan Roberts , Sean Christopherson , Shaoqin Huang , Suzuki K Poulose , Wei Xu , Will Deacon , Yu Zhao , Zenghui Yu , kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20240724011037.3671523-1-jthoughton@google.com> <20240724011037.3671523-5-jthoughton@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240724011037.3671523-5-jthoughton@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 450D01C0027 X-Stat-Signature: ygedfrbsukgsy8dzei64xoff7cj5154e X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1722504855-586138 X-HE-Meta: U2FsdGVkX18UHMf2ZbPNedmvAN3GyjQnqsryPsg1gY/qpEipAAo1SYNvK97eAA60GCXiGKKrkJmTjWJ8hwt6rKrV+pvK9SF5+Zq2VpGhk4NX6ekLM7a2i9P2BmylgdanzslX1AjwrPYLOZYkGCABf2eYX4twx0HadPd1w6IL/7QEwm89+k3+pW9jflEZfMUeczBU9CIrCOXDCKV1s1hSjPzCQ3XFWtVBqE18cV/HDJ902JRDAL/ato6BWh+UshMRp8/0Ml/1qda9T1VGnI+NRH7DwrRL+x1Qz0gPuEUXJouP0Aiy6TLuSMmsrDRJo02N3rHDlMawLCdrYQfQbiYl2ZsECDO+++ZyyBgfb3Vt1H2jDWpsoC4uYpWQMJZyKLVfC6LqUnPdnJXYyYVteDNhjcJDOVBOyg9ZeX+URbN33NwThZDRW09EFtK8aOkDJKYdtYDGIduQRXlWtv0fFsRSN6VyKEqvguPcVPen06a84iBZl7XpbYlo3G2+hgs7/Ce0o3ceGM0pcYNA48/9yxBxFfqNuSRs7puAsBkW7tHE2nWn/AhTGECbGQAXxmlXvXpSfeiSNcwLq+OmEwppdrDqdfHpWX75K9TfWAy0zTEq6wMK3ZHCAVUgkZ/p6/hkMbd3D2gVC4jr5mr/Cr/GMMvnMgF0OCKik44KHPxAahwwlLRbkUEL5HkYVqGb0xLPtemQsk0SW2+hMeR1YDysUlpTZikP72IEzS34e1Fo2qceeXdu52nzdw5sgGmwB6Sc6f7TcgKzDX5Qsk7uVh+MXuswdEhCwX303koCc7r1Cj9vB1AjIn9zZYYImk27yHQbuDQFVQllSniXYwIg02BK7G3xQgsoZp87m9pydrj/qZTTJmlfLv1aIE6Rd7iPJqMJ7nyA+ClF5Ul9dfSheeCF36pqVmqG1xhuYlNKoB18KyYQHvDxtfTajrxP6EmIaeRso6osRiEzQP5sDil4lnaIq5v iyFJv88Q GCXirly+s+iTU26Lq3+gRo4TkSgqbdVzDhhcem6q1CHqgfI/ZbP4v63LbH3PoZsCsV8p3BA0tQ76OD0v5kDwoDVJrT90B/0XlDVWsy7T+ea28p1EDKW85oqKkqdtyM6XdgMGUmSr9PHjIoieXS7dIyJHSR68YuGhcaBFefOwr8xH3a4OyESTM3TVucxOm7t0l5onf5quxIlXXONSkE978+wITzrnF1HblqmH33FRmkCe9oOoev8n7oGS2VfLabfvGG3jM3j8dmRL5ur88leJAJl+eAguGSWKqwaUg6UHx366IV8Muiwe2nDNcXw+aPX9LUoycvhJjcWFQO6Q8hbJVhchkKVo5yqECa/D2+5bzd2NpAOq7y79O2EP1qxIatEVUa+Lp3evJJkpT4hRb8zjSGeq1B1uBHdv1R0x8eOcj3bKUNF6KatB/8SiEUY/TgAxWudwz7HYBheGSmMbG87ntBEo0kBabtSu/FRcY/BrNVbibKkrLOm/0T7mBBtya5u4lEDJe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.07.24 03:10, James Houghton wrote: > Remove the now unnecessary ifdef in mm/damon/vaddr.c as well. > > Signed-off-by: James Houghton > --- > include/linux/mmu_notifier.h | 7 +++++++ > mm/damon/vaddr.c | 2 -- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h > index d39ebb10caeb..e2dd57ca368b 100644 > --- a/include/linux/mmu_notifier.h > +++ b/include/linux/mmu_notifier.h > @@ -606,6 +606,13 @@ static inline int mmu_notifier_clear_flush_young(struct mm_struct *mm, > return 0; > } > > +static inline int mmu_notifier_clear_young(struct mm_struct *mm, > + unsigned long start, > + unsigned long end) > +{ > + return 0; > +} > + > static inline int mmu_notifier_test_young(struct mm_struct *mm, > unsigned long address) > { > diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c > index 381559e4a1fa..a453d77565e6 100644 > --- a/mm/damon/vaddr.c > +++ b/mm/damon/vaddr.c > @@ -351,11 +351,9 @@ static void damon_hugetlb_mkold(pte_t *pte, struct mm_struct *mm, > set_huge_pte_at(mm, addr, pte, entry, psize); > } > > -#ifdef CONFIG_MMU_NOTIFIER > if (mmu_notifier_clear_young(mm, addr, > addr + huge_page_size(hstate_vma(vma)))) > referenced = true; > -#endif /* CONFIG_MMU_NOTIFIER */ > > if (referenced) > folio_set_young(folio); Acked-by: David Hildenbrand -- Cheers, David / dhildenb