From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3F77C2D0CE for ; Tue, 21 Jan 2020 14:40:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 90CBD24653 for ; Tue, 21 Jan 2020 14:40:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Tj7tj63h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90CBD24653 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 31BBC6B0005; Tue, 21 Jan 2020 09:40:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F35E6B000D; Tue, 21 Jan 2020 09:40:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 208A46B000E; Tue, 21 Jan 2020 09:40:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0126.hostedemail.com [216.40.44.126]) by kanga.kvack.org (Postfix) with ESMTP id 0A88C6B0005 for ; Tue, 21 Jan 2020 09:40:50 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id B0E563D0F for ; Tue, 21 Jan 2020 14:40:49 +0000 (UTC) X-FDA: 76401903018.18.swing06_5e775a4faa417 X-HE-Tag: swing06_5e775a4faa417 X-Filterd-Recvd-Size: 5539 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Tue, 21 Jan 2020 14:40:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579617648; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JSSit0Wm+RQr1Jgst7x5naV4XKUyLXD3AhAyDv7TiYs=; b=Tj7tj63hMPU19wrJcoj1TH8CGkiDyBpUV3lfXKpgy2kY8apxYkEalVoHqja4B886ckbsla +UrtKNn3GJ1fSQym3X5fbjorDKM6/GCXAXtUvWlvrlsa02kmH+/vbw1UsKo+MhYL9VMKoa qtADOhqfqaNDHHfMIPqDxYy9/nL2ugM= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-303-7Jk12pS9MpaiECeCa9IPoQ-1; Tue, 21 Jan 2020 09:40:46 -0500 Received: by mail-wr1-f70.google.com with SMTP id b13so1377246wrx.22 for ; Tue, 21 Jan 2020 06:40:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JSSit0Wm+RQr1Jgst7x5naV4XKUyLXD3AhAyDv7TiYs=; b=eOh2q95TyvyyT7vPI6yasH4IbD/0JWJsH6m8LbMavictnFawDzuz04kHcFMjHQkH80 9H53sfE4cZOkxtuHY66w5oUphyAMMf47jQcPPMEWRXIoQWOL9beB6axkzg3dL5INOlaT gRGlklqLYNvwnpw7FASq6SYmkPIRep3SWYtcAwpyzCbOOZCscpG4pdBAuJ2esVJvvuQz uQijd7Me1LTwwwew855CK3qz3yWXjh2QkYaQ7TepgvDIPMBkgR56/KR2EJ7qc5bmyYng B4jUHGt/+7NCDTuFQALrV3hcOjBFVqpU8+ygqN4TdbpZH4hqIT3ob2yeF7QeYK0z+/E+ ENAw== X-Gm-Message-State: APjAAAUI5sy2MO/YTja2JdKlkVP/BiCYQ+IjT/dQsPTdY4CUEnSX/m/Q TtjIl5GY/HhRkZwHMbbPZoHyKsvSKzss9bT96e6MLtQh+qkluszQzOHL5mQsfiZZIDnQev6BGnW FM3bCBDDzNw4= X-Received: by 2002:a7b:c851:: with SMTP id c17mr4596896wml.71.1579617645322; Tue, 21 Jan 2020 06:40:45 -0800 (PST) X-Google-Smtp-Source: APXvYqyUkg5d8MSonCO4Ge0L397jZ+4TsON4lVJzpAggAw2WjkJCWhAHkQt1Jw0IPvgT93BvWQD3aw== X-Received: by 2002:a7b:c851:: with SMTP id c17mr4596848wml.71.1579617645022; Tue, 21 Jan 2020 06:40:45 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:b509:fc01:ee8a:ca8a? ([2001:b07:6468:f312:b509:fc01:ee8a:ca8a]) by smtp.gmail.com with ESMTPSA id b67sm4417502wmc.38.2020.01.21.06.40.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jan 2020 06:40:44 -0800 (PST) Subject: Re: [PATCH 07/14] KVM: x86/mmu: Walk host page tables to find THP mappings To: Sean Christopherson Cc: Paul Mackerras , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Andrew Morton , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, syzbot+c9d1fb51ac9d0d10c39d@syzkaller.appspotmail.com, Andrea Arcangeli , Dan Williams , Barret Rhoden , David Hildenbrand , Jason Zeng , Dave Jiang , Liran Alon , linux-nvdimm References: <20200108202448.9669-1-sean.j.christopherson@intel.com> <20200108202448.9669-8-sean.j.christopherson@intel.com> From: Paolo Bonzini Message-ID: <6e9987a2-c34f-362d-a123-7dc4849811d1@redhat.com> Date: Tue, 21 Jan 2020 15:40:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20200108202448.9669-8-sean.j.christopherson@intel.com> Content-Language: en-US X-MC-Unique: 7Jk12pS9MpaiECeCa9IPoQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08/01/20 21:24, Sean Christopherson wrote: > + > + /* > + * Manually do the equivalent of kvm_vcpu_gfn_to_hva() to avoid the > + * "writable" check in __gfn_to_hva_many(), which will always fail on > + * read-only memslots due to gfn_to_hva() assuming writes. Earlier > + * page fault steps have already verified the guest isn't writing a > + * read-only memslot. > + */ > + slot = kvm_vcpu_gfn_to_memslot(vcpu, gfn); > + if (!memslot_valid_for_gpte(slot, true)) > + return PT_PAGE_TABLE_LEVEL; > + > + hva = __gfn_to_hva_memslot(slot, gfn); > + Using gfn_to_memslot_dirty_bitmap is also a good excuse to avoid kvm_vcpu_gfn_to_hva. + slot = gfn_to_memslot_dirty_bitmap(vcpu, gfn, true); + if (!slot) + return PT_PAGE_TABLE_LEVEL; + + hva = __gfn_to_hva_memslot(slot, gfn); (I am planning to remove gfn_to_hva_memslot so that __gfn_to_hva_memslot can lose the annoying underscores). Paolo