From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28D8BC4320A for ; Mon, 9 Aug 2021 17:25:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C252961078 for ; Mon, 9 Aug 2021 17:25:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C252961078 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 3D3246B0071; Mon, 9 Aug 2021 13:25:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 385056B0073; Mon, 9 Aug 2021 13:25:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24A7B6B0074; Mon, 9 Aug 2021 13:25:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0087.hostedemail.com [216.40.44.87]) by kanga.kvack.org (Postfix) with ESMTP id 0BCCF6B0071 for ; Mon, 9 Aug 2021 13:25:14 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 99D751F04B for ; Mon, 9 Aug 2021 17:25:13 +0000 (UTC) X-FDA: 78456218106.11.C55B321 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 25D47300011F for ; Mon, 9 Aug 2021 17:25:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628529912; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hTeRlhRqMh8+j3wOmrgr2KjDpOochc5TMrkMztkGvsQ=; b=aV5eRaehVaPrFk5af6IGAwDxzEuQnYGY/QNeT9hWj3Bo9uNniSCXvHCy76SuyfI3yrZxhf 6LhM/GWh2bn+miamFiRr9mXNVQ819mJ5tB4vElcShRw7iaymcf8yEJlfHXuTqXLXZW6o6Z n+1J3y5IKQD4LeG5/Om9xUMo/A1XSxU= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-374-B3ykJlRpMLeuqkylvqbRjw-1; Mon, 09 Aug 2021 13:25:09 -0400 X-MC-Unique: B3ykJlRpMLeuqkylvqbRjw-1 Received: by mail-wm1-f71.google.com with SMTP id c2-20020a7bc8420000b0290238db573ab7so7013361wml.5 for ; Mon, 09 Aug 2021 10:25:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=hTeRlhRqMh8+j3wOmrgr2KjDpOochc5TMrkMztkGvsQ=; b=BcEC8WjSChKIwZK8wVe4TjUVfQvzJxaMxn87C2mX7MCPOcilPYCCSjjB9bhT5mvaxU buCDFi8g+rbKbdRxC0j+6KXCV2J4iG9wg2YXle4VeSQMg7WaKQhodzk6ApdsRMJQ3oYI kLi+ljJ9/pGCxhCfbmDLWsnWF7DUpKLuEybUZwsPIEMtm/r0f3/XIL2wj6LyOuM8soAg SEAN65revlVhNc1fWKJTvxH7YUOej4veIARjBmQ3FPTN19EPPO0/69qrs0jAPi8qpsUi r/AkbkD/RksNzOObll4ItOwaf9W5ZGo9SmfaPGaXONlH/0WSyW5Kk2A0tmWoc1w3/wyu qo0A== X-Gm-Message-State: AOAM530NhF2Tq8f3m9lFPNOEjnWLzk5qSvHmLMigDY4K5vgAvcP0mcOt WCaRY/ArSQBqxE9S7TXIFFIoDcFkU5g0ITcubPZqyWppSvC50UEyHX0sHqo2DVsTqMP+4TUFL6+ m9Yh9FxyYE3umXTQiKLbhCW8LRzvf6xoUQ/2229quNiVR+yHBcYfU5/GEQaU= X-Received: by 2002:a5d:49c8:: with SMTP id t8mr26061453wrs.365.1628529908270; Mon, 09 Aug 2021 10:25:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzAHLSPzsnND+hO/zlQTOPI7qReRRIrDoFq5kGbbuFeAXmeig7zcuj0KbapLsDBHAQHngTKyQ== X-Received: by 2002:a5d:49c8:: with SMTP id t8mr26061423wrs.365.1628529908004; Mon, 09 Aug 2021 10:25:08 -0700 (PDT) Received: from ?IPv6:2003:d8:2f0a:7f00:fad7:3bc9:69d:31f? (p200300d82f0a7f00fad73bc9069d031f.dip0.t-ipconnect.de. [2003:d8:2f0a:7f00:fad7:3bc9:69d:31f]) by smtp.gmail.com with ESMTPSA id c1sm127690wmp.7.2021.08.09.10.25.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Aug 2021 10:25:07 -0700 (PDT) Subject: Re: [patch] x86/pat: pass correct address to sanitize_phys To: Jeff Moyer , dan.j.williams@intel.com Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Tony Luck , Borislav Petkov , linux-edac@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: From: David Hildenbrand Organization: Red Hat Message-ID: <6f485d5f-56b6-9397-a368-4e57bb109a9d@redhat.com> Date: Mon, 9 Aug 2021 19:25:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aV5eRaeh; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf09.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Stat-Signature: 3g3c5rjmamgg1gbajchc5b514jnqcn3t X-Rspamd-Queue-Id: 25D47300011F X-Rspamd-Server: rspam01 X-HE-Tag: 1628529913-337572 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 21.07.21 21:48, Jeff Moyer wrote: > memtype_reserve takes an address range of the form [start, end). It > then passes the start and end addresses to sanitize_phys, which is meant > to operate on the inclusive addresses. If end falls at the end of the > physical address space, sanitize_phys will return 0. This can result in > drivers failing to load: > > [ 10.000087] mpt3sas_cm0: unable to map adapter memory! or resource not found > [ 10.000334] mpt3sas_cm0: failure at drivers/scsi/mpt3sas/mpt3sas_scsih.c:10597/_scsih_probe()! > > Fix this by passing the inclusive end address to sanitize_phys. > > Fixes: 510ee090abc3 ("x86/mm/pat: Prepare {reserve, free}_memtype() for "decoy" addresses") > Signed-off-by: Jeff Moyer > -- > It might be worth adding a comment, here. If there are any suggestions > on what a sane wording would be, I'm all ears. > > diff --git a/arch/x86/mm/pat/memtype.c b/arch/x86/mm/pat/memtype.c > index 3112ca7786ed..482557905294 100644 > --- a/arch/x86/mm/pat/memtype.c > +++ b/arch/x86/mm/pat/memtype.c > @@ -583,7 +583,7 @@ int memtype_reserve(u64 start, u64 end, enum page_cache_mode req_type, > int err = 0; > > start = sanitize_phys(start); > - end = sanitize_phys(end); > + end = sanitize_phys(end - 1) + 1; > if (start >= end) { > WARN(1, "%s failed: [mem %#010Lx-%#010Lx], req %s\n", __func__, > start, end - 1, cattr_name(req_type)); > > LGTM Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb