From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97B2AEB64D7 for ; Wed, 21 Jun 2023 18:01:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D01998D0003; Wed, 21 Jun 2023 14:01:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB25C8D0002; Wed, 21 Jun 2023 14:01:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2B4E8D0003; Wed, 21 Jun 2023 14:01:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A20AB8D0002 for ; Wed, 21 Jun 2023 14:01:41 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CBBBF1408AE for ; Wed, 21 Jun 2023 18:01:40 +0000 (UTC) X-FDA: 80927522760.18.2512E9D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id A1D06140085 for ; Wed, 21 Jun 2023 18:01:30 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bVcrCvUx; spf=pass (imf26.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687370490; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZG+t0WGX6sTaTgh3a79i3TULO64iDRYDnoN3E5sKu+s=; b=ca7I/V/2oCzhS0YC4Tl27od48I8la5Y+goAjV5pVCGnbtXpH0JpRjKOvtIuKstq2KcSjuQ dm1DHUq89yozrj/xvtuHnqurCUDOPInsyYa9AHvhOl7iq8FWt6WX9CYl0bClBFgr1Nn9Xf 9mCMGK6tquKklLTDChlAU/xu6v1l6Fg= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bVcrCvUx; spf=pass (imf26.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687370490; a=rsa-sha256; cv=none; b=KT3p75Uu/FJDCRtJbk6YmO6JyKX9Ar22JwAs6N1EaEyhOuuU3t3iDgF68m4WQnr3s8eHHX +WrysOyzlYnnuC7VR6W3ER6wg5xvy74CtHiyazsF1i8NuQh0/YYq7lq34jXZqA/0rWTUYr xvjGJseqaWQy61EgVzmigphWhQj0ucU= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F29036166E; Wed, 21 Jun 2023 18:01:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 994ABC433C8; Wed, 21 Jun 2023 18:01:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687370487; bh=f6MfE+OwYlooIGk6bzrRy2nMoaF6fYVrxR9rt/b+wHA=; h=Subject:From:To:Date:In-Reply-To:References:From; b=bVcrCvUx5qUKiFKoGoCpRU9cOdPpOKYso9mJvg46pEjfpa5HrNdfQIs+z6jHr5sux dlx89O00OX+JFXaZsV1aqCsQCXMgGUPun8gG0+O63APDuieKF+NHNtURapcBRt6lwA XUSZY7Lxndjjm0Guu7ABZsDoRASFWxW9NDkbTecnzII3k7EzTCDZqTBAfGwPJVYC9o 4y1h+nwRvjsJy2OJKNcBHeZcxgyGTH5ATcgrCrgxjm4t9FpTdCYfY2dSxFdgqaYmjq McRt37g4zUkhYaqSUzhLnP9BOtEXfLTVHkZOUz8jt6fW2f8bh/uJnCW9nUVVVNS/3d grPvoD0B9Xewg== Message-ID: <6f4bcd7d79f688120d80e96e86d7c521854d8e84.camel@kernel.org> Subject: Re: [PATCH 01/79] fs: add ctime accessors infrastructure From: Jeff Layton To: Tom Talpey , Jeremy Kerr , Arnd Bergmann , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Greg Kroah-Hartman , Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Carlos Llamas , Suren Baghdasaryan , Dennis Dalessandro , Jason Gunthorpe , Leon Romanovsky , Brad Warrum , Ritu Agarwal , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , David Howells , Marc Dionne , Alexander Viro , Ian Kent , Luis de Bethencourt , Salah Triki , "Tigran A. Aivazian" , Eric Biederman , Kees Cook , Chris Mason , Josef Bacik , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Joel Becker , Christoph Hellwig , Nicolas Pitre , "Rafael J. Wysocki" , Tyler Hicks , Ard Biesheuvel , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Richard Weinberger , Anton Ivanov , Johannes Berg , Mikulas Patocka , Mike Kravetz , Muchun Song , David Woodhouse , Dave Kleikamp , Tejun Heo , Trond Myklebust , Anna Schumaker , Chuck Lever , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Mark Fasheh , Joseph Qi , Bob Copeland , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Iurii Zaikin , Tony Luck , "Guilherme G. Piccoli" , Anders Larsen , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Sergey Senozhatsky , Phillip Lougher , Steven Rostedt , Masami Hiramatsu , Evgeniy Dushistov , Hans de Goede , "Darrick J. Wong" , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Hugh Dickins , Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Stephen Smalley , Eric Paris , Juergen Gross , Ruihan Li , Laurent Pinchart , Wolfram Sang , Udipto Goswami , Linyu Yuan , John Keeping , Andrzej Pietrasiewicz , Dan Carpenter , Yuta Hayama , Jozef Martiniak , Jens Axboe , Alan Stern , Sandeep Dhavale , Dave Chinner , Johannes Weiner , ZhangPeng , Viacheslav Dubeyko , Tetsuo Handa , Aditya Garg , Erez Zadok , Yifei Liu , Yu Zhe , "Matthew Wilcox (Oracle)" , Oleg Kanatov , "Dr. David Alan Gilbert" , Jiangshan Yi , xu xin , Stefan Roesch , Zhihao Cheng , "Liam R. Howlett" , Alexey Dobriyan , Minghao Chi , Seth Forshee , Zeng Jingxiang , Bart Van Assche , Mimi Zohar , Roberto Sassu , Zhang Yi , Tom Rix , "Fabio M. De Francesco" , Chen Zhongjin , Zhengchao Shao , Rik van Riel , Jingyu Wang , Hangyu Hua , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org, linux-usb@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, autofs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-efi@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, linux-hardening@vger.kernel.org, reiserfs-devel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, selinux@vger.kernel.org Date: Wed, 21 Jun 2023 14:01:09 -0400 In-Reply-To: <1f97d595-e035-46ce-6269-eebfe922cf35@talpey.com> References: <20230621144507.55591-1-jlayton@kernel.org> <20230621144507.55591-2-jlayton@kernel.org> <1f97d595-e035-46ce-6269-eebfe922cf35@talpey.com> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.3 (3.48.3-1.fc38) MIME-Version: 1.0 X-Rspamd-Queue-Id: A1D06140085 X-Rspam-User: X-Stat-Signature: xo6ej5b7mb3upu163mg3if6eqx3yo3pd X-Rspamd-Server: rspam01 X-HE-Tag: 1687370490-981047 X-HE-Meta: U2FsdGVkX18UEMlF4pW2DuD4+S8zxEP1zuXlHChJ6mBqucuNU3TtWKDGfnScK1sXqc9cEDJqjLbReiydnuZZaWGg8/xcxyAcrwaWf0Sj9Y0DzUdJ6e5PlAifXMYTmJmOPRW4ZQQlboKyZ4e+BK40mul/7PL7PBQbhyc0DPP8NOxAJ3cvW/PWPyqiF8jyWNPnFsYk5XPaRa18+HnY5zdLMKJw50fs8tI8uksb4KyTerHaJD17csKK3ChMMUoCRMEiDB378PfDsygU7VhmwJf1Z0neXgubE7yk7QnOv9v64OG5hqctWf+Ortxwm7984gZi7VX93gWCqWygDthwi9LHCNSssQfDyzxpp2rW973/jP5OT+oA6AeJ1bbnrQeEojvGIQk7RroOvtkuYifUrid1feyGynMEP+YUD+LpJkoVVgIDmCiF6jNVeXCfLfMa6seOXN/n9GaC6IGQ82dlyoY5u5s/jupAuH33ZMOQ9O7QkpqW2/4XNXUQMJdXic/f/xEy3gpIRIYgJhIFv0xQI7eHzk6S34VMP0SUun60coIi0vfCAi2rYsxv2us201+0p/TEcKDlWB0KDTikaGJNsNnt8MTEbGTtl9BRlsbpakM3pdrxfuw25QmcE2SEW5VMFUP3ltyfRxxWCVkWJkfmvKv9PnZfepiyim+LfZ+iF2kxzwP4Zy7Uykiqc8GA4n6Dzw9hiGvA+oAlU7rVU51gD2Hg5T8BDG36E8Wj4YL3rn2vc43QXyKjmz8UNs7puE1S357ogEEpPN3wwGTc3N7lzJu+uQqh5YOAo0J5cxhxE1QnvEB9AJDhhULnoQOBHsfM7DrTDChejsOqDo2kJN5bfeuKfcjEeIFpKtOsOHDXo+uliesjHAhYjC/Em+k/yKhObU4NyZ3wP/7PQfRtcoNtlhOgp1NJ+OHGaV9yLFnbV2gI/bLThpsNnKBOZceDvYzwZa57539r5NKDIGyDhcAY8HS fPXuoBEk yABl7LL/9/TYnCSI1GQDDijXwvQkgSzrcQ8B/QIUrFLyAD8SSjYntjN0IZYjrFUkr4pRvfUK/4cs4rc6E/Ktilr0hMF718Q/EbKxRMLX0F+ZSrGiW0nHAver7S8h3Teg1c1mE5155nXL8avTxFFW23iX53QBTXn1zwRBfPyD3jSNVJ7XcZpcJVguBXzLNeQPC4U5CU+ofPsjTzKZgn9vTCcIJ3afA58Jnzqz5xi582ynWeamOUyqikIKTDjxWb+/l6UQbL6hQw86fndDPw96CcX/xRdHyvtMu6GbrI+sPRSoG/+Do/UkDvwrVRoIZ3MBuww5sy8evFNahqEt8/CwrEGoJjgM/qu0cEGX8BRIAbogSyqxsf7BdiPks0A/3oZ9DAtv+/jh6OFga9pTPfl1tUlD0hoSF+G0CeQ5QZdg8QwlRF8nMbcBfUn8dZpM/4I84yV5x/rohAbAL7OVDaU7EcqPJRNoQTXSw33PbgFoZT9HNfLEhrfMq2AGmpUummkXU/Vtu+MLScGtq7fsnr0Kl/Y489Q1pPleYHiackeV374SruhgLLiskBA+onfGjsvZ3MwEsuCgBugXj7XR5wXITf9BUf2n6gJ+4T0NO8/6Vjux063/c1t0bXd20uouny7ngEiS1R4BkISATODvzYOdy1T/hQUMEaR4DC1QMCB9gY3oDp8j6wrI28kQ+kQ4oYmt2+vrES4FBKpliS3xl2j2Xe2+Q5iKJ5ksQFf6ZjITU17cegZatSJcA+4FOmZXQxx/dzeSVUZIP1HxbHUN2kAS+DCIJ6atTbnE8Fr21mUDxxMpBmO6xg7mYoKUhJu9feBVkYSXXLN0h8nayZMGKH7izklmTl07t/OH3cGhKqSP8G4ndBQS8NobMNUkvwKFGi0FXcEpiUbIDfXxrJy6B65aPca/PoZIpdUEq7w0eYwJerYyYTVYp1BiKWhidTFj3ylM5lFPsAXXqwpRw2Ov+RKHQTLxdrCwT EvT3raxV UejAfQBvRH+aUXDM6ry9qSKl8jzDpM+2GZtBpvg/zzK7TbOigs2vob0Jhz+nKhUpdwNCjUCKkeghMiwnw5LeQZ7l0d4gjFVAalEZudhzLjeGijLiX7BmJkBkhexo6aFIOc5g/YA2wIrhkgWEnd3kepMYoLik8TEEme1MO+hZGs17Q/KkliTapnJrfSnWMxVBQQqdMyfx0AdigSbfINs/FHuSiOEdeysJaFenN4SsynuT1SOt+p0vQyMOlhxp1lzZalRxChDm30/qZbOK7cw0pApWFhSZayEKSOk7OyCab/xUcc6lOjjDeZ5HCkJxSRLcdAlLq7HDo5InxGEODo3EKWQPvqjNuO7WoyaLkRGJ+4eVbXBtjQFbmHyN/XYGYY5iyfzAD6FLYcW6AiOAyMjqwmZvW10IIkUDcO1NMn9TXQB8a04z0TwJ2rg8D/wm969KePIw34S+6SYL635K96XclAiaHOK4JxrGkLo3n4Dl3g9boKgJSMANHP+vvrJLmf/0ylNwxRqZbUWXZXKHnU7ts+PkvSFZKmnYqv00RlCZrLl1bpSy1GTtmG1oC5w6B9aUeLtRLiZ4yRkFn+D6G7ivi/XlgQ1oCoaKtM1eK1BqOs0TEQb6VfEAYjSTwun34wox3OErDAeW3QPKVXz6BSgt2UY5odpuj8hcCcDEsbWQq6fcoufbO4KPjz7oK8C5Dz1cjtD3GDSEwRbuQ+crWnMUel5f8zVnNpBLyncnP0eG36bPFepznabxet6lxetWglBYBxUAf4sIBjtxT6427nYxsNXjz4rNwMqawR/xUtZxVQW/gjdNn2nbPQ+C16+MrP2XKHD0yheQRERY0Jcdgn5naGiRykJ3qW06G2qBizTNTTuVaTV6hqkxPrYSowQfN1ezovXhba7TL50ojDkCLUUQvC12QylyRWrCmnh3vEvyAoa72KrdJj5pCGFkMliQa2PTQUIDKF02mLJ6Fk03gIA8q3r943OhY FF6ySR3K 9uhVXMAPbtD4NQKZ4SSOyGpDQ4zrq5oRzBXxqk2FCXTSFvoIAfI4Q0/Nnp6xK6QXx4bUJBm7hnRVwHwhPtSsVibqgIwHAnGVCcbZ80cxoznCyzcm+iWeFMn0mvUGmbs0WRvIzWaqf868r93IWVizFym9BwiyJeTTrwGkbKzq1RRrQOcSo4Csye159YfGrNXolgYlyrCCwOUirg5nwJ98L3TgtnvT2wTzFOFamVpSMUgGfZtxauqFENJ2jfE/ocIRLkvq189UtVggg6yiLhFRG4RwLF4yweu6Fvc4h0e751/yXqyOg6MByDiTspsDv1Lhxc2pLCSb7Cfgw1G0GrpniYifJD2s4HWrr0v4nl1WG+XEX8IY+qVKx0tS3DaiDI6MH5zoJRXV+9ZM/WGX69j15h+Q+p6IyZch9L3PSmcUv+r3IFP8G3O2G/YBbsP6TqlzeqT/LOtpWe5ANnCQYgdy2UmVaHFMRdK7JCM04wRIXylpg4IJBsxY45nPfLPe/HzKf/RnmC4S67kSjktC0okmqcVGJmJ3Q+OJIhjbLio5V4MbN23o1tYHapF4JE4EbL8GkxivFAC0lo3FE9qiQXIvVl0O96spXw9RBaKS8dJ1OpbLbNZYp9IaN/prrV/yiD/tLfhnQBfUNbTlGQvegDAIp9p9jt6j/z1/Eiri34tIzreh/ywKujYtlLH+rOaWZOtx8/l6XmAkVxUCzD7xlbNVN8QEYjQC8YR84esjffwBp8idOOO2dOfC5FMwq8QUmplmq9y9C8Yps2hYgRt7yd5mCcdNdagv77MQYSOIOMX0YzQXLs2A4aVrV/vq5ZOQAjkdf6rRhEd7Ggna4phVvSiMvXjUsoZ5cnaS+8iXvF9KCM/v99DV6MScwk+y9Ks88L792lRaufcuqWKCXpGftp79bfMUC8i5tdH+ePVRUBTB+Fa3cpIIOlB9OOwB5D4Q2+49eRApzFLYlXtNKyqTZEDm6/tsGeW/J 8gB0/h9v lWlyEDUPC3WD44J7rLHbP4tWanmtqvGQneWMbi6Kw7dCG+dzEieueu/Lp+hgRLUNBPzvJSl4O/vR+wyXJnrSqynLGDzFQbJGV5kp2TlRfH8Kr8s6op9Igl4ggEzOp6nyoWiQA+OCDWhvCYzsNu+gF63zkv4olVyP81v4G69K3Ti1XtxnAZwC8uXDB5xbkPNPJDFzrLiq6Xgbk4P2jzNmRMlqE1wp/ZvrCJ18WrN/hU2TZ8nUrHbv7zJc7Pyk7vVauuVNb+sxo2kx2s7vlKdBjUB+inTSrcHg4DObFNLE0mo7CedyVQI5iH3Xdtm3RqZc+D7Psbx+PheJhk1PglsKkWqYJjLxoi03I0K2PjOrFcrLecB6XN48yiA7ocggV87+J57guCuy1X8EaSyecSIuGTlCvE5s/tbXQiILwNGuxb+XJSE5fVJvm2HgHkMqzAzx3aUmmB0ZDiJJEhiFmgwx22 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 2023-06-21 at 13:29 -0400, Tom Talpey wrote: > On 6/21/2023 10:45 AM, Jeff Layton wrote: > > struct timespec64 has unused bits in the tv_nsec field that can be used > > for other purposes. In future patches, we're going to change how the > > inode->i_ctime is accessed in certain inodes in order to make use of > > them. In order to do that safely though, we'll need to eradicate raw > > accesses of the inode->i_ctime field from the kernel. > >=20 > > Add new accessor functions for the ctime that we can use to replace the= m. > >=20 > > Signed-off-by: Jeff Layton > > --- > > fs/inode.c | 16 ++++++++++++++ > > include/linux/fs.h | 53 +++++++++++++++++++++++++++++++++++++++++++++= - > > 2 files changed, 68 insertions(+), 1 deletion(-) > >=20 > > diff --git a/fs/inode.c b/fs/inode.c > > index d37fad91c8da..c005e7328fbb 100644 > > --- a/fs/inode.c > > +++ b/fs/inode.c > > @@ -2499,6 +2499,22 @@ struct timespec64 current_time(struct inode *ino= de) > > } > > EXPORT_SYMBOL(current_time); > > =20 > > +/** > > + * inode_ctime_set_current - set the ctime to current_time > > + * @inode: inode > > + * > > + * Set the inode->i_ctime to the current value for the inode. Returns > > + * the current value that was assigned to i_ctime. > > + */ > > +struct timespec64 inode_ctime_set_current(struct inode *inode) > > +{ > > + struct timespec64 now =3D current_time(inode); > > + > > + inode_set_ctime(inode, now); > > + return now; > > +} > > +EXPORT_SYMBOL(inode_ctime_set_current); > > + > > /** > > * in_group_or_capable - check whether caller is CAP_FSETID privilege= d > > * @idmap: idmap of the mount @inode was found from > > diff --git a/include/linux/fs.h b/include/linux/fs.h > > index 6867512907d6..9afb30606373 100644 > > --- a/include/linux/fs.h > > +++ b/include/linux/fs.h > > @@ -1474,7 +1474,58 @@ static inline bool fsuidgid_has_mapping(struct s= uper_block *sb, > > kgid_has_mapping(fs_userns, kgid); > > } > > =20 > > -extern struct timespec64 current_time(struct inode *inode); > > +struct timespec64 current_time(struct inode *inode); > > +struct timespec64 inode_ctime_set_current(struct inode *inode); > > + > > +/** > > + * inode_ctime_peek - fetch the current ctime from the inode > > + * @inode: inode from which to fetch ctime > > + * > > + * Grab the current ctime from the inode and return it. > > + */ > > +static inline struct timespec64 inode_ctime_peek(const struct inode *i= node) > > +{ > > + return inode->i_ctime; > > +} > > + > > +/** > > + * inode_ctime_set - set the ctime in the inode to the given value > > + * @inode: inode in which to set the ctime > > + * @ts: timespec value to set the ctime > > + * > > + * Set the ctime in @inode to @ts. > > + */ > > +static inline struct timespec64 inode_ctime_set(struct inode *inode, s= truct timespec64 ts) > > +{ > > + inode->i_ctime =3D ts; > > + return ts; > > +} > > + > > +/** > > + * inode_ctime_set_sec - set only the tv_sec field in the inode ctime >=20 > I'm curious about why you choose to split the tv_sec and tv_nsec > set_ functions. Do any callers not set them both? Wouldn't a > single call enable a more atomic behavior someday? >=20 > inode_ctime_set_sec_nsec(struct inode *, time64_t, time64_t) >=20 > (or simply initialize a timespec64 and use inode_ctime_spec() ) >=20 Yes, quite a few places set the fields individually. For example, when loading a value from disk that doesn't have sufficient granularity to set the nsecs field to anything but 0. Could I have done it by declaring a local timespec64 variable and just use the inode_ctime_set function in these places? Absolutely. That's a bit more difficult to handle with coccinelle though. If someone wants to suggest a way to do that without having to change all of these call sites manually, then I'm open to redoing the set. That might be better left for a later cleanup though. > > + * @inode: inode in which to set the ctime > > + * @sec: value to set the tv_sec field > > + * > > + * Set the sec field in the ctime. Returns @sec. > > + */ > > +static inline time64_t inode_ctime_set_sec(struct inode *inode, time64= _t sec) > > +{ > > + inode->i_ctime.tv_sec =3D sec; > > + return sec; > > +} > > + > > +/** > > + * inode_ctime_set_nsec - set only the tv_nsec field in the inode ctim= e > > + * @inode: inode in which to set the ctime > > + * @nsec: value to set the tv_nsec field > > + * > > + * Set the nsec field in the ctime. Returns @nsec. > > + */ > > +static inline long inode_ctime_set_nsec(struct inode *inode, long nsec= ) > > +{ > > + inode->i_ctime.tv_nsec =3D nsec; > > + return nsec; > > +} > > =20 > > /* > > * Snapshotting support. --=20 Jeff Layton