linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* Redundant barrier_nospec() added by commit 74e19ef0ff80 ("uaccess: Add speculation barrier to copy_from_user()")
@ 2025-06-19  8:42 Christophe Leroy
  0 siblings, 0 replies; only message in thread
From: Christophe Leroy @ 2025-06-19  8:42 UTC (permalink / raw)
  To: Dave Hansen
  Cc: Linus Torvalds, Thomas Gleixner, Daniel Borkmann,
	linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org

Hello Dave,

In commit 74e19ef0ff80 ("uaccess: Add speculation barrier to 
copy_from_user()") you add barrier_nospec() to copy_from_user().

There is already a barrier_nospec() in allow_read_from_user() which is 
called by raw_copy_from_user(), see commit 8524e2e76441 
("powerpc/uaccess: Perform barrier_nospec() in KUAP allowance helpers"). 
Why do you need an additional one ?

And why only copy_from_user() and not also other places like 
copy_from_user_iter() for instance ?

Thanks
Christophe



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2025-06-19  8:42 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-19  8:42 Redundant barrier_nospec() added by commit 74e19ef0ff80 ("uaccess: Add speculation barrier to copy_from_user()") Christophe Leroy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).