From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7229C74A5B for ; Tue, 21 Mar 2023 15:29:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1428D6B0074; Tue, 21 Mar 2023 11:29:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F33B6B0078; Tue, 21 Mar 2023 11:29:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F235A6B007B; Tue, 21 Mar 2023 11:29:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E32806B0074 for ; Tue, 21 Mar 2023 11:29:40 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 70A5912011F for ; Tue, 21 Mar 2023 15:29:40 +0000 (UTC) X-FDA: 80593290120.13.F56C714 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf03.hostedemail.com (Postfix) with ESMTP id 159C020003 for ; Tue, 21 Mar 2023 15:29:37 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=VZJsnuGB; spf=none (imf03.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679412578; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V+bmw1RvbbZi6jSx984W7m2Bc3dCIIAmL6vIS1dzYPQ=; b=elwIx/2XrfZPSQAvnK3qwV3IcorBhMTLi5EHRQd888sq0bTWHwkbtoGNxOEJ+jWIClKJRc fylbNstHasZIMBKUf2K9zKOomRMP6epG/bljYTXGF3ooD7KiyXHMsc5G19tnNFuHASfBKH cH04X3c6NCmv/RW5RF8LA+/x8nQuT7A= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=VZJsnuGB; spf=none (imf03.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679412578; a=rsa-sha256; cv=none; b=7O49OhgBSsIMfUAFpeXsOnyu347FDDSGmVqj0OFp4mnOqMdb/AUyMdTnz+K6X1VihDsjvM iwbOMVcGtF61JbZH8K4n5JWfeYtV+QmL9xMeNWN402bkG+ViZXM8CINxKEHWpvHzSX4DpJ cTEjQz75MdyrckQtHZlNCJkZpYrTijo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=V+bmw1RvbbZi6jSx984W7m2Bc3dCIIAmL6vIS1dzYPQ=; b=VZJsnuGBRKlaSnPzQK8ytVfPvu LP9xzhVAVhV54fQxrlSHoK1Oik/3I1hFCje+oVe9mjp+few0Rihx4xtT11eTtmAQZxc8kQZWqtRYV 3WtKN7ZrH2Rs7l83POxtcSA5vuSmH2pmKkXsaBPH+UquPtHDlqjfx8c1LXPF1EfWhiWDnP42K8PPR NCm3M7aRkOWN7beNPeIuJcZDYDuO4wM45/OE0CNaW6I9Ca4TpLO7eKOOY9QToZNY/leetuqgX/FwV 7V5leD5cAdSPFiq/iBacDNopHBP9FYJPOOYPdQqKjtYVP0/CjUm+qrjVQCQurdTRh8D1CSvAYJ1CT oJmjXEyw==; Received: from [2601:1c2:980:9ec0::21b4] by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pedvK-00CvRL-1W; Tue, 21 Mar 2023 15:29:18 +0000 Message-ID: <6f5fd9d9-f247-a7c0-a5e5-c40c37c76281@infradead.org> Date: Tue, 21 Mar 2023 08:29:16 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] mm/slab: Fix undefined init_cache_node_node() for NUMA and !SMP Content-Language: en-US To: Geert Uytterhoeven , Dave Hansen , Arnd Bergmann , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: John Paul Adrian Glaubitz , linux-mm@kvack.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org References: <67261c513706241d479b8b4cf46eb4e6fb0417ba.1679387262.git.geert+renesas@glider.be> From: Randy Dunlap In-Reply-To: <67261c513706241d479b8b4cf46eb4e6fb0417ba.1679387262.git.geert+renesas@glider.be> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: gsfmcsek94tkxqoi7uogq71c9fb4yhcp X-Rspamd-Queue-Id: 159C020003 X-HE-Tag: 1679412577-910846 X-HE-Meta: U2FsdGVkX1/R9DeccFKeVgObMxwaBpNNDW+kLtedIBYbFtCjzmVGeFf5x4V20L9FK4KVUolRo3ilXZJMVBUIWERLu4OqR7Izz5hYGVy/U0TOCzU1Oh5NAwAxcNyB5re1pYlaSBY6u+jO36KUTYJMUuSn4ny/F64zKutvvgLh9YYVV9K/gy8872AAgxx3wWzNiqUrsqEQUWr96WQcxccPKNZtkl6U1tW8yA/0deiaEjgdHkO0nTtEcD/f07euu5cvgJZeRL3KM3H6L4O0G5A3nCWEYUNUIxY9E3g3wUe/Xf1Ri1IAWqqUkeM8OgTQ2JoJt8BvyaAMlnT0q/Kjfq4omsGQtnvQ5uHjdZ9OOraIPzRThFvMSSvYV/7dGyk4AbQfS0Jp7RzITjrjzRvaPhKnNRnsHFES5z3JIp6O7k+39CXN+vuGgu/N8zaRUae/6TWjctRPo7dpurZUQEdyXDfEroGV+x70rwKzqB2AiRFkR2uSD6SR8t558sWdQDaLYTYm+FSz5Kx8Tr48ih4R2oxisXMQwh/lkxzTpgDvmPlpU9XKEEv+7HhYFB3uhAX9ny6jJ8tUj9WmFDkjm1cg0bAc+2WzWTKzI6zOhFDXaG5dqZkDUiAsQQ3cU7gWmVYWvtirY9dMFKwQG7FJbfkZQp78GSMFQUiFjDu4Qtk3hgtA6phhyMdqaXnYPamMRqD5LUCMqyS1Lb8ZuTIlacGuW8p/1axaUss+oK8Ttz4xEWOLUSUc2EWnuPTez5q3Xw6p8oJGrcqoYXWx1cPkGHmU1qFZix7P5wRO6laaXts/l6UgI9JWi/pxCuCZyy+Z/MTV8THkzyqThkBCTnJrQs2kUb2QtUmE5QCsWf7a2JQhcRCZnGXMMKMBaqEibJKTf5muAU2NUASlh5uKq5UOGU5726azGh3P7lmnRidd3XakPI0rjtCk4Q3g9R00O2duymL1lUnUF/QbP9VhQ1t7LNQKb+5 6vyu+g42 MoyiL69ysYp4t1/2TYWEAHprQGOZawYc7iOlf9loGQADK0ps/It5BDo31THSmeOuhkM0KZvg7qOyoz1P+PCqB7LhdwjeRd/nBFGnaSbPrJktXEQ32AdjxRDbJc93/3pNdUFGr+0jek+syd5ZtLr+qZFs9TpouPzaHyFFJAZnDkkkfJJJPFqJi6PqmIphQWmjAaCEAPfZoWfj98ZZ+kNZ57Bd1Wekjsj4UTmF6if7flkQmXkx0p8LVwJAxu8/ZllBvDOHA2ov6RaR2CtQ2Kkm4dvybQkOCz/jKzGkmJLFcK+SXTywjHYiOsUXPnptXEr6lnFRLC7tX+BKas1i5ve80TtWhse8UT/8u927KVxdMpmrsO+Su6fZbG6NUyhvK1cr1hJQA6TcpRMH4HWI6HBymVHyKHzizZ42+i6WUvZEutJRpIZAw+zAsSy3/pUXq8AwFzOsHpHJjVMfv1IWHeVb+QOhpnY/CjDE5Imy/JTzPpE0tKgTpm/4lbcAzzyS2jnF2NGp1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/21/23 01:30, Geert Uytterhoeven wrote: > sh/migor_defconfig: > > mm/slab.c: In function ‘slab_memory_callback’: > mm/slab.c:1127:23: error: implicit declaration of function ‘init_cache_node_node’; did you mean ‘drain_cache_node_node’? [-Werror=implicit-function-declaration] > 1127 | ret = init_cache_node_node(nid); > | ^~~~~~~~~~~~~~~~~~~~ > | drain_cache_node_node > > The #ifdef condition protecting the definition of init_cache_node_node() > no longer matches the conditions protecting the (multiple) users. > > Fix this by syncing the conditions. > > Fixes: 76af6a054da40553 ("mm/migrate: add CPU hotplug to demotion #ifdef") > Reported-by: Randy Dunlap > Link: https://lore.kernel.org/r/b5bdea22-ed2f-3187-6efe-0c72330270a4@infradead.org > Signed-off-by: Geert Uytterhoeven Acked-by: Randy Dunlap Thanks. > --- > mm/slab.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/slab.c b/mm/slab.c > index ba454246ee13dd4d..de1523a78f2e7367 100644 > --- a/mm/slab.c > +++ b/mm/slab.c > @@ -839,7 +839,7 @@ static int init_cache_node(struct kmem_cache *cachep, int node, gfp_t gfp) > return 0; > } > > -#if (defined(CONFIG_NUMA) && defined(CONFIG_MEMORY_HOTPLUG)) || defined(CONFIG_SMP) > +#if defined(CONFIG_NUMA) || defined(CONFIG_SMP) > /* > * Allocates and initializes node for a node on each slab cache, used for > * either memory or cpu hotplug. If memory is being hot-added, the kmem_cache_node -- ~Randy