From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9064AC67861 for ; Mon, 8 Apr 2024 07:00:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 29F066B008A; Mon, 8 Apr 2024 03:00:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 24CF26B008C; Mon, 8 Apr 2024 03:00:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 115356B0092; Mon, 8 Apr 2024 03:00:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E781C6B008A for ; Mon, 8 Apr 2024 03:00:53 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 68636140792 for ; Mon, 8 Apr 2024 07:00:53 +0000 (UTC) X-FDA: 81985467186.21.227B440 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by imf04.hostedemail.com (Postfix) with ESMTP id 773FE4000E for ; Mon, 8 Apr 2024 07:00:51 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gzjdNX0P; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of seakeel@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=seakeel@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712559651; a=rsa-sha256; cv=none; b=0VlW20/KqzswO1H6SXDQcY3HRlqxLSWItd56fHoUypafbz6xmfrTDn76iGpX/rF4ARVq3u tsMz/3KzMFXA4f0OgVpSpUp1WmkaxVU06RKrLvK0KmTx8E/8pfXttJKsiCWHWClF4BJ6Ak Bvy6sWiaUa1y02p1PutN/sf+fYlVPc8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gzjdNX0P; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of seakeel@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=seakeel@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712559651; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CY9C66wsjL0ewJNgfMPGlt1GE5TAeprjU8e3L87Pn+Q=; b=fWKVXwGydKBpc+XeA5ykrerhaMvvKV+UCCK9pvT9RJ7SoLZdNwNZI2Qw1qjRE6kBaAEoCW FnHpE8yGIpQ/KNOSFQo0etMnxqlII4BdG8VeGU0ukCwGBRGXV94+YNuBzLmnz3b0Ucko3E Eg8+EP/Qa5dUTSsuxEDsS6SNYW7gOlA= Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-6ecea46e1bfso3785535b3a.3 for ; Mon, 08 Apr 2024 00:00:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712559650; x=1713164450; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CY9C66wsjL0ewJNgfMPGlt1GE5TAeprjU8e3L87Pn+Q=; b=gzjdNX0Plh7xn9hipPWHbSIpAMz36MBNNyFXGIHseE+pupVDy/V3VkVzHgoHFCSj8d pvhBe5CqPVP57UzMzmgczMxbA3a4vUXKl2BRfcn/+/TP/O+7S/zmaK3NyUe6fWOEWGkt nvs9/FLZLTpmcpZWaMoNs6uxQWfkCEeOnRAiD6uRf9db69InF/YbQOZVv5bswLCg1lYc z92Q4PTWXI5iby71f5ZMaYxQFEGjlXbemI7Y7MWzCNP69a7RRLCm4v9Nx3U/tYAca+gE 2X1oiMcL3KSk1FWBzL5eHPpDu48yJN2zb3qxCOfti+LXL8Ia48B6Ktlj+d4ya8zRN3hh tk1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712559650; x=1713164450; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CY9C66wsjL0ewJNgfMPGlt1GE5TAeprjU8e3L87Pn+Q=; b=RtOGvz5w5wJvjZ3MYcTNjYY8iI89C1QMqq+jbEeGIJnpVy4I8zbLfOyVnyYxH4Pgkp vBP101LHEOcLLTi4iAczfhbYndgt647OdridJW17UO6WPtxJsV1t6LOTVrDYcTYR01vM eHfWfczoLvS4T0ZWSZ9t+KxyJcq3P/mnY1YpYJg9p6j7mkp/7SOI7OiBXJhG9B32ctW4 fHLk9/nJOfmRvTd6EWlMR6ARSJ5WpPaKc6UCCyiQqtj+oYRwEU5BWV+biK+WXEB0V9AM eTmMXVQt+JHdo60uqVOeepmwmkj/A9AhbJMIDHrBbygw1y8SwP3GtI1OhtobLRaZfeIm qRnQ== X-Forwarded-Encrypted: i=1; AJvYcCVcKfwQ9eRp7E/7Z/Z1wLWV92gKEVaPMLr9hAJTBGXh7Zn5RfBLcG7k23ITOLM1gijkoB75YmVaEV89Cp7/+YH1KyM= X-Gm-Message-State: AOJu0Yyt92ywNoPBS4UzSQA/M3BusQTVlybi5DBhIIcEfV7xmDkKE9/I az6grDmxcBbfSFA8KqEfzLI3wSuLJ9vR8JJ++tL0oKMhliQoTCYD X-Google-Smtp-Source: AGHT+IGHtcVp3ZqgHgUkHIxLmpZXlLwJJR0ZD28k7oSjCn8LRXSmxh9c5z8PqU0+47vfMmunNyeVjA== X-Received: by 2002:a05:6a21:3e05:b0:1a6:fced:424f with SMTP id bk5-20020a056a213e0500b001a6fced424fmr6264155pzc.62.1712559650057; Mon, 08 Apr 2024 00:00:50 -0700 (PDT) Received: from [192.168.255.10] ([43.132.141.21]) by smtp.gmail.com with ESMTPSA id c8-20020a170903234800b001e4565a2596sm475190plh.92.2024.04.08.00.00.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Apr 2024 00:00:49 -0700 (PDT) Message-ID: <6f8ab03f-7755-4044-81a1-6269aa9a62ed@gmail.com> Date: Mon, 8 Apr 2024 15:00:46 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 14/14] mm/ksm: remove set_page_stable_node To: David Hildenbrand , alexs@kernel.org, Matthew Wilcox , Andrea Arcangeli , Izik Eidus , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ryncsn@gmail.com Cc: Hugh Dickins , Chris Wright References: <20240325124904.398913-1-alexs@kernel.org> <20240325124904.398913-15-alexs@kernel.org> Content-Language: en-US From: Alex Shi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 773FE4000E X-Stat-Signature: aa6h6mpk6qgmbfsyaspiu1a7e1y3x3b1 X-HE-Tag: 1712559651-684779 X-HE-Meta: U2FsdGVkX1+IKO3yx2Ysog5+vD4hK2UhAr8JR9yiyrdOgezbZ4TUcrPBkbnfMySnp8RPuqoyMnpSQvstVJYPLyzen0Ja4o3Jh0fC87Nxa6yVBptrqR3ScPSfb0MUOoqnuHIvKX7rQlS4abJU4EBHFHRi3olKhS53iC0n7ZwKx8IzQRbSNeKrIgb0dseVopB3WXXkPH+7ZJ4i4mF4Br6N9OfwFsYtJgmsVffOtfHgSSZ+KKeODyyeTw3qEwMMLGW1F55by4JB0Ig8hgXQBLvfbIbjbMWdiB1iC3NYBaC0m10aZM2r8rUtLPt7YzbHOgTgE6GPwt6NKm46qwyr8K1XrshVQPB4VHuqi4qtm2kcGkZ4p7Geux9lW5KVDOMMEuMwdlbMwOxcXv8AfHn/UpOWOhr+xraj/uRn5rbMivBIUTTaNavwQjrGWSfxrG28KraEXndhFIKp0otws9PqEvn/YLME7ACdEvL6xiQ4yh8LSaeuqPWocRP5vADWyVDKbmBSwM7uxmsd5N0ZhRmL4cVpALuO7fGDXolDVoXRVAAh3baCJWlPC8HA9juRklROWOZwqqurfUaEJE+nuc8bZMztmiYbMYPvmJS/jXBd9amyu0H9yoourxNHWnC0n35W76Mru+yxIZMaIgJdk0UanQDjEO2//ELJlL2X1hkG0mJF+ZSkqDx+LjmgJIBK51nILQNfkjDzw4zlpBxPrWyU4HAJj73dzj/irg1eIPdWJY1+32M6I9X4FBz2iLyr+JdocYLES7i2Qa870QSpNIIpIgmdYv7w6kmCsqN3RSCqmL4sY+dmstwg682vEQ5hx8SnHthRkEQnjZcewOqK/FmxF3Nr4k3H27F09E2V39bG/HqmJWRIYAU+jM4YBH1Pe1k/Sn7bwJzwOmTBKKEwmIO5fYBwVJZ867o2TQyd/dzEhG0J25kY5XgQHmAnuT1WtLn1e6xSkJhIVa3Z6htqD8pEOl7 B04Ryycm BsGgVkIAa8+Uu8WarZJT6lgKy+/iIxJZy1ThkpVtE0NdZIiwgsPbIIS10fdLr0c1Wr1eellrtbjI8saWaKyBVa2kpQyGa0dMYZrl8Cdd1T8mKN8vVJ2HYi/s8AW63s/PPBghOeThXHe/vzVPKaFnlEbTWTjJLLMMRydoXqQ5tzQ5Dy6t0FyhG8irLIhVNY/1eL7hX1ZB9K8GGiYCelMUMxboK9XhyzJ0Ts1792ASC9qkLE20dyDxL20tfW7jjDuNEgHbsW40ocCBV4kvDRP/T80SJ7UrC4lkqa3xQZRKuGUk9E44fDbSjf6BWDFVOzgygU69hmkjdXr4vsMVtzziYk2jR6/gBYt6IqrOMXjGqRfHO1j1hBf/C3uME0q6ZVrlBcLurrkM8e8tSvAAAM0J3cuuwuIhlGmac9i3nBVpzYAkAH2Bs6CfUIPoD8A3gQ4V4ZivUbq2RSHdqpmEZ6Wur8NEeCHY9xe+VpNHx2T/zbOFH3SUhjtH1yyjNYLI+dMJnmn7fmTwNg+k5QUx59q5WGl25ZqLoquTOuntoKppnc5CvC7rFaelTKG3ImfbEJnEUwYuk1z5hOYoVw229XPAMVGPV3Rwz2m3L+B06 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/5/24 3:32 PM, David Hildenbrand wrote: > On 25.03.24 13:49, alexs@kernel.org wrote: >> From: "Alex Shi (tencent)" >> >> Remove the func since all caller are gone. Also remove the >> VM_BUG_ON_PAGE() because it's not applicable for a folio. > > Ehm, it is for small folios that we are working with here. > > Please keep that check and convert it into a warn. > > VM_WARN_ON_FOLIO(folio_test_anon(folio) && PageAnonExclusive(&folio->page), folio); will take it. Thanks! > >> -    page->mapping = (void *)((unsigned long)stable_node | PAGE_MAPPING_KSM); >> -} >> - >>   static inline void folio_set_stable_node(struct folio *folio, >>                        struct ksm_stable_node *stable_node) >>   { >> -    set_page_stable_node(&folio->page, stable_node); >> +    folio->mapping = (void *)((unsigned long)stable_node | PAGE_MAPPING_KSM); >>   } >>     #ifdef CONFIG_SYSFS > >