From: Bhupesh Sharma <bhsharma@igalia.com>
To: Askar Safin <safinaskar@zohomail.com>, bhupesh@igalia.com
Cc: akpm@linux-foundation.org, alexei.starovoitov@gmail.com,
andrii.nakryiko@gmail.com, arnaldo.melo@gmail.com,
bpf@vger.kernel.org, brauner@kernel.org, bsegall@google.com,
david@redhat.com, ebiederm@xmission.com, jack@suse.cz,
juri.lelli@redhat.com, kees@kernel.org, keescook@chromium.org,
kernel-dev@igalia.com, laoar.shao@gmail.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-perf-users@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, lkp@intel.com,
mathieu.desnoyers@efficios.com, mgorman@suse.de,
mingo@redhat.com, mirq-linux@rere.qmqm.pl, oliver.sang@intel.com,
peterz@infradead.org, pmladek@suse.com, rostedt@goodmis.org,
torvalds@linux-foundation.org, viro@zeniv.linux.org.uk,
vschneid@redhat.com, willy@infradead.org
Subject: Re: [PATCH v5 3/3] treewide: Switch from tsk->comm to tsk->comm_str which is 64 bytes long
Date: Thu, 24 Jul 2025 18:08:10 +0530 [thread overview]
Message-ID: <6fec26c9-b240-6548-c970-882c0576ef33@igalia.com> (raw)
In-Reply-To: <20250724091604.2336532-1-safinaskar@zohomail.com>
On 7/24/25 2:46 PM, Askar Safin wrote:
>> where TASK_COMM_EXT_LEN is 64-bytes.
> Why 64? As well as I understand, comm is initialized from executable file name by default. And it is usually limited by 256 (or 255?) bytes. So, please, make limit 256 bytes.
>
>
Check existing users like proc_task_name(), which use 64-byte comm names:
void proc_task_name(struct seq_file *m, struct task_struct *p, bool escape)
{
char tcomm[64];
....
Hence, it was decided not to change this and other similar existing
users and cap tsk->comm to 64-bytes.
Thanks,
Bhupesh
prev parent reply other threads:[~2025-07-24 12:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 12:39 [PATCH v5 0/3] Add support for long task name Bhupesh
2025-07-16 12:39 ` [PATCH v5 1/3] exec: Remove obsolete comments Bhupesh
2025-07-16 12:39 ` [PATCH v5 2/3] treewide: Switch memcpy() users of 'task->comm' to a more safer implementation Bhupesh
2025-07-16 12:39 ` [PATCH v5 3/3] treewide: Switch from tsk->comm to tsk->comm_str which is 64 bytes long Bhupesh
2025-07-16 18:10 ` Andrii Nakryiko
2025-07-16 20:18 ` Bhupesh Sharma
2025-07-16 20:47 ` Andrii Nakryiko
2025-07-17 18:35 ` Linus Torvalds
2025-07-21 7:52 ` Bhupesh Sharma
2025-07-17 4:23 ` kernel test robot
2025-07-24 9:16 ` Askar Safin
2025-07-24 12:38 ` Bhupesh Sharma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fec26c9-b240-6548-c970-882c0576ef33@igalia.com \
--to=bhsharma@igalia.com \
--cc=akpm@linux-foundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=arnaldo.melo@gmail.com \
--cc=bhupesh@igalia.com \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=bsegall@google.com \
--cc=david@redhat.com \
--cc=ebiederm@xmission.com \
--cc=jack@suse.cz \
--cc=juri.lelli@redhat.com \
--cc=kees@kernel.org \
--cc=keescook@chromium.org \
--cc=kernel-dev@igalia.com \
--cc=laoar.shao@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=oliver.sang@intel.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=safinaskar@zohomail.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=vschneid@redhat.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).