From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80A4FC4338F for ; Tue, 27 Jul 2021 12:21:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0B86061A71 for ; Tue, 27 Jul 2021 12:21:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0B86061A71 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id A2E518D0001; Tue, 27 Jul 2021 08:21:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B78D6B005D; Tue, 27 Jul 2021 08:21:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 857148D0001; Tue, 27 Jul 2021 08:21:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0240.hostedemail.com [216.40.44.240]) by kanga.kvack.org (Postfix) with ESMTP id 660696B0036 for ; Tue, 27 Jul 2021 08:21:33 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id EFA078249980 for ; Tue, 27 Jul 2021 12:21:32 +0000 (UTC) X-FDA: 78408278424.23.264B664 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 4E3BBB0042B6 for ; Tue, 27 Jul 2021 12:21:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627388491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LN9VGkVetG/NwFHIx+rWl4d+U3ZCuABiM4oRqn8aEJM=; b=J20JhjZX5LvALQSZzPZgmxrJFn9+hHNgFOcJlzqvwGN29tlpwbzuiE3KMYZ7sQi9Nfi52S gWRnWstJaOnUthE5X5Yo71CYBwdCfcLa+xtyUHe0qnCKxsOh5H9R1BZtJUXm/4naBsRJ0a 6UkUROnqV7p43lXcoKGPNQ1DoEu0Gng= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-220--cphmX05OKKXa3poMsugTg-1; Tue, 27 Jul 2021 08:21:30 -0400 X-MC-Unique: -cphmX05OKKXa3poMsugTg-1 Received: by mail-wm1-f71.google.com with SMTP id r125-20020a1c2b830000b0290197a4be97b7so1284903wmr.9 for ; Tue, 27 Jul 2021 05:21:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=LN9VGkVetG/NwFHIx+rWl4d+U3ZCuABiM4oRqn8aEJM=; b=r7uk/fKVYw5ZVI+xoHGgpFUxhdyyF3GcOay0HWbhAncGwlyNAcPTTbaw1dmi3NNYb9 aCj/sL4e9yWtgbR4aI/kCBDNnVRyg3fY+FLEMDmfw03Gz6XWqlfotzGAa7AkDWK+lbHB rwD5PG3UIjL4Ud6TY9hxPmBV43CWqqKHbjqCfTlFQKErPQsBSQv/N7eV+Q4bEONAlOPc zq/y62mx9vFXGUN0aeqRpsurQsjW+i29/dGzGX4a18oyCJrefM5AxIYcSJdxhRCh+T6j B27Y7D8f7rsu20zB1HqmUc7I2nH0p0OF6z59E31BCAmRs9myPoJafw9th5wPbQPUa7OQ JOzQ== X-Gm-Message-State: AOAM530jiX3QkJwbUJySPhHlI3ABFrt7/lDi3m4+nFf0ksF44CyQ91Sz VUhT0A85aEwZIVNUeD27hh0lSyP0EcFIhg22O8sl3tPp+6uEQgcZcsACGM1FKRKq7raqmvJlqbE E53+71sLIZVnRGNSNwKrWU971ipT7PyhyLC+uKx11+hoj5sMHLIwBljn6Sew= X-Received: by 2002:a05:600c:19cb:: with SMTP id u11mr3860759wmq.1.1627388489353; Tue, 27 Jul 2021 05:21:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQnNIw4yzhbK/hXIiowJKU9c6Yhf3WFk7FQBEZQiomOdMaGA+TgOqmsNh4ypiuVnQyMVEu/g== X-Received: by 2002:a05:600c:19cb:: with SMTP id u11mr3860731wmq.1.1627388489098; Tue, 27 Jul 2021 05:21:29 -0700 (PDT) Received: from [192.168.3.132] (p4ff23c36.dip0.t-ipconnect.de. [79.242.60.54]) by smtp.gmail.com with ESMTPSA id k9sm3199009wrc.6.2021.07.27.05.21.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jul 2021 05:21:28 -0700 (PDT) Subject: Re: [PATCH v4] mm: Enable suspend-only swap spaces From: David Hildenbrand To: Evan Green , Andrew Morton Cc: Michal Hocko , Pavel Machek , linux-api@vger.kernel.org, Alex Shi , Alistair Popple , Johannes Weiner , Joonsoo Kim , "Matthew Wilcox (Oracle)" , Miaohe Lin , Minchan Kim , Suren Baghdasaryan , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20210726171106.v4.1.I09866d90c6de14f21223a03e9e6a31f8a02ecbaf@changeid> Organization: Red Hat Message-ID: <6ff28cfe-1107-347b-0327-ad36e256141b@redhat.com> Date: Tue, 27 Jul 2021 14:21:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=J20JhjZX; spf=none (imf24.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4E3BBB0042B6 X-Stat-Signature: mu9s8x194rsq6zt43k18iucqo9siwzey X-HE-Tag: 1627388492-299942 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 27.07.21 11:48, David Hildenbrand wrote: > On 27.07.21 02:12, Evan Green wrote: >> Add a new SWAP_FLAG_HIBERNATE_ONLY that adds a swap region but refuses >> to allow generic swapping to it. This region can still be wired up for >> use in suspend-to-disk activities, but will never have regular pages >> swapped to it. This flag will be passed in by utilities like swapon(8), >> usage would probably look something like: swapon -o hibernate /dev/sda2. >> >> Currently it's not possible to enable hibernation without also enabling >> generic swap for a given area. One semi-workaround for this is to delay >> the call to swapon() until just before attempting to hibernate, and then >> call swapoff() just after hibernate completes. This is somewhat kludgy, >> and also doesn't really work to keep swap out of the hibernate region. >> When hibernate begins, it starts by allocating a large chunk of memory >> for itself. This often ends up forcing a lot of data out into swap. By >> this time the hibernate region is eligible for generic swap, so swap >> ends up leaking into the hibernate region even with the workaround. >> >> There are a few reasons why usermode might want to be able to >> exclusively steer swap and hibernate. One reason relates to SSD wearing. >> Hibernate's endurance and speed requirements are different from swap. >> It may for instance be advantageous to keep hibernate in primary >> storage, but put swap in an SLC namespace. These namespaces are faster >> and have better endurance, but cost 3-4x in terms of capacity. >> Exclusively steering hibernate and swap enables system designers to >> accurately partition their storage without either wearing out their >> primary storage, or overprovisioning their fast swap area. >> >> Another reason to allow exclusive steering has to do with security. >> The requirements for designing systems with resilience against >> offline attacks are different between swap and hibernate. Swap >> effectively requires a dictionary of hashes, as pages can be added and >> removed arbitrarily, whereas hibernate only needs a single hash for the >> entire image. If you've set up block-level integrity for swap and >> image-level integrity for hibernate, then allowing swap blocks to >> possibly leak out to the hibernate region is problematic, since it >> creates swap pages not protected by any integrity. >> >> Swap regions with SWAP_FLAG_HIBERNATE_ONLY set will not appear in >> /proc/meminfo under SwapTotal and SwapFree, since they are not usable as >> general swap. These regions do still appear in /proc/swaps. > > Right, and they also don't account towards the memory overcommit > calculations. > > Thanks for extending the patch description! > > [...] > >> + if (swap_flags & SWAP_FLAG_HIBERNATE_ONLY) { >> + if (IS_ENABLED(CONFIG_HIBERNATION)) { >> + if (swap_flags & ~SWAP_HIBERNATE_ONLY_VALID_FLAGS) >> + return -EINVAL; >> + >> + } else { >> + return -EINVAL; >> + } >> + } > > We could do short > > if ((swap_flags & SWAP_FLAG_HIBERNATE_ONLY) && > (!IS_ENABLED(CONFIG_HIBERNATION) || > (swap_flags & ~SWAP_HIBERNATE_ONLY_VALID_FLAGS))) > return -EINVAL; > > or > > if (swap_flags & SWAP_FLAG_HIBERNATE_ONLY)) > if (!IS_ENABLED(CONFIG_HIBERNATION) || > (swap_flags & ~SWAP_HIBERNATE_ONLY_VALID_FLAGS)) > return -EINVAL; > >> + >> if (!capable(CAP_SYS_ADMIN)) >> return -EPERM; >> >> @@ -3335,16 +3366,20 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags) >> if (swap_flags & SWAP_FLAG_PREFER) >> prio = >> (swap_flags & SWAP_FLAG_PRIO_MASK) >> SWAP_FLAG_PRIO_SHIFT; >> + >> + if (swap_flags & SWAP_FLAG_HIBERNATE_ONLY) >> + p->flags |= SWP_HIBERNATE_ONLY; >> enable_swap_info(p, prio, swap_map, cluster_info, frontswap_map); >> >> - pr_info("Adding %uk swap on %s. Priority:%d extents:%d across:%lluk %s%s%s%s%s\n", >> + pr_info("Adding %uk swap on %s. Priority:%d extents:%d across:%lluk %s%s%s%s%s%s\n", >> p->pages<<(PAGE_SHIFT-10), name->name, p->prio, >> nr_extents, (unsigned long long)span<<(PAGE_SHIFT-10), >> (p->flags & SWP_SOLIDSTATE) ? "SS" : "", >> (p->flags & SWP_DISCARDABLE) ? "D" : "", >> (p->flags & SWP_AREA_DISCARD) ? "s" : "", >> (p->flags & SWP_PAGE_DISCARD) ? "c" : "", >> - (frontswap_map) ? "FS" : ""); >> + (frontswap_map) ? "FS" : "", >> + (p->flags & SWP_HIBERNATE_ONLY) ? "H" : ""); >> >> mutex_unlock(&swapon_mutex); >> atomic_inc(&proc_poll_event); >> > > Looks like the cleanest alternative to me, as long as we don't want to > invent new interfaces. > > Acked-by: David Hildenbrand > Pavel just mentioned uswsusp, and I wonder if it would be a possible alternative to this patch. -- Thanks, David / dhildenb